Jump to content

How can i getStackInSlot in a custom IInventory.


TheRealMcrafter

Recommended Posts

Hey,

 

I have created a custom player inventory, with one extra slot. When I try to get the ItemStack in that slot, it always returns null, even if I do something like

setInventorySlotContents(0, new ItemStack(Blocks.dirt));

before a System.out.println(getStackInSlot(0))

 

I have tried the following ways of getting the itemstack:

 

ExtendedPlayer extendedPlayer = new ExtendedPlayer(getPlayer());
ItemStack holsterSlot = extendedPlayer.inventory.getStackInSlot(0);

 

InventoryCustomPlayer inventory = new InventoryCustomPlayer();
ItemStack holsterSlow = inventory.getStackInSlot(0);

 

but nothing seems to work, it always prints null.

 

I have tried checking the slot on the Client Side, and also sending a packet to the server side, and checking it there. Nothing seems to work.

 

Is this the correct way to get an ItemStack in a custom player inventory slot?

 

Thanks for your time,

 

-TheRealMcrafter

Link to comment
Share on other sites

Show the ExtendedPlayer class.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

 

 

 

public class ExtendedPlayer implements IExtendedEntityProperties{

public final static String EXT_PROP_NAME = "ExtendedPlayer";
private final EntityPlayer player;	
public final InventoryCustomPlayer inventory = new InventoryCustomPlayer();


public ExtendedPlayer(EntityPlayer player){
	this.player = player;
}

public static final void register(EntityPlayer player){
	player.registerExtendedProperties(ExtendedPlayer.EXT_PROP_NAME, new ExtendedPlayer(player));
}

public static final ExtendedPlayer get(EntityPlayer player){
	return (ExtendedPlayer) player.getExtendedProperties(EXT_PROP_NAME);
}

// Save any custom data that needs saving here
@Override
public void saveNBTData(NBTTagCompound compound){
	NBTTagCompound properties = new NBTTagCompound();

	this.inventory.writeToNBT(properties);

	compound.setTag(EXT_PROP_NAME, properties);
}

@Override
public void loadNBTData(NBTTagCompound compound){
	NBTTagCompound properties = (NBTTagCompound) compound.getTag(EXT_PROP_NAME);

	this.inventory.readFromNBT(properties);

	System.err.println("Loading Player's NBT: " + this.inventory.getStackInSlot(0) != null ? this.inventory.getStackInSlot(0) : "");
}
@Override
public void init(Entity entity, World world){
}
}

 

 

Link to comment
Share on other sites

The problem looks to be that you are always creating 'new' instances of your extended player and inventory, when what you really want is the one that should already exist:

ExtendedPlayer props = ExtendedPlayer.get(player);
props.inventory.setStackInSlot(0, new ItemStack(Items.stick));
System.out.println("Stack in slot 0: " + props.inventory.getStackInSlot(0));

Link to comment
Share on other sites

The problem looks to be that you are always creating 'new' instances of your extended player and inventory, when what you really want is the one that should already exist:

ExtendedPlayer props = ExtendedPlayer.get(player);
props.inventory.setStackInSlot(0, new ItemStack(Items.stick));
System.out.println("Stack in slot 0: " + props.inventory.getStackInSlot(0));

 

Oh! That makes sense! So where could I put that instance for the extended player then?

Link to comment
Share on other sites

Welp, that didn't seem to work either.

 

I'm doing this:

 

 
private final static ExtendedPlayer extendedPlayer = new ExtendedPlayer(Minecraft.getMinecraft().thePlayer);

    public static boolean tryToHolster(EntityPlayer player){
   		ItemStack stack = player.inventory.getCurrentItem();
	ItemStack holsterSlot = extendedPlayer.inventory.getStackInSlot(0);


	System.err.println(holsterSlot);
	System.err.println(extendedPlayer.inventory.getStackInSlot(0));

	if (stack != null){
		if (stack.getItem() == CitiesMod.M1911){
			if (holsterSlot != null){
				System.err.println("Reached!");
			}
		} else if (stack.getItem() == CitiesMod.Glock21){
			if (holsterSlot != null){
				System.err.println("Reached!");

			}
		}
	}
    	
    	return false;
    }

Link to comment
Share on other sites

Oh dear lord...

 

1. DO NOT use 'static' fields to store the player, extended properties, or anything else - clearly you don't know what it's for.

 

2. DO NOT use Minecraft.getMinecraft().thePlayer - that is CLIENT side only player.

 

3. You are still using a 'new ExtendedPlayer' - NEVER do that - the player already has an ExtendedPlayer instance created by Forge, which is why you use the ExtendedPlayer.get(player) method to retrieve it (which is just a wrapper for player.getExtendedProperties("YourProperties")).

Link to comment
Share on other sites

Oh dear lord...

 

1. DO NOT use 'static' fields to store the player, extended properties, or anything else - clearly you don't know what it's for.

 

2. DO NOT use Minecraft.getMinecraft().thePlayer - that is CLIENT side only player.

 

3. You are still using a 'new ExtendedPlayer' - NEVER do that - the player already has an ExtendedPlayer instance created by Forge, which is why you use the ExtendedPlayer.get(player) method to retrieve it (which is just a wrapper for player.getExtendedProperties("YourProperties")).

 

I know, I know! I've just been trying everything possible to get this to work. (Even doing things I know I shouldnt)  :'(

 

And THATS what I needed, I forgot I had that .get(player) method. Thanks for all your help!

 

Edit: Seriously, thank you so much coolAlias. Your tutorials and explanations are amazing and you dont get enough credit for what you do for the forge community :)

 

-TheRealMcrafter

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Meaning I need to restart the server and redownload cobblemon?
    • Crash with the error: The game crashed whilst exception ticking world Error: java.util.ConcurrentModificationException pastebin crashlog the game worked for like 24h, then started to receive this error. Things I've tried: removing optifine or other performace mods. tried different versions (older) of the pack. set true to remove error entities and tiles in forge.cfg asked for help on the sevtech github, they said its fixed, its not. tried a different pc and still crashed happened only one time on another map although i cant make it happen again on that map.
    • no this one https://pastebin.com/5uMxHeWf
    • I am in such a mess. I have lost over 4.7m due to a scammer... It started as bank wires and then bitcoin. it is hard to imagine but it is true and can send any proof, then I tried to use a couple of recovery companies and was as well. Graphic design has been more than just a hobby for me since high school—it has become a thriving career. Starting in my parents' garage, I eventually expanded to my office, running a successful graphic design business. However, like many, I faced the need to diversify my investments due to inflation. This led me to invest 60.16 in Bitcoin, a decision that paid off handsomely as my investment grew to 4.7m over time. This financial windfall allowed me to upgrade my equipment and take on more ambitious projects, furthering the growth of my business. Unfortunately, my excitement was abruptly cut short when I fell victim to a hacking incident. Malware infected my computer, giving hackers access to my Bitcoin wallet. The devastation of potentially losing all my hard-earned savings and plans weighed heavily on me. At this dire moment, a fellow designer suggested Linux Cyber Security Company as a potential solution. Desperate for a lifeline, I reached out to them, hoping for a miracle. The response from Linux Cyber Security Company was prompt, incredibly professional, and effective. Their team quickly traced the hacker’s activities and recovered most of my funds, alleviating a significant amount of stress and uncertainty. Beyond the recovery, they took the time to educate me on essential practices to secure my Bitcoin holdings better. They emphasized using antivirus software to prevent malware infections, avoiding suspicious downloads, and the added security provided by hardware wallets. This experience served as a critical wake-up call for me. It highlighted the vulnerabilities inherent in digital assets and underscored the importance of robust security measures. Thanks to the guidance and expertise of Linux Cyber Security Company, I now feel more equipped to protect my digital assets proactively. Their insights have empowered me to implement stronger security protocols in my business operations and personal finances alike. With my Bitcoin funds securely recovered and a newfound understanding of digital security best practices, I am more confident in navigating future challenges. This journey has reinforced my commitment to safeguarding my hard-earned assets and leveraging technology responsibly. I am optimistic about the growth opportunities ahead, creatively in graphic design and prudently in investment strategies. In conclusion, while the hacking incident was a setback, it ultimately became a catalyst for enhancing my digital security awareness and resilience. I am grateful to Linux Cyber Security Company for their expertise and support during a challenging time, enabling me to continue pursuing my passion for graphic design with renewed confidence and financial stability. Contact a professional company I am sure they can help you with your case too, Website [www.linuxcybersecurity.com Email the team; info@)(linuxcybersecurity.com
    • https://pastebin.com/B2HnBZTa
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.