How can i getStackInSlot in a custom IInventory.

[TheRealMcrafter]

Hey,

 

I have created a custom player inventory, with one extra slot. When I try to get the ItemStack in that slot, it always returns null, even if I do something like

setInventorySlotContents(0, new ItemStack(Blocks.dirt));

before a System.out.println(getStackInSlot(0))

 

I have tried the following ways of getting the itemstack:

 

ExtendedPlayer extendedPlayer = new ExtendedPlayer(getPlayer());
ItemStack holsterSlot = extendedPlayer.inventory.getStackInSlot(0);

 

InventoryCustomPlayer inventory = new InventoryCustomPlayer();
ItemStack holsterSlow = inventory.getStackInSlot(0);

 

but nothing seems to work, it always prints null.

 

I have tried checking the slot on the Client Side, and also sending a packet to the server side, and checking it there. Nothing seems to work.

 

Is this the correct way to get an ItemStack in a custom player inventory slot?

 

Thanks for your time,

 

-TheRealMcrafter

[deadrecon98]

Could I get the error log as well as me methods you are using?

[larsgerrits]

Show the ExtendedPlayer class.

[TheRealMcrafter]

I never said there was an error, it is just always null, even though I can see the item in the slot, and if I put the System.out... statement in InventoryCustomPlayer#getStackInSlot, and I open up my custom inventory GUI, it prints out the correct item.

[TheRealMcrafter]

 

 

 

public class ExtendedPlayer implements IExtendedEntityProperties{

public final static String EXT_PROP_NAME = "ExtendedPlayer";
private final EntityPlayer player;	
public final InventoryCustomPlayer inventory = new InventoryCustomPlayer();


public ExtendedPlayer(EntityPlayer player){
	this.player = player;
}

public static final void register(EntityPlayer player){
	player.registerExtendedProperties(ExtendedPlayer.EXT_PROP_NAME, new ExtendedPlayer(player));
}

public static final ExtendedPlayer get(EntityPlayer player){
	return (ExtendedPlayer) player.getExtendedProperties(EXT_PROP_NAME);
}

// Save any custom data that needs saving here
@Override
public void saveNBTData(NBTTagCompound compound){
	NBTTagCompound properties = new NBTTagCompound();

	this.inventory.writeToNBT(properties);

	compound.setTag(EXT_PROP_NAME, properties);
}

@Override
public void loadNBTData(NBTTagCompound compound){
	NBTTagCompound properties = (NBTTagCompound) compound.getTag(EXT_PROP_NAME);

	this.inventory.readFromNBT(properties);

	System.err.println("Loading Player's NBT: " + this.inventory.getStackInSlot(0) != null ? this.inventory.getStackInSlot(0) : "");
}
@Override
public void init(Entity entity, World world){
}
}

 

 

[coolAlias]

The problem looks to be that you are always creating 'new' instances of your extended player and inventory, when what you really want is the one that should already exist:

ExtendedPlayer props = ExtendedPlayer.get(player);
props.inventory.setStackInSlot(0, new ItemStack(Items.stick));
System.out.println("Stack in slot 0: " + props.inventory.getStackInSlot(0));

[TheRealMcrafter]

The problem looks to be that you are always creating 'new' instances of your extended player and inventory, when what you really want is the one that should already exist:

ExtendedPlayer props = ExtendedPlayer.get(player);
props.inventory.setStackInSlot(0, new ItemStack(Items.stick));
System.out.println("Stack in slot 0: " + props.inventory.getStackInSlot(0));

 

Oh! That makes sense! So where could I put that instance for the extended player then?

[coolAlias]

You have to get it every time you want to use it, i.e. as a local variable in whatever method you happen to be in, or even a class constructor such as the Container / GUI combo for your GUI.

[TheRealMcrafter]

I'm using it in a custom class, that is called when the server gets a packet from my key handler. I can't believe i missed a solution as simple as that, although I've been at this for a long time now so I probably cant see straight 

[TheRealMcrafter]

Welp, that didn't seem to work either.

 

I'm doing this:

 

 
private final static ExtendedPlayer extendedPlayer = new ExtendedPlayer(Minecraft.getMinecraft().thePlayer);

    public static boolean tryToHolster(EntityPlayer player){
   		ItemStack stack = player.inventory.getCurrentItem();
	ItemStack holsterSlot = extendedPlayer.inventory.getStackInSlot(0);


	System.err.println(holsterSlot);
	System.err.println(extendedPlayer.inventory.getStackInSlot(0));

	if (stack != null){
		if (stack.getItem() == CitiesMod.M1911){
			if (holsterSlot != null){
				System.err.println("Reached!");
			}
		} else if (stack.getItem() == CitiesMod.Glock21){
			if (holsterSlot != null){
				System.err.println("Reached!");

			}
		}
	}
    	
    	return false;
    }

[coolAlias]

Oh dear lord...

 

1. DO NOT use 'static' fields to store the player, extended properties, or anything else - clearly you don't know what it's for.

 

2. DO NOT use Minecraft.getMinecraft().thePlayer - that is CLIENT side only player.

 

3. You are still using a 'new ExtendedPlayer' - NEVER do that - the player already has an ExtendedPlayer instance created by Forge, which is why you use the ExtendedPlayer.get(player) method to retrieve it (which is just a wrapper for player.getExtendedProperties("YourProperties")).

[TheRealMcrafter]

Oh dear lord...

 

1. DO NOT use 'static' fields to store the player, extended properties, or anything else - clearly you don't know what it's for.

 

2. DO NOT use Minecraft.getMinecraft().thePlayer - that is CLIENT side only player.

 

3. You are still using a 'new ExtendedPlayer' - NEVER do that - the player already has an ExtendedPlayer instance created by Forge, which is why you use the ExtendedPlayer.get(player) method to retrieve it (which is just a wrapper for player.getExtendedProperties("YourProperties")).

 

I know, I know! I've just been trying everything possible to get this to work. (Even doing things I know I shouldnt)  :'(

 

And THATS what I needed, I forgot I had that .get(player) method. Thanks for all your help!

 

Edit: Seriously, thank you so much coolAlias. Your tutorials and explanations are amazing and you dont get enough credit for what you do for the forge community

 

-TheRealMcrafter