Jump to content

Recommended Posts

Posted

Hello, I cannot seem to be able to render a simple item/block in forge 1.8-11.14.0.1299 using eclipse

I wrote a quick test mod to narrow down the problem.

 

The client crashes at the following method:

public static void registerRender(Item item){
	Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, new ModelResourceLocation(Reference.MOD_ID + ":" + item.getUnlocalizedName().substring(5), "inventory"));	
}

with the corresponding crash details:

http://pastebin.com/0XSA7642

 

I have both a model file in "src\main\resources\assets\testmod\models\item"  called "test_item.json"

and a texture in "src\main\resources\assets\testmod\textures\items" called "test_item.png"

 

Posted

Not enough code. Follow the stacktrace. You are probably trying to register renderer to not yet initialized item/block.

1.7.10 is no longer supported by forge, you are on your own.

Posted

Main Class:

package com.kandivia.testmod.main;

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;

import com.kandivia.testmod.init.RegisterItems;
import com.kandivia.testmod.proxy.CommonProxy;

@Mod(modid = Reference.MOD_ID, name = Reference.MOD_NAME, version = Reference.VERSION)
public class MainRegistry{

@SidedProxy(clientSide = Reference.CLIENT_PROXY_CLASS, serverSide = Reference.SERVER_PROXY_CLASS)
public static CommonProxy proxy;

@EventHandler
public void preInit(FMLPreInitializationEvent preEvent){
	RegisterItems.init();
	RegisterItems.register();
}

@EventHandler
public void init(FMLPreInitializationEvent Event){
	proxy.registerRenders();
}

@EventHandler
public void postInit(FMLPreInitializationEvent postEvent){
}

}

 

Item Register Class:

package com.kandivia.testmod.init;

import net.minecraft.client.Minecraft;
import net.minecraft.client.resources.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.fml.common.registry.GameRegistry;

import com.kandivia.testmod.main.Reference;

public class RegisterItems {
public static Item test_item;

public static void init(){
	test_item = new Item().setUnlocalizedName("test_item");
}

public static void register(){
	GameRegistry.registerItem(test_item, test_item.getUnlocalizedName().substring(5));
}

public static void registerRenders(){
	registerRender(test_item);
}

public static void registerRender(Item item){
	Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, new ModelResourceLocation(Reference.MOD_ID + ":" + item.getUnlocalizedName().substring(5), "inventory"));	
}

}

Proxy Classes:

package com.kandivia.testmod.proxy;

import com.kandivia.testmod.init.RegisterItems;

public class ClientProxy extends CommonProxy{
@Override
public void registerRenders(){
	RegisterItems.registerRenders();
}
}

package com.kandivia.testmod.proxy;

public class CommonProxy {
public void registerRenders(){

}
}

 

Reference Class:

package com.kandivia.testmod.main;

public class Reference {
public static final String MOD_ID = "testmod";
public static final String MOD_NAME = "Test Mod";
public static final String VERSION = "1.0";
public static final String CLIENT_PROXY_CLASS = "com.kandivia.testmod.proxy.ClientProxy";
public static final String SERVER_PROXY_CLASS = "com.kandivia.testmod.proxy.CommonProxy";

}

 

Rendering is in the init method and should run well after Item registers in the preInit method

 

 

Posted

1. Renderers should be in load(). (you are good here).

2. Are you sure you know how .substring(index) works? You are taking String from 5 index to end. (That will cause bad texture naming).

 

I am sorry, I don't see anything. My code looks very similar. ;c

P.S: Be on the safe side - check for null in registerRender(Item item)

 

1.7.10 is no longer supported by forge, you are on your own.

Posted

item.getUnlocalizedName().substring(5) equates to "testitem" as doubled checked with a simple print statement

 

So it should be the same as:

new ModelResourceLocation("testmod:testitem", "inventory");

 

Running the game is just fine without running the render code. Trying to check for null atm.

Posted

This would not be directly related with your issue, but you should import and access Minecraft only in client proxy or client-only class.

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Posted

Narrowed the problem down futher today. Seems like i can't reference testitem after preInit?

 

Will Crash:

public static void registerRender(Item item){
String name = item.getUnlocalizedName().substring(5);
}

 

No Crash:

public static void registerRender(Item item){
String name = "testmod:testitem";
}

 

Will Crash:

public static void registerRender(Item item){
ModelResourceLocation loc = new ModelResourceLocation("testmod:testitem", "inventory");
Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, loc); // Crash on this line	
}

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I want to create block with entity, that will have height of 3 or more(configurable) and I tried to change first VoxelShape by increasing collision box on height I want and for changing block height on visual side i tried to configure BlockModelBuilder:  base.element() .from(0, 0, 0) .to(16f, 48f, 16f) .face(Direction.UP).texture("#top").end() .face(Direction.DOWN).texture("#bottom").end() .face(Direction.NORTH).texture("#side").end() .face(Direction.SOUTH).texture("#side").end() .face(Direction.WEST).texture("#side").end() .face(Direction.EAST).texture("#side").end() .end(); but, getting crash with next error: Position y out of range, must be within [-16, 32]. Found: %d [48.0]; Looks like game wont to block height modified by more than 32. Is there any way to fix that problem?
    • As long as the packets you are sending aren't lost, there's nothing wrong with what you're currently doing. Although, this sounds like something that would benefit from you making your own datapack registry instead of trying to arbitrarily sync static maps. Check out `DataPackRegistryEvent.NewRegistry`.
    • Hey all, I've been working a lot with datapacks lately, and I'm wondering what the most efficient way to get said data from server to client is.  I'm currently using packets, but given that a lot of the data I'm storing involves maps along the lines of Map<ResourceLocation, CustomDataType>, it can easily start to get messy if I need to transmit a lot of that data all at once. Recently I started looking into the ReloadableServerResources class, which is where Minecraft stores its built-ins.  I see you can access it via the server from the server's resources.managers, and it seems like this can be done even from the client to appropriately retrieve data from the server, unless I'm misunderstanding.  However, from what I can tell, this only works via built-in methods such as getRecipeManager() or getLootTables(), etc.  These are all SimpleJsonResourceReloadListeners, just like my datapack entries are, so it seems like it could be possible for me to access my datapack entries similarly?  But I don't see anywhere in ReloadableServerResources that stores loaded modded entries, so either I'm looking in the wrong place or it doesn't seem to be a thing. Are packets really the best way of doing this, or am I missing a method that would let me use ReloadableServerResources or something similar?
    • Hi, everyone! I'm new to minecraft modding stuff and want ask you some questions. 1. I checked forge references and saw there com.mojang and net.minecraft (not net.minecraftforge) and as I understand it's original game packages with all minecraft logic inside including renderers and so on, right? 2. Does it mean that forge has a limited set of instruments which doesn't cover all the aspects of the game? If make my question more specific then does forge provide such instruments that allow me totally change minecraft itself, like base mechanics and etc.? Or I have to use "original game packages" to implement such things? 3. I actively learning basic concepts with forge documentation and tutorials. So in my plans make different inventory system like in diabloids. Is that possible with forge? 4. It is last question related to the second one. So how deeply I can change minecraft with forge? I guess all my questions above because of that I haven't globally understanding what forge is and how it works inside and how it works with minecraft. It would be great if you provide some links or topics about it or explain it by yourself but I guess it's to big to be explained in that post at once. Anyway, thank you all for any help!
    • Im trying add to block a hole in center, just a usual block and in center of it on up side, there is should be a hole. I tried to add it via BlockModelBuilder, but its not working. Problem is that it only can change block size outside. I tried it to do with VoxelShape and its working, but its has been on server side and looks like its just changed collision shape, but for client, there is a texture covering this hole. I tried to use: base.renderType("cutout"); and removed some pixels from texture. I thought its should work, but game optimization makes block inside looks transparent. So, only custom model?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.