[solved][1.8] Problem with TileEntities

[Failender]

I create my own tileentity.

Right now its only use is to safe its owner and return it

The Problem is, that even if the setOwner method is called correctly and the String seems to be set properly, the TileEntity is ALWAYS returning null and I have no idea why

I guess im missing one little part that is ruining it, but I cant find it

 

[02:10:57] [server thread/INFO] [sTDOUT]: [de.failender.challengemod.blocks.ResearchCenter:onBlockActivated:48]: null

 

 
public class TileEntityResearch extends TileEntity{

private String owner;

public void setOwner(String owner)
{
	this.owner = owner;
}

public String getOwner()
{
	return owner;
}


@Override
public void readFromNBT(NBTTagCompound compound) {
	compound.getString("rc");
	super.readFromNBT(compound);
}

@Override
public void writeToNBT(NBTTagCompound compound) {
	compound.setString("rc", owner);
	super.writeToNBT(compound);
}

 

I registered my tileentity like so

GameRegistry.registerTileEntity(TileEntityResearch.class, "researchcenterentity");

 

And created my own block using the TileEntitiy

 

public class ResearchCenter extends Block{

public ResearchCenter() {
	super(Material.rock);
	setCreativeTab(CreativeTabs.tabTools);

}

@Override
public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state,
		EntityLivingBase placer, ItemStack stack) {
	if (!worldIn.isRemote)
    	{
    		TileEntityResearch rc = (TileEntityResearch) worldIn.getTileEntity(pos);
    		rc.setOwner(placer.getName());
    	}
	super.onBlockPlacedBy(worldIn, pos, state, placer, stack);
}

@Override
public boolean onBlockActivated(World worldIn, BlockPos pos,
		IBlockState state, EntityPlayer playerIn, EnumFacing side,
		float hitX, float hitY, float hitZ) {

	if (!worldIn.isRemote)
	{
		TileEntityResearch rc = (TileEntityResearch) worldIn.getTileEntity(pos);
		System.out.println(rc.getOwner());

	}



	return super.onBlockActivated(worldIn, pos, state, playerIn, side, hitX, hitY,
			hitZ);
}

@Override
public boolean hasTileEntity(IBlockState state) {
	return true;
}

@Override
public TileEntity createTileEntity(World world, IBlockState state) {
	// TODO Auto-generated method stub
	return new TileEntityResearch();
}



}

 

 

[Draco18s]

You need to save the data in an NBT tag (read/write to/from NBT methods) and then add:

 

	@Override
public Packet getDescriptionPacket() {
	NBTTagCompound nbtTag = new NBTTagCompound();
	writeToNBT(nbtTag);
	return new S35PacketUpdateTileEntity(xCoord, yCoord, zCoord, 1, nbtTag);
}

@Override
public void onDataPacket(NetworkManager net, S35PacketUpdateTileEntity packet) {
	readFromNBT(packet.func_148857_g());
}

 

So that the data is passed from server to client.

[Failender]

Perfect. It works now. Thank you very much!

[Failender]

Just one more question so I'll get it right.

The method u showed me sends the nbt package, which is server sided, to the client. Is this method called everytime the client tries to read the nbt of that tileentity?

[Draco18s]

It's not sided.  But it gets sent any time the server sees that it needs to be sent.  You'll want to call

worldObj.markBlockForUpdate(xCoord, yCoord, zCoord);

if you make any changes to the data and it needs to update right away.

[Failender]

It seemed to be working. But it seems like there is an error when he tries to safe the String owner.

 

Any Ideas?

 

[03:52:13] [Client thread/INFO] [sTDOUT]: [net.minecraft.init.Bootstrap:printToSYSOUT:568]: #@!@# Game crashed! Crash report saved to: #@!@# .\crash-reports\crash-2015-02-23_03.52.13-server.txt

[03:52:13] [Client thread/INFO] [FML]: Waiting for the server to terminate/save.

[03:52:13] [server thread/ERROR] [FML]: A TileEntity type de.failender.challengemod.tileentities.TileEntityResearch has throw an exception trying to write state. It will not persist. Report this to the mod author

java.lang.IllegalArgumentException: Empty string not allowed

at net.minecraft.nbt.NBTTagString.<init>(NBTTagString.java:23) ~[NBTTagString.class:?]

at net.minecraft.nbt.NBTTagCompound.setString(NBTTagCompound.java:105) ~[NBTTagCompound.class:?]

at de.failender.challengemod.tileentities.TileEntityResearch.writeToNBT(TileEntityResearch.java:33) ~[TileEntityResearch.class:?]

at net.minecraft.world.chunk.storage.AnvilChunkLoader.writeChunkToNBT(AnvilChunkLoader.java:382) [AnvilChunkLoader.class:?]

at net.minecraft.world.chunk.storage.AnvilChunkLoader.saveChunk(AnvilChunkLoader.java:183) [AnvilChunkLoader.class:?]

at net.minecraft.world.gen.ChunkProviderServer.saveChunkData(ChunkProviderServer.java:246) [ChunkProviderServer.class:?]

at net.minecraft.world.gen.ChunkProviderServer.saveChunks(ChunkProviderServer.java:305) [ChunkProviderServer.class:?]

at net.minecraft.world.WorldServer.saveAllChunks(WorldServer.java:938) [WorldServer.class:?]

at net.minecraft.server.MinecraftServer.saveAllWorlds(MinecraftServer.java:363) [MinecraftServer.class:?]

at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:395) [MinecraftServer.class:?]

at net.minecraft.server.integrated.IntegratedServer.stopServer(IntegratedServer.java:328) [integratedServer.class:?]

at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:531) [MinecraftServer.class:?]

at java.lang.Thread.run(Thread.java:745) [?:1.7.0_55]

[Failender]

Nevermind i found it