[SOLVED][1.6.4] Trying to make a custom potion effect

[shmcrae]

I got it working, but when the time goes to 0 the potion effect still lasts. I'm trying to make an immortal potion so when they drink it nothing can damage them for 25 seconds.

 

Main:

 

 

 

        public static Potion ImmortalPotion;

 

@PreInit

public void load(FMLPreInitializationEvent event)

{

Potion[] potionTypes = null;

 

for (Field f : Potion.class.getDeclaredFields())

{

f.setAccessible(true);

try

{

if (f.getName().equals("potionTypes") || f.getName().equals("field_76425_a"))

{

Field modfield = Field.class.getDeclaredField("modifiers");

modfield.setAccessible(true);

modfield.setInt(f, f.getModifiers() & ~Modifier.FINAL);

 

potionTypes = (Potion[])f.get(null);

final Potion[] newPotionTypes = new Potion[256];

System.arraycopy(potionTypes, 0, newPotionTypes, 0, potionTypes.length);

f.set(null, newPotionTypes);

}

}

catch (Exception e)

{

System.err.println("Severe error, please report this to the mod author:");

System.err.println(e);

}

 

 

MinecraftForge.EVENT_BUS.register(new AlchemyMainEventHooks());

}

}

 

@Init

public void load(FMLInitializationEvent event)

{

ImmortalPotion = (new PotionAlchemy(32, false, 0)).setIconIndex(0, 0).setPotionName("potion.ImmortalPotion");

}

 

 

 

Event Hook:

 

 

        @ForgeSubscribe

public void onEntityUpdate(LivingUpdateEvent event)

{

if (event.entityLiving.isPotionActive(AlchemyMain.ImmortalPotion))

{

if (event.entityLiving.worldObj.rand.nextInt(20) == 0)

{

PlayerCapabilities.disableDamage = true;

}

 

if (event.entityLiving.getActivePotionEffect(AlchemyMain.ImmortalPotion).getDuration() == 0)

{

event.entityLiving.removePotionEffect(AlchemyMain.ImmortalPotion.id);

PlayerCapabilities.disableDamage = false;

return;

}

 

}

}

 

 

 

If im missing anything let me know, thanks.

[Abastro]

Where did you registered the potion to the array? You didn't in Main class.

If you didn't, try adding the potion to the array.

[shmcrae]

where exactly would i register the potion? and how would i register it? would i replace the potionType with my potion name?

Thanks for your time!

[Abastro]

Oh I misread the Potion class. The constructor would automatically registers the potion.

[shmcrae]

So do you see anything wrong in the EventHook class?

[Abastro]

It seems that PotionEfect#getDuration() does not return 0 when LivingUpdateEvent called.

Maybe changing 0 to 1 would solve your problem.

 

EDIT: No, Don't do the suggestion above.

There is some methods in Potion meeting your needs.

 

So.

1. Make your own Potion class,

2. Override applyAttributesModifiersToEntity, and add ability there.

3. Override removeAttributesModifiersFromEntity, and remove ability there.

[shmcrae]

In my main class

@Init

  public void load(FMLInitializationEvent event)

  {

      ImmortalPotion = (new PotionAlchemy(32, false, 0)).setIconIndex(0, 0).setPotionName("potion.ImmortalPotion");

  }

 

is the "PotionAlchemy" the potion class?

[Abastro]

Of course it is your potion class :  PotionAlchemy class.

[shmcrae]

Like this?

 

@Override

public void applyAttributesModifiersToEntity(EntityLivingBase par1EntityLivingBase, BaseAttributeMap par2BaseAttributeMap, int par3)

    {

PlayerCapabilities.disableDamage = true;

    }

 

@Override

public void removeAttributesModifiersFromEntity(EntityLivingBase par1EntityLivingBase, BaseAttributeMap par2BaseAttributeMap, int par3)

    {

PlayerCapabilities.disableDamage = false;

    }

[shmcrae]

Anybody?

[Abastro]

Like this?

 

@Override

public void applyAttributesModifiersToEntity(EntityLivingBase par1EntityLivingBase, BaseAttributeMap par2BaseAttributeMap, int par3)

    {

PlayerCapabilities.disableDamage = true;

    }

 

@Override

public void removeAttributesModifiersFromEntity(EntityLivingBase par1EntityLivingBase, BaseAttributeMap par2BaseAttributeMap, int par3)

    {

PlayerCapabilities.disableDamage = false;

    }

 

Correct, try that.

[shadowfacts]

Update to 1.7.10 if not 1.8, 1.6.4 is ancient.

[shmcrae]

i don't want to update because im familiar to 1.6.4 code, and i already tested that and it doesn't work sooo im really stuck here

 

[jkorn2324swagg]

Shmcrae if you are familiar to the 1.6 code can you help me with my question I'm also stuck at 1.6.4

[shmcrae]

I might be able to help, whats your question

[jkorn2324swagg]

My question is the topic right below you It says:

[1.6.4] Custom branches and custom leaf patterns

[shmcrae]

Ok ill see what i can do and ill post on your forum

[jkorn2324swagg]

Ok thanks

[shmcrae]

I still really need help with this if anyone can help me please

[Abastro]

What was problem.? Doesn't the code work?

[shmcrae]

it doesn't work, do i need to get rid of my EventHook?

[Abastro]

Ah yes of course.

[shmcrae]

ok ill try that

[shmcrae]

now it doesn't work at all, when i drink it i take damage

[Abastro]

Sorry, there was some mistakes I did.

1. You have to check if the Entity is player, and get the PlayerCapabilities for the player, and disable Damage for that.

2. Does applyAttributesModifiersToEntity not called? Check it.