[solved]Code for Fly Ring

[Xetapro12]

What i do wrong?

 

package com.BetterArmourAndTools.blocksitems;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraftforge.event.entity.player.PlayerEvent;

public class FlyRing extends Item{

public FlyRing(int id){
	super();
	this.setCreativeTab(BetterArmourAndTools.rubyTab);
	this.setMaxStackSize(1);
}

@SideOnly(Side.CLIENT)
public void registerIcons(IIconRegister reg){
	this.itemIcon = reg.registerIcon("BetterArmourAndTools:FlyRing");
}

public void onUpdate(ItemStack par1ItemStack, World par2World, Entity par3Entity, int par4, boolean par5) {
	super.onUpdate(par1ItemStack, par2World, par3Entity, par4, par5);

	EntityPlayer player = (EntityPlayer) par3Entity;

	ItemStack flyingRingItemStack = new ItemStack(BetterArmourAndTools.FlyRing, 1, 0);

	for(i = 0; i <= 8; i++) {
	if(player.inventory.mainInventory[i] != null &amp;&amp; player.inventory.mainInventory[i].isItemEqual(flyingRingItemStack)) {
	player.capabilities.allowFlying = true;
	}else{
	player.capabilites.allowFlying = false;
	}

	if(i ==  {
	i = 0;
	}
	}
	}
}

 

[Xetapro12]

the under ItemStack flyRIngItemStack is red and a fail whats wrong?

[Draco18s]

Right click -> Source -> Correct Indentation (its magic).

[Xetapro12]

Right click -> Source -> Correct Indentation (its magic).

this really dont help

http://gyazo.com/24c8b987a40c4e592f2b7ca0c9bbdd88

[larsgerrits]

What up with that

&&

?

[Xetapro12]

idk i found a annother code here on the forum and its from 1.6.4 just copy it and try making it work for i trying to Check if he have FLyRing in inventory he be allowed to have CreativeFly

 

How i check for

BetterArmourAndTools.FlyRing = true then player.capabilities.allowFlying how

[larsgerrits]

You can check if the player has an Item in it's inventory with this:

player.inventory.hasItem(Item)

.

You can allow creative flying by setting

player.capabilities.allowFlying

to

true

.

[Xetapro12]

package com.BetterArmourAndTools.blocksitems;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraftforge.event.entity.player.PlayerEvent;

public class FlyRing extends Item{

public FlyRing(int id){
	super();
	this.setCreativeTab(BetterArmourAndTools.rubyTab);
	this.setMaxStackSize(1);

	if(player.inventory.getCurrentItem() != null && player.inventory.getCurrentItem().ItemID == BetterArmourAndTools.FlyRing)
	{
	System.out.println("CALL");
	player.capabilities.allowFlying = true;
}

@SideOnly(Side.CLIENT)
public void registerIcons(IIconRegister reg){
	this.itemIcon = reg.registerIcon("BetterArmourAndTools:FlyRing");

}
}

 

dont think this is the best thing to doo

[Xetapro12]

Again. Please, for the love of god use proper indentation.

It makes the error obvious. I did it for you this time.

 

I know but this dont work http://gyazo.com/49f32b5a20327815d126115cb69b4f3d

 

player.inventory and player.capabilities i try to use the easy fix but nothing pop up

[Xetapro12]

Learn Java.

Yeah Yeah its not the first time you say it . i have readed alot of java things but i really dont understand it better so im sorry about thet  *Sad face PANDA!* :'(

[artman41]

What he means is you need to learn simple coding in general. For example, when reading the pastebin Diesieben made, I noticed that your public method didn't have a closing brace (}) you opened two braces and only close one.

 

You need to learn how to use simple code like diesie said before tackling things like this. If I were you, I would try a simpler language or learn how IF, AND and NOT functions work and watch a tutorial about how to use them. Learn the language and the general rules about them.

 

9 times out of 10, indentation WILL help identify a problem. To identify a problem, follow the code; it's a piece of text that should do what you want when you read it in your head and indentation will help you read it.

 

Copying and Pasting is also not learning how to code. It's cheating and you'll learn nothing that way. Try to achieve somethings on your own. For example, create a java app that calls a method that checks if a boolean is true or false and then outputs something to the console, WITHOUT googling for help and copying. Training yourself with exercises like this is what will help you learn how to code.

[Xetapro12]

What he means is you need to learn simple coding in general. For example, when reading the pastebin Diesieben made, I noticed that your public method didn't have a closing brace (}) you opened two braces and only close one.

 

You need to learn how to use simple code like diesie said before tackling things like this. If I were you, I would try a simpler language or learn how IF, AND and NOT functions work and watch a tutorial about how to use them. Learn the language and the general rules about them.

 

9 times out of 10, indentation WILL help identify a problem. To identify a problem, follow the code; it's a piece of text that should do what you want when you read it in your head and indentation will help you read it.

 

Copying and Pasting is also not learning how to code. It's cheating and you'll learn nothing that way. Try to achieve somethings on your own. For example, create a java app that calls a method that checks if a boolean is true or false and then outputs something to the console, WITHOUT googling for help and copying. Training yourself with exercises like this is what will help you learn how to code.

 

It's not about reading.

Stop modding for a while. Follow a Java tutorial and make your own app. Even if it's just a simple calculator. It is important that you create this app without any help, that is not by just copying the steps from a tutorial.

 

Then start modding again. Yes, it will take time, but that's just the way it is. Learning programming takes time.

 

I know i know i gonna stop modding :'(