Jump to content

Structure "regenerates" itself [SOLVED]


IgazHarcos

Recommended Posts

Hi everybody, I begin modding days ago, and try to create a structure. It works fine, but when i break a block of the structure, the block created again a little later. I think, the game generates again the entire structure (I use fix coordinates for test), but Í don't know how to fix this. I use the latest Forge for Minecraft 1.8. Here is my codes:

 

 

WorldGen.java:

 


package com.harcos.bunkerstrukture.common;

import java.util.Random;

import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraftforge.fml.common.IWorldGenerator;

public class WorldGen implements IWorldGenerator 
{
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider)
{
  switch (world.provider.getDimensionId())
  {
   case 0: generateSurface(world, random, chunkX*16, chunkZ*16);
  }
}

  

  private void generateSurface(World world, Random random, int blockX, int blockZ) 
{
  
  int Xcoord1 = blockX + random.nextInt(16);
  int Ycoord1 = random.nextInt(80);
  int Zcoord1 = blockZ + random.nextInt(16);
   
  (new StructureGenerator()).generate(world, 1, 500, 100, 500);
}

}


 

StructureGenerator:

 



package com.harcos.bunkerstrukture.common;

import java.util.Random;

import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Blocks;
import net.minecraft.util.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.gen.feature.WorldGenerator;

public class StructureGenerator extends WorldGenerator
{
    public boolean generate(World par1World, int par2, int par3, int par4, int par5)
    {
    	/*
        while (par1World.isAirBlock(new BlockPos(par3, par4, par5)) && par4 > 2)       
        {
            --par4;
        }
        */
        IBlockState checkBlock = par1World.getBlockState(new BlockPos(par3, par4, par5));
        par1World.setBlockState(new BlockPos(par3, par4, par5), Blocks.air.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4, par5+1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4, par5+1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4, par5+1), Blocks.brick_block.getDefaultState());
        
        par1World.setBlockState(new BlockPos(par3, par4-1, par5), Blocks.air.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4-1, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4-1, par5+1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-1, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-1, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-1, par5+1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-1, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-1, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-1, par5+1), Blocks.brick_block.getDefaultState());

        par1World.setBlockState(new BlockPos(par3, par4-2, par5), Blocks.air.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4-2, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4-2, par5+1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-2, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-2, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-2, par5+1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-2, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-2, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-2, par5+1), Blocks.brick_block.getDefaultState());
        
        par1World.setBlockState(new BlockPos(par3, par4-3, par5), Blocks.air.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4-3, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4-3, par5+1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-3, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-3, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-3, par5+1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-3, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-3, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-3, par5+1), Blocks.brick_block.getDefaultState());
        

            par1World.setBlockState(new BlockPos(par3, par4-4, par5), Blocks.air.getDefaultState());
            par1World.setBlockState(new BlockPos(par3, par4-4, par5-1), Blocks.air.getDefaultState());
            par1World.setBlockState(new BlockPos(par3, par4-4, par5+1), Blocks.air.getDefaultState());
            par1World.setBlockState(new BlockPos(par3-1, par4-4, par5-1), Blocks.air.getDefaultState());
            par1World.setBlockState(new BlockPos(par3-1, par4-4, par5), Blocks.air.getDefaultState());
            par1World.setBlockState(new BlockPos(par3-1, par4-4, par5+1), Blocks.air.getDefaultState());
            par1World.setBlockState(new BlockPos(par3+1, par4-4, par5-1), Blocks.air.getDefaultState());
            par1World.setBlockState(new BlockPos(par3+1, par4-4, par5), Blocks.air.getDefaultState());
            par1World.setBlockState(new BlockPos(par3+1, par4-4, par5+1), Blocks.air.getDefaultState());
            
        par1World.setBlockState(new BlockPos(par3-2, par4-4, par5-2), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-4, par5-2), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4-4, par5-2), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-4, par5-2), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+2, par4-4, par5-2), Blocks.brick_block.getDefaultState());
        
        par1World.setBlockState(new BlockPos(par3-2, par4-4, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+2, par4-4, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-2, par4-4, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+2, par4-4, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-2, par4-4, par5+1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+2, par4-4, par5+1), Blocks.brick_block.getDefaultState());
        
        par1World.setBlockState(new BlockPos(par3-2, par4-4, par5+2), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-4, par5+2), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4-4, par5+2), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-4, par5+2), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+2, par4-4, par5+2), Blocks.brick_block.getDefaultState());
        

        par1World.setBlockState(new BlockPos(par3, par4-5, par5-1), Blocks.air.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4-5, par5+1), Blocks.air.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-5, par5-1), Blocks.air.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-5, par5), Blocks.air.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-5, par5+1), Blocks.air.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-5, par5-1), Blocks.air.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-5, par5), Blocks.air.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-5, par5+1), Blocks.air.getDefaultState());
        
    par1World.setBlockState(new BlockPos(par3-2, par4-5, par5-2), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3-1, par4-5, par5-2), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3, par4-5, par5-2), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3+1, par4-5, par5-2), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3+2, par4-5, par5-2), Blocks.brick_block.getDefaultState());
    
    par1World.setBlockState(new BlockPos(par3-2, par4-5, par5-1), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3+2, par4-5, par5-1), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3-2, par4-5, par5), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3+2, par4-5, par5), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3-2, par4-5, par5+1), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3+2, par4-5, par5+1), Blocks.brick_block.getDefaultState());
    
    par1World.setBlockState(new BlockPos(par3-2, par4-5, par5+2), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3-1, par4-5, par5+2), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3, par4-5, par5+2), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3+1, par4-5, par5+2), Blocks.brick_block.getDefaultState());
    par1World.setBlockState(new BlockPos(par3+2, par4-5, par5+2), Blocks.brick_block.getDefaultState());
    
    par1World.setBlockState(new BlockPos(par3, par4-6, par5-1), Blocks.air.getDefaultState());
    par1World.setBlockState(new BlockPos(par3, par4-6, par5+1), Blocks.air.getDefaultState());
    par1World.setBlockState(new BlockPos(par3-1, par4-6, par5-1), Blocks.air.getDefaultState());
    par1World.setBlockState(new BlockPos(par3-1, par4-6, par5), Blocks.air.getDefaultState());
    par1World.setBlockState(new BlockPos(par3-1, par4-6, par5+1), Blocks.air.getDefaultState());
    par1World.setBlockState(new BlockPos(par3+1, par4-6, par5-1), Blocks.air.getDefaultState());
    par1World.setBlockState(new BlockPos(par3+1, par4-6, par5), Blocks.air.getDefaultState());
    par1World.setBlockState(new BlockPos(par3+1, par4-6, par5+1), Blocks.air.getDefaultState());
    
par1World.setBlockState(new BlockPos(par3-2, par4-6, par5-2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3-1, par4-6, par5-2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3, par4-6, par5-2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+1, par4-6, par5-2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+2, par4-6, par5-2), Blocks.brick_block.getDefaultState());

par1World.setBlockState(new BlockPos(par3-2, par4-6, par5-1), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+2, par4-6, par5-1), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3-2, par4-6, par5), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+2, par4-6, par5), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3-2, par4-6, par5+1), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+2, par4-6, par5+1), Blocks.brick_block.getDefaultState());

par1World.setBlockState(new BlockPos(par3-2, par4-6, par5+2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3-1, par4-6, par5+2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3, par4-6, par5+2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+1, par4-6, par5+2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+2, par4-6, par5+2), Blocks.brick_block.getDefaultState());

par1World.setBlockState(new BlockPos(par3, par4-7, par5-1), Blocks.air.getDefaultState());
par1World.setBlockState(new BlockPos(par3, par4-7, par5+1), Blocks.air.getDefaultState());
par1World.setBlockState(new BlockPos(par3-1, par4-7, par5-1), Blocks.air.getDefaultState());
par1World.setBlockState(new BlockPos(par3-1, par4-7, par5), Blocks.air.getDefaultState());
par1World.setBlockState(new BlockPos(par3-1, par4-7, par5+1), Blocks.air.getDefaultState());
par1World.setBlockState(new BlockPos(par3+1, par4-7, par5-1), Blocks.air.getDefaultState());
par1World.setBlockState(new BlockPos(par3+1, par4-7, par5), Blocks.air.getDefaultState());
par1World.setBlockState(new BlockPos(par3+1, par4-7, par5+1), Blocks.air.getDefaultState());

par1World.setBlockState(new BlockPos(par3-2, par4-7, par5-2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3-1, par4-7, par5-2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3, par4-7, par5-2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+1, par4-7, par5-2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+2, par4-7, par5-2), Blocks.brick_block.getDefaultState());

par1World.setBlockState(new BlockPos(par3-2, par4-7, par5-1), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+2, par4-7, par5-1), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3-2, par4-7, par5), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+2, par4-7, par5), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3-2, par4-7, par5+1), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+2, par4-7, par5+1), Blocks.brick_block.getDefaultState());

par1World.setBlockState(new BlockPos(par3-2, par4-7, par5+2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3-1, par4-7, par5+2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3, par4-7, par5+2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+1, par4-7, par5+2), Blocks.brick_block.getDefaultState());
par1World.setBlockState(new BlockPos(par3+2, par4-7, par5+2), Blocks.brick_block.getDefaultState());


        par1World.setBlockState(new BlockPos(par3, par4-8, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4-8, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3, par4-8, par5+1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-8, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-8, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3-1, par4-8, par5+1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-8, par5-1), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-8, par5), Blocks.brick_block.getDefaultState());
        par1World.setBlockState(new BlockPos(par3+1, par4-8, par5+1), Blocks.brick_block.getDefaultState());
        
        return true;
    }

@Override
public boolean generate(World arg0, Random arg1, BlockPos arg2) {
	// TODO Auto-generated method stub
	return false;
}
}


 

CommonProxy.java:

 


package com.harcos.bunkerstrukture;

import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.registry.GameRegistry;
import com.harcos.bunkerstrukture.common.WorldGen;


public class CommonProxy {

public void preInit(FMLPreInitializationEvent e) {
}

public void init(FMLInitializationEvent e) {
    GameRegistry.registerWorldGenerator(new WorldGen(), 0);
}

public void postInit(FMLPostInitializationEvent e) {

}
}



 

Thanks for any help!

Link to comment
Share on other sites

Well it would help if you didn't tell the structure to always generate in the same place.  Every time the game generates a new chunk, it builds another copy of your structure right where the existing one is, "regenerating" the broken blocks.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

private static boolean generated = false;

 

?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • For hours I have been trying to just instal Mr. Crayfish's Refurbished Furniture Mod, but each step to fix the error codes, the more problems arise. The farthest I got through the steps was getting to the Forge Installer, but once I had selected the file, an error saying "The directory is missing a launcher profile. Please run the minecraft launcher first". At this point I don;'t know what more I can do. Please help.
    • I create my mod pack,yesterday my mod pack is fine but i add one mod and error. I'm delete this mmod but minecraft is still stop on CONFIG_LOAD then I tried to delete config and restart it but again. If you can pleace help me. https://imgur.com/ngZBzuv
    • game crashes before even opening (log:https://mclo.gs/M8xvX7c)
    • I have created a custom entity that extends "TamableAnimal", but I am wanting to have it spawn in the ocean. I have it spawning right now, but it spawns way too frequently even with weight set to 1. I am guessing it is because it is rolling in the spawn pool of land animals since TameableAnimal extends Animal and is different than WaterAnimal, and since no land animals spawn in the ocean it just fills every inch up with my custom entity. I have followed basic tutorials for spawning entities with Forge, but I feel like I am missing something about how to change what spawn pool this custom entity ends up in. Is it possible to change that or do I need to refactor it to be based off of WaterAnimal to get those spawn? My biome modifier JSON file: { "type": "forge:add_spawns", "biomes": "#minecraft:is_ocean", "spawners": { "type": "darwinsmysticalmounts:water_animal", "weight": 20, "minCount": 1, "maxCount": 1 } } My client event: event.register(ModEntityTypes.WATER_ANIMAL.get(), SpawnPlacements.Type.NO_RESTRICTIONS, Heightmap.Types.MOTION_BLOCKING_NO_LEAVES, WaterWyvernEntity::checkCustomWaterAnimalSpawnRules, SpawnPlacementRegisterEvent.Operation.REPLACE); And the actual custom spawn rule that makes it spawn in the water: public static boolean checkCustomWaterAnimalSpawnRules(EntityType<WaterAnimalEntity> pAnimal, LevelAccessor pLevel, MobSpawnType pSpawnType, BlockPos pPos, RandomSource pRandom) { return pPos.getY() > pLevel.getSeaLevel() - 16 && pLevel.getFluidState(pPos.below()).is(FluidTags.WATER); }  
    • Starting today, I am unable to load my modded minecraft world. Forge crash log initially said it was a specific mod called Doggy Talents, which I disabled. Then it blamed JEI, and when that was disabled it blamed another mod so I assume it's something more than a specific mod. Minecraft launcher log claims "Exit Code 1". Nothing had changed since last night when it was working fine Forge Log: https://pastebin.com/S1GiBGVJ Client Log: https://pastebin.com/aLwuGUNL  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.