Hey,

how to properly make an item/block ?

 

this

 

 

        public static Item tutorialitem = new tutorialitem();

public static Block tutorialblock = new tutorialblock(Material.rock);

 

@EventHandler

public void preInit(FMLPreInitializationEvent event) {

GameRegistry.registerBlock(tutorialblock, "tutorialblock");

GameRegistry.registerItem(tutorialitem, "tutorialitem");

 

}

 

 

 

 

or this ?

 

 

        public static Item tutorialitem();

public static Block tutorialblock = new tutorialblock(Material.rock);

 

@EventHandler

public void preInit(FMLPreInitializationEvent event) {

                tutorialitem = new tutorialitem();

                tutorialblock = new tutorialblock(Material.rock)

 

GameRegistry.registerBlock(tutorialblock, "tutorialblock");

GameRegistry.registerItem(tutorialitem, "tutorialitem");

 

}

 

 

 

What is better ? Where is the difference ?

 

As far as I know there's no reason to split the instantiation and assignment unless you're getting the value to be assigned to the variable from the constructor, but it's likely considered to just be different coding styles.

It's good practice to split the declaration and assignment, as with 1.8 (IIRC) you must do it that way.

 

Also, your second codeblock won't compile.

 

        public static Item tutorialitem(); //this line won't compile
   public static Block tutorialblock = new tutorialblock(Material.rock); //you left the = new...() part here, you should have removed it
   
   @EventHandler
   public void preInit(FMLPreInitializationEvent event) {
                tutorialitem = new tutorialitem();
                tutorialblock = new tutorialblock(Material.rock) //missing semicolon; second definition

      GameRegistry.registerBlock(tutorialblock, "tutorialblock");
      GameRegistry.registerItem(tutorialitem, "tutorialitem");
   }

A couple things.

 

First of all, you should follow standard convention for capitalization of class names. It should be "new TutorialItem()" etc.

 

Secondly, as mentioned in programming sometimes the difference is just style. There are even other ways to do it, like creating a Blocks and Items class and creating the instances there (similar to the way vanilla does it).

 

As long as you have a public static instance somewhere that is created before the registration I think it should all be good.

 

So you should choose what is most natural to your thought process. Some people like to brainstorm all the fields and declare them but then only initialize them when they are needed. I personally mix it, I initialize some in the declaration if I know what the default value will be, and leave some uninitialized if it may change.

Ok thank you all:)