Jump to content

Recommended Posts

Posted

I am trying to make a item be replaced with another onEntitySwing(Left Click). I looked around on the forums and online but couldn't figure it out.

Here is my current code:

@Override
    onEntitySwing() {
    	};

 

Posted

I will start with this: "Please, go learn basics of Java."

Nothing will help you if you can't even override methods.

 

 

You need to override vanilla Item.class's method:

    public boolean onEntitySwing(EntityLivingBase entityLiving, ItemStack stack)
    {
        return false;
    }

 

You will want to grab 'entityLiving', check if its player (instanceof/cast), then get current held item (the stack) and set it different, new one.

playerIn.inventory.currentItem

1.7.10 is no longer supported by forge, you are on your own.

Posted

Sorry that I don't know that much java. I really don't want to learn it because I wont need it other then for this.

I fixed the override but I don't know how to "grab 'entityLiving', check if its player (instanceof/cast), then get current held item (the stack) and set it different, new one." and idk what the code at bottem is.

 

Posted

Sorry that I don't know that much java. I really don't want to learn it because I wont need it other then for this.

I fixed the override but I don't know how to "grab 'entityLiving', check if its player (instanceof/cast), then get current held item (the stack) and set it different, new one." and idk what the code at bottem is.

You should learn basic java to do that exactly...

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Posted

playerIn is a name Ernio assigned to EntityLivingBase.

 

Basically you want to check if EntityLivingBase is an instance of EntityPlayer. In java its a simple as this:

 

public boolean onEntitySwing(EntityLivingBase theEntityYoureChecking, ItemStack theItemStackTheEntityIsHolding){
    if (theEntityYoureChecking instanceof EntityPlayer){
        //The Entity Is A Player.
    }
    return false;
}

 

If the Entity is a player, then we want to replace the item. If it is a zombie, or a chicken, we don't. So we can add an else statement.

 

public boolean onEntitySwing(EntityLivingBase theEntityYoureChecking, ItemStack theItemStackTheEntityIsHolding){
    if (theEntityYoureChecking instanceof EntityPlayer){
        //The Entity Is A Player.
        return true;
    } else {
        //The Entity Is Not A Player.
        return false;
    }
}

 

Since the entity is a player, we want to get the current stack theyre holding, and then replace it with your own. You can do this by casting the Entity to EntityPlayer:

 

 
    EntityPlayer player = (EntityPlayer) theEntityYoureChecking;
                                            
                                           ^
                               That is called "Casting"

 

 

and then getting the slot theyre currently using, like this:

 

public boolean onEntitySwing(EntityLivingBase theEntityYoureChecking, ItemStack theItemStackTheEntityIsHolding){
    if (theEntityYoureChecking instanceof EntityPlayer){
        EntityPlayer player = (EntityPlayer) theEntityYoureChecking;

        Int slot= player.inventory.currentItem;

        //The Entity Is A Player.
        return true;
    } else {
        //The Entity Is Not A Player.
        return false;
    }
}

 

To replace it with your own items, you need to create a new ItemStack() with the items you want. It is done like this:

 

ItemStack stack = new ItemStack(ItemYouWantHere, AmountOfItems);

an example:

ItemStack stack = new ItemStack(Items.egg, 5);

 

This would make a new ItemStack with 5 eggs in it. You can add that to your method.

 

 
public boolean onEntitySwing(EntityLivingBase theEntityYoureChecking, ItemStack theItemStackTheEntityIsHolding){
    if (theEntityYoureChecking instanceof EntityPlayer){
        //The Entity Is A Player.

        EntityPlayer player = (EntityPlayer) theEntityYoureChecking;

        Int slot = player.inventory.currentItem;

        ItemStack stack = new ItemStack(Items.egg, 5);
        return true;
    } else {
        //The Entity Is Not A Player.
        return false;
    }
}

 

Now, it is very simple. Just replace the players current held ItemStack with the one you created. That is done like this:

 

player.inventory.setInventorySlotContents(slotToPutItIn, itemStackToPut);

 

Since we already have the slot the player is currently using, and we have out stack to put in it, we can add the final part to our method:

 

public boolean onEntitySwing(EntityLivingBase theEntityYoureChecking, ItemStack theItemStackTheEntityIsHolding){
    if (theEntityYoureChecking instanceof EntityPlayer){
        //The Entity Is A Player.

        EntityPlayer player = (EntityPlayer) theEntityYoureChecking;

        Int slot = player.inventory.currentItem;

        ItemStack stack = new ItemStack(Items.egg, 5);

        player.inventory.setInventorySlotContents(slot, stack);
        return true;
    } else {
        //The Entity Is Not A Player.
        return false;
    }
}

 

Hope I helped!

Posted

1) use System.out.println(); in various places to aid in debugging (if you type Sysout or sysout and click the ctrl and the space keys on keyboard) this is a short way of typing System.out.println();

 

3) Watch some java tutorials before posting because people always get upset if you dont have a decent understanding of JAVA - I know this from experience

 

4) some useful modding links:

 

Useful Resources

 

 

http://see.stanford.edu/see/lecturelist.aspx?coll=824a47e1-135f-4508-a5aa-866adcae1111

JAVA Programming Lectures

 

http://bmanolov.free.fr/javaoperators.php

Java Operators doc

 

www.google.com

Google - great resource

 

https://www.youtube.com/user/nealegaming

a Youtube series for how to add some stuff in Minecraft 1.7.2/1.7.10 pretty good overview

 

http://greyminecraftcoder.blogspot.com.au/2013/12/overview-of-forge-and-what-it-can-do.html

A Blog overview of how Minecraft Forge Works

 

http://www.wuppy29.com/minecraft/modding-tutorials/forge-modding-1-7/

Alot of good Tutorials for modding Minecraft 1.7.2 and earlier versions

 

http://anthony-lomeli.net/tutorials/tutorial-how-to-make-a-simple-multiblock-structure

Multiblock structure tutorial

 

http://greyminecraftcoder.blogspot.com.au/2013/07/rendering-transparent-blocks.html

rendering invisible blocks

 

Minecraft Forge's functions and fields map

https://github.com/MinecraftForge/FML/tree/1.7.10/conf

 

http://jabelarminecraft.blogspot.ca/p/minecraft-forge-172-event-handling.html

Event Handling

 

http://www.minecraftforum.net/topic/2001807-172how-to-code-custom-3d-armor-models-3d-weapons-or-items-tutorial-by-senpaisubaraki/

3D Armour

 

 

https://www.youtube.com/watch?v=LBF0oXZ0VyY

http://jabelarminecraft.blogspot.ca/p/complex-entity-models-including.html

Animation Tutorials

 

http://www.minecraftforum.net/forums/mapping-and-modding/resource-packs/resource-pack-discussion/1256350-animation-in-resource-packs-a-minecraft-1-6

Item texture and block texture animation tutorials

 

https://www.youtube.com/watch?v=D3U2JTicSjg&index=2&list=PL6lD77ZPqAf3XCIf86jzxxFsJILbdMo_G

Rendering Tutorials

 

 

5) Look at Vanilla classes figure out how they work - great way to accomplish stuff you want. If  modding in Eclipse look in ReferenceLibraries\forgeSrc to find the source code for Minecraft

 

6) in Eclipse pressing the Ctrl and the H keys together when in the Package Explorer is useful in finding stuff in your code/vanilla code

 

7) If you want to figure out how a function is called right click on it and press Ctrl + Alt + H keys together to see where it is called in code

 

8) The Thank You button is located ---------------------------------> That way ish ---------------------->

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.