bug with PlayerInteractEvent cancellation

[hydroflame]

hi, i came accross this weird bug where cancelled event wouldn't be processed before the next event and the 2nd event wouldn't be properly processed.

 

the code is really simple (the one needed to reproduce the bug anyway):

 

@ForgeSubscribe

public void cancelAllBlockPlaced(PlayerInteractEvent event){

if(event.action == event.Action.RIGHT_CLICK_BLOCK){

event.setCanceled(true);

}

}

 

so basicly this should stop ALL block from behing placed (as well as removing the possibility of using crafting table and other GUI block but that's not the point)

 

but this code appears to be skipped when the players spam right click to place blocks

example:

p = player

[] = empty block

 

p[][][][]

p[][][c][]

 

when the player right click once on block 'c', the event is canceled correctly (nice )

when the player spam r click the ground (not too fast), it makes a block appear and dissapear .

finally, when the player right click at a fast enough speed, he can place a block on the canceled block (before it dissapear) and permanently place a new block

ex:

 

before:

p[][][]

p[][][]

 

click 1:

p[][][][]

p[][][c][]

 

click 2 (shortly after click 1):

p[][][][]

p[][c][c][]

 

after forge cancel event 1:

p[][][][]

p[][c][][]

 

anybody know why it does this and an easy way to fix this (beside adding the event to a thread and look if all event were canceled succefully/correctly)?

 

thx in advance

[Zetal]

This is still an issue. I have the same problem. The source of the problem (after hours of debugging) is that for whatever reason the server doesn't acknowledge that the player is trying to place a block on a block. Instead, it defaults to a 'event.Action.RIGHT_CLICK_AIR' event. In this case, even if you cancel the 'Right Click Air', the block is placed because that kind of event doesn't pertain to a block being placed.

 

This is DEFINITELY A BUG, and should be treated as such. I'd really like some help, Forge. I've been working at my mod for about ten hours straight now, and am nearing completion...but this kind of thing puts a brick wall in the way.

 

I cannot stress enough how much this either

 

A) Needs to be FIXED

or

B) Needs to have Block events implemented (ie onBlockDestroy, onBlockPlace, onBlockActivated, etc)

 

Thank you for your time!

[luacs1998]

I've informed Lex on the irc, he will take action soon.

[Zetal]

Thank you, luacs. For those having the same issue, a temporary (if lengthy and iffy) workaround is to hard-code the rightclick actions you want clientside, and then use a custom TCPConnection to verify that the files for the client are valid. It took a while, but we eventually got that working, so now the Server kicks clients if they don't have the correct files, and if they don't send the files in the first place they get kicked too. I hope this gets fixed regardless, however.