Jump to content

Recommended Posts

Posted

I am wanting to control the speed at which the player can mine blocks.

 

The problem:

It seems to work the way I want it to... Except when I go to mine a block with the proper tool.

IE. using a diamond pickaxe on diamond ore vs. using your hand on diamond ore.  I want both to mine at the same speed.

 

Here is my method: (Sorry, spoilers aren't working)

 

@SubscribeEvent

public void onBlockStartBreak(PlayerEvent.BreakSpeed event){

    event.newSpeed = 5;

}

 

Any idea why a diamond pickaxe would be faster at mining diamond ore than a hand?

 

I know it doesn't make too much sense to do this, but this is the first step in the process and I need to get a better understanding of what's actually going on.

 

Thanks!

Posted

It's because if the current tool (or hand) cannot break the block, the speed is divided by 100 instead of 30:

// in ForgeHooks:
public static float blockStrength(IBlockState state, EntityPlayer player, World world, BlockPos pos)
    {
        float hardness = state.getBlock().getBlockHardness(world, pos);
        if (hardness < 0.0F)
        {
            return 0.0F;
        }

        if (!canHarvestBlock(state.getBlock(), player, world, pos))
        {
            return player.getBreakSpeed(state, pos) / hardness / 100F;
        }
        else
        {
            return player.getBreakSpeed(state, pos) / hardness / 30F;
        }
    }

As you can see, always returning 5 will yield pretty different results based on the above algorithm.

 

Btw, you can easily find out such things yourself by utilizing the power of your IDE - select a method, right click and 'open call hierarchy' to see where it is called from, then keep following the rabbit hole. ;)

Posted

It's because if the current tool (or hand) cannot break the block, the speed is divided by 100 instead of 30:

// in ForgeHooks:

Btw, you can easily find out such things yourself by utilizing the power of your IDE - select a method, right click and 'open call hierarchy' to see where it is called from, then keep following the rabbit hole. ;)

 

Thanks for the tip!

 

Well I feel slightly embarrassed...

I thought it was working.  How would I edit or re-declare the "blockStrength" method?

Posted

You don't. It's a Forge method - tampering with it would bring the world crashing down.

 

To clarify, you want the player to mine ALL blocks at the same speed, regardless of tool? In that case, just check in your BreakEvent if the player's currently held item can harvest the block - if it cannot, multiply your break speed by (100 / 30) to compensate for the difference.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • @Tsuk1 Also, new note, you can use blockbench to make the custom item model for when it is not on the head.   EDIT: Funny story, I am making a mod similar to yours! Mine is called NorseMC.
    • @Nood_dev Could you send a screenshot of your weapon code? Here is the one I made (for a dagger): The specific UUID does not matter, just that it is the same every time, which is why UUID#randomUUID does not work public class DaggerItem extends TieredItem implements Vanishable { protected static final double REACH_MODIFIER = -1.5D; protected final Multimap<Attribute, AttributeModifier> defaultModifiers; protected final UUID BASE_ATTACK_REACH_UUID = UUID.fromString("6fe75b5c-9d1b-4e83-9eea-a1d5a94e8dd5") public DaggerItem(Tier pTier, int pAttackDamageModifier, float pAttackSpeedModifier, Properties pProperties) { super(pTier, pAttackDamageModifier, pAttackSpeedModifier, pProperties); this.attackDamage = (float) pAttackDamageModifier + pTier.getAttackDamageBonus(); ImmutableMultimap.Builder<Attribute, AttributeModifier> builder = ImmutableMultimap.builder(); builder.put(Attributes.ATTACK_DAMAGE, new AttributeModifier(BASE_ATTACK_DAMAGE_UUID, "Weapon modifier", this.attackDamage, AttributeModifier.Operation.ADDITION)); builder.put(Attributes.ATTACK_SPEED, new AttributeModifier(BASE_ATTACK_SPEED_UUID, "Weapon modifier", pAttackSpeedModifier, AttributeModifier.Operation.ADDITION)); // THE ONE YOU WANT: builder.put(ForgeMod.ENTITY_REACH.get(), new AttributeModifier(BASE_ATTACK_REACH_UUID, "Weapon modifier", REACH_MODIFIER, AttributeModifier.Operation.ADDITION)); this.defaultModifiers = builder.build(); } @Override public Multimap<Attribute, AttributeModifier> getDefaultAttributeModifiers(EquipmentSlot pEquipmentSlot) { return pEquipmentSlot == EquipmentSlot.MAINHAND ? this.defaultModifiers : super.getDefaultAttributeModifiers(pEquipmentSlot); } }
    • https://images.app.goo.gl/1PxFKdxByTgkxvSu6
    • That's what we'll try out. I could never figure out how to recreate the crash, so I'll just have to wait and see.
    • Ok, I updated to the latest version and now the models are visible, the problem now is that the glowing eyes are not rendered nor any texture I render there when using shaders, even using the default Minecraft eyes RenderType, I use entityTranslucent and entityCutout, but it still won't render. Something I noticed when using shaders is that a texture, instead of appearing at the world position, would appear somewhere on the screen, following a curved path, it was strange, I haven't been able to reproduce it again. I thought it could be that since I render the texture in the AFTER ENTITIES stage which is posted after the batches used for entity rendering are finished, maybe that was the reason why the render types were not being drawn correctly, so I tried injecting code before finishing the batches but it still didn't work, plus the model was invisible when using shaders, there was a bug where if I look at the model from above it is visible but if I look at it from below it is invisible. So in summary, models are now visible but glowing eyes and textures are not rendered, that hasn't changed.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.