Jump to content

Recommended Posts

Posted

hi :)

 

i'm trying to remove recipes and i can remove vanilla crafting recipes with this:

  public static void RemoveVanillaCraftingRecipes(){

      List<IRecipe> recipes  = CraftingManager.getInstance().getRecipeList();

     

      Iterator<IRecipe> Rem = recipes.iterator();

     

        while(Rem.hasNext()){

            ItemStack stack = Rem.next().getRecipeOutput();

            if(stack != null && stack.getItem() == Items.bread){

              Rem.remove();

            }else if(stack != null && stack.getItem() == Items.mushroom_stew){

              Rem.remove();

            }else if(stack != null && stack.getItem() == Items.pumpkin_pie){

              Rem.remove();                 

            }else if(stack != null && stack.getItem() == Items.golden_carrot){

              Rem.remove();

        }

      } 

  }

but i have no idea about how to remove Smelting recipes... i've tried:

public static void RemoveVanillaFoodFurnaceRecipes(){

      List<IRecipe> recipes  = (List<IRecipe>) FurnaceRecipes.smelting().getSmeltingList();

  Iterator<IRecipe> Rem1 = recipes.iterator();

  while(Rem1.hasNext()){

      ItemStack stack = Rem1.next().getRecipeOutput();

      if(stack != null && stack.getItem() == Items.getItemFromBlock(Blocks.stone)){

        Rem1.remove();

      }

      }

  }

Posted

ok... i've read it and tried this:

public static void removeFurnaceRecipe() {

Map recipes = FurnaceRecipes.smelting().getSmeltingList();

 

Iterator entries = recipes.entrySet().iterator();

while (entries.hasNext()) {

 

Entry thisEntry = (Entry) entries.next();

  if (thisEntry != null && thisEntry.getKey() == Item.getItemFromBlock(Blocks.stone)) {

entries.remove();

}

}

}

 

but i can't get it to work... what am i doing wrong?

Posted

public static void removeFurnaceRecipe() {

Map recipes = FurnaceRecipes.smelting().getSmeltingList();

 

Iterator entries = recipes.entrySet().iterator();

while (entries.hasNext()) {

 

Entry thisEntry = (Entry) entries.next();

  if (thisEntry != null && thisEntry.getKey() == Items.baked_potato) {

entries.remove();

}

}

}

Posted

public static void removeFurnaceRecipe(ItemStack stack) {

      Map recipes = FurnaceRecipes.smelting().getSmeltingList();

     

      Iterator entries = recipes.entrySet().iterator();

      while (entries.hasNext()) {

       

        Entry thisEntry = (Entry) entries.next();

        if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {

            entries.remove();

        }

      }

  }

Posted

I tend not to use Iterator myself (but thats because i didnt grow up with them being there)

to me it looks like you are searching the this of item you put into the furnace , and as far as i know Items.baked_potato comes out, not goes in

 

secondly these 2 things are your friends when dealing with unknowns

 

System.out.println(unknown);

unknown.getClass().getSimpleName();

 

and togeather

System.out.println(unknown.getClass().getSimpleName());

 

 

Posted

Look at TiCon code there is reciperemover class and bunch of usefull stuff in it ;)

I'm beginner in java and in minecraft modding.

Please be specific.

Any code examples are appreciated.

Sorry for my english i'm from Czech republic.

Please hit that thank you button if i helped :)

Posted

Yes, Failender your right, he isnt testing the recipe at all is he, in or out

 

There are actually 2 major errors

 

both these 2 lines contain the errors

 

 if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {
               entries.remove();

Posted

Yes, Failender your right, he isnt testing the recipe at all is he, in or out

 

There are actually 2 major errors

 

both these 2 lines contain the errors

 

 if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {
               entries.remove();

 

Please explain why

entries.remove();

is wrong...

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Posted

this is the post he made

public static void removeFurnaceRecipe(ItemStack stack) {
         Map recipes = FurnaceRecipes.smelting().getSmeltingList();
         
         Iterator entries = recipes.entrySet().iterator();
         while (entries.hasNext()) {
            
            Entry thisEntry = (Entry) entries.next();
           if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {
               entries.remove();
            }
         }
      }

 

problem 1

if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {

this is testing to see what the item passes to the method is not the item from the recipe, in the very first post he actually had this bit correct

 

problem 2

entries.remove();

is removing it from the Iterator not the Recipe HashMap it should be

recipes.remove(thisEntry.getKey());

 

just as a note, removing the items from a hashmap can cause errors while reading through the Map

I would recommend instead of removing immediately create a list of items to remove then remove them after scanning the list

 

like this

public static void removeFurnaceRecipe(ItemStack stack) {
        Map<ItemStack, ItemStack> recipes = FurnaceRecipes.smelting().getSmeltingList();
        LinkedList<ItemStack> remlist=new LinkedList<ItemStack>();
        Iterator<Entry<ItemStack, ItemStack>> entries = recipes.entrySet().iterator();
        while (entries.hasNext()) {
           Entry<ItemStack, ItemStack> thisEntry = (Entry<ItemStack, ItemStack>) entries.next();
           if (ItemStack.areItemStacksEqual(thisEntry.getValue(), stack)) {
        	   remlist.add(thisEntry.getKey());
           }
        }
        for(ItemStack rm:remlist) recipes.remove(rm);
     }

 

 

 

 

 

Posted

this is the post he made

public static void removeFurnaceRecipe(ItemStack stack) {
         Map recipes = FurnaceRecipes.smelting().getSmeltingList();
         
         Iterator entries = recipes.entrySet().iterator();
         while (entries.hasNext()) {
            
            Entry thisEntry = (Entry) entries.next();
           if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {
               entries.remove();
            }
         }
      }

 

problem 1

if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {

this is testing to see what the item passes to the method is not the item from the recipe, in the very first post he actually had this bit correct

 

problem 2

entries.remove();

is removing it from the Iterator not the Recipe HashMap it should be

recipes.remove(thisEntry.getKey());

 

just as a note, removing the items from a hashmap can cause errors while reading through the Map

I would recommend instead of removing immediately create a list of items to remove then remove them after scanning the list

 

like this

public static void removeFurnaceRecipe(ItemStack stack) {
        Map<ItemStack, ItemStack> recipes = FurnaceRecipes.smelting().getSmeltingList();
        LinkedList<ItemStack> remlist=new LinkedList<ItemStack>();
        Iterator<Entry<ItemStack, ItemStack>> entries = recipes.entrySet().iterator();
        while (entries.hasNext()) {
           Entry<ItemStack, ItemStack> thisEntry = (Entry<ItemStack, ItemStack>) entries.next();
           if (ItemStack.areItemStacksEqual(thisEntry.getValue(), stack)) {
        	   remlist.add(thisEntry.getKey());
           }
        }
        for(ItemStack rm:remlist) recipes.remove(rm);
     }

 

You know that updating the iterator (e.g. removing an element) updates the list/map as well!?

 

That's the point of an Iterator... To modify the list/map while iterating through it and not cause a ConcurrentModificationException or needing complicated workaround code.

 

Your code is just overcomplicating the thing the Iterator is there for...

 

This is my code using the iterator to remove elements, it works:

https://github.com/SanAndreasP/ClaySoldiersMod/blob/master/java/de/sanandrew/mods/claysoldiers/entity/EntityClayMan.java#L126-L137

 

 

EDIT: Also what diesieben07 said (I should read the 2nd page before posting <.<)

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Verified users can now unlock a $100 OFF Temu Coupon Code using the verified promo code [ALF401700]. This Temu $100 OFF code works for both new and existing customers and can be used to redeem up to 50% off your next order. Our exclusive Temu coupon code [ALF401700] delivers a flat $100 OFF on top of existing deals. First-time customers using code ALF401700 can save an extra 100% off select items. Returning users also qualify for an automatic $100 OFF discount just by applying this code at checkout. But wait—there’s more. With our Temu coupon codes for 2025, users can score up to 90% OFF on clearance items. Whether you’re shopping in the USA, Canada, UK, or elsewhere, Temu promo code ALF401700 unlocks extra discounts tailored to your account. Some users are saving 100% on items using this 2025 Temu promo code. 🔥 Temu Coupon Highlights Using Code [ALF401700]: Temu new user code – ALF401700: Save 50% off your first order + $100 OFF. Temu promo for existing customers – ALF401700: Enjoy flat $100 OFF instantly. Global availability: Works in the USA, UK, Canada, Germany, France, Japan, Chile, Colombia, Malaysia, Mexico, South Korea, Philippines, Saudi Arabia, Qatar, Pakistan, and more. Top 2025 Coupon Deal: Get $200 OFF plus 100% bonus discounts using code ALF401700. Top-Ranked Temu Deals for 2025 (Coupon Code: ALF401700): ✅ Temu $100 OFF Memorial Day Sale — Use ALF401700 ✅ Temu First Order Coupon — Use ALF401700 for 50% + $100 OFF ✅ Temu USA Coupon Code — Save $100 instantly with ALF401700 ✅ Temu Japan, Germany, Chile Codes — All support ALF401700 ✅ Temu Reddit Discount – $100 OFF: Valid for both new and old users ✅ Temu Coupon Bundle 2025 — $100 OFF + up to 50% slash ✅ 100% OFF Free Gift Code — Use ALF401700, no invite needed ✅ Temu Sign-Up Bonus Promo — Get a welcome $100 OFF instantly ✅ Free Temu Code for New Users — Use ALF401700, no referral required  Temu Clearance Codes 2025 — Use ALF401700 for 85–100% discounts Why ALF401700 is the Best Temu Code in 2025 Using Temu code ALF401700 is your ticket to massive savings, free shipping, first-order discounts, and stackable coupon bundles. Whether you're browsing electronics, fashion, home goods, or beauty products, this verified Temu discount code offers real savings—up to 90% OFF + $100 OFF on qualified orders. 💡 Pro Tip: Apply ALF401700 during checkout in the Temu app or website to activate your instant $100 discount, even if you’re not a new user. Temu $100 OFF Code by Country (All Use ALF401700): 🇺🇸 Temu USA – ALF401700 🇯🇵 Temu Japan – ALF401700 🇲🇽 Temu Mexico – ALF401700 🇨🇱 Temu Chile – ALF401700 🇨🇴 Temu Colombia – ALF401700 🇲🇾 Temu Malaysia – ALF401700 🇵🇭 Temu Philippines – ALF401700 🇰🇷 Temu Korea – ALF401700 🇵🇰 Temu Pakistan – ALF401700 🇫🇮 Temu Finland – ALF401700 🇸🇦 Temu Saudi Arabia – ALF401700 🇶🇦 Temu Qatar – ALF401700 🇫🇷 Temu France – ALF401700 🇩🇪 Temu Germany – ALF401700 🇮🇱 Temu Israel – ALF401700 Temu Coupon Code [ALF401700] Summary for SEO: Temu $100 OFF Code  Temu First Order Discount Code 2025  Temu Verified Promo Code ALF401700  Temu 50% OFF + $100 Bonus  Temu 100% OFF Code 2025  Temu App Promo ALF401700  Temu Working Discount Code 2025 
    • Hey there, nothing to do with the code, I am just suggesting you use Intelij IDEA. Trust me, it is the best.
    • Hey there, nothing to do with the code, I am just suggesting you use Intelij IDEA. Trust me, it is the best.
    • You can check the config of Geckolib and Mowzie's Mobs - maybe there is a way to disable some render features
    • You can use the .requires() function  the server also has a permission level of 4, which is the highest permission level.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.