Jump to content

Remove Recipes


Recommended Posts

hi :)

 

i'm trying to remove recipes and i can remove vanilla crafting recipes with this:

  public static void RemoveVanillaCraftingRecipes(){

      List<IRecipe> recipes  = CraftingManager.getInstance().getRecipeList();

     

      Iterator<IRecipe> Rem = recipes.iterator();

     

        while(Rem.hasNext()){

            ItemStack stack = Rem.next().getRecipeOutput();

            if(stack != null && stack.getItem() == Items.bread){

              Rem.remove();

            }else if(stack != null && stack.getItem() == Items.mushroom_stew){

              Rem.remove();

            }else if(stack != null && stack.getItem() == Items.pumpkin_pie){

              Rem.remove();                 

            }else if(stack != null && stack.getItem() == Items.golden_carrot){

              Rem.remove();

        }

      } 

  }

but i have no idea about how to remove Smelting recipes... i've tried:

public static void RemoveVanillaFoodFurnaceRecipes(){

      List<IRecipe> recipes  = (List<IRecipe>) FurnaceRecipes.smelting().getSmeltingList();

  Iterator<IRecipe> Rem1 = recipes.iterator();

  while(Rem1.hasNext()){

      ItemStack stack = Rem1.next().getRecipeOutput();

      if(stack != null && stack.getItem() == Items.getItemFromBlock(Blocks.stone)){

        Rem1.remove();

      }

      }

  }

Link to comment
Share on other sites

ok... i've read it and tried this:

public static void removeFurnaceRecipe() {

Map recipes = FurnaceRecipes.smelting().getSmeltingList();

 

Iterator entries = recipes.entrySet().iterator();

while (entries.hasNext()) {

 

Entry thisEntry = (Entry) entries.next();

  if (thisEntry != null && thisEntry.getKey() == Item.getItemFromBlock(Blocks.stone)) {

entries.remove();

}

}

}

 

but i can't get it to work... what am i doing wrong?

Link to comment
Share on other sites

public static void removeFurnaceRecipe() {

Map recipes = FurnaceRecipes.smelting().getSmeltingList();

 

Iterator entries = recipes.entrySet().iterator();

while (entries.hasNext()) {

 

Entry thisEntry = (Entry) entries.next();

  if (thisEntry != null && thisEntry.getKey() == Items.baked_potato) {

entries.remove();

}

}

}

Link to comment
Share on other sites

public static void removeFurnaceRecipe(ItemStack stack) {

      Map recipes = FurnaceRecipes.smelting().getSmeltingList();

     

      Iterator entries = recipes.entrySet().iterator();

      while (entries.hasNext()) {

       

        Entry thisEntry = (Entry) entries.next();

        if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {

            entries.remove();

        }

      }

  }

Link to comment
Share on other sites

I tend not to use Iterator myself (but thats because i didnt grow up with them being there)

to me it looks like you are searching the this of item you put into the furnace , and as far as i know Items.baked_potato comes out, not goes in

 

secondly these 2 things are your friends when dealing with unknowns

 

System.out.println(unknown);

unknown.getClass().getSimpleName();

 

and togeather

System.out.println(unknown.getClass().getSimpleName());

 

 

Link to comment
Share on other sites

Look at TiCon code there is reciperemover class and bunch of usefull stuff in it ;)

I'm beginner in java and in minecraft modding.

Please be specific.

Any code examples are appreciated.

Sorry for my english i'm from Czech republic.

Please hit that thank you button if i helped :)

Link to comment
Share on other sites

Yes, Failender your right, he isnt testing the recipe at all is he, in or out

 

There are actually 2 major errors

 

both these 2 lines contain the errors

 

 if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {
               entries.remove();

Link to comment
Share on other sites

Yes, Failender your right, he isnt testing the recipe at all is he, in or out

 

There are actually 2 major errors

 

both these 2 lines contain the errors

 

 if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {
               entries.remove();

 

Please explain why

entries.remove();

is wrong...

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

this is the post he made

public static void removeFurnaceRecipe(ItemStack stack) {
         Map recipes = FurnaceRecipes.smelting().getSmeltingList();
         
         Iterator entries = recipes.entrySet().iterator();
         while (entries.hasNext()) {
            
            Entry thisEntry = (Entry) entries.next();
           if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {
               entries.remove();
            }
         }
      }

 

problem 1

if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {

this is testing to see what the item passes to the method is not the item from the recipe, in the very first post he actually had this bit correct

 

problem 2

entries.remove();

is removing it from the Iterator not the Recipe HashMap it should be

recipes.remove(thisEntry.getKey());

 

just as a note, removing the items from a hashmap can cause errors while reading through the Map

I would recommend instead of removing immediately create a list of items to remove then remove them after scanning the list

 

like this

public static void removeFurnaceRecipe(ItemStack stack) {
        Map<ItemStack, ItemStack> recipes = FurnaceRecipes.smelting().getSmeltingList();
        LinkedList<ItemStack> remlist=new LinkedList<ItemStack>();
        Iterator<Entry<ItemStack, ItemStack>> entries = recipes.entrySet().iterator();
        while (entries.hasNext()) {
           Entry<ItemStack, ItemStack> thisEntry = (Entry<ItemStack, ItemStack>) entries.next();
           if (ItemStack.areItemStacksEqual(thisEntry.getValue(), stack)) {
        	   remlist.add(thisEntry.getKey());
           }
        }
        for(ItemStack rm:remlist) recipes.remove(rm);
     }

 

 

 

 

 

Link to comment
Share on other sites

this is the post he made

public static void removeFurnaceRecipe(ItemStack stack) {
         Map recipes = FurnaceRecipes.smelting().getSmeltingList();
         
         Iterator entries = recipes.entrySet().iterator();
         while (entries.hasNext()) {
            
            Entry thisEntry = (Entry) entries.next();
           if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {
               entries.remove();
            }
         }
      }

 

problem 1

if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {

this is testing to see what the item passes to the method is not the item from the recipe, in the very first post he actually had this bit correct

 

problem 2

entries.remove();

is removing it from the Iterator not the Recipe HashMap it should be

recipes.remove(thisEntry.getKey());

 

just as a note, removing the items from a hashmap can cause errors while reading through the Map

I would recommend instead of removing immediately create a list of items to remove then remove them after scanning the list

 

like this

public static void removeFurnaceRecipe(ItemStack stack) {
        Map<ItemStack, ItemStack> recipes = FurnaceRecipes.smelting().getSmeltingList();
        LinkedList<ItemStack> remlist=new LinkedList<ItemStack>();
        Iterator<Entry<ItemStack, ItemStack>> entries = recipes.entrySet().iterator();
        while (entries.hasNext()) {
           Entry<ItemStack, ItemStack> thisEntry = (Entry<ItemStack, ItemStack>) entries.next();
           if (ItemStack.areItemStacksEqual(thisEntry.getValue(), stack)) {
        	   remlist.add(thisEntry.getKey());
           }
        }
        for(ItemStack rm:remlist) recipes.remove(rm);
     }

 

You know that updating the iterator (e.g. removing an element) updates the list/map as well!?

 

That's the point of an Iterator... To modify the list/map while iterating through it and not cause a ConcurrentModificationException or needing complicated workaround code.

 

Your code is just overcomplicating the thing the Iterator is there for...

 

This is my code using the iterator to remove elements, it works:

https://github.com/SanAndreasP/ClaySoldiersMod/blob/master/java/de/sanandrew/mods/claysoldiers/entity/EntityClayMan.java#L126-L137

 

 

EDIT: Also what diesieben07 said (I should read the 2nd page before posting <.<)

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I would like to setup a test that makes sure an animation completes, however this animation can be a couple of seconds long. Are there any examples of using a GameTestSequence created from GameTestHelper#startSequence to wait until a certain function in the code is reached or finished?
    • Minecraft java and forge seem to have it out for me, any ideas? I have had issues with exit code 1 while loading forge -fabric was having the same issues, but I seemed to fix it in these repairs? (tried different versions upwards from 1.19 to 1.20.2 for forge, nothing worked and I'm confident older versions wouldn't either) -The launcher itself loads fine, it will load the game within the launcher, and then crash the moment it tries to load outside of the launcher. I have tried the default launcher, legacy launcher, and the curse forge launcher, none have worked! (all have had the same problem) I think this started when I took a break and upgraded to windows 11 and wonder if that changed anything? I have tried the following: uninstalled & reinstalled java, (I have having issues where I download jdk 17 but only 8 would show up (would not show up anywhere but the control panel, not even the official uninstaller, I *think* I got that fixed) tried jarfix uninstalled & reinstalled minecraft tried alternate launchers -forge & legacy, & repaired them too. tried without mods updated game drivers uninstalled and reinstalled forge -including completely wiping it from my system changed java excutable path followed everything in the error code 1 post completely reset my pc I tried to change the launch path but couldn't seem to get it to work -the default launcher wont let me even see properties as an option, i have yet to try with the other two (i did try on legacy but it was being weird) I want to include my debug log; but its over the max size? sorry my brains gone numb from trying to fix this for the past 2 days
    • I personally create registries using DataPackRegistryEvent.NewRegistry. It's pretty powerful as long as you know how to make codecs. In some class, make a registry key like so: public static final ResourceKey<Registry<MyDataType>> MY_REGISTRY = ResourceKey.createRegistryKey(new ResourceLocation(MyMod.MOD_ID, "registry_name")); This will make a registry that holds objects of type "MyDataType". JSON files stored in data/<datapack_namespace>/modid/registryname/ will be parsed and put into this registry. Note that the directory structure has a folder named after your mod inside your datapack directory, so the actual path would look like: data/my_mod/my_mod/registry_name (or if another mod uses your registry: data/their_mod/my_mod/registry_name. To register this registry, subscribe to the DataPackRegistryEvent.NewRegistry event on the MOD event bus and call event.dataPackRegistry() for every registry you have. An example of what I'm doing for my mod (this is in the constructor for the main mod file): IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus(); bus.addListener((DataPackRegistryEvent.NewRegistry event) -> { event.dataPackRegistry(ModRegistries.INSULATOR_DATA, InsulatorData.CODEC); }); CODEC is a public static field inside the class for the custom data type I am registering. It holds a Codec<InsulatorData> that tells Minecraft how to serialize/deserialize the data. Most of my data so far can be represented by records, so I use RecordCodecBuilder.create() to do this: public static final Codec<InsulatorData> CODEC = RecordCodecBuilder.create(instance -> instance.group( // Yadda yadda ).apply(instance, InsulatorData::new)); What exactly to put here depends on what you're trying to do, so that's up to you. But basically you're just defining a list of codecs that correspond to the parameters of the record (data type). Most primitive data types have records in the Codec class (ex. Codec.INT) that you can use, and other classes like ResourceLocation have their own codecs as a static field (ex. ResourceLocation.CODEC). Hopefully this is what you're looking for, and that this helps.
    • Good days  I finnaly manage to fix and get a working gui from BlockItem and from BlockEntity the next issues i have to fix is this the block Entity model for some reason is moved to the south west  this briefcase model must be centered but is moved to a side, i have nothing weird in the code but this is happening // ########## ########## ########## ########## @Override public RenderShape getRenderShape(BlockState blkstate) {     return RenderShape.MODEL; } the block model is out of place However The hitBox of the block is right in place   ########################################################################################################### This next issue  Mi gui also adds the 5 slots from the player equipment the thing is theres no filter to determine whats can be put in an armor slot and what not      i have this method that draws the slots for the armor, the part i dont get i slike wheres the code that responds when you set an item in a item slot to do checks and allow the item to be set or not  //########## ########## ########## //Draw Player Armor private void addPlayerArmorSlots(Inventory playerInventory) { // 36 this.addSlot(new Slot(playerInventory, 39, 8, 8)); this.addSlot(new Slot(playerInventory, 38, 8, 26)); this.addSlot(new Slot(playerInventory, 37, 8, 44)); this.addSlot(new Slot(playerInventory, 36, 8, 62)); this.addSlot(new Slot(playerInventory, 40, 26, 53)); }   theres must be a method that triggers when you set a itemstack inside an slot and allows to do a check if its a valid item for that slot                                             
    • No like how do I use my new PreperableReloadListener, I know how to set it up now and register it, I just need to know how to use it in other classes.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.