Hello , i need event when player kills entity , because i need to do some modifications on item he is holding when he kills it, so far i found LivingDeathEvent but it doesn't return player. , There is AttackEntityEvent from player events, but i need to get it when entity dies . I tried to calculate if entity will die after attack but i couldn't do it correctly because there is armor, enchantments and stuff.

@SubscribeEvent
public void kill(LivingDeathEvent event) {
if (event.source.getSourceOfDamage() instanceof EntityPlayer) {
	EntityPlayer player = (EntityPlayer) source.getSourceOfDamage();
                
                doSomethingWithPlayer(player);
}
}

/**
 * Returns true if the mob was killed by player.
 */
public static boolean wasEntityKilledByPlayer(DamageSource source){
	if(source.getDamageType().equals("player")){
		return true;
	}

	Entity atacker = source.getSourceOfDamage();
	if(atacker instanceof EntityArrow){
		EntityArrow arrow = (EntityArrow)atacker;
		atacker = arrow.shootingEntity;
	}else if(atacker instanceof IThrowableEntity){
		IThrowableEntity throwable = (IThrowableEntity)atacker;
		atacker = throwable.getThrower();
	}else if(atacker instanceof EntityThrowable){
		EntityThrowable throwable = (EntityThrowable)atacker;
		atacker = throwable.getThrower();
	}

	return atacker instanceof EntityPlayer;
}

diesieben07,

I went to look this up out of curiosity.  in 1.8, here is the method in DamageSource

 

 

 

    public Entity getEntity()

    {

        return null;

    }

 

 

 

Did something change?

DamageSource

is simply the base class.

EntityDamageSource

and

EntityDamageSourceIndirect

are used for damage caused by entities and correctly override

DamageSource#getEntity

and

DamageSource#getSourceOfDamage

.