Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.7.10] Right clicking fluid with a bucket returns water bucket (Still unsolved

Hlaaftana

By Hlaaftana
in Modder Support

 Share

Recommended Posts

Hlaaftana Tree Puncher

Hlaaftana

Posted
Posted

I've been following http://www.minecraftforge.net/wiki/Create_a_Fluid yet right clicking my fluids' blocks with a bucket returns a water bucket.

 

Fluids' block class (they're all the same except the names changed):

package com.hlaaftana.mods.OlivicBlocks.blocks;

import com.hlaaftana.mods.OlivicBlocks.help.Reference;
import com.hlaaftana.mods.OlivicBlocks.init.ModFluids;
import com.hlaaftana.mods.OlivicBlocks.tabs.ModTabs;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.util.IIcon;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fluids.BlockFluidBase;
import net.minecraftforge.fluids.BlockFluidClassic;
import net.minecraftforge.fluids.BlockFluidFinite;
import net.minecraftforge.fluids.FluidStack;

public class BlockFluidOliveOil extends BlockFluidClassic {
public BlockFluidOliveOil(){
	super(ModFluids.oilOlive, Material.water);
	setBlockName("oilOlive");
	setBlockTextureName(Reference.MODID + ":" + getUnlocalizedName().substring(5));
	setCreativeTab(ModTabs.tabOlivic);
}
@SideOnly(Side.CLIENT)
protected IIcon stillIcon;

@SideOnly(Side.CLIENT)
protected IIcon flowingIcon;

@Override
public IIcon getIcon(int side, int meta){
	return (side == 0 || side == 1)? stillIcon : flowingIcon;
}

@SideOnly(Side.CLIENT)
@Override
public void registerBlockIcons(IIconRegister register){
	stillIcon = register.registerIcon(Reference.MODID + ":oilOlive_flowing");
	flowingIcon = register.registerIcon(Reference.MODID + ":oilOlive_flowing");		
}

@Override
public boolean canDisplace(IBlockAccess world, int x, int y, int z){
	if (world.getBlock(x,  y,  z).getMaterial().isLiquid()) return false;
        return super.canDisplace(world, x, y, z);

}

    @Override
    public boolean displaceIfPossible(World world, int x, int y, int z) {
    	if (world.getBlock(x,  y,  z).getMaterial().isLiquid()) return false;
    	return super.displaceIfPossible(world, x, y, z);
    }
}

 

BucketHandler:

package com.hlaaftana.mods.OlivicBlocks.handlers;

import java.util.HashMap;
import java.util.Map;

import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.MovingObjectPosition;
import net.minecraft.world.World;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.entity.player.FillBucketEvent;

import com.hlaaftana.mods.OlivicBlocks.init.ModBlocks;
import com.hlaaftana.mods.OlivicBlocks.init.ModItems;

import cpw.mods.fml.common.eventhandler.Event.Result;
import cpw.mods.fml.common.eventhandler.SubscribeEvent;


public class BucketHandler {

        public static BucketHandler INSTANCE = new BucketHandler();
        public Map<Block, Item> buckets = new HashMap<Block, Item>();

        private BucketHandler() {
        	BucketHandler.INSTANCE.buckets.put(ModBlocks.tar, ModItems.bucketTar);
        	BucketHandler.INSTANCE.buckets.put(ModBlocks.creosote, ModItems.bucketCreosote);
        	BucketHandler.INSTANCE.buckets.put(ModBlocks.oilOlive, ModItems.bucketOliveOil);
        	BucketHandler.INSTANCE.buckets.put(ModBlocks.oilOlive, ModItems.bottleOliveOil);
        	MinecraftForge.EVENT_BUS.register(BucketHandler.INSTANCE);
        }

        @SubscribeEvent
        public void onBucketFill(FillBucketEvent event) {

                ItemStack result = fillCustomBucket(event.world, event.target);

                if (result == null)
                        return;

                event.result = result;
                event.setResult(Result.ALLOW);
        }

        private ItemStack fillCustomBucket(World world, MovingObjectPosition pos) {

                Block block = world.getBlock(pos.blockX, pos.blockY, pos.blockZ);

                Item bucket = buckets.get(block);
                if (bucket != null && world.getBlockMetadata(pos.blockX, pos.blockY, pos.blockZ) == 0) {
                        world.setBlockToAir(pos.blockX, pos.blockY, pos.blockZ);
                        return new ItemStack(bucket);
                } else
                        return null;

        }
}

 

Custom buckets' register:

package com.hlaaftana.mods.OlivicBlocks.init;

import net.minecraft.init.Items;
import net.minecraft.item.*;

import com.hlaaftana.mods.OlivicBlocks.init.ModArmory;
import com.hlaaftana.mods.OlivicBlocks.help.RegisterHelper;
import com.hlaaftana.mods.OlivicBlocks.items.*;

import cpw.mods.fml.common.IFuelHandler;

public class ModItems{
*A bunch of items*
public static Item bucketTar = new OlivicBlocksBucketItem("Tar", ModBlocks.tar);
public static Item bucketOliveOil = new OlivicBlocksBucketItem("OliveOil", ModBlocks.oilOlive);
public static Item bucketCreosote = new OlivicBlocksBucketItem("Creosote", ModBlocks.creosote);
public static void init(){
	*A bunch of items*
	RegisterHelper.registerItem(bucketOliveOil);
	RegisterHelper.registerItem(bucketTar);
	RegisterHelper.registerItem(bucketCreosote);

	RegisterHelper.registerFluidContainer(ModFluids.tar, bucketTar);
	RegisterHelper.registerFluidContainer(ModFluids.oilOlive, bucketOliveOil);
	RegisterHelper.registerFluidContainer(ModFluids.creosote, bucketCreosote);
	RegisterHelper.registerFluidContainer(ModFluids.oilOlive, bottleOliveOil);

 

The RegisterHelper class:

package com.hlaaftana.mods.OlivicBlocks.help;

import cpw.mods.fml.common.registry.GameRegistry;
import net.minecraft.block.Block;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemStack;
import net.minecraftforge.fluids.Fluid;
import net.minecraftforge.fluids.FluidContainerRegistry;
import net.minecraftforge.fluids.FluidRegistry;

public class RegisterHelper {
public static void registerBlock(Block block){
	GameRegistry.registerBlock(block, block.getUnlocalizedName().substring(5));
}

public static void registerItem(Item item){
	GameRegistry.registerItem(item, item.getUnlocalizedName().substring(5));
}

public static void registerFluid(Fluid fluid){
	FluidRegistry.registerFluid(fluid);
}

public static void registerFluidContainer(Fluid fluid, Item bucket){
	FluidContainerRegistry.registerFluidContainer(fluid, new ItemStack(bucket), new ItemStack(Items.bucket));
}
}

 

OlivicBlocksBucketItem:

package com.hlaaftana.mods.OlivicBlocks.items;

import net.minecraft.block.Block;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBucket;

import com.hlaaftana.mods.OlivicBlocks.help.Reference;
import com.hlaaftana.mods.OlivicBlocks.tabs.ModTabs;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class OlivicBlocksBucketItem extends ItemBucket{
public OlivicBlocksBucketItem(String name, Block fluid){
	super(fluid);
	setCreativeTab(ModTabs.tabOlivic);
	setUnlocalizedName("bucket" + name);
	setContainerItem(Items.bucket);
}

@SideOnly(Side.CLIENT)
@Override
public void registerIcons(IIconRegister par1IconRegister){
	itemIcon = par1IconRegister.registerIcon(Reference.MODID + ":" + getUnlocalizedName().substring(5));
}
}

Main class:

package com.hlaaftana.mods.OlivicBlocks;

import net.minecraft.item.ItemStack;

import com.hlaaftana.mods.OlivicBlocks.crafting.Recipes;
import com.hlaaftana.mods.OlivicBlocks.generation.OlivicBlocksWorldGen;
import com.hlaaftana.mods.OlivicBlocks.generation.VanillaChestLootGen;
import com.hlaaftana.mods.OlivicBlocks.handlers.ConfigHandler;
import com.hlaaftana.mods.OlivicBlocks.handlers.FuelHandler;
import com.hlaaftana.mods.OlivicBlocks.help.LogHelper;
import com.hlaaftana.mods.OlivicBlocks.help.Reference;
import com.hlaaftana.mods.OlivicBlocks.init.ModBlocks;
import com.hlaaftana.mods.OlivicBlocks.init.ModFluids;
import com.hlaaftana.mods.OlivicBlocks.init.ModItems;
import com.hlaaftana.mods.OlivicBlocks.init.OreDictionaryRegister;

import cpw.mods.fml.common.IFuelHandler;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPostInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.registry.GameRegistry;

@Mod(modid = Reference.MODID, name = Reference.NAME, version = Reference.VERSION)
public class OlivicBlocks {
OlivicBlocksWorldGen eventWorldGen = new OlivicBlocksWorldGen();
IFuelHandler OBFuelHandler = new FuelHandler();
@Mod.EventHandler
public void preInit(FMLPreInitializationEvent event){
	LogHelper.info("Pre-init starting, registering fluids");
	ModFluids.init();
	LogHelper.info("Fluids registered, registering items");
	ModItems.init();
	LogHelper.info("Items registered, registering blocks");
	ModBlocks.init();
	LogHelper.info("Blocks registered, initalizing world generator");
	GameRegistry.registerWorldGenerator(this.eventWorldGen, 0);
	LogHelper.info("World generator initialized, registering OreDict entries");
	OreDictionaryRegister.registerOres();
	LogHelper.info("OreDict entries registered, checking/creating config");
	ConfigHandler.initProps(event.getModConfigurationDirectory());
	LogHelper.info("Config created/checked, adding loot");
	VanillaChestLootGen.init();
	LogHelper.info("Loot added");
	LogHelper.info("Pre-init done");
}
@Mod.EventHandler
public void Init(FMLInitializationEvent event){
	LogHelper.info("Init starting, registering fuels");
	GameRegistry.registerFuelHandler(OBFuelHandler);
	LogHelper.info("Fuels registered, adding recipes");
	Recipes.init();
	LogHelper.info("Recipes added");
	LogHelper.info("Init done");
}

@Mod.EventHandler
public void postInit(FMLPostInitializationEvent event){
	LogHelper.info("Post-init starting, scanning environment");
	CheckAround.verifyEnvironmentSanity();
	LogHelper.info("Environment scanned");
	LogHelper.info("Post-init done");
}
}

 

larsgerrits Reality Controller

larsgerrits

Posted
Posted

You never use that class outside of it. Therefore it never gets loaded, and never instantiate the INSTANCE field, and never registers your BucketHandler as an event handler. Easiest solution in my opinion: move the registration outside of the class, e.g. in init in your main mod file.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • jaysonwilfred12
      RAPID DIGITAL RECOVERY IS THE FUTURE OF BITCOIN RECOVERY AND SECURITY

      By jaysonwilfred12 · Posted

      Reach Out To Rapid Digital: What sapp Info: +1 41 4 80 7 14 85 Email INFO: rap iddi gita lrecov ery @ exe cs. com Hello, my name is Jayson, and I’m 35 years old from the United Kingdom. My family and I recently endured an incredibly challenging experience that I wouldn’t wish on anyone. We became victims of a cryptocurrency investment fraud scheme that saw us lose a staggering $807,000 in USDT and Bitcoins. The fraudsters had created a convincing facade, and we were lured into investing, only to discover later that the platform was a complete scam. We were left devastated, not just financially, but emotionally, as we had trusted these people and believed in the legitimacy of the investment. After the initial shock wore off, we desperately searched for ways to recover the lost funds. It seemed like an impossible task, and we felt as though there was no hope. That’s when, by sheer luck, we stumbled across a post about Rapid Digital Recovery, a cryptocurrency and funds recovery organization with a proven track record in cybersecurity and fraud recovery. We decided to reach out to them, and from the first interaction, we were impressed with their professionalism and transparency. They explained the recovery process in detail and reassured us that they had the skills and expertise to track down the perpetrators and recover our funds. This gave us a renewed sense of hope, something we hadn’t felt in months. What truly stood out during our experience with Rapid Digital Recovery was their dedication to the recovery process. The team went above and beyond, using sophisticated tracking tools and cyber forensics to gather critical information. Within a matter of weeks, they had successfully located the funds and traced the scam back to the fraudsters responsible. They worked with the authorities to ensure the criminals were held accountable for their actions. To our relief, the team at Rapid Digital Recovery was able to recover every single penny we had lost. The funds were returned in full, and the sense of closure we felt was invaluable. We couldn’t have imagined such a positive outcome in the early stages of our recovery journey, and we are deeply grateful for the work they did. If you ever find yourself in a similar situation, I highly recommend contacting Rapid Digital Recovery. Their expertise, transparency, and dedication to their clients make them the go-to choice for anyone seeking to recover lost cryptocurrency or funds. They truly gave us back our financial future.  
    • Cherry05
      [1.21.4] Could not resolve LocalPlayer.sendSystemMessage

      By Cherry05 · Posted

      This is my first time modding anything, so maybe just skill issue. I'm using Forge 54.0.12 and Temurin 21.0.5+11-LTS I wanted to create a custom keybind and to check whether it works I'd like to send a chat message. I tried using Minecraft.getInstance().player.sendSystemMessage(Component.literal("test")); but IntelliJ couldnt resolve sendSystemMessage(...). Since I saw people using it in earlier versions, I tried the same thing with 1.20.6(- 50.1.0), where it works fine, now I can't figure out if this is intentional and whether there are other options for sending chat messages. On that note, is there more documentation than https://docs.minecraftforge.net/en/1.21.x/? It seems very incomplete compared to something like the Oracle Java docs
    • lucxswrm
      ERROR CODE 01 - Forge 1.20.1

      By lucxswrm · Posted

      Hi, i'm having this error and I wanna fix it. we try: -Reload drivers -Eliminate .minecraft -Eliminate Java -Restart launcher -Verify if minecraft is using gpu -Mods  in .minecraft is empty -Install the latest and recomended version of forge idk what i have to do, help me pls. the lastest log is: https://mclo.gs/WAMao8x  
    • Ugdhar
      Minecraft textures break when fullscreen

      By Ugdhar · Posted

      Read the FAQ, Rule #2. (https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/)  
    • Ugdhar
      Minecraft crashes about 80 percent of the time when im loading into the world

      By Ugdhar · Posted

      The link to your log does not work, it says it is forbidden, Error, this is a private paste or is pending moderation.

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept