Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

The method the game uses to check for collisions between entities is *slightly* inefficient, and in my case slows down my code by a lot.

 

The method called World.getEntitiesWithinAABB() that takes in a filter goes down to this chunk method

public void getEntitiesOfTypeWithinAAAB(Class entityClass, AxisAlignedBB aabb, List listToFill, Predicate p_177430_4_)
    {
        int i = MathHelper.floor_double((aabb.minY - World.MAX_ENTITY_RADIUS) / 16.0D);
        int j = MathHelper.floor_double((aabb.maxY + World.MAX_ENTITY_RADIUS) / 16.0D);
        i = MathHelper.clamp_int(i, 0, this.entityLists.length - 1);
        j = MathHelper.clamp_int(j, 0, this.entityLists.length - 1);

        for (int k = i; k <= j; ++k)
        {
            Iterator iterator = this.entityLists[k].func_180215_b(entityClass).iterator();

            while (iterator.hasNext())
            {
                Entity entity = (Entity)iterator.next();

                if (entity.getEntityBoundingBox().intersectsWith(aabb) && (p_177430_4_ == null || p_177430_4_.apply(entity)))
                {
                    listToFill.add(entity);
                }
            }
        }
    }

 

My suggestion is to move the predicate checker 1 step higher to something like this

 

public void getEntitiesOfTypeWithinAAAB(Class entityClass, AxisAlignedBB aabb, List listToFill, Predicate p_177430_4_)
    {
        int i = MathHelper.floor_double((aabb.minY - World.MAX_ENTITY_RADIUS) / 16.0D);
        int j = MathHelper.floor_double((aabb.maxY + World.MAX_ENTITY_RADIUS) / 16.0D);
        i = MathHelper.clamp_int(i, 0, this.entityLists.length - 1);
        j = MathHelper.clamp_int(j, 0, this.entityLists.length - 1);

        for (int k = i; k <= j; ++k)
        {
            Iterator iterator = this.entityLists[k].func_180215_b(entityClass).iterator();

            while (iterator.hasNext())
            {
                Entity entity = (Entity)iterator.next();
                if(p_177430_4_ == null || p_177430_4_.apply(entity)){
                     if (entity.getEntityBoundingBox().intersectsWith(aabb) && ()
                     {
                           listToFill.add(entity);
                     }
               }
            }
        }
    }

 

This code does Exactly the same thing but it avoids unnecessary intercept calculations.

 

In my case where I have thousands of entities that use a complex intercept calculation this slows things down by a lot.

 

Please change, its a performance improvement for everybody!

"you seem to be THE best modder I've seen imo."

~spynathan

 

ლ(́◉◞౪◟◉‵ლ

Thats the thing tho, the intersection calculations should be the SIMPLE part of that statement.

As it should be simple 'is this box inside this other box'

The predicate is the expensive part which usually ends up doing inheritance checking or other things.

So what you're proposing us do si actually make it less efficient for the proper use cases...

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

@thebest108 - bro, you know you should not use thousands of entities just to make one entity have multiple hitBoxes.

From your previous posts I can tell this goes under bad design. You have entites assigned to one entity and you make server not even update those sub-entities, that is literally missing the point of making entities. Making multipart entity is not that hard :o Why you choose such workaround?

1.7.10 is no longer supported by forge, you are on your own.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.