Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[SOLVED]need help using the NBT [1.7.10]

BoonieQuafter-CrAfTeR

By BoonieQuafter-CrAfTeR
in Modder Support

 Share

Recommended Posts

Choonster Reality Controller

Choonster

Posted
Posted

Wand Level

 

...

 

actually and this is final, the cooldown changes depending on what level and type of spell

 

So create a 

getCooldown(ItemStack)

method that reads the wand's level and spell from the 

ItemStack

and returns the cooldown of the wand in ticks. Replace the 

FIRE_RATE

constant with a call to this method in 

isOffCooldown

.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

BoonieQuafter-CrAfTeR Diamond Finder

BoonieQuafter-CrAfTeR

Posted
  • Author
Posted

so while I was waiting for a reply I wrote this code for the cooldown thing and I want to know the errors and flaws about it just so that in the future I can figure this stuff out by myself. also I get this weird bug with checking if the correct owner is the player who is the owner, I started a lan to test it and when the wand transfers from one inventory to another and back to the owners, the owner no longer has access to the spells and info on the wand. why is this ?

package com.OlympiansMod.Item;

import java.util.List;

import com.OlympiansMod.entity.SlownessSpell;
import com.OlympiansMod.entity.SpellBombardo;
import com.OlympiansMod.entity.SpellChicken;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagLong;
import net.minecraft.util.ChatComponentText;
import net.minecraft.util.EnumChatFormatting;
import net.minecraft.util.IIcon;
import net.minecraft.world.World;

public class RandomWand extends Item{
//SlownessSpell
public int FIRE_RATE = 300;


private boolean isOffCooldown(ItemStack stack, World world) { 
		return !stack.hasTagCompound() || (world.getTotalWorldTime() - stack.getTagCompound().getLong("LastUseTime")) >= FIRE_RATE; 
	} 

    private void setLastUseTime(ItemStack stack, long time) { 
		stack.setTagInfo("LastUseTime", new NBTTagLong(time)); 
	} 

public ItemStack onItemRightClick(ItemStack itemstack, World world,
		EntityPlayer player) {
	if (!world.isRemote) {
        itemstack.damageItem(1, player);
	 if (itemstack.getTagCompound() == null)
        {
      if(itemstack.hasTagCompound() == false){
	 itemstack.stackTagCompound = new NBTTagCompound();
	 itemstack.stackTagCompound.setInteger("Spell", 0);
	 itemstack.stackTagCompound.setInteger("Other", 0);
	 itemstack.stackTagCompound.setInteger("XP", 1);
	 itemstack.stackTagCompound.setInteger("Level", 1);
	 itemstack.stackTagCompound.setInteger("Focus", 0);
	 itemstack.stackTagCompound.setString("owner", player.getDisplayName());

        }
        }
	int Level = itemstack.stackTagCompound.getInteger("Level");
    int Other = itemstack.stackTagCompound.getInteger("Other");
        int spell = itemstack.stackTagCompound.getInteger("Spell");
        int XP = itemstack.stackTagCompound.getInteger("XP");
        int Focus = itemstack.stackTagCompound.getInteger("Focus");
        String owner = itemstack.stackTagCompound.getString("owner");
        boolean isowner = owner == player.getDisplayName();
	boolean offCooldown = isOffCooldown(itemstack, world);

        
           
        if (isowner) {
            
      
      
    	
    
         
        
		if (player.isSneaking()) {
			if (spell == 0) {
				itemstack.stackTagCompound.setInteger("Spell", 1);
				player.addChatMessage(new ChatComponentText(EnumChatFormatting.GRAY +
						"Slowness Spell"));
			}
			if(spell == 1 && XP >= 20){
				itemstack.stackTagCompound.setInteger("Spell", 2);
				player.addChatMessage(new ChatComponentText(EnumChatFormatting.RED +
						"Explosive Spell"));
			}else{ 
			if(spell == 1 && XP <= 20)	{
				itemstack.stackTagCompound.setInteger("Spell", 0);
				player.addChatMessage(new ChatComponentText(EnumChatFormatting.BOLD +
						"Wand"));
			}

			}
			if(spell == 2 && XP >= 30){
				itemstack.stackTagCompound.setInteger("Spell", 3);
				player.addChatMessage(new ChatComponentText(EnumChatFormatting.WHITE +
						"Chicken Spell"));
			}else{
				if(spell == 2 && XP <= 30)	{
					itemstack.stackTagCompound.setInteger("Spell", 0);
					player.addChatMessage(new ChatComponentText(EnumChatFormatting.BOLD +
							"Wand"));

				}
			  }

			if(spell == 3 && XP >= 65){
				itemstack.stackTagCompound.setInteger("Spell", 4);
				player.addChatMessage(new ChatComponentText(EnumChatFormatting.LIGHT_PURPLE +
						"Healing Spell"));
			}else{
				if(spell == 3 && XP <= 65)	{
					itemstack.stackTagCompound.setInteger("Spell", 0);
					player.addChatMessage(new ChatComponentText(EnumChatFormatting.BOLD +
							"Wand"));

				}
			}
			if(spell == 4 && XP >= 65){
				itemstack.stackTagCompound.setInteger("Spell", 0);
				player.addChatMessage(new ChatComponentText(EnumChatFormatting.BOLD +
						"Wand"));

		}
		}
		if (player.isSneaking()) {
		}else{

		if(XP >= 19 && Other == 0 && offCooldown){
			itemstack.stackTagCompound.setInteger("Other", 1);
			itemstack.stackTagCompound.setInteger("Level", 2);
			itemstack.stackTagCompound.setInteger("Focus", 10);
			player.addChatMessage(new ChatComponentText(EnumChatFormatting.AQUA +
						"You Have Leveled Up!"));
			player.addChatMessage(new ChatComponentText(EnumChatFormatting.AQUA +
						"You have learned a new spell,"));
			player.addChatMessage(new ChatComponentText(EnumChatFormatting.AQUA +
						"as well as reduced 10% focus energy"));
			player.addChatMessage(new ChatComponentText(EnumChatFormatting.AQUA +
						"for all learned spells "));
		}
		if(spell == 1 && offCooldown){

			if(Level == 2 && spell == 1 ){
				FIRE_RATE = 270;
			}else if(Level == 3){
					FIRE_RATE = 255;
			}else if(Level == 4){
				    FIRE_RATE = 200;

			}
		        setLastUseTime(itemstack, world.getTotalWorldTime());
				player.playSound("fireworks.launch", 1.0f, 1.0f);
				world.spawnEntityInWorld(new SlownessSpell(world, player));

			if(XP > 0){
				itemstack.stackTagCompound.setInteger("XP", XP + 1);
			}

		}else{
			  if(spell == 2 && Level == 2){
				    FIRE_RATE = 550;
			  
			  }else if(spell == 2 && Level == 3){
					FIRE_RATE = 495;
			  }else if(spell == 2 && Level == 4){
					FIRE_RATE = 300;


			  }
			  if(spell == 3 && Level == 3){
				    FIRE_RATE = 300;
			  
			  }else if(spell == 3 && Level == 4){
					FIRE_RATE = 270;

			  }
			  if(spell == 4 && Level == 4){
				    FIRE_RATE = 650;
			  }
		}

		if(XP >= 29 && Other == 1 && offCooldown){
			itemstack.stackTagCompound.setInteger("Other", 2);
			itemstack.stackTagCompound.setInteger("Focus", Focus + 5);
			itemstack.stackTagCompound.setInteger("Level", 3);
			player.addChatMessage(new ChatComponentText(EnumChatFormatting.AQUA +
					"You Have Leveled Up!"));
			player.addChatMessage(new ChatComponentText(EnumChatFormatting.AQUA +
					"You have learned a new spell,"));
			player.addChatMessage(new ChatComponentText(EnumChatFormatting.AQUA +
					"as well as reduced 5% focus energy"));
			player.addChatMessage(new ChatComponentText(EnumChatFormatting.AQUA +
					"for all learned spells "));
		}

		if(spell == 2 && offCooldown){
			if(Level == 2 && spell == 2 ){
				FIRE_RATE = 550;
			}else if(Level == 3){
					FIRE_RATE = 495;
			}else if(Level == 4){
				    FIRE_RATE = 300;
			}
			    setLastUseTime(itemstack, world.getTotalWorldTime());
				player.playSound("fireworks.launch", 1.0f, 1.0f);
				world.spawnEntityInWorld(new SpellBombardo(world, player));
				player.addChatMessage(new ChatComponentText(EnumChatFormatting.RED +
						"Bombarda!"));


				if(XP > 0){
					itemstack.stackTagCompound.setInteger("XP", XP + 2);
				}


		}else{
		  if(spell == 1 && Level == 1){
			    FIRE_RATE = 300;
		  
		  }else if(spell == 1 && Level == 2){
				FIRE_RATE = 270;
		  }else if(spell == 1 && Level == 3){
				FIRE_RATE = 255;
		  }else if(spell == 1 && Level == 4){
				FIRE_RATE = 200;
		   
		  }
		  if(spell == 3 && Level == 3){
			    FIRE_RATE = 300;
		  
		  }else if(spell == 3 && Level == 4){
				FIRE_RATE = 270;

		  }
		  if(spell == 4 && Level == 4){
			    FIRE_RATE = 650;
		  }
		   

		}

		if(XP >= 64 && Other == 2 && offCooldown){
			itemstack.stackTagCompound.setInteger("Other", 5);
			itemstack.stackTagCompound.setInteger("Focus", Focus + 15);
			itemstack.stackTagCompound.setInteger("Level", 4);
			player.addChatMessage(new ChatComponentText(EnumChatFormatting.AQUA +
					"You Have Leveled Up!"));
			player.addChatMessage(new ChatComponentText(EnumChatFormatting.AQUA +
					"You have learned a new spell,"));
			player.addChatMessage(new ChatComponentText(EnumChatFormatting.AQUA +
					"as well as reduced 15% focus energy"));
			player.addChatMessage(new ChatComponentText(EnumChatFormatting.AQUA +
					"for all learned spells "));
		}
			if(spell == 3 && offCooldown){
				if(Level == 3 && spell == 3 ){
					FIRE_RATE = 270;
				}else if(Level == 4){
						FIRE_RATE = 255;
				//}else if(Level == 5){
					  //  FIRE_RATE = 200;

				}
			setLastUseTime(itemstack, world.getTotalWorldTime());
			player.playSound("fireworks.launch", 1.0f, 1.0f);
			world.spawnEntityInWorld(new SpellChicken(world, player));

			if(XP > 0){
				itemstack.stackTagCompound.setInteger("XP", XP + 1);
		}
			}else{
				  if(spell == 1 && Level == 1){
					    FIRE_RATE = 300;
				  
				  }else if(spell == 1 && Level == 2){
						FIRE_RATE = 270;
				  }else if(spell == 1 && Level == 3){
						FIRE_RATE = 255;
				  }else if(spell == 1 && Level == 4){
						FIRE_RATE = 200;
				   
				  }
				  if(spell == 2 && Level == 2){
					    FIRE_RATE = 550;
				  
				  }else if(spell == 2 && Level == 3){
						FIRE_RATE = 495;
				  }else if(spell == 2 && Level == 4){
						FIRE_RATE = 300;

				  }
				  if(spell == 4 && Level == 4){
					    FIRE_RATE = 650;
				  }



	}


		if(spell == 4 && offCooldown) {
			if(Level == 4 && spell == 4 ){
				FIRE_RATE = 650;
			//}else if(Level == 4){
					//FIRE_RATE = 255;
			//}else if(Level == 4){
				   // FIRE_RATE = 200;

			}
			setLastUseTime(itemstack, world.getTotalWorldTime());
			player.playSound("fireworks.launch", 1.0f, 1.0f);
			player.heal(3.0f);
			if(XP > 0){
				itemstack.stackTagCompound.setInteger("XP", XP + 2);



		}
		}else{
			  if(spell == 1 && Level == 1){
				    FIRE_RATE = 300;
			  
			  }else if(spell == 1 && Level == 2){
					FIRE_RATE = 270;
			  }else if(spell == 1 && Level == 3){
					FIRE_RATE = 255;
			  }else if(spell == 1 && Level == 4){
					FIRE_RATE = 200;
			   
			  }
			  if(spell == 2 && Level == 2){
				    FIRE_RATE = 550;
			  
			  }else if(spell == 2 && Level == 3){
					FIRE_RATE = 495;
			  }else if(spell == 2 && Level == 4){
					FIRE_RATE = 300;

			  }
			  if(spell == 3 && Level == 3){
				    FIRE_RATE = 300;
			  
			  }else if(spell == 3 && Level == 4){
					FIRE_RATE = 270;

			  }
			}
		}
        }else if(isowner == false){
	}
        
	}
	return itemstack;
}





public boolean isFull3D() {
	return true;
}
public void addInformation(ItemStack stack, EntityPlayer player, List list,
		boolean i) {
	list.add(EnumChatFormatting.BOLD + "Wand");
	list.add("      ");
	if(stack.hasTagCompound() == true){
	int Focus = stack.stackTagCompound.getInteger("Focus");
    int Level = stack.stackTagCompound.getInteger("Level");
        int spell = stack.stackTagCompound.getInteger("Spell");
        String owner = stack.stackTagCompound.getString("owner");
        int XP = stack.stackTagCompound.getInteger("XP");
        boolean isowner = owner == player.getDisplayName();

       if (isowner) {
                list.add(EnumChatFormatting.GREEN + "owner: " + owner);
          
        
	if(spell == 1) {
	list.add(EnumChatFormatting.GRAY + "Slowness Spell");
	}
	if(spell == 2) {
	list.add(EnumChatFormatting.RED + "Explosive Spell");
	}
	if(spell == 3) {
	list.add(EnumChatFormatting.WHITE + "Chicken Spell");
	}
	if(spell == 4) {
		list.add(EnumChatFormatting.LIGHT_PURPLE + "Healing Spell");
	}
	if(spell == 0) {
		list.add(EnumChatFormatting.WHITE + "    ");
	}
	list.add(EnumChatFormatting.YELLOW + "Current XP: " + XP);
        
        list.add(EnumChatFormatting.GOLD + "Level " + Level +":");
         
        list.add(EnumChatFormatting.AQUA + "-" + Focus + "%" +" Focus Energy");



       }else if(isowner == false){
       	list.add(EnumChatFormatting.RED + "owner: " + owner);
       }
	}
}

}

 

aslo for my question earlier:

like this?

	private int getCooldown(ItemStack stack) { 
    int Level = stack.stackTagCompound.getInteger("Level");
    int spell = stack.stackTagCompound.getInteger("Spell");

   if(Level == 1 && spell == 1){
	return 300;
      }
   if(Level == 2 && spell == 1){
	return 270;
     }
   if(Level == 3 && spell == 1){
	return 255;
    }
   if(Level == 3 && spell == 1){
		return 210;
     }
   if(Level == 4 && spell == 2){          
	return 550;                      
   }                                       
   if(Level == 2 && spell == 2){
	return 495;
      }
   if(Level == 3 && spell == 2){
	return 466;
     }
   if(Level == 4 && spell == 2){
	return 385;
    }
   if(Level == 3 && spell == 3){
	return 300;
   }
   if(Level == 4 && spell == 3){
	return 270;
  }
   if(Level == 4 && spell == 4){
		return 650;
   }
   
      return 0;
	} 

private boolean isOffCooldown(ItemStack stack, World world) { 
		return !stack.hasTagCompound() || (world.getTotalWorldTime() - stack.getTagCompound().getLong("LastUseTime")) >= getCooldown(stack); 
	} 

    private void setLastUseTime(ItemStack stack, long time) { 
		stack.setTagInfo("LastUseTime", new NBTTagLong(time)); 
	}

Im serious don't look at it!!

Choonster Reality Controller

Choonster

Posted
Posted

Don't compare strings with 

==

, use the 

equals

method. Strings with the same content (which is what the equals method checks) aren't always the same object (which is what the 

==

operator checks).

 

Since display names can be changed, I'd recommend storing the 

UUID

of the owner instead (which is guaranteed to remain the same); you can get this from the 

Entity#getUniqueId

method. 

UUID

s are stored in NBT as a 

long

for the most significant bits and a 

long

for the least significant bits (returned from the appropriate 

UUID

getter methods) and can be read back with the 

UUID(long,long)

constructor.

 

UsernameCache.getLastKnownUsername

will return the last known username of the player with the specified 

UUID

.

 

I'm not too sure what would cause an item to lose its NBT when dropped. Your code is a bit hard to read, I'd recommend using your IDE's auto-format tool and posting it on Gist or Pastebin with syntax highlighting.

 

The cooldown code in the second code block looks right to me.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

BoonieQuafter-CrAfTeR Diamond Finder

BoonieQuafter-CrAfTeR

Posted
  • Author
Posted

ok here is the code(Formated):

package com.OlympiansMod.Item;

import java.util.List;

import com.OlympiansMod.entity.SlownessSpell;
import com.OlympiansMod.entity.SpellBombardo;
import com.OlympiansMod.entity.SpellChicken;
import com.OlympiansMod.entity.SpellIncendio;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagLong;
import net.minecraft.util.ChatComponentText;
import net.minecraft.util.EnumChatFormatting;
import net.minecraft.util.IIcon;
import net.minecraft.world.World;

public class RandomWand extends Item {
// SlownessSpell
public static final int FIRE_RATE = 300;

private int getCooldown(ItemStack stack) {
	int Level = stack.stackTagCompound.getInteger("Level");
	int spell = stack.stackTagCompound.getInteger("Spell");

	if (Level == 1 && spell == 1) {
		return 300;
	}
	if (Level == 2 && spell == 1) {
		return 270;
	}
	if (Level == 3 && spell == 1) {
		return 255;
	}
	if (Level == 4 && spell == 1) {
		return 210;
	}
	if (Level == 5 && spell == 1) {
		return 195;
	}

	if (Level == 2 && spell == 2) {
		return 495;
	}
	if (Level == 3 && spell == 2) {
		return 466;
	}
	if (Level == 4 && spell == 2) {
		return 385;
	}
	if (Level == 5 && spell == 2) {
		return 357;
	}
	if (Level == 3 && spell == 3) {
		return 300;
	}
	if (Level == 4 && spell == 3) {
		return 255;
	}
	if (Level == 5 && spell == 3) {
		return 215;
	}
	if (Level == 4 && spell == 4) {
		return 650;
	}
	if (Level == 5 && spell == 4) {
		return 618;
	}
	if (Level == 5 && spell == 5) {
		return 300;
	}

	return 0;
}

private boolean isOffCooldown(ItemStack stack, World world) {
	return !stack.hasTagCompound()
			|| (world.getTotalWorldTime() - stack.getTagCompound().getLong(
					"LastUseTime")) >= getCooldown(stack);
}

private void setLastUseTime(ItemStack stack, long time) {
	stack.setTagInfo("LastUseTime", new NBTTagLong(time));
}

public ItemStack onItemRightClick(ItemStack itemstack, World world,
		EntityPlayer player) {
	if (!world.isRemote) {
		itemstack.damageItem(1, player);
		if (itemstack.getTagCompound() == null) {
			if (itemstack.hasTagCompound() == false) {
				itemstack.stackTagCompound = new NBTTagCompound();
				itemstack.stackTagCompound.setInteger("Spell", 0);
				itemstack.stackTagCompound.setInteger("Other", 0);
				itemstack.stackTagCompound.setInteger("XP", 1);
				itemstack.stackTagCompound.setInteger("Level", 1);
				itemstack.stackTagCompound.setInteger("Focus", 0);
				itemstack.stackTagCompound.setString("owner",
						player.getDisplayName());

			}
		}
		int Level = itemstack.stackTagCompound.getInteger("Level");
		int Other = itemstack.stackTagCompound.getInteger("Other");
		int spell = itemstack.stackTagCompound.getInteger("Spell");
		int XP = itemstack.stackTagCompound.getInteger("XP");
		int Focus = itemstack.stackTagCompound.getInteger("Focus");
		String owner = itemstack.stackTagCompound.getString("owner");
		boolean isowner = owner.equals(player.getDisplayName());
		boolean offCooldown = isOffCooldown(itemstack, world);

		if (isowner) {

			if (player.isSneaking()) {
				if (spell == 0) {
					itemstack.stackTagCompound.setInteger("Spell", 1);
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.GRAY + "Slowness Spell"));
				}
				if (spell == 1 && XP >= 20) {
					itemstack.stackTagCompound.setInteger("Spell", 2);
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.RED + "Explosive Spell"));
				} else {
					if (spell == 1 && XP <= 20) {
						itemstack.stackTagCompound.setInteger("Spell", 0);
						player.addChatMessage(new ChatComponentText(
								EnumChatFormatting.BOLD + "Wand"));
					}

				}
				if (spell == 2 && XP >= 30) {
					itemstack.stackTagCompound.setInteger("Spell", 3);
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.WHITE + "Chicken Spell"));
				} else {
					if (spell == 2 && XP <= 30) {
						itemstack.stackTagCompound.setInteger("Spell", 0);
						player.addChatMessage(new ChatComponentText(
								EnumChatFormatting.BOLD + "Wand"));

					}
				}

				if (spell == 3 && XP >= 65) {
					itemstack.stackTagCompound.setInteger("Spell", 4);
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.LIGHT_PURPLE
									+ "Healing Spell"));
				} else {
					if (spell == 3 && XP <= 65) {
						itemstack.stackTagCompound.setInteger("Spell", 0);
						player.addChatMessage(new ChatComponentText(
								EnumChatFormatting.BOLD + "Wand"));

					}
				}
				if (spell == 4 && XP >= 105) {
					itemstack.stackTagCompound.setInteger("Spell", 5);
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.BOLD + "Fire Spell"));
				} else {
					if (spell == 4 && XP <= 105) {
						itemstack.stackTagCompound.setInteger("Spell", 0);
						player.addChatMessage(new ChatComponentText(
								EnumChatFormatting.BOLD + "Wand"));
					}

				}
				if (spell == 5 && XP >= 105) {
					itemstack.stackTagCompound.setInteger("Spell", 0);
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.BOLD + "Wand"));
				}
			}
			if (player.isSneaking()) {
			} else {

				if (XP >= 19 && Other == 0 && offCooldown) {
					itemstack.stackTagCompound.setInteger("Other", 1);
					itemstack.stackTagCompound.setInteger("Level", 2);
					itemstack.stackTagCompound.setInteger("Focus", 10);
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "You Have Leveled Up!"));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "You have learned a new spell,"));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "as well as reduced 10% focus energy"));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "for all learned spells "));
				}
				if (spell == 1 && offCooldown) {

					setLastUseTime(itemstack, world.getTotalWorldTime());
					player.playSound("fireworks.launch", 1.0f, 1.0f);
					world.spawnEntityInWorld(new SlownessSpell(world,
							player));

					if (XP > 0) {
						itemstack.stackTagCompound.setInteger("XP", XP + 1);
					}

				}

				if (XP >= 29 && Other == 1 && offCooldown) {
					itemstack.stackTagCompound.setInteger("Other", 2);
					itemstack.stackTagCompound.setInteger("Focus",
							Focus + 5);
					itemstack.stackTagCompound.setInteger("Level", 3);
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "You Have Leveled Up!"));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "You have learned a new spell,"));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "as well as reduced 5% focus energy"));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "for all learned spells "));
				}

				if (spell == 2 && offCooldown) {

					setLastUseTime(itemstack, world.getTotalWorldTime());
					player.playSound("fireworks.launch", 1.0f, 1.0f);
					world.spawnEntityInWorld(new SpellBombardo(world,
							player));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.RED + "Bombarda!"));

					if (XP > 0) {
						itemstack.stackTagCompound.setInteger("XP", XP + 2);
					}

				}

				if (XP >= 64 && Other == 2 && offCooldown) {
					itemstack.stackTagCompound.setInteger("Other", 3);
					itemstack.stackTagCompound.setInteger("Focus",
							Focus + 15);
					itemstack.stackTagCompound.setInteger("Level", 4);
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "You Have Leveled Up!"));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "You have learned a new spell,"));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "as well as reduced 15% focus energy"));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "for all learned spells "));
				}
				if (spell == 3 && offCooldown) {

					setLastUseTime(itemstack, world.getTotalWorldTime());
					player.playSound("fireworks.launch", 1.0f, 1.0f);
					world.spawnEntityInWorld(new SpellChicken(world, player));

					if (XP > 0) {
						itemstack.stackTagCompound.setInteger("XP", XP + 1);
					}

				}
				if (XP >= 104 && Other == 3 && offCooldown) {
					itemstack.stackTagCompound.setInteger("Other", 4);
					itemstack.stackTagCompound.setInteger("Level", 5);
					itemstack.stackTagCompound.setInteger("Focus",
							Focus + 5);
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "You Have Leveled Up!"));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "You have learned a new spell,"));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "as well as reduced 5% focus energy"));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.AQUA
									+ "for all learned spells "));
				}
				if (spell == 4 && offCooldown) {

					setLastUseTime(itemstack, world.getTotalWorldTime());
					player.playSound("fireworks.launch", 1.0f, 1.0f);
					player.heal(3.0f);
					if (XP > 0) {
						itemstack.stackTagCompound.setInteger("XP", XP + 2);
					}
				}
				if (spell == 5 && offCooldown) {

					setLastUseTime(itemstack, world.getTotalWorldTime());
					player.playSound("fireworks.launch", 1.0f, 1.0f);
					world.spawnEntityInWorld(new SpellIncendio(world,
							player));
					player.addChatMessage(new ChatComponentText(
							EnumChatFormatting.YELLOW + "Incendio!"));
					if (XP > 0) {
						itemstack.stackTagCompound.setInteger("XP", XP + 1);
					}
				}
			}
		} else if (isowner == false) {
		}

	}
	return itemstack;
}

public boolean isFull3D() {
	return true;
}

public void addInformation(ItemStack stack, EntityPlayer player, List list,
		boolean i) {
	list.add(EnumChatFormatting.BOLD + "Wand");
	list.add("      ");
	if (stack.hasTagCompound() == true) {
		int Focus = stack.stackTagCompound.getInteger("Focus");
		int Level = stack.stackTagCompound.getInteger("Level");
		int spell = stack.stackTagCompound.getInteger("Spell");
		String owner = stack.stackTagCompound.getString("owner");
		int XP = stack.stackTagCompound.getInteger("XP");
		boolean isowner = owner.equals(player.getDisplayName());

		if (isowner) {
			list.add(EnumChatFormatting.GREEN + "owner: " + owner);

			if (spell == 1) {
				list.add(EnumChatFormatting.GRAY + "Slowness Spell");
			}
			if (Level == 2 && spell == 1) {
				list.add(EnumChatFormatting.GRAY + "-10% Focus Energy");

			}
			if (Level == 3 && spell == 1) {
				list.add(EnumChatFormatting.GRAY + "-15% Focus Energy");

			}
			if (Level == 4 && spell == 1) {
				list.add(EnumChatFormatting.GRAY + "-30% Focus Energy");

			}
			if (Level == 5 && spell == 1) {
				list.add(EnumChatFormatting.GRAY + "-35% Focus Energy");

			}
			if (spell == 2) {
				list.add(EnumChatFormatting.RED + "Explosive Spell");
			}
			if (Level == 3 && spell == 2) {
				list.add(EnumChatFormatting.GRAY + "-5% Focus Energy");

			}
			if (Level == 4 && spell == 2) {
				list.add(EnumChatFormatting.GRAY + "-20% Focus Energy");
			}
			if (Level == 5 && spell == 2) {
				list.add(EnumChatFormatting.GRAY + "-25% Focus Energy");

			}
			if (spell == 3) {
				list.add(EnumChatFormatting.WHITE + "Chicken Spell");
			}

			if (Level == 4 && spell == 3) {
				list.add(EnumChatFormatting.GRAY + "-15% Focus Energy");

			}
			if (Level == 5 && spell == 3) {
				list.add(EnumChatFormatting.GRAY + "-20% Focus Energy");

			}
			if (spell == 4) {
				list.add(EnumChatFormatting.LIGHT_PURPLE + "Healing Spell");
			}
			if (Level == 5 && spell == 3) {
				list.add(EnumChatFormatting.GRAY + "-20% Focus Energy");

			}

			if (spell == 5) {
				list.add(EnumChatFormatting.LIGHT_PURPLE + "Fire Spell");
			}
			if (spell == 0) {
				list.add(EnumChatFormatting.WHITE + "    ");
			}
			list.add(EnumChatFormatting.YELLOW + "Current XP: " + XP);

			list.add(EnumChatFormatting.GOLD + "Level " + Level + ":");
			if (Level == 1) {
				list.add(EnumChatFormatting.AQUA + "Next Level at: "
						+ EnumChatFormatting.YELLOW + "20 XP");
			}
			if (Level == 2) {
				list.add(EnumChatFormatting.AQUA + "Next Level at: "
						+ EnumChatFormatting.YELLOW + "30 XP");
			}
			if (Level == 3) {
				list.add(EnumChatFormatting.AQUA + "Next Level at: "
						+ EnumChatFormatting.YELLOW + "65 XP");
			}
			if (Level == 4) {
				list.add(EnumChatFormatting.AQUA + "Next Level at: "
						+ EnumChatFormatting.YELLOW + "105 XP");
			}

		} else if (isowner == false) {
			list.add(EnumChatFormatting.RED + "owner: " + owner);
		}

	}
}
}

 

Im serious don't look at it!!

Choonster Reality Controller

Choonster

Posted
Posted

ok here is the code(Formated):

if (itemstack.getTagCompound() == null) {
if (itemstack.hasTagCompound() == false) {

 

This particular check is redundant. If 

getTagCompound

returned 

null

, 

hasTagCompound

will always return 

false

; so there's no need to check both.

 

Have you considered moving the spells to their own classes? It would reduce the number of huge if chains in your wand class.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept