Jump to content

[UNSOLVED][1.8]Changing a player's skin (on the client-side only)


Recommended Posts

Posted

Hey guys, I am trying to make the player's skin change, on the client side only, in single player. I have tried 2 methods, the first of which does nothing, and the second has an error in the console to go with it not working.

Yes, I have the skin named correctly at the path I pointed the code to.

First method: Trying to replace RenderPlayer with a custom one during RenderPlayerEvent.Pre

 

 

My Main Mod File

@SideOnly(Side.CLIENT)
@Mod(modid=SaveMySkin.MODID, name=SaveMySkin.MODNAME, version=SaveMySkin.VERSION, clientSideOnly=true)
public class SaveMySkin {
public static final String MODID = "savemyskin";
public static final String MODNAME = "Save My Skin";
public static final String VERSION = "2.0.0.1";
@Instance(MODID)
public static SaveMySkin instance;

public static final File skindir = new File((File)FMLInjectionData.data()[6], "cachedskins/");

@EventHandler
public void preInit(FMLPreInitializationEvent event){
	try {
		Files.createDirectory(skindir.toPath());
	} catch (IOException e) {}
	((SimpleReloadableResourceManager)Minecraft.getMinecraft().getResourceManager()).reloadResourcePack(new DummyResourcePack());
	MinecraftForge.EVENT_BUS.register(this);
}
@SubscribeEvent
public void renderPlayer(RenderPlayerEvent.Pre event){
	ReflectionHelper.setPrivateValue(RenderManager.class, Minecraft.getMinecraft().getRenderManager(), new ReRenderPlayer(Minecraft.getMinecraft().getRenderManager()), "field_178637_m");
}
}

ReRenderPlayer.class

public class ReRenderPlayer extends RenderPlayer {

public ReRenderPlayer(RenderManager renderManager) {
	super(renderManager);
}
@Override
protected ResourceLocation getEntityTexture(Entity entity)
{
	return new ResourceLocation(SaveMySkin.MODID, String.format("%s.png", Minecraft.getMinecraft().getSession().getUsername()));
}
}

DummyResourcePack.class

public class DummyResourcePack extends FileResourcePack {

public DummyResourcePack() {
	super(new File((File)FMLInjectionData.data()[6], "cachedskins/"));
}
@Override
public String getPackName()
{
	return SaveMySkin.MODID;
}
}

 

 

Method 2: Replace the skin during ClientConnectedToServerEvent

 

 

Main Mod File:

@SideOnly(Side.CLIENT)
@Mod(modid=SaveMySkin.MODID, name=SaveMySkin.MODNAME, version=SaveMySkin.VERSION, clientSideOnly=true)
public class SaveMySkin {
public static final String MODID = "savemyskin";
public static final String MODNAME = "Save My Skin";
public static final String VERSION = "2.0.0.1";
@Instance(MODID)
public static SaveMySkin instance;

public static final File skindir = new File((File)FMLInjectionData.data()[6], "cachedskins/");

@EventHandler
public void preInit(FMLPreInitializationEvent event){
	try {
		Files.createDirectory(skindir.toPath());
	} catch (IOException e) {}
	FMLCommonHandler.instance().bus().register(this);
}
@SubscribeEvent
public void onPlayerLogin(final ClientConnectedToServerEvent event) {
	(new Thread() {
		@Override
		public void run() {
			while (Minecraft.getMinecraft().getTextureManager() == null || Minecraft.getMinecraft().thePlayer == null){
				try {
					Thread.sleep(100);
				} catch (InterruptedException e) {
				}
			}
			EntityPlayerSP player = Minecraft.getMinecraft().thePlayer;
			TextureManager texturemanager = Minecraft.getMinecraft().getTextureManager();
			ITextureObject textureObject = texturemanager.getTexture(player.getLocationSkin());

			if (textureObject == null) {
				textureObject = new ThreadDownloadImageData((File) null, String.format("http://skins.minecraft.net/MinecraftSkins/%s.png", Minecraft.getMinecraft().getSession().getUsername()), player.getLocationSkin(), new ImageBufferDownload());
				texturemanager.loadTexture(player.getLocationSkin(), textureObject);
			}
			try {
				TextureUtil.uploadTextureImage(textureObject.getGlTextureId(), ImageIO.read(new File(skindir, Minecraft.getMinecraft().getSession().getUsername()+".png")));
			} catch (IOException e) {
				e.printStackTrace();
			}
		}
	}).start();
}

Error(It doesn't crash):

Exception in thread "Thread-14" [22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: net.minecraft.util.ReportedException: Registering texture
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: 	at net.minecraft.client.renderer.texture.TextureManager.loadTexture(TextureManager.java:92)
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: 	at the_fireplace.savemyskin.SaveMySkin$1.run(SaveMySkin.java:109)
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: Caused by: java.lang.RuntimeException: No OpenGL context found in the current thread.
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: 	at org.lwjgl.opengl.GLContext.getCapabilities(GLContext.java:124)
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: 	at org.lwjgl.opengl.GL11.glGenTextures(GL11.java:1403)
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: 	at net.minecraft.client.renderer.GlStateManager.generateTexture(GlStateManager.java:332)
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: 	at net.minecraft.client.renderer.texture.TextureUtil.glGenTextures(TextureUtil.java:36)
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: 	at net.minecraft.client.renderer.texture.AbstractTexture.getGlTextureId(AbstractTexture.java:57)
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: 	at net.minecraft.client.renderer.ThreadDownloadImageData.getGlTextureId(ThreadDownloadImageData.java:62)
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: 	at net.minecraft.client.renderer.texture.SimpleTexture.loadTexture(SimpleTexture.java:58)
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: 	at net.minecraft.client.renderer.ThreadDownloadImageData.loadTexture(ThreadDownloadImageData.java:79)
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: 	at net.minecraft.client.renderer.texture.TextureManager.loadTexture(TextureManager.java:70)
[22:40:48] [Thread-14/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: 	... 1 more

SaveMySkin.java is my main mod file, line 109 is

texturemanager.loadTexture(player.getLocationSkin(), textureObject);

to make it easier to find in the code above, here is it and the surrounding lines

if (textureObject == null) {
				textureObject = new ThreadDownloadImageData((File) null, String.format("http://skins.minecraft.net/MinecraftSkins/%s.png", Minecraft.getMinecraft().getSession().getUsername()), player.getLocationSkin(), new ImageBufferDownload());
				texturemanager.loadTexture(player.getLocationSkin(), textureObject);
			}

I think method 1 is closer to getting it right than this one.

 

 

I apologize if how I am going about this is completely wrong or I am making a simple mistake; it is late and I have only been working on this for an hour or two.

 

Any help is appreciated.

If I helped please press the Thank You button.

 

Check out my mods at http://www.curse.com/users/The_Fireplace/projects

Posted

I think you are not allowed to do that..

Also RenderPlayerEvent will not work on 1.8;

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Posted

In your post, you are referencing the cache of skins, but you only need to do that if you are hijacking a skin.

 

Do you want the player to have a default list of skins of your picking or do you want to just give him the skin of some other player you are dynamically picking?

 

The first is easier.  Just look at how zombies or whatever have a static skin referenced and do that for getting the resourcelocation instead of the the current method.

Long time Bukkit & Forge Programmer

Happy to try and help

Posted

In your post, you are referencing the cache of skins, but you only need to do that if you are hijacking a skin.

 

Do you want the player to have a default list of skins of your picking or do you want to just give him the skin of some other player you are dynamically picking?

 

The first is easier.  Just look at how zombies or whatever have a static skin referenced and do that for getting the resourcelocation instead of the the current method.

Yes, I know the first one is easier, but the goal here is to download the player's skin while they are connected to the internet(I have that part working, so I didn't show it there with my code), and apply it to the player when the player starts the game and they are offline. So yeah, it has to be dynamic.

If I helped please press the Thank You button.

 

Check out my mods at http://www.curse.com/users/The_Fireplace/projects

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.