Search the Forums BEFORE making a new post.

[Solved] [1.8] onBlockPlacedBy and onBlockPlaced Not Working

Posted September 4, 201510 yr

I've created a block, and it's supposed to set its block bounds when it's placed. I put in the code for it to set them, but when I placed the block, nothing happened. I put in debug code for it to print when those methods are called, but the debug code isn't called either. Here's my block class:


package lordmastodon.miscal.block;


import java.util.Random;


import lordmastodon.miscal.Miscal;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyBool;
import net.minecraft.block.properties.PropertyDirection;
import net.minecraft.block.state.BlockState;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumWorldBlockLayer;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;


public class LightationBlock extends Block {
   
   public static final PropertyDirection FACING = PropertyDirection.create("facing");
    public static final PropertyBool LIT_UP = PropertyBool.create("lit");


    private float pixel = 1F/16F;
    
   public LightationBlock() {
      super(Material.iron);
      
      this.setDefaultState(this.blockState.getBaseState().withProperty(FACING, EnumFacing.NORTH).withProperty(LIT_UP, Boolean.valueOf(false)));
   }
   
   @Override
   public Item getItemDropped(IBlockState state, Random rand, int fortune) {
      return Item.getItemFromBlock(MiscalBlocks.lightation);
   }
   
   @Override
   public boolean canPlaceBlockOnSide(World worldIn, BlockPos pos, EnumFacing side) {
      return worldIn.isSideSolid(pos.offset(side.getOpposite()), side, true);
   }
   
   @Override
   public boolean canPlaceBlockAt(World world, BlockPos pos) {
      EnumFacing[] anenumfacing = EnumFacing.values();
      int i  = anenumfacing.length;
      
      for (int j = 0; j < i; j++) {
         EnumFacing enumfacing = anenumfacing[j];
         
         if (world.isSideSolid(pos.offset(enumfacing), enumfacing.getOpposite(), true)) {
            return true;
         }
      }
      
      return false;
   }
   
   @Override
   public IBlockState onBlockPlaced(World world, BlockPos pos, EnumFacing facing, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer) {
        Miscal.modLogger.debug("Placed Block");
      
      return world.isSideSolid(pos.offset(facing.getOpposite()), facing, true) ? this.getDefaultState().withProperty(FACING, facing).withProperty(LIT_UP, Boolean.valueOf(false)) : this.getDefaultState().withProperty(FACING, EnumFacing.DOWN).withProperty(LIT_UP, Boolean.valueOf(false));
    }
   
   @Override
   public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
      setBlockBoundsBasedOnFacing(worldIn, pos);
      
      Miscal.modLogger.debug("Placed Block");
   }
   
   @Override
   public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer player, EnumFacing side, float hitX, float hitY, float hitZ) {
      if (!world.isRemote) {
         boolean litUp = (Boolean) state.getValue(LIT_UP);
         
         if(!litUp) {
            world.setBlockState(pos, state.withProperty(LIT_UP, Boolean.valueOf(true)));
            
            setBlockBoundsBasedOnFacing(world, pos);
         } else {
            world.setBlockState(pos, state.withProperty(LIT_UP, Boolean.valueOf(false)));
            
            setBlockBoundsBasedOnFacing(world, pos);
         }
      }
      
      world.notifyNeighborsOfStateChange(pos, this);
        world.notifyNeighborsOfStateChange(pos.offset(((EnumFacing) state.getValue(FACING)).getOpposite()), this);
      
      return true;
   }
   
   //Switches light value when blockstate changes
   @Override
   public int getLightValue(IBlockAccess world, BlockPos pos) {
      int lightValue = 0;
      
      boolean litUp = (Boolean) world.getBlockState(pos).getValue(LIT_UP);


         if (litUp) {
            lightValue = 15;
      } else {
         lightValue = 0;
      }
   
      return lightValue;
   }
   
   @Override
   public IBlockState getStateFromMeta(int meta) {
      boolean lit = false;
      EnumFacing facing = EnumFacing.NORTH;
      
      switch (meta) {
      case 0:
         lit = false;
         break;
      case 1:
         lit = true;
         break;
      case 2:
         facing = EnumFacing.NORTH;
         break;
      case 3:
         facing = EnumFacing.EAST;
         break;
      case 4:
         facing = EnumFacing.SOUTH;
         break;
      case 5:
         facing = EnumFacing.WEST;
         break;
      case 6:
         facing = EnumFacing.UP;
         break;
      case 7:
         facing = EnumFacing.DOWN;
         break;
      }
      
      return this.getDefaultState().withProperty(LIT_UP, Boolean.valueOf(lit)).withProperty(FACING, facing);
   }
   
   
   public void setBlockBoundsBasedOnFacing(IBlockAccess world, BlockPos pos) {
      boolean litUp = (Boolean) world.getBlockState(pos).getValue(LIT_UP);
      EnumFacing facing = (EnumFacing) world.getBlockState(pos).getValue(FACING);
      
      if (facing == EnumFacing.NORTH) {
         if (litUp) {
            this.setBlockBounds(0F * pixel, 5F * pixel, 5F * pixel, 2F * pixel, 11F * pixel, 11F * pixel);
         } else {
            this.setBlockBounds(16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel);
         }
      } else if (facing == EnumFacing.WEST) {
         if (litUp) {
            this.setBlockBounds(5F * pixel, 5F * pixel, 0F * pixel, 11F * pixel, 2F * pixel, 11F * pixel);
         } else {
            this.setBlockBounds(16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel);
         }
      } else if (facing == EnumFacing.SOUTH) {
         if (litUp) {
            this.setBlockBounds(16F * pixel, 11F * pixel, 11F * pixel, 13F * pixel, 5F * pixel, 5F * pixel);
         } else {
            this.setBlockBounds(16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel);
         }
      } else if (facing == EnumFacing.EAST) {
         if (litUp) {
            this.setBlockBounds(11F * pixel, 11F * pixel, 16F * pixel, 5F * pixel, 13F * pixel, 5F * pixel);
         } else {
            this.setBlockBounds(16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel);
         }
      } else if (facing == EnumFacing.UP) {
         if (litUp) {
            this.setBlockBounds(5F * pixel, 0F * pixel, 5F * pixel, 11F * pixel, 2F * pixel, 11F * pixel);
         } else {
            this.setBlockBounds(16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel);
         }
      } else if (facing == EnumFacing.DOWN) {
         if (litUp) {
            this.setBlockBounds(11F * pixel, 16F * pixel, 11F * pixel, 5F * pixel, 13F * pixel, 5F * pixel);
         } else {
            this.setBlockBounds(16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel);
         }
      }
      
      Miscal.modLogger.debug("Set Block Bounds to " + toString(facing));
   }
   
   private String toString(EnumFacing facing) {
      return facing.getName();
   }
   
   @Override
   public int getMetaFromState(IBlockState state) {
      if((EnumFacing) state.getValue(FACING) == EnumFacing.NORTH) {
         return 0;
      } else if ((EnumFacing) state.getValue(FACING) == EnumFacing.WEST) {
         return 1;
      } else if ((EnumFacing) state.getValue(FACING) == EnumFacing.SOUTH) {
         return 2;
      } else if ((EnumFacing) state.getValue(FACING) == EnumFacing.EAST) {
         return 3;
      } else if ((EnumFacing) state.getValue(FACING) == EnumFacing.UP) {
         return 4;
      } else if ((EnumFacing) state.getValue(FACING) == EnumFacing.DOWN) {
         return 5;
      } else if ((Boolean) state.getValue(LIT_UP) == false) {
         return 6;
      } else {
         return 7;
      }
   }
   
   @Override
   @SideOnly(Side.CLIENT)
   public IBlockState getStateForEntityRender(IBlockState state) {
      return this.getDefaultState().withProperty(LIT_UP, Boolean.valueOf(false)).withProperty(FACING, Integer.valueOf(0));
   }
   
   @Override
   protected BlockState createBlockState() {
      return new BlockState(this, new IProperty[] {LIT_UP, FACING});
   }
   
   @Override
   public int getRenderType() {
      return 3; 
   }
   
   @Override
   public boolean isOpaqueCube() {
      return false;
   }
   
   @SideOnly(Side.CLIENT)
   @Override
   public EnumWorldBlockLayer getBlockLayer() {
      return EnumWorldBlockLayer.CUTOUT_MIPPED;
   }
   
   @Override
   public boolean isFullCube() {
      return false;
   }
   
   @Override
   public int isProvidingWeakPower(IBlockAccess worldIn, BlockPos pos, IBlockState state, EnumFacing side) {
        return (Boolean) state.getValue(LIT_UP) ? 15 : 0;
    }


   @Override
    public int isProvidingStrongPower(IBlockAccess worldIn, BlockPos pos, IBlockState state, EnumFacing side){
        return (Boolean) state.getValue(LIT_UP) ? 0 : (state.getValue(FACING) == side ? 15 : 0);
    }
    
   @Override
    public boolean canProvidePower() {
        return true;
    }
   
}

Any help? Thanks in advance!

EDIT 1

Never mind. It seems that they ARE working, but Logger.debug is not. No clue why that is.

Who are you? Why have you brought me here? And why are there so many PewDiePie fanboys surrounding meeeeeeeee....... *falls into pit and dies*.

Also this. Check it out.

width=700 height=200 http://i.imgur.com/J4rrGt6.png[/img]

Quote

September 4, 201510 yr

You probably waiting for help but i would like to know what propertydirection is . I have used forgedirections before but this?

Quote

September 4, 201510 yr

Author

It uses EnumFacing. It's how you switch the block's direction when it's placed and things like that. It's basically NORTH, WEST, SOUTH, EAST, UP, DOWN.

Who are you? Why have you brought me here? And why are there so many PewDiePie fanboys surrounding meeeeeeeee....... *falls into pit and dies*.

Also this. Check it out.

width=700 height=200 http://i.imgur.com/J4rrGt6.png[/img]

Quote

September 4, 201510 yr

OnBlockPlacedBy doesn't work for me either - i try setting rotation of a tileentity with it. Probably this is a forge bug?

Quote

September 4, 201510 yr

Author

I don't know. It seems to be working for my other block, but there I use onBlockAdded so I don't know if that's important.

Who are you? Why have you brought me here? And why are there so many PewDiePie fanboys surrounding meeeeeeeee....... *falls into pit and dies*.

Also this. Check it out.

width=700 height=200 http://i.imgur.com/J4rrGt6.png[/img]

Quote

September 4, 201510 yr

Author

UPDATE

onBlockAdded

doesn't seem to be working either. There also seems to be an odd bug that results in the block having no bounding box when I place it, but when I close Minecraft and reload the world the block has a full bounding box until I place a new block, and then the bounding boxes of every single instance of that block disappears. When I right-click the block when it has a bounding box the box disappears as well.

Who are you? Why have you brought me here? And why are there so many PewDiePie fanboys surrounding meeeeeeeee....... *falls into pit and dies*.

Also this. Check it out.

width=700 height=200 http://i.imgur.com/J4rrGt6.png[/img]

Quote

September 5, 201510 yr

EDIT 1

Never mind. It seems that they ARE working, but Logger.debug is not. No clue why that is.

Are you looking at the IDE's console or the log file itself? Messages with a

Level

less specific than

INFO

(i.e.

DEBUG

TRACE

ALL

) won't be written to the standard output (i.e. the IDE's console), but will be written to the log file.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

September 8, 201510 yr

Author

Why is that? Can I change it?

Who are you? Why have you brought me here? And why are there so many PewDiePie fanboys surrounding meeeeeeeee....... *falls into pit and dies*.

Also this. Check it out.

width=700 height=200 http://i.imgur.com/J4rrGt6.png[/img]

Quote

September 9, 201510 yr

Why is that? Can I change it?

It's controlled by the log4j2.xml file inside the Forge JAR. You can probably change it by removing

level="INFO"

from line 54.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

September 9, 201510 yr

Author

It's not letting me edit the file in eclipse.

Who are you? Why have you brought me here? And why are there so many PewDiePie fanboys surrounding meeeeeeeee....... *falls into pit and dies*.

Also this. Check it out.

width=700 height=200 http://i.imgur.com/J4rrGt6.png[/img]

Quote

September 14, 201510 yr

Author

OK, thanks.

Who are you? Why have you brought me here? And why are there so many PewDiePie fanboys surrounding meeeeeeeee....... *falls into pit and dies*.

Also this. Check it out.

width=700 height=200 http://i.imgur.com/J4rrGt6.png[/img]

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/33362-solved-18-onblockplacedby-and-onblockplaced-not-working/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · 4 hours ago4 hr
Orbital strike cannon fishing rod mod

@FoxyWoxy do you potentially have an estimated time for fabric 1.21.5 and what will it be posted on (modrinth, etc.)

By JayKing014 · 7 hours ago7 hr
Orbital strike cannon fishing rod mod

By FoxyWoxy · 8 hours ago8 hr
New Forum Design/Update: Issues and Suggestions

I don't know that either - newer worked with Invision Community 😕

The Forum/Guides show a customized toolbar:
https://invisioncommunity.com/4guides/themes-and-customizations/editor-and-emoticons_327/customizing-editor-toolbars-r132/
But I have no idea if this applies to v5

Regarding the Forum, "Mark all as read" seems to be hidden as default but is available if I click on my profile:
https://invisioncommunity.com/forums/topic/481218-fix-for-unreadmark-read/

I saw that it works here and also fixes the one unread thread mentioned in my first post - so I had just overlooked it

The toolbar changes are just QoL - if there is no way to change it at the moment, that's fine

By TileEntity · 10 hours ago10 hr
New Forum Design/Update: Issues and Suggestions

I understand what you're asking for, but I don't know how to do that. The settings have moved around a bit in the admin panel and I can no longer see a way of customising the editor. If you know how to customise the editor in Invision Community 5, let me know and I'll try applying it.

By Paint_Ninja · 11 hours ago11 hr

There are no registered users currently online

Sign In

[Solved] [1.8] onBlockPlacedBy and onBlockPlaced Not Working

Featured Replies

Join the conversation

Posts

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

New Forum Design/Update: Issues and Suggestions

New Forum Design/Update: Issues and Suggestions

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)