Spawning my entity causes gamecrash[STILL UNSOLVED]

ItsAMysteriousYT · September 8, 2015

Yes what i did now is i made a KeyHandler class in which i get the closest VehicleEntity to the player from the entity list. And in there i have this method. I registered this class to the EVENT_BUS, but the event isn't called.

    @SubscribeEvent
    public void onKeyInput(KeyInputEvent event) {
    	if(Keybindings.EnterVehicleKey.isPressed()){
    		System.out.println("Pressed Enter");
    		if(getClosestEntity()!=null){
    			RealLifeMod.network.sendToServer(new MountVehicleMessage(getClosestEntity().getEntityId()));
    		}
    		
    	}
    }

I do this cuz otherwise i would have to edit the entityplayerclass or not?

ItsAMysteriousYT · September 8, 2015

Or can i just do it in the entities update method? OH - damn, im thinking to complicated. I can just do it in the onUpdate method. It does not matter if the returning VehicleENtity is the same class as the one the method was called from

ItsAMysteriousYT · September 8, 2015

Thanks for your help diesieben07, you really know how to code mods So now, i tried saving these entities through worldSave, but somehow it does not work the way i want it to. In the textfile in which i define the entitie's name and values i also set an ID for it(internal, not the entity.setEntityID()-stuff), which i then save to the NBT-Data. But somehow when the entity is being loaded, it is not able to read the specific data from the global list of vehiclefiles. Am i using the right methods?

EDIT:

The keybinding still wont run somehow The method in the packethandler that gets the vehicle from the ID send by the packet returns null

ItsAMysteriousYT · September 8, 2015

First, no you should no do it in the vehicle update method. In there you have no idea again which vehicle to choose.

Then about your NBT data, I have no idea. show your code.

I chose the vehicle based on the players position (in my forloop i look which getDistanceSquaredToEntity is the smallest and then return this entity).

The problem is, that the entity that is being sent in the packet is null if i get it from the id that was send.

And here is the NBT stuff:

@Override

public void readEntityFromNBT(NBTTagCompound tagCompund) {

NBTTagCompound vehicletag = tagCompund.getCompoundTag("VehicleTag");

this.fuellevel = vehicletag.getDouble("Fuel");

if (file == null)

if (Vehicles.getFromId(vehicletag.getInteger("FileID")) != null) {

this.file = Vehicles.getFromId(vehicletag.getInteger("FileID"));

}

@Override

public void writeEntityToNBT(NBTTagCompound tagCompund) {

NBTTagCompound tag = new NBTTagCompound();

tag.setDouble("Fuel", this.fuellevel);

tagCompund.setInteger("FileID", file.getID());

tagCompund.setTag("VehicleTag", tag);

}

ItsAMysteriousYT · September 8, 2015

The method does not return null, so the problem must be in the PacketHandler if the packet is okay:

package itsamysterious.mods.reallifemod.core.packets;

import java.util.UUID;

import itsamysterious.mods.reallifemod.RealLifeMod;
import itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps;
import itsamysterious.mods.reallifemod.core.vehicles.EntityVehicle;
import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.util.IThreadListener;
import net.minecraft.world.World;
import net.minecraft.world.WorldServer;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class MountHandler implements IMessageHandler<MountVehicleMessage, MountVehicleMessage>{

	@Override
	public MountVehicleMessage onMessage(final MountVehicleMessage message, final MessageContext ctx) {
		final EntityPlayer player = ctx.getServerHandler().playerEntity;
        IThreadListener mainThread = (WorldServer) ctx.getServerHandler().playerEntity.worldObj; // or Minecraft.getMinecraft() on the client
        mainThread.addScheduledTask(
        		new Runnable() {
            @Override
            public void run() {
    			World world = ctx.getServerHandler().playerEntity.worldObj;
    			
    			EntityVehicle v=(EntityVehicle)world.getEntityByID(message.vehicleId);
    			if(v!=null){
    				ctx.getServerHandler().playerEntity.mountEntity(v);
    			}else
    				System.out.println("Still null!");

            }
        });
		return null;
	}

}

ItsAMysteriousYT · September 8, 2015

Does anybody know why the Entity is null? The id from the packet is being sent correctly but somehow in the packethandler it does not get the correct entity.

This is my code:

package itsamysterious.mods.reallifemod.core.packets;

import java.util.UUID;

import itsamysterious.mods.reallifemod.RealLifeMod;
import itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps;
import itsamysterious.mods.reallifemod.core.vehicles.EntityVehicle;
import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.util.IThreadListener;
import net.minecraft.world.World;
import net.minecraft.world.WorldServer;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class MountHandler implements IMessageHandler<MountVehicleMessage, MountVehicleMessage>{

	@Override
	public MountVehicleMessage onMessage(final MountVehicleMessage message, final MessageContext ctx) {
		final EntityPlayer player = ctx.getServerHandler().playerEntity;
		final World world = ctx.getServerHandler().playerEntity.worldObj;
		final EntityVehicle v=(EntityVehicle)world.getEntityByID(message.vehicleId);

        IThreadListener mainThread = (WorldServer) ctx.getServerHandler().playerEntity.worldObj; // or Minecraft.getMinecraft() on the client
        mainThread.addScheduledTask(
        		new Runnable() {
            @Override
            public void run() {
    			System.out.println(message.vehicleId);
    			if(v!=null){
    				player.mountEntity(v);
    			}else
    				System.out.println("Still null!");

            }
        });
		return null;
	}

}

ItsAMysteriousYT · September 8, 2015

Like this?

public class MountHandler implements IMessageHandler<MountVehicleMessage, MountVehicleMessage>{

	@Override
	public MountVehicleMessage onMessage(final MountVehicleMessage message, final MessageContext ctx) {
        IThreadListener mainThread = (WorldServer) ctx.getServerHandler().playerEntity.worldObj; // or Minecraft.getMinecraft() on the client
        mainThread.addScheduledTask(
        		new Runnable() {
            @Override
            public void run() {
            	EntityPlayer player = ctx.getServerHandler().playerEntity;
    			World world = ctx.getServerHandler().playerEntity.worldObj;
    			Entity v=ctx.getServerHandler().playerEntity.worldObj.getEntityByID(message.vehicleId);
    			System.out.println(message.vehicleId);
    			if(v!=null){
    				player.mountEntity(v);
    			}else
    				System.out.println("Still null!");

            }
        });
		return null;
	}

}

This doesn't work either

ItsAMysteriousYT · September 8, 2015

Yes. If that does not work, you are not sending the right ID or your Entity is not correctly spawned, but that would take some serious fuckups.

Okay, i think the spawning thing is the issue. Might it be possible, that it does not spawn correctly, cuz i generate the item in the clientproxy?

ItsAMysteriousYT · September 8, 2015

Yes... of course ... -.-

Game elements like Items need to be created on both sides.

Okay, corrected that, but still it does not work. Entityregistration also has to be on both sides. Does that mean i just have to write the code in the commonproxy or as an example in the Main class?

ItsAMysteriousYT · September 8, 2015

It has to be all on both sides, it shouldn't be in your proxies at all. A CommonProxy is a stupid concept.

Okay then ill put it in an other class.

ItsAMysteriousYT · September 8, 2015

Okay, so i put the register methods into another class and call them from the MainClass. But it still does return null in the packethandler.

ItsAMysteriousYT · September 8, 2015

When i register something in preInit, is that correct? (Sorry if i ask so basic questions)

ItsAMysteriousYT · September 8, 2015

I still think the id is correct, but it is not known on the server because the entity does not spawn correctly which would explain the fact, that i can't rightclick on it. Doesn't it?

ItsAMysteriousYT · September 8, 2015

WTF? Something with the initmethod of my entitiy :

[19:35:47] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

[19:35:47] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

[19:35:47] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

[19:35:47] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at java.lang.reflect.Method.invoke(Unknown Source)

[19:35:47] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)

[19:35:47] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

[19:35:47] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

[19:35:47] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

[19:35:47] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

[19:35:47] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at java.lang.reflect.Method.invoke(Unknown Source)

[19:35:47] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at net.minecraftforge.gradle.GradleStartCommon.launch(Unknown Source)

[19:35:47] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at GradleStart.main(Unknown Source)

[19:35:47] [Client thread/INFO]: SoundSystem shutting down...

[19:35:47] [Client thread/WARN]: Author: Paul Lamb, www.paulscode.com

[19:35:47] [sound Library Loader/INFO]: Starting up SoundSystem...

[19:35:47] [Thread-11/INFO]: Initializing LWJGL OpenAL

[19:35:47] [Thread-11/INFO]: (The LWJGL binding of OpenAL. For more information, see http://www.lwjgl.org)

[19:35:47] [Thread-11/INFO]: OpenAL initialized.

[19:35:47] [sound Library Loader/INFO]: Sound engine started

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: java.io.FileNotFoundException: .\screenshots\sounds.json (Das System kann die angegebene Datei nicht finden)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at java.io.FileInputStream.open0(Native Method)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at java.io.FileInputStream.open(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at java.io.FileInputStream.<init>(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at itsamysterious.mods.reallifemod.Screenshotspack.getResourceStream(Screenshotspack.java:50)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at itsamysterious.mods.reallifemod.Screenshotspack.resourceExists(Screenshotspack.java:43)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at net.minecraft.client.resources.FallbackResourceManager.getAllResources(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at net.minecraft.client.resources.SimpleReloadableResourceManager.getAllResources(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at net.minecraft.client.audio.SoundHandler.onResourceManagerReload(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at net.minecraft.client.resources.SimpleReloadableResourceManager.notifyReloadListeners(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at net.minecraft.client.resources.SimpleReloadableResourceManager.reloadResources(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at net.minecraft.client.Minecraft.refreshResources(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at itsamysterious.mods.reallifemod.RealLifeMod.loadCoreModules(RealLifeMod.java:204)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at itsamysterious.mods.reallifemod.RealLifeMod.Init(RealLifeMod.java:169)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at java.lang.reflect.Method.invoke(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at net.minecraftforge.fml.common.FMLModContainer.handleModStateEvent(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at java.lang.reflect.Method.invoke(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at com.google.common.eventbus.EventBus.post(EventBus.java:275)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(Unknown Source)

[19:35:51] [Client thread/INFO] [sTDERR]: [java.lang.Throwable$WrappedPrintStream:println:-1]: at net.minecraftforge.fml.common.LoadController.propogateStateMessage(Unknown Source)