Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • HashMapping issue has me stumped
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 0
Draco18s

HashMapping issue has me stumped

By Draco18s, September 20, 2015 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

Draco18s    2417

Draco18s

Draco18s    2417

  • Reality Controller
  • Draco18s
  • Members
  • 2417
  • 16012 posts
Posted September 20, 2015

So I'm having an issue with a wrapper class I wrote, so I can map a block+metadata to another piece of information data.  It works find in Eclipse, no problems, none.

 

Yet I've got reports from players (of a specific modpack, none the less, I haven't had reports from anyone else) of some console spam that only shows up if there is no match between the block and the info in the hashmap.  The console spam is just debug logging info trying to resolve the underlying problem.

 

Here's a section of that logging info, note the 4th listed item:

 

[15:43:27][com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:201]: Hard Ore block, tile.ore_diamond has no flower data.  This is a bug!
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:203]: Listing all mapped blocks:
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.ore_iron:-1 false
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.ore_gold:-1 false
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.beyondrealitycore:oreCopper:0 false
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.ore_diamond:-1 true
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.beyondrealitycore:oreTin:0 false
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.ore_redstone:0 false
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.ore_redstone:1 false

 

Here's the code that generates the logging:

		BlockWrapper bw = new BlockWrapper(this,-1);
	OreData dat = HardLibAPI.recipeManager.getOreList().get(bw);
	if(dat != null) {
		//do stuff
	}
	else {
		System.out.println("Hard Ore block, " + this.getUnlocalizedName() + " has no flower data.  This is a bug!");
		System.out.println("Listing all mapped blocks:");
		Map<BlockWrapper,OreFlowerData> map = HardLibAPI.recipeManager.getOreList();
		for(BlockWrapper b : map.keySet()) {
			System.out.println("    " + b.block.getUnlocalizedName() + ":" + b.meta + " " + bw.equals(b));
		}
	}

 

Here's the wrapper class:

public class BlockWrapper {
public Block block;
public int meta;
private int fHashCode;

/**
 * the block and metadata to match, -1 matches all
 **/
public BlockWrapper(Block block, int meta) {
	this.block = block;
	this.meta = meta;
}

@Override
public int hashCode() {
	if (fHashCode == 0) {
	      int result = HashUtils.SEED;
	      result = HashUtils.hash(result, Block.getIdFromBlock(block));
	      fHashCode = result;
	}
	return fHashCode;
    }

@Override
public boolean equals(Object aThat) {
	if(aThat instanceof BlockWrapper) {
		BlockWrapper other = (BlockWrapper)aThat;
		return other.block == this.block && (other.meta == -1 || this.meta == -1 || other.meta == this.meta);
	}
	return false;
}
}

 

I don't get what could possibly be going wrong to cause map.get(key) to be returning null here.

  • Quote

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Share this post


Link to post
Share on other sites

diesieben07    7706

diesieben07

diesieben07    7706

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7706
  • 56508 posts
Posted September 20, 2015

Block IDs are not consistent, hence your hash code will not be consistent. That is a BAD idea.

  • Quote

Share this post


Link to post
Share on other sites

Draco18s    2417

Draco18s

Draco18s    2417

  • Reality Controller
  • Draco18s
  • Members
  • 2417
  • 16012 posts
Posted September 20, 2015

Block IDs are not consistent, hence your hash code will not be consistent. That is a BAD idea.

 

Even when the mods don't change? I thought it was at least stable under those conditions. And the hash is built during startup, IDs shouldn't change while the program is running and nothing about this data structure persists between runs (or even be relevant), it shouldn't even matter that the IDs changed due to a new mod install.

  • Quote

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Share this post


Link to post
Share on other sites

Ernio    600

Ernio

Ernio    600

  • Reality Controller
  • Ernio
  • Forge Modder
  • 600
  • 2638 posts
Posted September 20, 2015

IDs are not generated on startup, but per-world.

 

Whenever new world is generated - (or there are missing entries) dictionary is being created in world's data.

Dictionary binds names with newly generated IDs.

 

In world1 245 can be Copper_Ore

In world2 245 can be Tungsten_Rod

  • Quote

1.7.10 is no longer supported by forge, you are on your own.

Share this post


Link to post
Share on other sites

Draco18s    2417

Draco18s

Draco18s    2417

  • Reality Controller
  • Draco18s
  • Members
  • 2417
  • 16012 posts
Posted September 20, 2015

Ahh, that's what I didn't know.

  • Quote

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 0
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • ChocoCookies33
      Description: Exception in server tick loop

      By ChocoCookies33 · Posted 9 minutes ago

      local server set up not working, help is appreciated.  crash-2021-03-07_00.55.37-server.txt
    • LessyDoggy
      Forge 1.12.2 Installing Bug

      By LessyDoggy · Posted 1 hour ago

      So I used forge 1.16.5 but now I cant change it too 1.12.2 no mather what. I have tried Installing client, Installing server and extract but nothing works. I even removed forge 1.16.5 from my computer but I still have that verison on and idk how to change it.
    • Yourskillx2
      !!Keeps crashing during launch!!

      By Yourskillx2 · Posted 1 hour ago

      I have a decent sized mod pack with around 90 mods and every time I go to launch the game, it loads some stuff then crashes with exit code 0, I cannot figure out if its a mod in the pack doing it, like maybe not a release version or if it just doesn't work with Mc like its supposed to.
    • IMaironI
      server error

      By IMaironI · Posted 8 hours ago

      2021-03-06-8.log
    • diesieben07
      server error

      By diesieben07 · Posted 8 hours ago

      Like I already said: The logs folder.
  • Topics

    • ChocoCookies33
      0
      Description: Exception in server tick loop

      By ChocoCookies33
      Started 9 minutes ago

    • LessyDoggy
      0
      Forge 1.12.2 Installing Bug

      By LessyDoggy
      Started 1 hour ago

    • Yourskillx2
      0
      !!Keeps crashing during launch!!

      By Yourskillx2
      Started 1 hour ago

    • IMaironI
      13
      server error

      By IMaironI
      Started 12 hours ago

    • prototype204
      0
      Attacking/Hitting issue

      By prototype204
      Started 8 hours ago

  • Who's Online (See full list)

    • Nyko
    • Kreepydude
    • Helios885
    • ChocoCookies33
    • vemerion
    • zlappedx3
    • VecsonON
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • HashMapping issue has me stumped
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community