[1.8] Help me simplify this method?

[AnZaNaMa]

I feel like there is a way to simplify this method, but I can't figure out how. Any help is appreciated.

 

public PowerConnectable[] getConnectedMachines(){
        PowerConnectable[] machines = new PowerConnectable[]{null};
        if(worldObj.getTileEntity(pos.east()) != null && worldObj.getTileEntity(pos.east()) instanceof PowerConnectable){
            machines[0] = (PowerConnectable)worldObj.getTileEntity(pos.east());
        }
        if(worldObj.getTileEntity(pos.west()) != null && worldObj.getTileEntity(pos.west()) instanceof PowerConnectable){
            machines[machines.length] = (PowerConnectable)worldObj.getTileEntity(pos.west());
        }
        if(worldObj.getTileEntity(pos.north()) != null && worldObj.getTileEntity(pos.north()) instanceof PowerConnectable){
            machines[machines.length] = (PowerConnectable)worldObj.getTileEntity(pos.north());
        }
        if(worldObj.getTileEntity(pos.south()) != null && worldObj.getTileEntity(pos.south()) instanceof PowerConnectable){
            machines[machines.length] = (PowerConnectable)worldObj.getTileEntity(pos.south());
        }
        if(worldObj.getTileEntity(pos.up()) != null && worldObj.getTileEntity(pos.up()) instanceof PowerConnectable){
            machines[machines.length] = (PowerConnectable)worldObj.getTileEntity(pos.up());
        }
        if(worldObj.getTileEntity(pos.down()) != null && worldObj.getTileEntity(pos.down()) instanceof PowerConnectable){
            machines[machines.length] = (PowerConnectable)worldObj.getTileEntity(pos.down());
        }
        return machines;
    }

[RANKSHANK]

Make an array of the blockpos and iterate through it

[AnZaNaMa]

good idea! thanks! I was trying to figure out how I could make it into a for loop, but with needing east, west, north, south, up, down, I couldn't figure it out.

[RANKSHANK]

Well BlockPos.offset(EnumFacing e) can be used

 

Parse through EnumFacing.values() to create the array and then parse through the positions, this way you're not instantiating up to 3 new BlockPos per step

[Draco18s]

Also store the TE in a variable:

 

TileEntity te = world.getTileEntity (pos.Noth ());
If (te != null && te instanceof PowerConnectable) { }

[RANKSHANK]

Also why are you using an array when you clearly want a list?

 

PowerConnectable[] machines = new PowerConnectable[]{null};

machines[machines.length] = (PowerConnectable)worldObj.getTileEntity(pos.west());

You're going to crash since the max index of that array is 0 and then length is always going to be 1

[jeffryfisher]

  Quote

BlockPos.offset(EnumFacing e) can be used

That's what I'd do. I also recommend walking through the entire EnumFacing class from top to bottom to learn what's available for use. Don't reinvent any wheels.

 

And I agree that a list would be better than an array.

[RANKSHANK]

So most space & process efficient is:

List<MyTileEntity> found = Lists.<MyTileEntity>newArrayList();
TileEntity t;
for(Enumfacing e : EnumFacing.values())
    if((t = World.getTileEntity(BlockPos.offset(e , 1))) instanceof MyTileEntity)
        found.add((MyTileEntity)t);

 

If you don't need to hold onto the list you may as well remove it and directly invoke whatever methods you need where the add is.