Jump to content

Recommended Posts

Posted

So, after creating my working json in the config directory, I would like to send an update to the client (if joining a server) with the server's information from the json, rather than the clients (so basically, tell the client that the server json must be used for this information). I am not quite sure how to go about this, and if anyone could point be in the correct direction, I would be very grateful. :)

I am not a cat. I know my profile picture is sexy and amazing beyond anything you could imagine but my cat like features only persist in my fierce eyes. I might be a cat.

Posted

You'll need to send a packet to the client containing the server's settings. Forge's Read the Docs site has a section on networking here, you'll want to use the Simple Network Implementation.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

I should explain a bit more: I need to know how exactly I would gather that information to send. What event would I use? Can I simply check if the world is not remote and that will get the server json? Just so you know, as I should of mentioned in my post; I understand networking, and use Simple Network Implementation. :P

I am not a cat. I know my profile picture is sexy and amazing beyond anything you could imagine but my cat like features only persist in my fierce eyes. I might be a cat.

Posted

Subscribe to

FMLNetworkEvent.ServerConnectionFromClientEvent

to be notified on the server when a client connects. All subclasses of

FMLNetworkEvent

are fired on a Netty thread, so you need to schedule a task on the main thread using the appropriate

IThreadListener

like you do for message handlers*.

 

This will give you an

INetHandlerPlayServer

from the

FMLNetworkEvent#handler

field which you can cast to

NetHandlerPlayServer

to get the player from the

NetHandlerPlayServer#playerEntity

field. You can then send whatever data you need to this player.

 

You'll probably want to subscribe to

FMLServerStartingEvent

(this is a state event handled by an

@Mod.EventHandler

method in your

@Mod

class) and repopulate the data from the JSON if it's an integrated server. This is because the client and integrated server are two threads running in the same JVM, they share an instance of your

@Mod

class and anything created in it. For this same reason, it's probably not necessary to handle

FMLNetworkEvent.ServerConnectionFromClientEvent

in the integrated server.

 

* I'm not entirely sure whether or not it's safe to use a

SimpleNetworkWrapper

from a Netty thread.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

So, I would be creating an IThreadListener in the event? And, do I have to create the json on the server, or by creating in the config, will it already do it?

I am not a cat. I know my profile picture is sexy and amazing beyond anything you could imagine but my cat like features only persist in my fierce eyes. I might be a cat.

Posted

Bruh... Before stating a question, just think about it for a while.

 

You need your client to have access to server-set configuration. Configuration is NOTHING more than data - good as ANY. It could be whole damn book or a goddamn dinosaur model - you don't care - it's all data. How do you synchronize data? You send it. How? Packets.

 

Now the question is - do you want to send .json file and load it on client (same way server does it) or maybe you want to send data itself (alredy parsed by server).

 

In any case - you just need to pack it all to packet and send it. In 1.8+ (or even earlier) packets server->client doen't even care about size (auto-splitted) - so that's a big plus, but back on track:

I do belive you want to send that Map of item weights. Simple (clear) way would be to pack a Map into NBT and send it. Then read it on client and put it is the place that data normally would be. So yeah - just make a packet that sends NBTTagCompound to some player, and on receiver  client - just read it.

Simple design:

NBTTagCompound is nothing less/more than a MAP.

compound.setInteger( KEY, VALUE ) - can be literally used to literally encode a MAP.

on client you just grab that NBTTagCompound and do compound.keySet() - on which you iterate and recreate a java Map from it.

 

Where are all your problems coming from? :o

 

BTW:

So, I would be creating an IThreadListener in the event? And, do I have to create the json on the server, or by creating in the config, will it already do it?

What?

 

You just send that packet with PlayerJoinedEvent (from server) or as suggested before - with other methods.

 

PS. I belive you have my Skype so you can always call if you need (even) more help.

1.7.10 is no longer supported by forge, you are on your own.

Posted

Sorry about that Ernio, I made this thread last night at about 2 A.M. just to push me in the right direction. :P Anyway, I never thought about creating a map to be read from for the values. This is considering every time I look up the values, I search through the json. I will try what you're saying, but I would like to ask: for client side, would it be more efficient to write the json, then add those values to a map that is read from? Rather than parsing the json every time I need to look an item up? I'm guessing it would be, I'd just like your opinion. :)

 

And, sorry about my question to Choonster. xD Didn't seem to understand his answer too well.

 

And finally, thank you for the offer with Skyping you. I think I have it from here, nothing too big that I'd need more help with as of now.

I am not a cat. I know my profile picture is sexy and amazing beyond anything you could imagine but my cat like features only persist in my fierce eyes. I might be a cat.

Posted

Too much "sorrying" and thanking. (especially the 1st one). :D

 

Anyway - yeah, you should most definitely read json once and put its proper contents (not every user-written stuff is "proper", 1stcheck if entry exists in item/block registry, if not - make some print warning) to actual Java Map. As stated before - map can be easily encoded to NBT (some may say that you should write straight to buffer, but that won't save you lots, still - "cutting middlemen" is often better) and then recreated on client.

 

 

1.7.10 is no longer supported by forge, you are on your own.

Posted

Sorry about that. ;) Anyway, I've remade it to only read everything once. My question is, is the config path different for a server? Or can I just check if the world is not remote, and load everything from the same path?

I am not a cat. I know my profile picture is sexy and amazing beyond anything you could imagine but my cat like features only persist in my fierce eyes. I might be a cat.

Posted

Sorry about that. ;) Anyway, I've remade it to only read everything once. My question is, is the config path different for a server? Or can I just check if the world is not remote, and load everything from the same path?

The config path itself isn't different, but the config file that is sitting on the server cannot be read from the client, as it is usually on a different computer. You have to write every value you want to sync to the packet / byte buffer, then read it back in from that buffer on the other side and set the values in the config instance that already exists.

 

In very very rough pseudo-code:

// YourPacket#write:
buffer.writeInt(map.size());
for (each entry in your map) {
  buffer.writeString(key);
  buffer.writeString(value);
}

// YourPacket#read:
map = new Map();
int n = buffer.readInt(); // this is the number of entries
for (i = 0; i < n; ++i) {
  map.put(buffer.readString(), buffer.readString());
}
YourMod.config.map = map; // overrwrite the previously existing map entirely

That's just one way to do it, of course, but the key point is that both the server and the client have independent copies of the Config file which they read in independently, and you want to overwrite certain values on the client's version with those from the server.

 

Keep in mind that the only reason to sync Config values to the clients is if those values are actually used on the client side, such as for rendering in the GUI. Generally, this is not the case, but it sounds like you'd like to display the weight values, so in that case you should sync those values, but probably not anything else.

Posted

The only reason why I need to, is because I want the server owner to be able to change weight values, if wanted, for any item. :P So, I have it set up where I made a public, static Map in my ModReference class. I use that map to write the values of the json to, and read for the client to display. With that, all I would need to do is create the packet, register it on Server side only, and use that static Map (which should be on both sides I believe) to get the new values over, correct?

I am not a cat. I know my profile picture is sexy and amazing beyond anything you could imagine but my cat like features only persist in my fierce eyes. I might be a cat.

Posted

The config file on the server, which the server owner would modify, is the only one that matters as far as most anything is concerned. Encumbrance should only matter on the server side, and thus the server config is the only thing that is important.

 

You can't (well, shouldn't) use the server values to actually overwrite any config / .json file on the client side; you only use it to overwrite the values in memory. Also, you don't use the map to write the .json file, you use the .json file to create the map (except, perhaps, for the very first time).

 

Basically, the config (.json) file that the client reads in should be completely irrelevant as the whole point is you read the file into memory, and those values will be replaced by the ones sent from the server. The only exception is single player, in which the same file is read by both the integrated server and the client, so sending a packet makes no difference (but also won't hurt anything).

Posted

By the way, sending the json file is perfectly acceptable: it had already been serialized and you've already got the code that deserializes it and stores it in a map. Why the conversion to a separate serialized data type?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.