Jump to content

Recommended Posts

Posted

Hello everyone.

 

I'm pretty new to modding with Forge and forums and I apologize if this is in the wrong place or anything.

 

I'm pulling my hair out trying to figure out how to properly register and render a new entity in 1.8.9.

 

I have no idea what the IRenderFactory is or how to use it and I'm not even really sure rendering is my only problem.

I have the entity class and the model class for the mob and a render class but I'm hitting a wall trying to find examples of how to do it properly with the new update. Everyone is just saying "use the registerEntityRenderingHandler" thing but I really have no idea specifically how to do this. This is my first mod.

 

Could someone out there help me out? Thank you!!

 

I have seen this topic:  [1.8]Error Spawning in Entities, and this one,  [1.8.9] Entity rendering registering recently changed?, but I need more information about how to actually do what they talk about.

 

Also I'm not sure how to link a post. >> Sorry....

 

Please be gentle...

Posted

If you're targeting Java 6/7, just create an anonymous class that implements

IRenderFactory

and overrides

createRenderFor

to return a new instance of the your

Render

class.

 

If you're targeting Java 8, you can use a method reference to pass your

Render

class's constructor (

RenderMyEntity::new

) as an

IRenderFactory

instead.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted
  On 1/29/2016 at 7:15 AM, DragonessAtHeart said:

Could you maybe give an example of how to use it?

 

Well I am pretty lazy with my registry so I literally dump all my classes through a Proxy method:

@Override
public void sidedEntityRegistry(Class<? extends Entity> c){
	try {
		final Class cc = (Class<? extends Render>) c.getClassLoader().loadClass("rankshank/pikmine/client/render/entity/" + c.getName().substring(c.getName().lastIndexOf("Entity")).replace("Entity", "Render"));
		RenderingRegistry.registerEntityRenderingHandler(c, new IRenderFactory<Entity>(){
                            @Override 
                            public Render createRenderFor(RenderManager rm) {
                                try {
                                    return (Render) cc.getConstructor(RenderManager.class).newInstance(rm);
                                } catch(Exception e){
                                      e.printStackTrace();
                                return null;}}});
	    } catch (Exception e) {
		e.printStackTrace();
	    }
}

Works a treat though since I follow a set naming standard. You can just do direct class references if iteration is too 'scary'

  Quote
I think its my java of the variables.

Posted

I am trying to target Java 8, but thank you for mentioning both.

 

"you can use a method reference to pass your Render class's constructor (RenderMyEntity::new) as an IRenderFactory instead."

 

The render class here we are talking about is the new mob's render class?

 

I feel like I want to do something like this,

registerEntityRenderingHandler(EntityNewMob.class, IRenderFactory (RenderNewMob::new));

but that isn't how you do it.

 

Also oh my goodness RANKSHANK there is so much going on there!

 

I'll have to study that code to see if I can't figure out what is going on.

 

Can you tell me where I need to start researching to figure it out or try to explain it a bit more?

 

If you don't feel like it, that's cool. I can probably figure it out eventually. :)

Posted
  On 1/29/2016 at 7:40 AM, DragonessAtHeart said:

Can you tell me where I need to start researching to figure it out or try to explain it a bit more?

 

It's actually not too bad, the error handling just gunks it up a bit

 

Basically I'm working off the principle that all of my renderers are in rankshank/pikmine/client/render/entity/ and follow the naming format Render{EntityName}.class, their corresponding entity classes just need to follow the naming format Entity{EntityName}.class.

 

Using the known package and transforming the Entity prefix to the Render prefix, I then have a string handle for my Render class.

 

Then using that string handle I query the ClassLoader for the class object which I then create and instance of it using the Render(RenderManager) constructor, which is a consistent constructor throughout my render classes.

 

I then use that as the return value of my RenderFactory which registers the renderer.

 

It all runs off the expectation that I'll continue to follow the same format. I may have to switch to using hard coded strings so that I can subpackage my render folder.

  Quote
I think its my java of the variables.

Posted
  On 1/29/2016 at 7:40 AM, DragonessAtHeart said:

I am trying to target Java 8, but thank you for mentioning both.

 

"you can use a method reference to pass your Render class's constructor (RenderMyEntity::new) as an IRenderFactory instead."

 

The render class here we are talking about is the new mob's render class?

 

I feel like I want to do something like this,

registerEntityRenderingHandler(EntityNewMob.class, IRenderFactory (RenderNewMob::new));

but that isn't how you do it.

 

The parentheses weren't part of the code. Just pass the method reference itself as the

IRenderFactory

argument, you don't need to explicitly cast to or specify that it's an

IRenderFactory

.

 

registerEntityRenderingHandler(EntityNewMob.class, RenderNewMob::new);

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

I'm sorry. I didn't mention that I had tried that already unsuccessfully.

 

I am now doing this:

registerEntityRenderingHandler(EntityGiantLizard.class, RenderGiantLizard::new);

 

Which tells me that the registerEntityRenderingHandler method is not defined for my client proxy.

 

I've imported

import net.minecraft.client.Minecraft;

import net.minecraft.client.renderer.entity.RenderManager;

import net.minecraftforge.fml.client.registry.RenderingRegistry;

import net.minecraftforge.fml.common.Mod.Instance;

import net.minecraftforge.fml.common.event.FMLInitializationEvent;

import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;

import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;

import net.minecraftforge.fml.common.registry.EntityRegistry;

import net.minecraftforge.fml.common.registry.EntityRegistry.EntityRegistration;

import net.minecraftforge.fml.common.registry.LanguageRegistry;

import net.minecraftforge.fml.relauncher.Side;

 

import net.minecraftforge.fml.client.registry.IRenderFactory;

import net.minecraftforge.fml.client.registry.ClientRegistry;

import com.dragonessatheart.firstmod.*;

 

So unless I'm forgetting something, I'm not sure what to do.

 

When I try this:

RenderingRegistry.registerEntityRenderingHandler(EntityGiantLizard.class, RenderGiantLizard::new);

 

It says:

The method registerEntityRenderingHandler(Class<? extends Entity>, Render<? extends Entity>) in the type RenderingRegistry is not applicable for the arguments (Class<EntityGiantLizard>, RenderGiantLizard::new)

 

Which I honestly don't know how to decipher.

 

Thank you!

Posted

The version of forge is: forge-1.8.9-11.15.1.1722, at least that's what it says on the changelog txt name.

 

I know it's at least 1.8.9. The recommended one.

 

RenderGiantLizard is here.

 

  Reveal hidden contents

 

 

 

Thank you so much!

Posted

For a method reference to be used as an interface, the method must have the same signature as the interface's method.

 

IRenderFactory#createRenderFor

takes a single

RenderManager

argument and returns a

Render

, your method must do the same. Constructors implicitly return an instance of their class, so you just need to match the arguments.

 

You don't need to create your own

renderManager

field,

Render#renderManager

already exists with protected access.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

  Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

  Your link has been automatically embedded.   Display as a link instead

  Your previous content has been restored.   Clear editor

  You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • https://mclo.gs/9y5ciD2 anyone ever had this issue?  Internal exception illegal argument exception: unable to fit 3194354 into 3
    • Hi! I'm trying to add my custom models/textures renderer like this: public class PonyPlayerWrapperRenderer extends EntityRenderer<Player> { // wrapper class under my LivingEntityRenderer class implementation private final PonyPlayerRenderer innerRenderer; private final PonyPlayerRenderer innerSlimRenderer; public PonyPlayerWrapperRenderer(final EntityRendererProvider.Context context) { super(context); System.out.println("creating new PonyPlayerWrapperRenderer"); this.innerRenderer = new PonyPlayerRenderer(context, false); this.innerSlimRenderer = new PonyPlayerRenderer(context, true); } @Override public void render(final Player entity, final float yaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource bufferSource, final int packedLight) { System.out.println("PonyPlayerWrapperRenderer render: " + entity.toString()); if (entity instanceof AbstractClientPlayer clientPlayer) { if (clientPlayer.getModelName().contains("slim")) { innerSlimRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } else { innerRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } } } @Override public ResourceLocation getTextureLocation(final Player player) { System.out.println("PonyPlayerWrapperRenderer getTextureLocation"); if (player instanceof AbstractClientPlayer clientPlayer) { return clientPlayer.getSkinTextureLocation(); } System.out.println("player instanceof AbstractClientPlayer is false"); return getDefaultSkin(player.getUUID()); } } public class PonyPlayerRenderer extends LivingEntityRenderer<AbstractClientPlayer, PlayerModel<AbstractClientPlayer>> { private final PlayerModel<AbstractClientPlayer> earthModel; private final PlayerModel<AbstractClientPlayer> pegasusModel; private final PlayerModel<AbstractClientPlayer> unicornModel; public PonyPlayerRenderer(final EntityRendererProvider.Context context, final boolean slim) { super( context, slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)), 0.5f ); System.out.println("creating new PonyPlayerRenderer"); this.earthModel = slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); this.pegasusModel = new PegasusModel(context.bakeLayer(PegasusModel.LAYER_LOCATION)); this.unicornModel = new UnicornModel(context.bakeLayer(UnicornModel.LAYER_LOCATION)); } @Override public void render(final AbstractClientPlayer player, final float entityYaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource buffer, final int packedLight) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); this.model = switch (race) { case PEGASUS -> pegasusModel; case UNICORN -> unicornModel; case EARTH -> earthModel; }; super.render(player, entityYaw, partialTicks, poseStack, buffer, packedLight); } @Override public ResourceLocation getTextureLocation(final AbstractClientPlayer player) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); return switch (race) { case EARTH -> fromNamespaceAndPath(MODID, "textures/entity/earth_pony.png"); case PEGASUS -> fromNamespaceAndPath(MODID, "textures/entity/pegasus.png"); case UNICORN -> fromNamespaceAndPath(MODID, "textures/entity/unicorn.png"); }; } } @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { // mod bus render registration config @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onRegisterRenderers(final EntityRenderersEvent.RegisterRenderers event) { event.registerEntityRenderer(EntityType.PLAYER, PonyPlayerWrapperRenderer::new); System.out.println("onRegisterRenderers end"); } } Method onRegisterRenderers() is called and I can see it being logged. But when I enter the world, my PonyWrapperRenderer render() method doesn't ever seem to be called. I also tried to put my renderer to EntityRenderDispatcher's playerRenderers via reflection: @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onClientSetup(final FMLClientSetupEvent event) { event.enqueueWork(() -> { try { final EntityRenderDispatcher dispatcher = Minecraft.getInstance().getEntityRenderDispatcher(); final Field renderersField = getEntityRenderDispatcherField("playerRenderers"); final Field itemInHandRenderer = getEntityRenderDispatcherField("itemInHandRenderer"); @SuppressWarnings("unchecked") final Map<String, EntityRenderer<? extends Player>> playerRenderers = (Map<String, EntityRenderer<? extends Player>>)renderersField.get(dispatcher); final PonyPlayerWrapperRenderer renderer = new PonyPlayerWrapperRenderer( new EntityRendererProvider.Context( dispatcher, Minecraft.getInstance().getItemRenderer(), Minecraft.getInstance().getBlockRenderer(), (ItemInHandRenderer)itemInHandRenderer.get(dispatcher), Minecraft.getInstance().getResourceManager(), Minecraft.getInstance().getEntityModels(), Minecraft.getInstance().font ) ); playerRenderers.put("default", renderer); playerRenderers.put("slim", renderer); System.out.println("Player renderers replaced"); } catch (final Exception e) { throw new RuntimeException("Failed to replace player renderers", e); } }); } private static Field getEntityRenderDispatcherField(final String fieldName) throws NoSuchFieldException { final Field field = EntityRenderDispatcher.class.getDeclaredField(fieldName); field.setAccessible(true); return field; } } But I receive the error before Minecraft Client appears (RuntimeException: Failed to replace player renderers - from ClientRenderers onClientSetup() method - and its cause below): java.lang.IllegalArgumentException: No model for layer anotherlittlepony:earth_pony#main at net.minecraft.client.model.geom.EntityModelSet.bakeLayer(EntityModelSet.java:18) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.entity.EntityRendererProvider$Context.bakeLayer(EntityRendererProvider.java:69) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerRenderer.<init>(PonyPlayerRenderer.java:32) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerWrapperRenderer.<init>(PonyPlayerWrapperRenderer.java:24) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.ClientRenderers.lambda$onClientSetup$0(ClientRenderers.java:79) ~[main/:?] {re:classloading} ... 33 more Problem appears when EntityRendererProvider context tries to bakeLayer with my model layer location: new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); // PonyPlayerRenderer.java:32 public class PonyModel extends PlayerModel<AbstractClientPlayer> { // the model class itself public static final ModelLayerLocation LAYER_LOCATION = new ModelLayerLocation( ResourceLocation.fromNamespaceAndPath(MODID, "earth_pony"), "main" ); public PonyModel(final ModelPart root) { super(root, false); } public static LayerDefinition createBodyLayer() { // some CubeListBuilder stuff for model appearance } } Textures PNGs are placed at: resources/assets/[my mod id]/textures/entity. My forge version is 1.20.1. Would appreciate any help.
    • Well, a bit more information about what you're trying to do would be helpful. e.g. why you're trying to use "INVOKE_ASSIGN" instead of "INVOKE". "INVOKE_ASSIGN" calls your code after the "target" is called and its value is stored, if applicable. "INVOKE" calls your code before the target is called. "target" expects a fully qualified name, as per the SpongePowered docs, if that name is going to be remapped (which it will be if your injecting into Minecraft itself and not another mod). For more information on fully qualified names versus canonical names, see the Java specifications. Here's an example of a working "@At" from my own code that targets the "getClosestsVulnerablePlayerToEntity" call inside a mob's logic: @At(value = "INVOKE_ASSIGN", target = "net.minecraft.world.World.getClosestVulnerablePlayerToEntity(Lnet/minecraft/entity/Entity;D)Lnet/minecraft/entity/player/EntityPlayer;") Hope this helps!
    • Ran it one more time just to check, and there's no errors this time on the log??? Log : https://mclo.gs/LnuaAiu I tried allocating more memory to the modpack, around 8000MB and it's still the same; stopping at "LOAD_REGISTRIES". Are some of the mods clashing, maybe? I have no clue what to do LOL
    • Tried removing some biome generation mods and test ran it again, but it's still the same; still not responding as soon as it gets to "LOAD_REGISTRIES". This time with more errors though. Log : https://mclo.gs/uygZzD8 Is there too little memory allocated to the modpack maybe? Can someone help please.    (T.T)馃挃
  • Topics

  • Create New...

Important Information

By using this site, you agree to our Terms of Use.