[1.8.9] Performance drop with isOpaqueCube

[heero]

Hi,

 

The Minecraft Block isOpaqueCube function return the constant True.

I created a Block subclass with an opaque cube parameter to be able to easily change that value. The default value is still True.

 

I created a new Dirt Block with my new class. When I fill the world (50 first layers) with is, and I try to put Water, there is a performances Drop (60 -> 30).

If my new Dirt Block extend the Minecraft Block, there is no drop.

 

I'm not able to explain it, any idea ?

[diesieben07]

Please show your code.

[heero]

@Mod(modid = MyMod.MODID, version = MyMod.VERSION)
public class MyMod {
    public static final String MODID = "mymod";
    public static final String VERSION = "1.0";

    @EventHandler
    public void preInit(FMLPreInitializationEvent event) {
        GameRegistry.registerBlock(new BlockGeneric(Material.ground).setUnlocalizedName("dirt"), "dirt");
    }

    public class BlockGeneric extends Block {
        private boolean opaque = true;

        public BlockGeneric(Material material) {
            super(material);
        }

        @Override
        public boolean isOpaqueCube() {
            return opaque;
        }
    }
}

 

It's probably some kind of java optimisation, but I don't know how

[diesieben07]

That... should not cause a performance drop.

[Draco18s]

That return value won't do what you think it might.  It won't let you toggle blocks back and forth between opaque and not opaque.  It will toggle all blocks of that type.

[heero]

That return value won't do what you think it might.  It won't let you toggle blocks back and forth between opaque and not opaque.  It will toggle all blocks of that type.

 

That's what I want ? All my Dirt must be Opaque (or not).

It's just an helper so I don't have to create a new Class for un-opaque Block.

I did that with many Block property in my BlockGeneric.

 

So the solution is pretty obvious (ie. create that Class), but I juste want to understand Why