Jump to content

Recommended Posts

Posted

Hi, I got a problem with my custom leaves that when you look at them with a block below it, you can see right through the block underneath it. Also I can't get the "fast", "fanzy" option for the texture to work. Please help me.

 

Here is my LeafBlock Code:

package XetosMod.common;

import java.util.ArrayList;
import java.util.Random;

import cpw.mods.fml.common.Side;
import cpw.mods.fml.common.asm.SideOnly;
import net.minecraft.src.Block;
import net.minecraft.src.BlockLeavesBase;
import net.minecraft.src.ColorizerFoliage;
import net.minecraft.src.CreativeTabs;
import net.minecraft.src.EntityPlayer;
import net.minecraft.src.IBlockAccess;
import net.minecraft.src.Item;
import net.minecraft.src.ItemStack;
import net.minecraft.src.Material;
import net.minecraft.src.World;
import net.minecraftforge.common.IShearable;

public class XetosLeaves extends BlockLeavesBase implements IShearable {

    private int baseIndexInPNG;
    int[] adjacentTreeBlocks;

protected XetosLeaves(int par1, int par2) {
	super(par1, par2, Material.leaves, false);
	this.baseIndexInPNG = par2;
        this.setTickRandomly(true);
        this.setCreativeTab(CreativeTabs.tabDecorations);
        this.setStepSound(soundGrassFootstep);
}

    @SideOnly(Side.CLIENT)
    public int getBlockColor() {
        double var1 = 0.5D;
        double var3 = 1.0D;
        return ColorizerFoliage.getFoliageColor(var1, var3);
    }
    
    @SideOnly(Side.CLIENT)

    /**
     * Returns the color this block should be rendered. Used by leaves.
     */
    public int getRenderColor(int par1) {
        return ColorizerFoliage.getFoliageColorBasic();
    }
    
    public int colorMultiplier(IBlockAccess par1IBlockAccess, int par2, int par3, int par4)
    {
        int var5 = par1IBlockAccess.getBlockMetadata(par2, par3, par4);

        if ((var5 & 3) == 1)
        {
            return ColorizerFoliage.getFoliageColorPine();
        }
        else if ((var5 & 3) == 2)
        {
            return ColorizerFoliage.getFoliageColorBirch();
        }
        else
        {
            int var6 = 0;
            int var7 = 0;
            int var8 = 0;

            for (int var9 = -1; var9 <= 1; ++var9)
            {
                for (int var10 = -1; var10 <= 1; ++var10)
                {
                    int var11 = par1IBlockAccess.getBiomeGenForCoords(par2 + var10, par4 + var9).getBiomeFoliageColor();
                    var6 += (var11 & 16711680) >> 16;
                    var7 += (var11 & 65280) >> 8;
                    var8 += var11 & 255;
                }
            }

            return (var6 / 9 & 255) << 16 | (var7 / 9 & 255) << 8 | var8 / 9 & 255;
        }
    }
    
    public void breakBlock(World par1World, int par2, int par3, int par4, int par5, int par6)
    {
        byte var7 = 1;
        int var8 = var7 + 1;

        if (par1World.checkChunksExist(par2 - var8, par3 - var8, par4 - var8, par2 + var8, par3 + var8, par4 + var8))
        {
            for (int var9 = -var7; var9 <= var7; ++var9)
            {
                for (int var10 = -var7; var10 <= var7; ++var10)
                {
                    for (int var11 = -var7; var11 <= var7; ++var11)
                    {
                        int var12 = par1World.getBlockId(par2 + var9, par3 + var10, par4 + var11);

                        if (Block.blocksList[var12] != null)
                        {
                            Block.blocksList[var12].beginLeavesDecay(par1World, par2 + var9, par3 + var10, par4 + var11);
                        }
                    }
                }
            }
        }
    }
    
    public void updateTick(World par1World, int par2, int par3, int par4, Random par5Random) {
        if (!par1World.isRemote) {
            int var6 = par1World.getBlockMetadata(par2, par3, par4);

            if ((var6 &  != 0 && (var6 & 4) == 0) {
                byte var7 = 4;
                int var8 = var7 + 1;
                byte var9 = 32;
                int var10 = var9 * var9;
                int var11 = var9 / 2;

                if (this.adjacentTreeBlocks == null) {
                    this.adjacentTreeBlocks = new int[var9 * var9 * var9];
                }

                int var12;

                if (par1World.checkChunksExist(par2 - var8, par3 - var8, par4 - var8, par2 + var8, par3 + var8, par4 + var8)) {
                    int var13;
                    int var14;
                    int var15;

                    for (var12 = -var7; var12 <= var7; ++var12) {
                        for (var13 = -var7; var13 <= var7; ++var13) {
                            for (var14 = -var7; var14 <= var7; ++var14) {
                                var15 = par1World.getBlockId(par2 + var12, par3 + var13, par4 + var14);

                                Block block = Block.blocksList[var15];

                                if (block != null && block.canSustainLeaves(par1World, par2 + var12, par3 + var13, par4 + var14)) {
                                    this.adjacentTreeBlocks[(var12 + var11) * var10 + (var13 + var11) * var9 + var14 + var11] = 0;
                                }
                                else if (block != null && block.isLeaves(par1World, par2 + var12, par3 + var13, par4 + var14)) {
                                    this.adjacentTreeBlocks[(var12 + var11) * var10 + (var13 + var11) * var9 + var14 + var11] = -2;
                                }
                                else {
                                    this.adjacentTreeBlocks[(var12 + var11) * var10 + (var13 + var11) * var9 + var14 + var11] = -1;
                                }
                            }
                        }
                    }

                    for (var12 = 1; var12 <= 4; ++var12) {
                        for (var13 = -var7; var13 <= var7; ++var13) {
                            for (var14 = -var7; var14 <= var7; ++var14) {
                                for (var15 = -var7; var15 <= var7; ++var15) {
                                    if (this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11) * var9 + var15 + var11] == var12 - 1) {
                                        if (this.adjacentTreeBlocks[(var13 + var11 - 1) * var10 + (var14 + var11) * var9 + var15 + var11] == -2) {
                                            this.adjacentTreeBlocks[(var13 + var11 - 1) * var10 + (var14 + var11) * var9 + var15 + var11] = var12;
                                        }

                                        if (this.adjacentTreeBlocks[(var13 + var11 + 1) * var10 + (var14 + var11) * var9 + var15 + var11] == -2) {
                                            this.adjacentTreeBlocks[(var13 + var11 + 1) * var10 + (var14 + var11) * var9 + var15 + var11] = var12;
                                        }

                                        if (this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11 - 1) * var9 + var15 + var11] == -2) {
                                            this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11 - 1) * var9 + var15 + var11] = var12;
                                        }

                                        if (this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11 + 1) * var9 + var15 + var11] == -2) {
                                            this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11 + 1) * var9 + var15 + var11] = var12;
                                        }

                                        if (this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11) * var9 + (var15 + var11 - 1)] == -2) {
                                            this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11) * var9 + (var15 + var11 - 1)] = var12;
                                        }

                                        if (this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11) * var9 + var15 + var11 + 1] == -2) {
                                            this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11) * var9 + var15 + var11 + 1] = var12;
                                        }
                                    }
                                }
                            }
                        }
                    }
                }

                var12 = this.adjacentTreeBlocks[var11 * var10 + var11 * var9 + var11];

                if (var12 >= 0) {
                    par1World.setBlockMetadata(par2, par3, par4, var6 & -9);
                }
                else {
                    this.removeLeaves(par1World, par2, par3, par4);
                }
            }
        }
    }

    @SideOnly(Side.CLIENT)

    /**
     * A randomly called display update to be able to add particles or other items for display
     */
    public void randomDisplayTick(World par1World, int par2, int par3, int par4, Random par5Random) {
        if (par1World.canLightningStrikeAt(par2, par3 + 1, par4) && !par1World.doesBlockHaveSolidTopSurface(par2, par3 - 1, par4) && par5Random.nextInt(15) == 1) {
            double var6 = (double)((float)par2 + par5Random.nextFloat());
            double var8 = (double)par3 - 0.05D;
            double var10 = (double)((float)par4 + par5Random.nextFloat());
            par1World.spawnParticle("dripWater", var6, var8, var10, 0.0D, 0.0D, 0.0D);
        }
    }

    private void removeLeaves(World par1World, int par2, int par3, int par4) {
        this.dropBlockAsItem(par1World, par2, par3, par4, par1World.getBlockMetadata(par2, par3, par4), 0);
        par1World.setBlockWithNotify(par2, par3, par4, 0);
    }
    
    public int quantityDropped(Random par1Random) {
        return par1Random.nextInt(20) == 0 ? 1 : 0;
    }
    
    public int idDropped(int par1, Random par2Random, int par3) {
        return XetosMod.serpentSapling.blockID;
    }
    
    public void dropBlockAsItemWithChance(World par1World, int par2, int par3, int par4, int par5, float par6, int par7) {
        if (!par1World.isRemote) {
            byte var8 = 20;

            if ((par5 & 3) == 3) {
                var8 = 40;
            }

            if (par1World.rand.nextInt(var8) == 0) {
                int var9 = this.idDropped(par5, par1World.rand, par7);
                this.dropBlockAsItem_do(par1World, par2, par3, par4, new ItemStack(var9, 1, this.damageDropped(par5)));
            }

            if ((par5 & 3) == 0 && par1World.rand.nextInt(200) == 0) {
                this.dropBlockAsItem_do(par1World, par2, par3, par4, new ItemStack(Item.appleRed, 1, 0));
            }
        }
    }
    
    public void harvestBlock(World par1World, EntityPlayer par2EntityPlayer, int par3, int par4, int par5, int par6) {
        super.harvestBlock(par1World, par2EntityPlayer, par3, par4, par5, par6);
    }
    
    public boolean isOpaqueCube() {
        return !this.graphicsLevel;
    }
    
    @Override
    public String getTextureFile () {
    	return XetosModCommonProxy.BLOCK_PNG;
    }
    
    public int getBlockTextureFromSideAndMetadata(int i, int j)
    {
        if((j & 3) == 1) {
            return blockIndexInTexture;
        }
        else {
            return blockIndexInTexture;
        }
    }
    
    @SideOnly(Side.CLIENT)

    /**
     * Pass true to draw this block using fancy graphics, or false for fast graphics.
     */
    public void setGraphicsLevel(boolean par1) {
        this.graphicsLevel = par1;
    }
    
    @Override
    public boolean isShearable(ItemStack item, World world, int x, int y, int z) {
        return true;
    }
    
    @Override
    public boolean isLeaves(World world, int x, int y, int z) {
        return true;
    }

@Override
public ArrayList<ItemStack> onSheared(ItemStack item, World world, int x, int y, int z, int fortune) {
        ArrayList<ItemStack> ret = new ArrayList<ItemStack>();
        ret.add(new ItemStack(this, 1, world.getBlockMetadata(x, y, z) & 3));
        return ret;
}
}

Posted

I believe you need to return false from overriding renderAsSolidCube or isSolidBlock something like that >isBlockSolidOnSide<. This tells the renderer you can see through it.

That didn't work :(

Posted

Heres my leaf block code that works, it might help you

 


package thedecopack.medieval.blocks;

import cpw.mods.fml.common.Side;
import cpw.mods.fml.common.asm.SideOnly;

import net.minecraft.src.*;

import java.util.ArrayList;
import java.util.List;
import java.util.Random;

import thedecopack.medieval.DecoMedieval;

import net.minecraftforge.common.IShearable;

public class BlockMedievalCedarLeaves extends BlockLeavesBase implements IShearable
{
/**
 * The base index in terrain.png corresponding to the fancy version of the leaf texture. This is stored so we can
 * switch the displayed version between fancy and fast graphics (fast is this index + 1).
 */
private int baseIndexInPNG;
int[] adjacentTreeBlocks;

boolean fancy = ((BlockLeaves)Block.blocksList[18]).graphicsLevel;

protected BlockMedievalCedarLeaves(int par1, int par2)
{
	super(par1, par2, Material.leaves, false);
	this.baseIndexInPNG = par2;
	this.setTickRandomly(true);
	this.setCreativeTab(DecoMedieval.medievalTab);
}

/**
 * ejects contained items into the world, and notifies neighbours of an update, as appropriate
 */
public void breakBlock(World par1World, int par2, int par3, int par4, int par5, int par6)
{
	byte var7 = 1;
	int var8 = var7 + 1;

	if (par1World.checkChunksExist(par2 - var8, par3 - var8, par4 - var8, par2 + var8, par3 + var8, par4 + var8))
	{
		for (int var9 = -var7; var9 <= var7; ++var9)
		{
			for (int var10 = -var7; var10 <= var7; ++var10)
			{
				for (int var11 = -var7; var11 <= var7; ++var11)
				{
					int var12 = par1World.getBlockId(par2 + var9, par3 + var10, par4 + var11);

					if (Block.blocksList[var12] != null)
					{
						Block.blocksList[var12].beginLeavesDecay(par1World, par2 + var9, par3 + var10, par4 + var11);
					}
				}
			}
		}
	}
}

/**
 * Ticks the block if it's been scheduled
 */
public void updateTick(World par1World, int par2, int par3, int par4, Random par5Random)
{
	if (!par1World.isRemote)
	{
		int var6 = par1World.getBlockMetadata(par2, par3, par4);

		if ((var6 &  != 0 && (var6 & 4) == 0)
		{
			byte var7 = 4;
			int var8 = var7 + 1;
			byte var9 = 32;
			int var10 = var9 * var9;
			int var11 = var9 / 2;

			if (this.adjacentTreeBlocks == null)
			{
				this.adjacentTreeBlocks = new int[var9 * var9 * var9];
			}

			int var12;

			if (par1World.checkChunksExist(par2 - var8, par3 - var8, par4 - var8, par2 + var8, par3 + var8, par4 + var8))
			{
				int var13;
				int var14;
				int var15;

				for (var12 = -var7; var12 <= var7; ++var12)
				{
					for (var13 = -var7; var13 <= var7; ++var13)
					{
						for (var14 = -var7; var14 <= var7; ++var14)
						{
							var15 = par1World.getBlockId(par2 + var12, par3 + var13, par4 + var14);

							Block block = Block.blocksList[var15];

							if (block != null && block.canSustainLeaves(par1World, par2 + var12, par3 + var13, par4 + var14))
							{
								this.adjacentTreeBlocks[(var12 + var11) * var10 + (var13 + var11) * var9 + var14 + var11] = 0;
							}
							else if (block != null && block.isLeaves(par1World, par2 + var12, par3 + var13, par4 + var14))
							{
								this.adjacentTreeBlocks[(var12 + var11) * var10 + (var13 + var11) * var9 + var14 + var11] = -2;
							}
							else
							{
								this.adjacentTreeBlocks[(var12 + var11) * var10 + (var13 + var11) * var9 + var14 + var11] = -1;
							}
						}
					}
				}

				for (var12 = 1; var12 <= 4; ++var12)
				{
					for (var13 = -var7; var13 <= var7; ++var13)
					{
						for (var14 = -var7; var14 <= var7; ++var14)
						{
							for (var15 = -var7; var15 <= var7; ++var15)
							{
								if (this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11) * var9 + var15 + var11] == var12 - 1)
								{
									if (this.adjacentTreeBlocks[(var13 + var11 - 1) * var10 + (var14 + var11) * var9 + var15 + var11] == -2)
									{
										this.adjacentTreeBlocks[(var13 + var11 - 1) * var10 + (var14 + var11) * var9 + var15 + var11] = var12;
									}

									if (this.adjacentTreeBlocks[(var13 + var11 + 1) * var10 + (var14 + var11) * var9 + var15 + var11] == -2)
									{
										this.adjacentTreeBlocks[(var13 + var11 + 1) * var10 + (var14 + var11) * var9 + var15 + var11] = var12;
									}

									if (this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11 - 1) * var9 + var15 + var11] == -2)
									{
										this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11 - 1) * var9 + var15 + var11] = var12;
									}

									if (this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11 + 1) * var9 + var15 + var11] == -2)
									{
										this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11 + 1) * var9 + var15 + var11] = var12;
									}

									if (this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11) * var9 + (var15 + var11 - 1)] == -2)
									{
										this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11) * var9 + (var15 + var11 - 1)] = var12;
									}

									if (this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11) * var9 + var15 + var11 + 1] == -2)
									{
										this.adjacentTreeBlocks[(var13 + var11) * var10 + (var14 + var11) * var9 + var15 + var11 + 1] = var12;
									}
								}
							}
						}
					}
				}
			}

			var12 = this.adjacentTreeBlocks[var11 * var10 + var11 * var9 + var11];

			if (var12 >= 0)
			{
				par1World.setBlockMetadata(par2, par3, par4, var6 & -9);
			}
			else
			{
				this.removeLeaves(par1World, par2, par3, par4);
			}
		}
	}
}

public int getBlockTextureFromSideAndMetadata(int par1, int par2)
{
	fancy = ((BlockLeaves)Block.blocksList[18]).graphicsLevel;
	return this.fancy ? this.baseIndexInPNG + 1 : this.baseIndexInPNG;
}

@SideOnly(Side.CLIENT)

/**
 * A randomly called display update to be able to add particles or other items for display
 */
public void randomDisplayTick(World par1World, int par2, int par3, int par4, Random par5Random)
{
	if (par1World.canLightningStrikeAt(par2, par3 + 1, par4) && !par1World.doesBlockHaveSolidTopSurface(par2, par3 - 1, par4) && par5Random.nextInt(15) == 1)
	{
		double var6 = (double)((float)par2 + par5Random.nextFloat());
		double var8 = (double)par3 - 0.05D;
		double var10 = (double)((float)par4 + par5Random.nextFloat());
		par1World.spawnParticle("dripWater", var6, var8, var10, 0.0D, 0.0D, 0.0D);
	}
}

private void removeLeaves(World par1World, int par2, int par3, int par4)
{
	this.dropBlockAsItem(par1World, par2, par3, par4, par1World.getBlockMetadata(par2, par3, par4), 0);
	par1World.setBlockWithNotify(par2, par3, par4, 0);
}

/**
 * Returns the quantity of items to drop on block destruction.
 */
public int quantityDropped(Random par1Random)
{
	return par1Random.nextInt(20) == 0 ? 1 : 0;
}

/**
 * Returns the ID of the items to drop on destruction.
 */
public int idDropped(int par1, Random par2Random, int par3)
{
	return MedievalBlocks.redCedarSaplingID;
}

/**
 * Drops the block items with a specified chance of dropping the specified items
 */
public void dropBlockAsItemWithChance(World par1World, int par2, int par3, int par4, int par5, float par6, int par7)
{
	if (!par1World.isRemote)
	{
		byte var8 = 20;

		if ((par5 & 3) == 3)
		{
			var8 = 40;
		}

		if (par1World.rand.nextInt(var8) == 0)
		{
			int var9 = this.idDropped(par5, par1World.rand, par7);
			this.dropBlockAsItem_do(par1World, par2, par3, par4, new ItemStack(var9, 1, this.damageDropped(par5)));
		}

		if ((par5 & 3) == 0 && par1World.rand.nextInt(200) == 0)
		{
			this.dropBlockAsItem_do(par1World, par2, par3, par4, new ItemStack(Item.appleRed, 1, 0));
		}
	}
}

@Override
@SideOnly(Side.CLIENT)
public int getBlockTexture(IBlockAccess par1iBlockAccess, int par2, int par3, int par4, int par5) 
{
    int meta = par1iBlockAccess.getBlockMetadata(par2, par3, par4);
    return this.getBlockTextureFromSideAndMetadata(par5, meta);
}

/**
 * Called when the player destroys a block with an item that can harvest it. (i, j, k) are the coordinates of the
 * block and l is the block's subtype/damage.
 */
public void harvestBlock(World par1World, EntityPlayer par2EntityPlayer, int par3, int par4, int par5, int par6)
{
	super.harvestBlock(par1World, par2EntityPlayer, par3, par4, par5, par6);
}

/**
 * Determines the damage on the item the block drops. Used in cloth and wood.
 */
public int damageDropped(int par1)
{
	return par1 & 3;
}

/**
 * Is this block (a) opaque and (b) a full 1m cube?  This determines whether or not to render the shared face of two
 * adjacent blocks and also whether the player can attach torches, redstone wire, etc to this block.
 */
public boolean isOpaqueCube()
{
	return !this.fancy;
}

@Override
public boolean isShearable(ItemStack item, World world, int x, int y, int z) 
{
	return true;
}

@Override
public ArrayList<ItemStack> onSheared(ItemStack item, World world, int x, int y, int z, int fortune) 
{
	ArrayList<ItemStack> ret = new ArrayList<ItemStack>();
	ret.add(new ItemStack(this, 1, world.getBlockMetadata(x, y, z) & 3));
	return ret;
}

@Override
public void beginLeavesDecay(World world, int x, int y, int z)
{
	world.setBlockMetadata(x, y, z, world.getBlockMetadata(x, y, z) | ;
}

@Override
public boolean isLeaves(World world, int x, int y, int z)
{
	return true;
}

public String getTextureFile()
{
	return DecoMedieval.instance.blockTextureFile();
}
}


Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello all. I'm currently grappling with the updateShape method in a custom class extending Block.  My code currently looks like this: The conditionals in CheckState are there to switch blockstate properties, which is working fine, as it functions correctly every time in getStateForPlacement.  The problem I'm running into is that when I update a state, the blocks seem to call CheckState with the position of the block which was changed updated last.  If I build a wall I can see the same change propagate across. My question thus is this: is updateShape sending its return to the neighbouring block?  Is each block not independently executing the updateShape method, thus inserting its own current position?  The first statement appears to be true, and the second false (each block is not independently executing the method). I have tried to fix this by saving the block's own position to a variable myPos at inception, and then feeding this in as CheckState(myPos) but this causes a worse outcome, where all blocks take the update of the first modified block, rather than just their neighbour.  This raises more questions than it answers, obviously: how is a different instance's variable propagating here?  I also tried changing it so that CheckState did not take a BlockPos, but had myPos built into the body - same problem. I have previously looked at neighbourUpdate and onNeighbourUpdate, but could not find a way to get this to work at all.  One post on here about updatePostPlacement and other methods has proven itself long superceded.  All other sources on the net seem to be out of date. Many thanks in advance for any help you might offer me, it's been several days now of trying to get this work and several weeks of generally trying to get round this roadblock.  - Sandermall
    • sorry, I might be stupid, but how do I open it? because the only options I have are too X out, copy it, which doesn't work and send crash report, which doesn't show it to me, also, sorry for taking so long.
    • Can you reproduce this with version 55.0.21? A whole lot of plant placement issues were just fixed in this PR.
    • Necro'ing that thread to ask if you found a solution ? I'm encountering the same crash on loading the world. I created the world in Creative to test my MP, went into survival to test combat, died, crashed on respawn and since then crash on loading the world. Deactivating Oculus isn't fixing it either, and I don't have Optifine (Twilight forest is incompatible)
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.