Jump to content

Recommended Posts

Posted

This happened in Forge 1.9 - 12.16.0.1854

I have some stairs placed upside-down, like this

PMikZUS.png

 

But when i place a stair in the corner than this happen

XPk4GPO.png

y2u89As.png

Don't blame me if i always ask for your help. I just want to learn to be better :)

Posted

311c8b676c.png

No it doesn't, You're using the wrong model for your blockstate. If you notice your 'corner' is in the wrong spot.

The engine THINKS it is where it supposed to be so it culls some of the faces in the neighbors block.

This is how the engine works, if you use a invalidly shaped model for any other block this will be the same result.

 

Fix your model.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Posted

Strange, it works in a previous 1.9 version of Forge :/ I'll check this out, thanks for the answer ;)

Don't blame me if i always ask for your help. I just want to learn to be better :)

Posted

Stair rendering does have some problems. I get this as well:

 

Left: Forge 1.9-12.16.0.1863, Right: Vanilla 1.9

stairrenders.jpg

 

These are custom stair models so they are revealing the problem a bit differently. In 1.8.9 stairs would cull adjacent blocks to some sides. In 1.9 stairs do not cause any render culling (maybe of slabs, slabs have their own thing here), they are treated like a true transparent block. But, with Forge, stairs are culling adjacent blocks.

 

I checked the 1.8.9 stairs blockstates and they aren't really different from 1.9 (like fences are because of multiparts).

 

JimiIT92, if you'd like me to go over your blockstates or model code I can do that for ya. If in doubt, I generally recommend pasting in the original vanilla code first, especially for blockstates.

 

I wasn't sure if I should make my own thread, if there's a set of stair problems ;)

Posted

Yes those stairs are abusing a bug in vanillas culling system that forge fixes.

Blocks need to be the basic shapes that vanilla blocks are. Solid sides need to be solid, simple as that.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

  • 1 month later...
Posted

I had the same problem as shown in the first post. I'm using the latest recommended Forge: forge-1.9-12.16.1.1887-mdk

 

Vanilla Blocks just work fine in 1.8 and 1.9, my stais worked fine in 1.8, but in 1.9 my upper corner (inner and outer) stairs didn't rotate properly. The lower stairs were ok. Im using the vanilla models.

 

 

The solution for me was to change the blockstates and rotate the blocks there. I changed the "y"-Value in the lower half by either adding or substracting 90 degrees (outer_right +90, outer_left -90, inner_right +90, inner_left -90)

 

Code:

assets/roxastonestairs/blockstates/stoneStair.json for 1.8

{
    "variants": {
        "facing=east,half=bottom,shape=straight":    { "model": "RoxaStoneStairs:stoneStair" },
        "facing=west,half=bottom,shape=straight":    { "model": "RoxaStoneStairs:stoneStair", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=straight":   { "model": "RoxaStoneStairs:stoneStair", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=straight":   { "model": "RoxaStoneStairs:stoneStair", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_right": { "model": "RoxaStoneStairs:stoneStair_outer_stairs" },
        "facing=west,half=bottom,shape=outer_right": { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=outer_right":{ "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=outer_right":{ "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_left":  { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=outer_left":  { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=outer_left": { "model": "RoxaStoneStairs:stoneStair_outer_stairs" },
        "facing=north,half=bottom,shape=outer_left": { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 180, "uvlock": true },
        "facing=east,half=bottom,shape=inner_right": { "model": "RoxaStoneStairs:stoneStair_inner_stairs" },
        "facing=west,half=bottom,shape=inner_right": { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=inner_right":{ "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=inner_right":{ "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=inner_left":  { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=inner_left":  { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=inner_left": { "model": "RoxaStoneStairs:stoneStair_inner_stairs" },
        "facing=north,half=bottom,shape=inner_left": { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 180, "uvlock": true },
        "facing=east,half=top,shape=straight":       { "model": "RoxaStoneStairs:stoneStair", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=straight":       { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=straight":      { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=straight":      { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_right":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=west,half=top,shape=outer_right":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=outer_right":   { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=north,half=top,shape=outer_right":   { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_left":     { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=west,half=top,shape=outer_left":     { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=outer_left":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=outer_left":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=east,half=top,shape=inner_right":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=west,half=top,shape=inner_right":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=inner_right":   { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=north,half=top,shape=inner_right":   { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=inner_left":     { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=west,half=top,shape=inner_left":     { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=inner_left":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=inner_left":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":   0, "uvlock": true }
    }
}

 

assets/roxastonestairs/blockstates/stoneStair.json for 1.9

{
    "variants": {
        "facing=east,half=bottom,shape=straight":    { "model": "RoxaStoneStairs:stoneStair" },
        "facing=west,half=bottom,shape=straight":    { "model": "RoxaStoneStairs:stoneStair", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=straight":   { "model": "RoxaStoneStairs:stoneStair", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=straight":   { "model": "RoxaStoneStairs:stoneStair", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_right": { "model": "RoxaStoneStairs:stoneStair_outer_stairs" },
        "facing=west,half=bottom,shape=outer_right": { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=outer_right":{ "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=outer_right":{ "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_left":  { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=outer_left":  { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=outer_left": { "model": "RoxaStoneStairs:stoneStair_outer_stairs" },
        "facing=north,half=bottom,shape=outer_left": { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 180, "uvlock": true },
        "facing=east,half=bottom,shape=inner_right": { "model": "RoxaStoneStairs:stoneStair_inner_stairs" },
        "facing=west,half=bottom,shape=inner_right": { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=inner_right":{ "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=inner_right":{ "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=inner_left":  { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=inner_left":  { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=inner_left": { "model": "RoxaStoneStairs:stoneStair_inner_stairs" },
        "facing=north,half=bottom,shape=inner_left": { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 180, "uvlock": true },
        "facing=east,half=top,shape=straight":       { "model": "RoxaStoneStairs:stoneStair", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=straight":       { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=straight":      { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=straight":      { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_right":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=west,half=top,shape=outer_right":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=outer_right":   { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=outer_right":   { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=east,half=top,shape=outer_left":     { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=west,half=top,shape=outer_left":     { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=outer_left":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=north,half=top,shape=outer_left":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=inner_right":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=west,half=top,shape=inner_right":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=inner_right":   { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=inner_right":   { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=east,half=top,shape=inner_left":     { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=west,half=top,shape=inner_left":     { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=inner_left":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=north,half=top,shape=inner_left":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 270, "uvlock": true }
    }
}

Posted

I don't know if this will help, but this are all my json files

 

blockstate

{
    "variants": {
        "facing=east,half=bottom,shape=straight":  { "model": "mw:aluminium_stairs" },
        "facing=west,half=bottom,shape=straight":  { "model": "mw:aluminium_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=straight": { "model": "mw:aluminium_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=straight": { "model": "mw:aluminium_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_right":  { "model": "mw:aluminium_outer_stairs" },
        "facing=west,half=bottom,shape=outer_right":  { "model": "mw:aluminium_outer_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=outer_right": { "model": "mw:aluminium_outer_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=outer_right": { "model": "mw:aluminium_outer_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_left":  { "model": "mw:aluminium_outer_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=outer_left":  { "model": "mw:aluminium_outer_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=outer_left": { "model": "mw:aluminium_outer_stairs" },
        "facing=north,half=bottom,shape=outer_left": { "model": "mw:aluminium_outer_stairs", "y": 180, "uvlock": true },
        "facing=east,half=bottom,shape=inner_right":  { "model": "mw:aluminium_inner_stairs" },
        "facing=west,half=bottom,shape=inner_right":  { "model": "mw:aluminium_inner_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=inner_right": { "model": "mw:aluminium_inner_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=inner_right": { "model": "mw:aluminium_inner_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=inner_left":  { "model": "mw:aluminium_inner_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=inner_left":  { "model": "mw:aluminium_inner_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=inner_left": { "model": "mw:aluminium_inner_stairs" },
        "facing=north,half=bottom,shape=inner_left": { "model": "mw:aluminium_inner_stairs", "y": 180, "uvlock": true },
        "facing=east,half=top,shape=straight":  { "model": "mw:aluminium_stairs", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=straight":  { "model": "mw:aluminium_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=straight": { "model": "mw:aluminium_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=straight": { "model": "mw:aluminium_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_right":  { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=west,half=top,shape=outer_right":  { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=outer_right": { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=outer_right": { "model": "mw:aluminium_outer_stairs", "x": 180, "uvlock": true },
        "facing=east,half=top,shape=outer_left":  { "model": "mw:aluminium_outer_stairs", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=outer_left":  { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=outer_left": { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=outer_left": { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=inner_right":  { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=west,half=top,shape=inner_right":  { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=inner_right": { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=inner_right": { "model": "mw:aluminium_inner_stairs", "x": 180, "uvlock": true },
        "facing=east,half=top,shape=inner_left":  { "model": "mw:aluminium_inner_stairs", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=inner_left":  { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=inner_left": { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=inner_left": { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 270, "uvlock": true }
    }
}

 

Item

{
    "parent": "mw:block/aluminium_stairs"
}

 

Block models

normal

{
    "parent": "block/stairs",
    "textures": {
        "bottom": "mw:blocks/aluminium_block",
        "top": "mw:blocks/aluminium_block",
        "side": "mw:blocks/aluminium_block"
    }
}

 

inner

{
    "parent": "block/inner_stairs",
    "textures": {
        "bottom": "mw:blocks/aluminium_block",
        "top": "mw:blocks/aluminium_block",
        "side": "mw:blocks/aluminium_block"
    }
}

 

outer

{
    "parent": "block/outer_stairs",
    "textures": {
        "bottom": "mw:blocks/aluminium_block",
        "top": "mw:blocks/aluminium_block",
        "side": "mw:blocks/aluminium_block"
    }
}

 

Don't blame me if i always ask for your help. I just want to learn to be better :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.