I am changing a tick counter in an item every frame, and as a result the ItemStack is "changing" and thus appears to reset the block breakage. Is there a method I can override to prevent this?

Rather than incrementing a counter every tick, store the start time and compare with the current time.

Hmm... I considered doing that. I will try that now.

 

Also, is there a way to allocate an Item to a new ItemStack class?

 

Edit: Oh yeah, that still will not work, as the tick counter does affect other NBT data periodically.

Nope, you can't effectively sub-class ItemStack to add your own stuff, though you can with EntityItem.

Right, but is there a way to not cause it to refresh the block break whenever NBT data changes? It really makes things problematic.

Yes, there should be an Item method called something like #shouldCauseReequipAnimation - the syncing of the NBT to the client is what causes the re-equip animation which in turn interrupts block breaking. Be sure to still return true if the stack has indeed changed.

I am overriding that - but it still does not prevent block break from resetting...

Show your implementation. There's also always the possibility that it is a bug.

Implementation of shouldCauseReequipAnimation?

 

@Override
public boolean shouldCauseReequipAnimation(ItemStack oldStack, ItemStack newStack, boolean slotChanged)
{
return !oldStack.isItemEqual(newStack) || oldStack.getTagCompound().getBoolean("glowing") != newStack.getTagCompound().getBoolean("glowing");
}

That looks fine, so perhaps it's a bug? 1.9 did add 2 hands, after all, so I imagine quite a lot must have changed in the background. You could try following the call hierarchy of #shouldCauseReequipAnimation and see if there is anything amiss.

Even when it simply returns false, it still does not allow it to break the block, so it probably has nothing to do with that method, but I will have a little look.

It's possible I've misunderstood what that method does - it may only actually affect the reequip animation and have nothing to do with the block-breaking process, though I am/was pretty sure they were related. I've never had occasion to test while breaking a block, though I have had occasion to override the method

 

So, either that method isn't the right one, or it is currently bugged in 1.9.

I don't see any situation where you do not want it to play the re-equip animation, but do want to reset the block break animation.

Can I just get a confirmation that this is bugged, there is a method that I forgot to override or an event that I need to use?