[1.8.9][SOLVED] Tile Entity's Tank not updating (wrongly) client-side

[Eastonium]

I have a tank implemented on my tile entity, but the client isn't getting updated when I remove fluid from the tank bit by bit, but it does work when I fill the tank completely from being empty.

 

Here's my update function from my TileEntity/TileInventory class.

@Override
public void update(){
	boolean hasLava = this.hasLava();
	int lavaAmount = this.tank.getFluidAmount();
	boolean needsUpdate = false;

               //When I print out "lavaAmount" here, I get either 0/1000 (empty/full) when run by the client, but the actual amount when run by the server

	/*if(this.burnTimeRemaining > 0){
		--this.burnTimeRemaining;
	}*/
	if(!this.worldObj.isRemote){
		if(!hasLava && this.forgeItemstacks[FIRST_FUEL_SLOT] != null && this.forgeItemstacks[FIRST_FUEL_SLOT].getItem() == Items.lava_bucket){//TODO Change to include all items that hold fluids
			this.fill(null, new FluidStack(FluidRegistry.LAVA, FluidContainerRegistry.BUCKET_VOLUME), true);
			this.forgeItemstacks[FIRST_FUEL_SLOT] = this.forgeItemstacks[FIRST_FUEL_SLOT].getItem().getContainerItem(forgeItemstacks[FIRST_FUEL_SLOT]);
		}
		if(/*this.secondsOfFuelRemaining() > 0*/ hasLava && this.canSmelt()){
			this.tank.drain(5, true);
			++this.cookTime;
			if(this.cookTime == COOK_TIME_FOR_COMPLETION){
				this.cookTime = 0;
				this.smeltItem();
				needsUpdate = true;
			}
		}
		if (lavaAmount != this.tank.getFluidAmount()){
			needsUpdate = true;
			//TODO BlockMaskForge.updateFurnaceBlockState(this.isBurning(), this.worldObj, this.pos.getX(), this.pos.getY(), this.pos.getX());
		}
	}

	if (needsUpdate){
		this.markDirty();
	}
}

 

Is there something I'm missing here?

I'm sure you'll probably need more information to help me solve this, just let me know what you need.

 

EDIT: Solved it myself. Turns out when I was updating the IInventory setFeild() function, I was always adding fluid rather than adding/removing depending on what it should be.

 

So I changed this:

@Override
public void setField(int id, int value){
	if(id == COOK_FIELD_ID){
		cookTime = (short)value;
	}else if(id == FUEL_AMOUNT_FIELD_ID){
		this.fill(null, new FluidStack(FluidRegistry.LAVA, value), true);
	}else{
		System.err.println("Invalid field ID in TileInventorySmelting.setField:" + id);
	}
}

 

To this:

@Override
public void setField(int id, int value){
	if(id == COOK_FIELD_ID){
		cookTime = (short)value;
	}else if(id == FUEL_AMOUNT_FIELD_ID){
		FluidStack flStack = new FluidStack(FluidRegistry.LAVA, Math.abs(this.tank.getFluidAmount() - value));
		if(value > this.tank.getFluidAmount()){
			this.fill(null, flStack, true);
		}else if(value < this.tank.getFluidAmount()){
			this.drain(null, flStack, true);
		}
	}else{
		System.err.println("Invalid field ID in TileInventorySmelting.setField:" + id);
	}
}

[shadowfacts]

Of course it doesn't think there's any fluid present on the client side, your code that updates the lava tank is only run on the server side because of the

!isRemote

check. The game doesn't automatically sync your TileEntities to the client side, you need to do that yourself.

[Eastonium]

Did you read all of my post? It does show changes on clientside, but only in one circumstance.

[Draco18s]

Did you read all of my post? It does show changes on clientside, but only in one circumstance.

 

Your update function still bypasses the change that doesn't get tracked on the client, on the client.

[Eastonium]

But both of the changes I make to the tank both happen within the !isRemote section.

Am I just missing something really obvious?