Jump to content

Recommended Posts

Posted

The ForgeDirection rotation matrix for getRotation(axis) has some wrong values, leading to incorrect rotations. For example NORTH.getRotation(UP).getRotation(UP) returns NORTH, not (as one should expect) SOUTH.

Here's the fixed rotation matrix (now using the left-hand rule everywhere):

 

    public static final int[][] ROTATION_MATRIX = {
    	{0, 1, 4, 5, 3, 2, 6}, // Swapped 2 and 3
    	{0, 1, 5, 4, 2, 3, 6}, // Swapped 3 and 2
    	{5, 4, 2, 3, 0, 1, 6},
    	{4, 5, 2, 3, 1, 0, 6},
    	{2, 3, 1, 0, 4, 5, 6}, // Swapped 0 and 1
    	{3, 2, 0, 1, 4, 5, 6}, // Swapped 1 and 0
    	{0, 1, 2, 3, 4, 5, 6},
    };

Posted

Submit a PR here.

There's an EAQ for a reason. Read it!

"Note that failure to read this will make you look idiotic. You don't want that do you?" -- luacs1998

 

First rule of bug reports: More information is always better.

Oh, and logs OR IT DIDN'T HAPPEN!!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.