[Solved][1.7.10] checking biome location

[Glistre]

Trying to check for biome location to play Thunder in my biome, nothing seems to catch the biome: if I check for (event.player.worldObj.isRemote ) it plays constant thunder, or (!event.player.worldObj.isRemote ), I think is correct for server side ...then nothing happens

 

What I want to happen is for thunder to ONLY play in my biome

 

@SubscribeEvent
public void thunderStorm (PlayerTickEvent event){

Random rand = new Random(); 

int varX=rand.nextInt(25); 
int varZ=rand.nextInt(25);
int spawnchance=rand.nextInt(150);

if (spawnchance == 0){	

	if (!event.player.worldObj.isRemote )
	{ 
		if (event.player.worldObj.getBiomeGenForCoords(event.player.chunkCoordX, event.player.chunkCoordZ) == BiomeRegistry.biomeFreon){

			event.player.worldObj.playSound(event.player.posX, event.player.posY, event.player.posZ, "ambient.weather.thunder", 100.0F, 1.0F, false);



	event.player.worldObj.addWeatherEffect(new EntityLightningBolt(event.player.worldObj, event.player.posX + varX, 
			event.player.posY, event.player.posZ + varZ));

       
	}
	}
}
}

[Draco18s]

Well, the sound doesn't play on the server because World#playSound on the server thread is empty.

 

What you need to do is debug this line:

 

if (event.player.worldObj.getBiomeGenForCoords(event.player.chunkCoordX, event.player.chunkCoordZ) == BiomeRegistry.biomeFreon){

 

And figure out why it isn't doing what you want.

[Glistre]

Well, the sound doesn't play on the server because World#playSound on the server thread is empty.

 

What you need to do is debug this line:

 

if (event.player.worldObj.getBiomeGenForCoords(event.player.chunkCoordX, event.player.chunkCoordZ) == BiomeRegistry.biomeFreon){

 

And figure out why it isn't doing what you want.

 

How do you debug if it's not doing anything at all?

 

I solved the problem, but I would still like to learn to be a better modder and I might have solved it much quicker

 

By the way, I replaced the line with this and it works

			if (event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ) == BiomeRegistry.biomeFreon){
			// DEBUG

			       System.out.println("Getting biome coords" + event.player.chunkCoordX );

 

But, of course the original way, nothing prints in the console at all

 

[Draco18s]

Do it the other way around

 

System.out.println("Getting biome: " + event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ));
if (event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ) == BiomeRegistry.biomeFreon){

[Glistre]

Do it the other way around

 

System.out.println("Getting biome: " + event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ));
if (event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ) == BiomeRegistry.biomeFreon){

 

When I try the debug the way I originally had the code (did not work) ie,

 

 if (event.player.worldObj.getBiomeGenForCoords(event.player.chunkCoordX, event.player.chunkCoordZ) == BiomeRegistry.biomeFreon){

 

the console reads:

[20:20:28] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordstrue
[20:20:31] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordstrue
[20:20:31] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordstrue
[20:20:33] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:33] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:34] [Client thread/INFO]: Warning: Clientside chunk ticking took 101 ms
[20:20:36] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordstrue
[20:20:37] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:37] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:38] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:38] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:38] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:38] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:39] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:39] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:40] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:40] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse

 

 

 

[Draco18s]

That console output matches neither what I did, nor what you did (and is useless).

[Glistre]

[21:13:51] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:93]: Getting biome coordscom.glistre.glistremod.biome.FreonBiome@29e66bc1
[21:13:51] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[21:13:51] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:93]: Getting biome coordscom.glistre.glistremod.biome.FreonBiome@29e66bc1

 

the way you did it  ...console shows getting the biome ...works fine

 

the way I did it originally ... does not work ...seems to just check true in the biome or not but the code does not work ...

 

Works fine now here is my final code

 

@SubscribeEvent
public void thunderStorm (PlayerTickEvent event){
BiomeGenBase b = BiomeRegistry.biomeFreon;
Random rand = new Random(); 
int varX=rand.nextInt(25); 
int varZ=rand.nextInt(25);
int spawnchance=rand.nextInt(150);

if (spawnchance == 0){	

	if (!event.player.worldObj.isRemote )
		// DEBUG
		 System.out.println("Player Tick for: " + event.side );

	{ 
			// DEBUG
			System.out.println("Getting biome coords" + event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ));
			if (event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ) == BiomeRegistry.biomeFreon ||  event.player.worldObj.provider.dimensionId == {

						       //1.8 code			if(player.worldObj.getBiomeGenForCoords(new BlockPos(player.posX, player.posY, player.posZ)) == BiomeRegistry.biomeFreon)						
			event.player.worldObj.playSound(event.player.posX, event.player.posY, event.player.posZ, "ambient.weather.thunder", 100.0F, 1.0F, false);

			event.player.worldObj.addWeatherEffect(new EntityLightningBolt(event.player.worldObj, event.player.posX + varX, 
			event.player.posY, event.player.posZ + varZ));
		}
	  }
   }
}

[Draco18s]

the way you did it  ...console shows getting the biome ...works fine

 

I'm not surprised. To debug an if-statement you need to be logging outside of it and printing out the objects being compared not the comparison result.