Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[Solved][1.7.10] checking biome location

Glistre

By Glistre
in Modder Support

 Share

Recommended Posts

Glistre Creeper Killer

Glistre

Posted
Posted

Trying to check for biome location to play Thunder in my biome, nothing seems to catch the biome: if I check for (event.player.worldObj.isRemote ) it plays constant thunder, or (!event.player.worldObj.isRemote ), I think is correct for server side ...then nothing happens

 

What I want to happen is for thunder to ONLY play in my biome

 

@SubscribeEvent
public void thunderStorm (PlayerTickEvent event){

Random rand = new Random(); 

int varX=rand.nextInt(25); 
int varZ=rand.nextInt(25);
int spawnchance=rand.nextInt(150);

if (spawnchance == 0){	

	if (!event.player.worldObj.isRemote )
	{ 
		if (event.player.worldObj.getBiomeGenForCoords(event.player.chunkCoordX, event.player.chunkCoordZ) == BiomeRegistry.biomeFreon){

			event.player.worldObj.playSound(event.player.posX, event.player.posY, event.player.posZ, "ambient.weather.thunder", 100.0F, 1.0F, false);



	event.player.worldObj.addWeatherEffect(new EntityLightningBolt(event.player.worldObj, event.player.posX + varX, 
			event.player.posY, event.player.posZ + varZ));

       
	}
	}
}
}

Draco18s Reality Controller

Draco18s

Posted
Posted

Well, the sound doesn't play on the server because World#playSound on the server thread is empty.

 

What you need to do is debug this line:

 

if (event.player.worldObj.getBiomeGenForCoords(event.player.chunkCoordX, event.player.chunkCoordZ) == BiomeRegistry.biomeFreon){

 

And figure out why it isn't doing what you want.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Glistre Creeper Killer

Glistre

Posted
  • Author
Posted

Well, the sound doesn't play on the server because World#playSound on the server thread is empty.

 

What you need to do is debug this line:

 

if (event.player.worldObj.getBiomeGenForCoords(event.player.chunkCoordX, event.player.chunkCoordZ) == BiomeRegistry.biomeFreon){

 

And figure out why it isn't doing what you want.

 

How do you debug if it's not doing anything at all?

 

I solved the problem, but I would still like to learn to be a better modder and I might have solved it much quicker

 

By the way, I replaced the line with this and it works

			if (event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ) == BiomeRegistry.biomeFreon){
			// DEBUG

			       System.out.println("Getting biome coords" + event.player.chunkCoordX );

 

But, of course the original way, nothing prints in the console at all

 

Draco18s Reality Controller

Draco18s

Posted
Posted

Do it the other way around :|

 

System.out.println("Getting biome: " + event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ));
if (event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ) == BiomeRegistry.biomeFreon){

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Glistre Creeper Killer

Glistre

Posted
  • Author
Posted

Do it the other way around :|

 

System.out.println("Getting biome: " + event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ));
if (event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ) == BiomeRegistry.biomeFreon){

 

When I try the debug the way I originally had the code (did not work) ie,

 

 if (event.player.worldObj.getBiomeGenForCoords(event.player.chunkCoordX, event.player.chunkCoordZ) == BiomeRegistry.biomeFreon){

 

the console reads:


[20:20:28] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordstrue
[20:20:31] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordstrue
[20:20:31] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordstrue
[20:20:33] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:33] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:34] [Client thread/INFO]: Warning: Clientside chunk ticking took 101 ms
[20:20:36] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordstrue
[20:20:37] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:37] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:38] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:38] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:38] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:38] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:39] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:39] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:40] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:40] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse

 

 

 

Draco18s Reality Controller

Draco18s

Posted
Posted

That console output matches neither what I did, nor what you did (and is useless).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Glistre Creeper Killer

Glistre

Posted
  • Author
Posted 

[21:13:51] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:93]: Getting biome coordscom.glistre.glistremod.biome.FreonBiome@29e66bc1
[21:13:51] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[21:13:51] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:93]: Getting biome coordscom.glistre.glistremod.biome.FreonBiome@29e66bc1

 

the way you did it  ...console shows getting the biome ...works fine

 

the way I did it originally ... does not work ...seems to just check true in the biome or not but the code does not work ...

 

Works fine now here is my final code

 

@SubscribeEvent
public void thunderStorm (PlayerTickEvent event){
BiomeGenBase b = BiomeRegistry.biomeFreon;
Random rand = new Random(); 
int varX=rand.nextInt(25); 
int varZ=rand.nextInt(25);
int spawnchance=rand.nextInt(150);

if (spawnchance == 0){	

	if (!event.player.worldObj.isRemote )
		// DEBUG
		 System.out.println("Player Tick for: " + event.side );

	{ 
			// DEBUG
			System.out.println("Getting biome coords" + event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ));
			if (event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ) == BiomeRegistry.biomeFreon ||  event.player.worldObj.provider.dimensionId == {

						       //1.8 code			if(player.worldObj.getBiomeGenForCoords(new BlockPos(player.posX, player.posY, player.posZ)) == BiomeRegistry.biomeFreon)						
			event.player.worldObj.playSound(event.player.posX, event.player.posY, event.player.posZ, "ambient.weather.thunder", 100.0F, 1.0F, false);

			event.player.worldObj.addWeatherEffect(new EntityLightningBolt(event.player.worldObj, event.player.posX + varX, 
			event.player.posY, event.player.posZ + varZ));
		}
	  }
   }
}

Draco18s Reality Controller

Draco18s

Posted
Posted

the way you did it  ...console shows getting the biome ...works fine

 

I'm not surprised. To debug an if-statement you need to be logging outside of it and printing out the objects being compared not the comparison result.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • ItsMiiYT
      EXCEPTION_ACCESS_VIOLATION (0xc0000005) Issue

      By ItsMiiYT · Posted

      I wanted to make a horror CurseForge modpack, but my game crashed when I try to play it! Does anyone know what to do? I've looked at other forums with the same problem, but I didn't understand what the replies were talking about. I also checked the log, did everything it said, but still, it didn't work. I am playing on 1.20.1 Forge. This is my first time using Forge. I've also made another Forge modpack test, but that didn't work, and I tried it with a NeoForge modpack test, too, but that didn't work either. Fabric works fine, though. Please help. # # A fatal error has been detected by the Java Runtime Environment: # # EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x00007ffb0c676280, pid=30812, tid=27596 # # JRE version: OpenJDK Runtime Environment Microsoft-8035246 (17.0.8+7) (build 17.0.8+7-LTS) # Java VM: OpenJDK 64-Bit Server VM Microsoft-8035246 (17.0.8+7-LTS, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, windows-amd64) # Problematic frame: # C [atio6axx.dll+0x196280] # # No core dump will be written. Minidumps are not enabled by default on client versions of Windows # # If you would like to submit a bug report, please visit: # https://aka.ms/minecraftjavacrashes # The crash happened outside the Java Virtual Machine in native code. # See problematic frame for where to report the bug. # Remember: 1. I am using CurseForge 2. I am on 1.20.1 3. I am on Forge 4. Tried the log methods   If you have any details I need to show, please tell me.
    • Zii
      Suddenly crashing on launch.

      By Zii · Posted

      Server has been running fine until a restart today, at which point it crashes partway through load. I've tried swapping out the modpack to a fresh server and it boots fine, but if I bring in the world file it causes the crash so I'm guessing something is wrong in there but I have no idea how to read and understand these logs, so any advice on what to do next would be helpful, thanks! Here's the log: https://api.mclo.gs/1/raw/jYzFXVR
    • TileEntity
      Modpack problem

      By TileEntity · Posted

      And without betterfortresses?
    • TileEntity
      "... doesn't specify minVersion property" errors (1.20.1 Forge Modpack)

      By TileEntity · Posted

      Try other builds of Mekanism
    • Demi_Sheep
      Modpack problem

      By Demi_Sheep · Posted

      as I understand it, it helped, but a strange error happened again- https://pastes.io/minecraft-crash-6 The game crashed: feature placement Error: java.lang.IllegalArgumentException: Cannot set property DirectionProperty{name=facing, clazz=class net.minecraft.core.Direction, values=[north, south, west, east]} to down on Block{minecraft:dark_oak_button}, it is not an allowed value

  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept