Minecraft crashes when opening custom crafting table

[TristanvO]

So when I open my custom GUI the game crashes.

 

main.java:

http://pastebin.com/mPamAF6M

 

GuiHandler.java:

http://pastebin.com/rQirGUVq

 

moriumWorkbench.java:

http://pastebin.com/Re2gFmbG

 

ContainerMoriumWorkbench.java:

http://pastebin.com/r4VhqrEk

 

GuiMoriumWorkbench.java:

http://pastebin.com/T2nPNG6e

 

Error log(txt):

http://pastebin.com/TPUdFKCN

 

I hope somebody can help! Thanks!

[TristanvO]

How? I'm using 8 gigs... And I have a beastly computer with 16 GB of memory

[Choonster]

Memory: 886877880 bytes (845 MB) / 1037959168 bytes (989 MB) up to 1037959168 bytes (989 MB)

JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M

 

Minecraft is only configured to use 1 GB. Do you have the

_JAVA_OPTIONS

environment variable set?

[TristanvO]

Yeah, I think so. But this out of memory error never occured before. I changed some code and after changing that code it randomly did occur..?

[Draco18s]

FFS, why do we keep seeing this?

 

        if(ID == mod.guiIDMoriumWorkbench)
        {
            return ID == mod.guiIDMoriumWorkbench //...

 

You already checked the ID, why are you checking it again?

[TristanvO]

I have tried everything for what to put there. I just don't know what to put there, because it gives an error for every thing I put there except that what you see there right now.

[Draco18s]

What you should have is

 

        if(ID == mod.guiIDMoriumWorkbench)
        {
            return ContainerMoriumWorkbench(player.inventory, world, x, y, z);
        }

[TristanvO]

It underlines and gives an error on: ContainerMoriumWorkbench AND GuiMoriumWorkbench. It wants me to create a method for both but of course that won't do anything, it just needs to import is what I would think.

 

package com.tristanvo.mod.gui;

 

import com.tristanvo.mod.mod;

 

import cpw.mods.fml.common.network.IGuiHandler;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.entity.player.InventoryPlayer;

import net.minecraft.tileentity.TileEntity;

import net.minecraft.world.World;

 

public class GuiHandler implements IGuiHandler {

 

@Override

public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {

TileEntity entity = world.getTileEntity(x, y, z);

 

if(ID == mod.guiIDMoriumWorkbench)

{

return ContainerMoriumWorkbench(player.inventory, world, x, y, z);

}

}

@Override

public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {

TileEntity entity = world.getTileEntity(x, y, z);

 

if(ID == mod.guiIDMoriumWorkbench)

{

return GuiMoriumWorkbench(player.inventory, world, x, y, z);

}

}

}

[Draco18s]

oh, sorry, I must have snipped out the "new" keyword by accident.  You should have been able to fix that on your own.

[TristanvO]

Thanks, it doesn't give any error anymore. I could've know indeed haha. But it's still crashing when I'm opening the Gui. It says I'm running out of memory but I never ran out of memory before on Minecraft. So it's still not really fixed. Can you help?

[TristanvO]

It still crashes and freezes when I open my GUI...

[Choonster]

It still crashes and freezes when I open my GUI...

 

If it's running out of memory, I suspect you still have 1 GB assigned; probably from the

_JAVA_OPTIONS

environment variable.

[TristanvO]

First how do I assign more RAM to Minecraft in eclipse then? And secondly, why would it run out of memory when opening a GUI. Why a crash when opening my custom GUI and not when opening the standard crafting table GUI?

[Choonster]

First how do I assign more RAM to Minecraft in eclipse then? And secondly, why would it run out of memory when opening a GUI. Why a crash when opening my custom GUI and not when opening the standard crafting table GUI?

 

The default amount of memory (1.75 GB on my machine) should be fine, but something's limiting the memory to 1 GB with a JVM argument. This is most likely the run configuration in your IDE or an environment variable. If it's the former, delete the JVM arguments. If it's the latter, delete the environment variable.

 

I'm not sure exactly why only your GUI is crashing, perhaps it just uses more memory than the vanilla GUI.

 

I've just noticed that the crash report you linked in the OP doesn't mention your GUI (or any GUI) at all. Could you post the most recent crash report?

 

Edit: Added a missing word.

[TristanvO]

It doesn't give an error log. Minecraft does this:

 

http://picpaste.com/pics/mccrash-CpcSZLeb.1461410878.png

[Choonster]

Try set an exception breakpoint for

OutOfMemoryError

in your IDE's debugger and step through the stack frames. Does anything stand out?

 

Upload your FML log (logs/fml-client-latest.log) to Gist/Pastebin and link it here, it may also contain some useful information.

[TristanvO]

I don't really understand what you are saying but here is the FML log:

http://pastebin.com/mbbQ1fFv

[Choonster]

Breakpoints are part of your IDE's debugger, I suggest you read up on how to use it.

[TristanvO]

I've allocated 8 GB of RAM and the game still crashes.. I couldn't find anything about breakpoints and IDE. Do you know what to do now?

[Choonster]

Post the new FML log.

 

Search the Internet for "how to set breakpoints <your IDE here>", there should be plenty of results.

[TristanvO]

Can you explain what an IDE is, because I don't really know what it is :3.

 

fml log:

http://pastebin.com/KtuLvqxk

[Choonster]

It definitely looks like a memory leak now, there's no way Minecraft should be running out of memory with 8 GB available.

 

IDE stands for Integrated Development Environment, you could have looked this up yourself. Eclipse and IntelliJ IDEA are the two IDEs supported by Forge/ForgeGradle.

[TristanvO]

How to know where exactly to put the breakpoints? I can't find out. Because I guess you can only select breakpoints for certain lines right?

[Choonster]

Normally you'd set a breakpoint in a method related to your issue so you could step through it and see what's going on.

 

In this case, set an exception breakpoint rather than a line breakpoint so execution is paused when an

OutOfMemoryError

is thrown.

[TristanvO]

I can't figure out what exception I want to set a breakpoint on. Something like GuiHandler.java is not an exception but a class.

 

tutorial:

http://help.eclipse.org/mars/index.jsp?topic=%2Forg.eclipse.jdt.doc.user%2Freference%2Fviews%2Fbreakpoints%2Fref-addexception_viewaction.htm