nates1984 Posted April 22, 2016 Share Posted April 22, 2016 Probably silly questions, but asking none-the-less. It has been awhile since I touched Minecraft, and I admit I never became all that familiar with the code base... 1) In preInit(), the old way of registering variant names was ModelBakery.addVariantName(Item, String...) and doesn't seem to work anymore. If I'm following the classes right, it looks like I need to use ModelBakery.registerItemVariants(Item, ResourceLocation...) instead. Is the ResourceLocation equivalent to the ModelResourceLocation() used in init()? That's probably vague... I've included code at end of post... Just some general pointers on how to modify to update from 1.8 to 1.9 would be useful. This is the last error I'm fighting with. 2) GameRegistry.findItem() has deprecated. The popup says: "Use Item.REGISTRY.getValue(ResourceLocation) instead! Look up a mod item in the global "named item list"" Maybe I'm just being dense, but Item.REGISTRY doesn't exist. Item.itemRegistry.getValue() does though. Admittedly, I'm not sure what the global named item list is. Is that the items in ModelBakery.registerVariantNames()? Assuming once I get this sorted out, I the use setRegistryName() as described here in some way: http://www.minecraftforge.net/forum/index.php?topic=38187.0 public class ClientProxy extends CommonProxy { public static Block blockRedstoneAnvil; public void preInit() { blockRedstoneAnvil = new BlockRedstoneAnvil().setUnlocalizedName("redstone_anvil"); //GameRegistry.registerBlock(blockRedstoneAnvil, ItemRedstoneAnvilBlock.class, "redstone_anvil"); GameRegistry.register(blockRedstoneAnvil); Item itemRedstoneAnvilBlock = GameRegistry.findItem("nates1984redstoneanvil", "redstone_anvil"); ModelBakery.addVariantName(itemRedstoneAnvilBlock, "nates1984redstoneanvil:redstone_anvil_intact", "nates1984redstoneanvil:redstone_anvil_slightly_damaged", "nates1984redstoneanvil:redstone_anvil_very_damaged"); } public void init() { Item item = GameRegistry.findItem(Main.MOD_ID, "redstone_anvil"); ModelResourceLocation model = new ModelResourceLocation("nates1984redstoneanvil:redstone_anvil_intact", "inventory"); Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, model); model = new ModelResourceLocation("nates1984redstoneanvil:redstone_anvil_slightly_damaged", "inventory"); Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 1, model); model = new ModelResourceLocation("nates1984redstoneanvil:redstone_anvil_very_damaged", "inventory"); Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 2, model); GameRegistry.addRecipe(new ItemStack(blockRedstoneAnvil), "AAA", "BCB", "CCC", 'A', Blocks.iron_block, 'B', Blocks.redstone_block, 'C', Items.iron_ingot); NetworkRegistry.INSTANCE.registerGuiHandler(Main.instance, new GuiHandler()); } public void postInit() { } } Quote Link to comment Share on other sites More sharing options...
Choonster Posted April 22, 2016 Share Posted April 22, 2016 1) In preInit(), the old way of registering variant names was ModelBakery.addVariantName(Item, String...) and doesn't seem to work anymore. If I'm following the classes right, it looks like I need to use ModelBakery.registerItemVariants(Item, ResourceLocation...) instead. Is the ResourceLocation equivalent to the ModelResourceLocation() used in init()? That's probably vague... I've included code at end of post... Just some general pointers on how to modify to update from 1.8 to 1.9 would be useful. This is the last error I'm fighting with. That is the right method, yes. This tells Minecraft to load the models, you can then tell Minecraft to use these models for your items using ModelLoader.setCustomModelResourceLocation / ModelLoader.setCustomMeshDefinition in preInit (use these instead of ItemModelMesher#register in init). You can use ResourceLocation s or ModelResourceLocation s here (since ModelResourceLocation extends ResourceLocation ), ResourceLocation s will be converted to ModelResourceLocation s with the "inventory" variant. 2) GameRegistry.findItem() has deprecated. The popup says: "Use Item.REGISTRY.getValue(ResourceLocation) instead! Look up a mod item in the global "named item list"" Maybe I'm just being dense, but Item.REGISTRY doesn't exist. Item.itemRegistry.getValue() does though. Admittedly, I'm not sure what the global named item list is. Is that the items in ModelBakery.registerVariantNames()? Item.itemRegistry was renamed to Item.REGISTRY in more recent MCP mappings, use the appropriate name for your current mappings. You can also use ForgeRegistries.ITEMS instead. I suspect the doc comment is a leftover from older versions of Minecraft where blocks and items were stored in arrays indexed by their IDs. Pretty much every singleton class (e.g. Block , Item , BiomeGenBase ) is now stored in a registry. Assuming once I get this sorted out, I the use setRegistryName() as described here in some way: http://www.minecraftforge.net/forum/index.php?topic=38187.0 public class ClientProxy extends CommonProxy { public static Block blockRedstoneAnvil; public void preInit() { blockRedstoneAnvil = new BlockRedstoneAnvil().setUnlocalizedName("redstone_anvil"); //GameRegistry.registerBlock(blockRedstoneAnvil, ItemRedstoneAnvilBlock.class, "redstone_anvil"); GameRegistry.register(blockRedstoneAnvil); Item itemRedstoneAnvilBlock = GameRegistry.findItem("nates1984redstoneanvil", "redstone_anvil"); ModelBakery.addVariantName(itemRedstoneAnvilBlock, "nates1984redstoneanvil:redstone_anvil_intact", "nates1984redstoneanvil:redstone_anvil_slightly_damaged", "nates1984redstoneanvil:redstone_anvil_very_damaged"); } public void init() { Item item = GameRegistry.findItem(Main.MOD_ID, "redstone_anvil"); ModelResourceLocation model = new ModelResourceLocation("nates1984redstoneanvil:redstone_anvil_intact", "inventory"); Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, model); model = new ModelResourceLocation("nates1984redstoneanvil:redstone_anvil_slightly_damaged", "inventory"); Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 1, model); model = new ModelResourceLocation("nates1984redstoneanvil:redstone_anvil_very_damaged", "inventory"); Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 2, model); GameRegistry.addRecipe(new ItemStack(blockRedstoneAnvil), "AAA", "BCB", "CCC", 'A', Blocks.iron_block, 'B', Blocks.redstone_block, 'C', Items.iron_ingot); NetworkRegistry.INSTANCE.registerGuiHandler(Main.instance, new GuiHandler()); } public void postInit() { } } Things like block, item, recipe and IGuiHandler registration must be done on both physical sides (client and dedicated server), so do it in your @Mod class (or a class called from it). Your client proxy should only be doing client-only things like model registration. ItemBlock s are no longer automatically created and registered, you need to do this yourself (as described in the thread you linked). You can use Item.getItemFromBlock to get the ItemBlock form of a Block . You can see how I register my mod's blocks here and my item models (including ItemBlock s) here. Quote Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future. Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.