Search the Forums BEFORE making a new post.

[SOLVED][1.9] Torches reset on world reload

Posted May 17, 20169 yr

In my mod i have colored torches and lanterns, both sharing the same class (basically 3 blocks are sharing this class, the torch, the idle and the active lantern). Now, in the game everything works fine, the torch is placed as intended, as you can see by the image below

But if i close the world and then re-open it, then this happens

all torches are facing the same direction.

This is the class i use

package com.mwcolors.blocks.colors;

import java.util.Iterator;
import java.util.List;
import java.util.Random;

import com.google.common.base.Predicate;
import com.mwcolors.core.MWColoredBlocks;
import com.mwcolors.core.MWColoredModBlocks;
import com.mwcolors.core.MWTabs;

import net.minecraft.block.Block;
import net.minecraft.block.BlockTorch;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.MapColor;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyDirection;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.item.EnumDyeColor;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockRenderLayer;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.text.TextFormatting;
import net.minecraft.util.text.translation.I18n;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class BlockColoredTorch extends BlockTorch {

public static final PropertyEnum<EnumDyeColor> COLOR = PropertyEnum.<EnumDyeColor> create("color",EnumDyeColor.class);

private boolean active;
private boolean lantern;

private EnumFacing facing;
private EnumDyeColor color;

public BlockColoredTorch(boolean active, boolean lantern) {
	super();
	this.setDefaultState(this.blockState.getBaseState().withProperty(FACING, EnumFacing.NORTH).withProperty(COLOR,EnumDyeColor.WHITE));
	this.active = active;
	this.lantern = lantern;
	if (active && lantern)
		this.setCreativeTab((CreativeTabs) null);
	else
		this.setCreativeTab(MWTabs.tabColorsDecoration);
	if (lantern)
		this.setStepSound(SoundType.GLASS);
	else
		this.setStepSound(SoundType.WOOD);
}

/**
 * Gets the metadata of the item this Block can drop. This method is called
 * when the block gets destroyed. It returns the metadata of the dropped
 * item based on the old metadata of the block.
 */
public int damageDropped(IBlockState state) {
	return ((EnumDyeColor) state.getValue(COLOR)).getMetadata();
}

@Override
public Item getItemDropped(IBlockState state, Random rand, int fortune) {
	return this.lantern ? Item.getItemFromBlock(MWColoredModBlocks.colored_lantern_idle)
			: Item.getItemFromBlock(MWColoredModBlocks.colored_flambeau_idle);
}

@Override
public ItemStack getItem(World worldIn, BlockPos pos, IBlockState state) {
	return new ItemStack(getItemDropped(state, new Random(), 0), 1, damageDropped(state));
}

@Override
public void randomDisplayTick(IBlockState worldIn, World pos, BlockPos state, Random rand) {
	if (this.active)
		super.randomDisplayTick(worldIn, pos, state, rand);
}

/**
 * returns a list of blocks with the same ID, but different meta (eg: wood
 * returns 4 blocks)
 */
@SideOnly(Side.CLIENT)
public void getSubBlocks(Item itemIn, CreativeTabs tab, List<ItemStack> list) {
	for (EnumDyeColor enumdyecolor : EnumDyeColor.values()) {
		list.add(new ItemStack(itemIn, 1, enumdyecolor.getMetadata()));
	}
}

/**
 * Get the MapColor for this Block and the given BlockState
 */
public MapColor getMapColor(IBlockState state) {
	return ((EnumDyeColor) state.getValue(COLOR)).getMapColor();
}

/**
 * Convert the given metadata into a BlockState for this Block
 */
public IBlockState getStateFromMeta(int meta) {
	return this.getDefaultState().withProperty(COLOR, EnumDyeColor.byMetadata(meta));
}

/**
 * Convert the BlockState into the correct metadata value
 */
public int getMetaFromState(IBlockState state) {
	return ((EnumDyeColor) state.getValue(COLOR)).getMetadata();
}

protected BlockStateContainer createBlockState() {
	return new BlockStateContainer(this, new IProperty[] { COLOR, FACING });
}

private boolean canPlaceOn(World worldIn, BlockPos pos) {
	IBlockState state = worldIn.getBlockState(pos);
	if (state.isSideSolid(worldIn, pos, EnumFacing.UP)) {
		return true;
	} else {
		return state.getBlock().canPlaceTorchOnTop(state, worldIn, pos);
	}
}

private boolean canPlaceAt(World worldIn, BlockPos pos, EnumFacing facing) {
	BlockPos blockpos = pos.offset(facing.getOpposite());
	boolean flag = facing.getAxis().isHorizontal();
	return flag && worldIn.isSideSolid(blockpos, facing, true)
			|| facing.equals(EnumFacing.UP) && this.canPlaceOn(worldIn, blockpos);
}

/**
 * Called by ItemBlocks just before a block is actually set in the world, to
 * allow for adjustments to the IBlockstate
 */
public IBlockState onBlockPlaced(World worldIn, BlockPos pos, EnumFacing facing, float hitX, float hitY, float hitZ,
		int meta, EntityLivingBase placer) {
	this.color = EnumDyeColor.byMetadata(meta);
	this.facing = facing;
	if (this.canPlaceAt(worldIn, pos, facing)) {
		return this.getDefaultState().withProperty(FACING, facing).withProperty(COLOR,
				EnumDyeColor.byMetadata(meta));
	} else {
		for (EnumFacing enumfacing : EnumFacing.Plane.HORIZONTAL) {
			if (worldIn.isSideSolid(pos.offset(enumfacing.getOpposite()), enumfacing, true)) {
				this.facing = enumfacing;
				return this.getDefaultState().withProperty(FACING, enumfacing).withProperty(COLOR,
						EnumDyeColor.byMetadata(meta));
			}
		}

		return this.getDefaultState();
	}
}


public void onBlockAdded(World worldIn, BlockPos pos, IBlockState state) {
	if (!worldIn.isRemote) {
		if (this.active && this.lantern && worldIn.isBlockIndirectlyGettingPowered(pos) == 0) {
			worldIn.scheduleUpdate(pos, this, 4);
			worldIn.setBlockState(pos, MWColoredModBlocks.colored_lantern_idle.getDefaultState().withProperty(FACING, state.getValue(FACING)).withProperty(COLOR, state.getValue(COLOR)));
		} else if (!this.active && this.lantern && worldIn.isBlockIndirectlyGettingPowered(pos) != 0) {
			worldIn.setBlockState(pos, MWColoredModBlocks.colored_lantern_active.getDefaultState().withProperty(FACING, state.getValue(FACING)).withProperty(COLOR, this.color));
		}
	}
}

/**
 * Called when a neighboring block changes.
 */
public void onNeighborBlockChange(World worldIn, BlockPos pos, IBlockState state, Block neighborBlock) {
	if (!worldIn.isRemote) {
		if (this.active && this.lantern && worldIn.isBlockIndirectlyGettingPowered(pos) == 0) {
			worldIn.scheduleUpdate(pos, this, 4);
			worldIn.setBlockState(pos, MWColoredModBlocks.colored_lantern_idle.getDefaultState().withProperty(FACING, state.getValue(FACING)).withProperty(COLOR, state.getValue(COLOR)));
		} else if (!this.active && this.lantern && worldIn.isBlockIndirectlyGettingPowered(pos) != 0) {
			worldIn.setBlockState(pos, MWColoredModBlocks.colored_lantern_active.getDefaultState().withProperty(FACING, state.getValue(FACING)).withProperty(COLOR, this.color));
		}
	}
}

public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand) {
	if (!worldIn.isRemote) {
		if (this.active && this.lantern && worldIn.isBlockIndirectlyGettingPowered(pos) == 0) {
			worldIn.scheduleUpdate(pos, this, 4);
			worldIn.setBlockState(pos, MWColoredModBlocks.colored_lantern_idle.getDefaultState().withProperty(FACING, state.getValue(FACING)).withProperty(COLOR, state.getValue(COLOR)));
		}
	}
}

@Override
public void addInformation(ItemStack stack, EntityPlayer player, List<String> tooltip, boolean advanced) {
	tooltip.add(TextFormatting.BLUE + I18n.translateToLocal("info.dyed") + ": "
			+ I18n.translateToLocal(EnumDyeColor.byMetadata(stack.getMetadata()).getName()));
}

protected ItemStack createStackedBlock(IBlockState state)
    {
	return  this.lantern ? new ItemStack(MWColoredModBlocks.colored_lantern_idle) : new ItemStack(MWColoredBlocks.colored_torch) ;
    }
}

Thanks in advance for the help

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

May 17, 20169 yr

Author

How can i add this property to that functions?

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

May 17, 20169 yr

Author

Damn, this mean i will have 48 blocks instead of 3 with metas Ok, thanks for the tip, i guess i'll do like this

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

May 17, 20169 yr

48 blocks? No.

You need 5. Every block can have 16 states. 16x5 = 80.

You miscounted slightly, diesieben07.

current: 3 blocks * 16 meta = 48 current states (ignores facing)

desired: 3 blocks * 5 facing * 16 colors = 240 states

Either:

15 blocks with 16 states (different block for each facing; awkward)

16 blocks with 15 states (different block for color/type; weird)

48 blocks (different block for each color AND type, using meta for facing; numerous).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

May 17, 20169 yr

That said, making 14 identical (except for color) blocks is easy.

You just need a generic Block class that takes in the color parameter as part of its constructor and use a loop.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

May 18, 20169 yr

Author

Yes, i said 48 not considering the face property meta (so i just need a single generic class and every color has it's own block and id)

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/38797-solved19-torches-reset-on-world-reload/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Help with file conversion

This is really helpful

By Brialeblanc · 1 hour ago1 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 7 hours ago7 hr
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted 15 hours ago15 hr
New Forum Design/Update: Issues and Suggestions

Unfortunately, it seems that Invision has decided that everything is locked down and no longer customizable.
Their attitude to anyone who wants to edit anything is 'Just accept it we know best and screw you for even insinuating that you want to customize your own site'
So there isn't much we can do about the layout of actual features.
Best bet for the editor is that psudo markdown works, so typing ` around words make code blocks.
Only options is to start writing bespoke modifications to the forum's php code itself, which I really don't want to do.
I would of stayed on v4 but the version of PHP that it supports is going EOL and Invision has stated they have no intentions of upgrading it.
They also removed the central community for finding plugins/community addons.
Overall it is my feeling that they are intentionally trying to kill off self-hosting communities by removing features and locking things down, in an effort to force everyone into using their paid hosting services.

My HOPE is that someone in the overall forum community will write an exporter for Invision to something like SMF. Which is what we were originally on before old team members decided enterprise software is better.

By LexManos · 19 hours ago19 hr
Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · Yesterday at 03:38 AM1 day

Sign In

[SOLVED][1.9] Torches reset on world reload

Featured Replies

Join the conversation

Posts

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

New Forum Design/Update: Issues and Suggestions

Orbital strike cannon fishing rod mod

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)