Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.8.9] Show message and consume item on item right-click


arie2002
 Share

Recommended Posts

Hello!

I am currently developing a mod and I came across an issue that I couldn't seem to solve with a google search. I am trying to show a message to the player when an item is right-clicked, and then remove that item from the player's hand.

 

Currently, this is my code:

package ftgumod.item;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.ChatComponentText;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.World;
import ftgumod.api.TechnologyHandler;
import ftgumod.api.TechnologyUtil;

public class ItemParchmentResearch extends Item {

public ItemParchmentResearch(String name) {
	setUnlocalizedName(name);
	setMaxStackSize(1);
}

public ItemStack onItemRightClick(ItemStack item, World world, EntityPlayer player) {
	String tech = TechnologyUtil.getItemData(item).getString("FTGU");
	if (TechnologyHandler.isResearched(tech, player)) {
		player.addChatMessage(new ChatComponentText(TechnologyHandler.getTechnology(tech).getLocalisedName() + " is already researched"));
	} else {
		TechnologyHandler.putResearched(tech, player);
		player.addChatMessage(new ChatComponentText(TechnologyHandler.getTechnology(tech).getLocalisedName() + " Researched!"));
		item.stackSize--;
	}

	return item;
}

}

The Current problem is that the message appears twice, and that the item reappears a fraction of a second after it was consumed. I'm not sure what to do about this, so I'm asking for help.

I never post on the forums, but when I do, I have no clue how to do a certain thing.

Link to comment
Share on other sites

Only do things on the server side (

world.isRemote

is

false

).

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Only do things on the server side (

world.isRemote

is

false

).

Thanks, that solves one problem. However, the item still doesnt want to disappear...

I never post on the forums, but when I do, I have no clue how to do a certain thing.

Link to comment
Share on other sites

You have an

Item

with a max stack size of 1. Whenever you  right click the

Item

, you remove one from the stack size, resulting an

ItemStack

with a size of 0. Minecraft won't automatically remove stacks with a size of 0 IIRC, so have to return null if the item is consumed.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

You have an

Item

with a max stack size of 1. Whenever you  right click the

Item

, you remove one from the stack size, resulting an

ItemStack

with a size of 0. Minecraft won't automatically remove stacks with a size of 0 IIRC, so have to return null if the item is consumed.

 

Namely because it is unable to do so.  The ItemStack doesn't have a reference to the inventory it is in, and is thereby unable to make itself null.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Here is my configuration: % java -version java version "18.0.2" 2022-07-19 Java(TM) SE Runtime Environment (build 18.0.2+9-61) Java HotSpot(TM) 64-Bit Server VM (build 18.0.2+9-61, mixed mode, sharing) forge-1.19-41.1.0-mdk on macOS Monterey 12.5 I ran the command: ./gradlew genEclipseRuns and was hoping it will generate the Eclipse project files for me. The run log is at https://gist.github.com/arun-gupta/06b983a6976b4c0a0f510d0dc225ddd3 and the generated directory structure is at https://gist.github.com/arun-gupta/3f5bfc70ec5d3d903b0f97d42840abda. In previous versions (1.12-ish), it used to generate an eclipse directory but 1.19 does not seem to have it. I tried opening the top-level forge directory but Eclipse does not recognize it as a project as well. How do I open this project in Eclipse now?  
    • I didn't put in credentials, I used it only for testing installing forge. But still the problem mentioned above.
    • I am trying to use Forge 1.18.2, I have checked my firewall, redownloaded Forge, deleted the fml.toml file (which keeps reappearing) and looked at countless help pages. I am just trying to download and use forge so that I can play with my friends and it will not download. It tells me there may be an issue with the Java runtime config and that the exit code is one, and I have copied the exit code.   
    • Okay, i think i understand but im getting issues, i create another packet to sync entity to another players like this package com.naim.belloto.networking.packet; import com.naim.belloto.networking.handler.ClientSyncHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.FriendlyByteBuf; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.fml.DistExecutor; import net.minecraftforge.network.NetworkEvent; import java.util.Objects; import java.util.function.Supplier; public class ClientSyncPacket { public ClientSyncPacket() { } public ClientSyncPacket(FriendlyByteBuf buf) { } public void toBytes(FriendlyByteBuf buf) { } public boolean handle(Supplier<NetworkEvent.Context> ctx) { NetworkEvent.Context context = ctx.get(); context.enqueueWork(() -> { assert Minecraft.getInstance().player != null; int idplayer = Minecraft.getInstance().player.getId(); DistExecutor.unsafeCallWhenOn(Dist.CLIENT,() -> () -> ClientSyncHandler.handlePacket(ctx, idplayer)); }); return true; } } And in the handler: public class ClientSyncHandler { public static boolean handlePacket(Supplier<NetworkEvent.Context> ctx, int idPlayer) { Minecraft.getInstance().level.getEntity(idPlayer); return true; } } But is not working :// 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.