[1.8.9] Show message and consume item on item right-click

[arie2002]

Hello!

I am currently developing a mod and I came across an issue that I couldn't seem to solve with a google search. I am trying to show a message to the player when an item is right-clicked, and then remove that item from the player's hand.

 

Currently, this is my code:

package ftgumod.item;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.ChatComponentText;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.World;
import ftgumod.api.TechnologyHandler;
import ftgumod.api.TechnologyUtil;

public class ItemParchmentResearch extends Item {

public ItemParchmentResearch(String name) {
	setUnlocalizedName(name);
	setMaxStackSize(1);
}

public ItemStack onItemRightClick(ItemStack item, World world, EntityPlayer player) {
	String tech = TechnologyUtil.getItemData(item).getString("FTGU");
	if (TechnologyHandler.isResearched(tech, player)) {
		player.addChatMessage(new ChatComponentText(TechnologyHandler.getTechnology(tech).getLocalisedName() + " is already researched"));
	} else {
		TechnologyHandler.putResearched(tech, player);
		player.addChatMessage(new ChatComponentText(TechnologyHandler.getTechnology(tech).getLocalisedName() + " Researched!"));
		item.stackSize--;
	}

	return item;
}

}

The Current problem is that the message appears twice, and that the item reappears a fraction of a second after it was consumed. I'm not sure what to do about this, so I'm asking for help.

[larsgerrits]

Only do things on the server side (

world.isRemote

is

false

).

[arie2002]

Only do things on the server side (

world.isRemote

is

false

).

Thanks, that solves one problem. However, the item still doesnt want to disappear...

[larsgerrits]

You have an

Item

with a max stack size of 1. Whenever you  right click the

Item

, you remove one from the stack size, resulting an

ItemStack

with a size of 0. Minecraft won't automatically remove stacks with a size of 0 IIRC, so have to return null if the item is consumed.

[Draco18s]

You have an

Item

with a max stack size of 1. Whenever you  right click the

Item

, you remove one from the stack size, resulting an

ItemStack

with a size of 0. Minecraft won't automatically remove stacks with a size of 0 IIRC, so have to return null if the item is consumed.

 

Namely because it is unable to do so.  The ItemStack doesn't have a reference to the inventory it is in, and is thereby unable to make itself null.