Jump to content

[1.8.9] Show message and consume item on item right-click


arie2002

Recommended Posts

Hello!

I am currently developing a mod and I came across an issue that I couldn't seem to solve with a google search. I am trying to show a message to the player when an item is right-clicked, and then remove that item from the player's hand.

 

Currently, this is my code:

package ftgumod.item;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.ChatComponentText;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.World;
import ftgumod.api.TechnologyHandler;
import ftgumod.api.TechnologyUtil;

public class ItemParchmentResearch extends Item {

public ItemParchmentResearch(String name) {
	setUnlocalizedName(name);
	setMaxStackSize(1);
}

public ItemStack onItemRightClick(ItemStack item, World world, EntityPlayer player) {
	String tech = TechnologyUtil.getItemData(item).getString("FTGU");
	if (TechnologyHandler.isResearched(tech, player)) {
		player.addChatMessage(new ChatComponentText(TechnologyHandler.getTechnology(tech).getLocalisedName() + " is already researched"));
	} else {
		TechnologyHandler.putResearched(tech, player);
		player.addChatMessage(new ChatComponentText(TechnologyHandler.getTechnology(tech).getLocalisedName() + " Researched!"));
		item.stackSize--;
	}

	return item;
}

}

The Current problem is that the message appears twice, and that the item reappears a fraction of a second after it was consumed. I'm not sure what to do about this, so I'm asking for help.

I never post on the forums, but when I do, I have no clue how to do a certain thing.

Link to comment
Share on other sites

Only do things on the server side (

world.isRemote

is

false

).

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Only do things on the server side (

world.isRemote

is

false

).

Thanks, that solves one problem. However, the item still doesnt want to disappear...

I never post on the forums, but when I do, I have no clue how to do a certain thing.

Link to comment
Share on other sites

You have an

Item

with a max stack size of 1. Whenever you  right click the

Item

, you remove one from the stack size, resulting an

ItemStack

with a size of 0. Minecraft won't automatically remove stacks with a size of 0 IIRC, so have to return null if the item is consumed.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

You have an

Item

with a max stack size of 1. Whenever you  right click the

Item

, you remove one from the stack size, resulting an

ItemStack

with a size of 0. Minecraft won't automatically remove stacks with a size of 0 IIRC, so have to return null if the item is consumed.

 

Namely because it is unable to do so.  The ItemStack doesn't have a reference to the inventory it is in, and is thereby unable to make itself null.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I want to download Forge 1.20.6, but when I press download, it redirects me to Adfocus and does not provide any download. I have never encountered such a problem when I downloaded Forge 1.18.2 at least 12 months ago.
    • did you find any solutions? i have the same problem and also that mahito doesnt transform
    • Here's a simple example to solve this particular issue: public class ModArmorMaterials { public static final DeferredRegister<ArmorMaterial> ARMORS = DeferredRegister.create(Registries.ARMOR_MATERIAL, MyModName.MOD_ID); public static final RegistryObject<ArmorMaterial> COPPER = registerArmor("copper", Util.make(new EnumMap<>(ArmorItem.Type.class), enumMap -> { enumMap.put(ArmorItem.Type.BOOTS, 1); enumMap.put(ArmorItem.Type.LEGGINGS, 4); enumMap.put(ArmorItem.Type.CHESTPLATE, 5); enumMap.put(ArmorItem.Type.HELMET, 2); enumMap.put(ArmorItem.Type.BODY, 4); }), 12, SoundEvents.ARMOR_EQUIP_IRON, 0.0F, 0.0F, () -> Ingredient.of(Items.COPPER_INGOT)); private static RegistryObject<ArmorMaterial> registerArmor(String pGroup, EnumMap<ArmorItem.Type, Integer> pEnumMap, int pEnchantmentValue, Holder<SoundEvent> pEquipSound, float pToughness, float pKnockbackResistance, Supplier<Ingredient> pRepairIngredient) { List<ArmorMaterial.Layer> pLayerList = List.of(new ArmorMaterial.Layer(new ResourceLocation(pGroup))); return registerArmor(pGroup, pEnumMap, pEnchantmentValue, pEquipSound, pToughness, pKnockbackResistance, pRepairIngredient, pLayerList); } private static RegistryObject<ArmorMaterial> registerArmor( String pGroup, EnumMap<ArmorItem.Type, Integer> pEnumMap, int pEnchantmentValue, Holder<SoundEvent> pEquipSound, float pToughness, float pKnockbackResistance, Supplier<Ingredient> pRepairIngredient, List<ArmorMaterial.Layer> pLayerList) { return ARMORS.register(pGroup, () -> new ArmorMaterial(pEnumMap, pEnchantmentValue, pEquipSound, pRepairIngredient, pLayerList, pToughness, pKnockbackResistance)); } public static void register(IEventBus eventBus) { ARMORS.register(eventBus); } } Essentially, the TierSortingRegistry has been removed and so you now need to set up your own DeferredRegister. Please see the minecraftforge GitHub for more information; I found this solution through their issues (https://github.com/MinecraftForge/MinecraftForge/issues/9961)
    • How did I even leave that in there? I’ll try it in a bit, that very well could be it.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.