[1.9.4][SOLVED] canBlockSeeSky Only Returns False

[Tikaji]

I'm attempting to use canBlockSeeSky() from the World class. However, it will only return false. Is there something else that I should be using to check if a block can see the sky?

 

This is being done in the tile entity for the block. Perhaps I should be doing this check else where?

 

 

import com.tikaji.powerpylons.types.GeneratorType;

import com.tikaji.powerpylons.utility.LogHelper;

 

public class TileEntitySolarGenerator extends TileEntityGenerator

{

public TileEntitySolarGenerator()

{

super(GeneratorType.SOLAR);

}

 

@Override

public void update()

{

if (!worldObj.isRemote)

{

if (worldObj.isDaytime())

{

LogHelper.info(worldObj.canBlockSeeSky(pos));

if (worldObj.canSeeSky(pos))

{

LogHelper.info("GOT HERE");

storage.modifyEnergyStored(type.getGenerationRate());

LogHelper.info("ENERGY: " + storage.getEnergyStored());

}

}

}

}

}

 

 

 

If you need anything else to help diagnose the problem, please ask.

 

And thanks for any help!

[Tikaji]

I'm attempting to use canBlockSeeSky() from the World class. However, it will only return false. Is there something else that I should be using to check if a block can see the sky?

 

This is being done in the tile entity for the block. Perhaps I should be doing this check else where?

 

 

import com.tikaji.powerpylons.types.GeneratorType;

import com.tikaji.powerpylons.utility.LogHelper;

 

public class TileEntitySolarGenerator extends TileEntityGenerator

{

public TileEntitySolarGenerator()

{

super(GeneratorType.SOLAR);

}

 

@Override

public void update()

{

if (!worldObj.isRemote)

{

if (worldObj.isDaytime())

{

LogHelper.info(worldObj.canBlockSeeSky(pos));

if (worldObj.canSeeSky(pos))

{

LogHelper.info("GOT HERE");

storage.modifyEnergyStored(type.getGenerationRate());

LogHelper.info("ENERGY: " + storage.getEnergyStored());

}

}

}

}

}

 

 

 

If you need anything else to help diagnose the problem, please ask.

 

And thanks for any help!

[Draco18s]

Do the check from pos.up() instead.  The method looks at the block at pos and if it is not transparent, it return false.

[Draco18s]

Do the check from pos.up() instead.  The method looks at the block at pos and if it is not transparent, it return false.

[Tikaji]

That would do it! Thank you for that! I just assumed that this function took this into account, guess not.

[Tikaji]

That would do it! Thank you for that! I just assumed that this function took this into account, guess not.

[Draco18s]

That would do it! Thank you for that! I just assumed that this function took this into account, guess not.

 

Nope.  It assumes that the block pos being checked must itself be transparent.  I'm sure there's a good reason (it makes sense after the fact, but as for the decision process, I am not sure).

 

Was something I discovered myself back in 1.7.10

[Draco18s]

That would do it! Thank you for that! I just assumed that this function took this into account, guess not.

 

Nope.  It assumes that the block pos being checked must itself be transparent.  I'm sure there's a good reason (it makes sense after the fact, but as for the decision process, I am not sure).

 

Was something I discovered myself back in 1.7.10

[jeffryfisher]

Here's how BlockGrass did its updateTick in 1.8 (several dot-up calls, but using neighbor light instead of seeing sky for some reason):

 

   public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand)
    {
        if (!worldIn.isRemote)
        {
            if (worldIn.getLightFromNeighbors(pos.up()) < 4 && worldIn.getBlockState(pos.up()).getBlock().getLightOpacity(worldIn, pos.up()) > 2)
            {
                worldIn.setBlockState(pos, Blocks.dirt.getDefaultState());
            }
            else
            {
                if (worldIn.getLightFromNeighbors(pos.up()) >= 9)
                {
                    for (int i = 0; i < 4; ++i)
                    {
                        BlockPos blockpos1 = pos.add(rand.nextInt(3) - 1, rand.nextInt(5) - 3, rand.nextInt(3) - 1);
                        Block block = worldIn.getBlockState(blockpos1.up()).getBlock();
                        IBlockState iblockstate1 = worldIn.getBlockState(blockpos1);

                        if (iblockstate1.getBlock() == Blocks.dirt && iblockstate1.getValue(BlockDirt.VARIANT) == BlockDirt.DirtType.DIRT && worldIn.getLightFromNeighbors(blockpos1.up()) >= 4 && block.getLightOpacity(worldIn, blockpos1.up()) <= 2)
                        {
                            worldIn.setBlockState(blockpos1, Blocks.grass.getDefaultState());
                        }
                    }
                }
            }
        }
    }

[jeffryfisher]

Here's how BlockGrass did its updateTick in 1.8 (several dot-up calls, but using neighbor light instead of seeing sky for some reason):

 

   public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand)
    {
        if (!worldIn.isRemote)
        {
            if (worldIn.getLightFromNeighbors(pos.up()) < 4 && worldIn.getBlockState(pos.up()).getBlock().getLightOpacity(worldIn, pos.up()) > 2)
            {
                worldIn.setBlockState(pos, Blocks.dirt.getDefaultState());
            }
            else
            {
                if (worldIn.getLightFromNeighbors(pos.up()) >= 9)
                {
                    for (int i = 0; i < 4; ++i)
                    {
                        BlockPos blockpos1 = pos.add(rand.nextInt(3) - 1, rand.nextInt(5) - 3, rand.nextInt(3) - 1);
                        Block block = worldIn.getBlockState(blockpos1.up()).getBlock();
                        IBlockState iblockstate1 = worldIn.getBlockState(blockpos1);

                        if (iblockstate1.getBlock() == Blocks.dirt && iblockstate1.getValue(BlockDirt.VARIANT) == BlockDirt.DirtType.DIRT && worldIn.getLightFromNeighbors(blockpos1.up()) >= 4 && block.getLightOpacity(worldIn, blockpos1.up()) <= 2)
                        {
                            worldIn.setBlockState(blockpos1, Blocks.grass.getDefaultState());
                        }
                    }
                }
            }
        }
    }

[Draco18s]

(several dot-up calls, but using neighbor light instead of seeing sky for some reason)

 

Light values are cached, seeing sky requires iterating over the entire column of blocks to make sure they are all air/non-solid.

[Draco18s]

(several dot-up calls, but using neighbor light instead of seeing sky for some reason)

 

Light values are cached, seeing sky requires iterating over the entire column of blocks to make sure they are all air/non-solid.