Jump to content

Recommended Posts

Posted

Hi,

 

I've got some huge problems with my entity. It just "lags" when moving. So you can see that it moves, stops and then starts moving again.

 

                EntityMy my= (EntityMy ) entity;
                
                double speed = (double)((this.getSize() + my.getSize()) * 5.5f);
                if(distanceSqrt < speed && distanceSqrt > .1d) {
                    this.motionX += -moveX / distanceSqrt / (double) speed * (my.getSize() / 75.d);
                    this.motionY += -moveY / distanceSqrt / (double) speed * (my.getSize() / 75.d);
                    this.motionZ += -moveZ / distanceSqrt / (double) speed * (my.getSize() / 75.d);
                } 

This is the code for the movement. It is part of the moveNearbyEntity() method which handles all movement of surrounding entities and the

entity itself.

 

And in the update method I'm calling this:

        this.moveNearbyEntity();
        if(this.motionX != .0d || this.motionY != .0d || this.motionZ != .0d) {
            this.motionX *= .6d;
            this.motionY *= .6d;
            this.motionZ *= .6d;
            super.moveEntity(this.motionX, this.motionY, this.motionZ);
        }

 

Here is the part where I get the moveXYZ and distanceSqr values:

            double moveX = (this.posX + .5d) - (entity.posX + .5d);
            double moveY = (this.posY + .5d) - (entity.posY + .5d);
            double moveZ = (this.posZ + .5d) - (entity.posZ + .5d);
            
            double distanceSqrt = Math.sqrt(moveX * moveX + moveY * moveY + moveZ * moveZ);

It is done with the entity object and not the my object because it's used for all movement. And modifying the movement of other entities works fine with that code.

 

So what am I doing wrong?

 

Thx in advance.

Bektor

Developer of Primeval Forest.

Posted

EntityRegistry.registerModEntity(EntityMy.class, "My", 0, PrimevalForest.instance, 150, 3, true, 0x000001, 0x00ff0f);

 

EntityMy extends Entity

 

Oh and it's not moving really fast. I can move faster. :P

Developer of Primeval Forest.

Posted

Your velocity updates is 3. To give you perspective, a squid has 10 and an arrow has 20. Your tracking range is 150, and a normal vanilla mob's is 80.

Even with the values 20 for velocity updates  and 80 for tracking range it is so "laggy".

Developer of Primeval Forest.

Posted

Hi,

 

I've got some huge problems with my entity. It just "lags" when moving. So you can see that it moves, stops and then starts moving again.

 

                EntityMy my= (EntityMy ) entity;
                
                double speed = (double)((this.getSize() + my.getSize()) * 5.5f);
                if(distanceSqrt < speed && distanceSqrt > .1d) {
                    this.motionX += -moveX / distanceSqrt / (double) speed * (my.getSize() / 75.d);
                    this.motionY += -moveY / distanceSqrt / (double) speed * (my.getSize() / 75.d);
                    this.motionZ += -moveZ / distanceSqrt / (double) speed * (my.getSize() / 75.d);
                } 

This is the code for the movement. It is part of the moveNearbyEntity() method which handles all movement of surrounding entities and the

entity itself.

 

And in the update method I'm calling this:

        this.moveNearbyEntity();
        if(this.motionX != .0d || this.motionY != .0d || this.motionZ != .0d) {
            this.motionX *= .6d;
            this.motionY *= .6d;
            this.motionZ *= .6d;
            super.moveEntity(this.motionX, this.motionY, this.motionZ);
        }

 

Here is the part where I get the moveXYZ and distanceSqr values:

            double moveX = (this.posX + .5d) - (entity.posX + .5d);
            double moveY = (this.posY + .5d) - (entity.posY + .5d);
            double moveZ = (this.posZ + .5d) - (entity.posZ + .5d);
            
            double distanceSqrt = Math.sqrt(moveX * moveX + moveY * moveY + moveZ * moveZ);

It is done with the entity object and not the my object because it's used for all movement. And modifying the movement of other entities works fine with that code.

 

So what am I doing wrong?

 

Thx in advance.

Bektor

 

Are you performing these operations (setting new motion) on server, on client, or on both? I encountered similar problem, try moving this logic (setting motion) on server.

Blockbuster – simple machinimas and cinematics for Minecraft
Posted

If you modify the motion server side then yes, it's gonna be a big jaggy.

But why is it so?

I mean the server has to send the changes to the client and not the client to the server. Then every entity could move in a different direction on a server. So PlayerA sees the Entity moving south while PlayerB sees the entity moving north --> Server should handle entity movement.

 

I mean, it makes no sense....

And even when I do it client side, I still have to send a custom packet to the client which tells that the entity motion should changed.

EDIT: And isn't the movement of other entities in Minecraft also done server-side?

Developer of Primeval Forest.

Posted

Movement is calculated both client side and server side, provided that the mobs are making the same decisions.

 

Why?

 

Because the server is in control, but the update frequency and packet delay results in laggy, disjointed movement.

So it's calculated on the client too for interpolation.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Movement is calculated both client side and server side, provided that the mobs are making the same decisions.

 

Why?

 

Because the server is in control, but the update frequency and packet delay results in laggy, disjointed movement.

So it's calculated on the client too for interpolation.

So what need I to do to get it working correctly on my mod?

Developer of Primeval Forest.

Posted

Do it on both sides.

So I have to send a packet to the client with the values and in the onMessage method I have to apply them to the motion value?

 

EDIT: if I would know how to get access to the entity in a packet

Developer of Primeval Forest.

Posted

How does the server know when to apply the motion?

hm, no idea. I just have the onUpdate method and add a value to the motion, then multiply it by .8 and call super.moveEntity().

And add only motion when the boolean in the if statement is true, so when a specific entity is nearby.

Developer of Primeval Forest.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.