Jump to content
Currently supported: All versions

Make Packet1Login fully vanilla compatible

Doridian

By Doridian
in Suggestions

 Share

Recommended Posts

Doridian Tree Puncher

Doridian

Posted
Posted

I am, or rather was, trying to use BungeeCord as a Proxy for modded and non-modded servers alike.

The issue is only Packet1Login which Forge modifies.

Couldn't it just be modded so it sends the int dimension in a Packet250PluginMessage to not break vanilla protocol compatibility (and therefor allow proxies like BungeeCord to work seemlessly)?

LexManos Reality Controller

LexManos

Posted
Posted

Sadly, We can't as that would break things quite a bit with multiple dimensions and the like.

There is a reason why we have the sanity check when connecting to make sure that the client has Forge installed.

However, its fairly simple on there end to add support for the differences {IIRC its only this one thing}

I'm sure md_5 would be willing to do it :P

 

 

We don't like breaking compatibility here, but we do it in a clean way that we hope eventually we wont have to do.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Doridian Tree Puncher

Doridian

Posted
  • Author
Posted

You don't have to break compatibility here!

Just send a Packet250 with the actual dimension and then send Packet1Login with some random dimension, then edit it into the thing (like make a static field in NetClientHandler that sets the dimension of Packet1Login, rather than reading it from the wire in there).

Wouldn't be a lot of lines of code really...

LexManos Reality Controller

LexManos

Posted
Posted

Short answer is we're not gunna hack a walrus into the room to address the wobbely table.

We would have to figure a way to delay the creation of the world until we get the proper id, basically, this is a bitch.

Its not hard for the proxy to deal with, and if MC used a proper packet header it'd be a different issue :P

Its a non-issue, nothing that you'd be concerned with.

 

Basically, things are going to stay.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Guest
This topic is now closed to further replies.
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Crossback
      mouseclicked event handler

      By Crossback · Posted

      Different problem now. https://paste.ee/p/iDo8lS35
    • NightAnasazi
      LootItemCondition (when mod is loaded) - showing error "Couldn't parse element"

      By NightAnasazi · Posted

      I would like to have a BoP sapling drop from my block if it is also installed. I think I have done everything and I cannot pinpoint the problem, which is the error in the logs that appears when joining a world:   [Worker-Main-11/ERROR] [ne.mi.co.ForgeHooks/]: Couldn't parse element loot_tables:grasses:blocks/leaves_block com.google.gson.JsonSyntaxException: Expected name to be an item, was unknown string 'biomesoplenty:magic_sapling' My code:   LootItemConditions.CONDITIONS.register(modEventBus); public class LootItemConditions { public static final DeferredRegister<LootItemConditionType> CONDITIONS = DeferredRegister.create(Registries.LOOT_CONDITION_TYPE, Grasses.MOD_ID); public static final RegistryObject<LootItemConditionType> IS_MOD_LOADED = CONDITIONS.register("is_mod_loaded", () -> new LootItemConditionType(new IsModLoaded.ConditionSerializer())); } public class IsModLoaded implements LootItemCondition { private final boolean exists; private final String modID; public IsModLoaded(String modID) { this.exists = ModList.get().isLoaded(modID); this.modID = modID; } @Override public LootItemConditionType getType() { return LootItemConditions.IS_MOD_LOADED.get(); } @Override public boolean test(LootContext context) { return this.exists; } public static LootItemCondition.Builder builder(String modid) { return () -> new IsModLoaded(modid); } public static class ConditionSerializer implements Serializer<IsModLoaded> { @Override public void serialize(JsonObject json, IsModLoaded instance, JsonSerializationContext ctx) { json.addProperty("modid", instance.modID); } @Override public IsModLoaded deserialize(JsonObject json, JsonDeserializationContext ctx) { return new IsModLoaded(GsonHelper.getAsString(json, "modid")); } } } protected LootTable.Builder createLeavesDropsWithModIDCheck(Block selfBlock, Item sapling, Property<?>[] properties, String modIDToCheck, float... chances) { CopyBlockState.Builder blockStateCopyBuilder = CopyBlockState.copyState(selfBlock); for(Property<?> property : properties) { blockStateCopyBuilder.copy(property); } return LootTable.lootTable() .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(LootItem.lootTableItem(selfBlock) .when(HAS_SHEARS_OR_SILK_TOUCH) .apply(blockStateCopyBuilder))) .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionCondition(selfBlock, LootItem.lootTableItem(sapling)) .when(IsModLoaded.builder(modIDToCheck))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, chances)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH)) .withPool(LootPool.lootPool().name("sticks").setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionDecay(selfBlock, LootItem.lootTableItem(Items.STICK). apply(SetItemCountFunction.setCount(UniformGenerator.between(1.0F, 2.0F)))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, NORMAL_LEAVES_STICK_CHANCES)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH))); } I don't know. Am I making a mistake somewhere? Am I forgetting something? Should there be something else?
    • TileEntity
      mouseclicked event handler

      By TileEntity · Posted

      Remove vanquisher_spirit
    • Crossback
      mouseclicked event handler

      By Crossback · Posted

      https://paste.ee/p/h1JX9bbl
    • TileEntity
      mouseclicked event handler

      By TileEntity · Posted

      Add the latest.log from your logs-folder

  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept