recompile bug on mac in build 6.4.1.436

[Gloombone]

1)

I downloaded the latest forge, at the time of writing this it was:

Build 6.4.1.436: 2012-12-10 15:59:55 for MC: 1.4.5

 

2)

Read the readme which wasn't very clear on the area of MCP it both stats it includes it self but also that it should be placed in the MCP folder?

continued without placing it in a MCP folder.

 

3)

chmod +x install.sh

 

4)

./install.sh

 

which ended in a failed recompile. se log below for further details

 

http://pastebin.com/V9WkzT6N

 

Let me know if I should try something different - will try it while it's in an MCP folder later tonight.

[LexManos]

!! reformating disabled due to no astyle or config !!

You MUST have astyle.

I'll eventually get around to detecting it missing and throwing a major error

[Gloombone]

It is missing execution flag for the astyle-osx command that mcp is supplying.

unzipping the mcp zip manually sets the execution flag for runtime/bin/astyle-osx correctly.

 

[Gloombone]

To be more clear, I have previously been able to run the ./install.sh script from forge - before forge was changed to download mcp by it self.

This was due to the fact that mcp actually includes the astyle-osx in it's runtime/bin directory.

 

So it is not a matter of detecting it nor throwing an error - but just make sure it has the execute flag, the mcp zip does have this flag configured but somehow forge doesn't respect this when unpacking it, so my guess without having looking into the code that handles the unpacking is that the problem is a missing parameter or similar on the call to unzip.

[LexManos]

I looked into it, it appears that pythons unzip function does not set execution flags.

I'll have to write a case to run chmod on things post decompile.

[Gloombone]

Have just testet it with the latest build minecraftforge-src-1.4.5-6.4.1.437 and it seems like it have been fixed, thank you very much for fixing this so quickly! you are a champ