Jump to content

Recommended Posts

Posted

I'm working on a magic-mod in Scala.  While it's taken me a long time to get up to speed on ye ole minecraft APIs, I just realized that perhaps a lot of things I'm doing should be exposed as capabilities (or could be better expressed as such).

 

There is on particular sticking point:  Right now,

Capability

instances are injected to static final values.  Scala isn't really friendly with static variables (prefering object instances instead).

 

So, would the minecraft forge folks be ammenable to some kind of "Lookup capability" (NOT implemented via injection) that I can hide behind some scala, like:

 

object MyMod {
    lazy val MyCapability = Capabilties.INSTANCE.lookUp(CapabilityName)
}

 

Alternatively, could we adapt the injection code to allow scala objects?  While (unfortunately) there's no marker trait for these, you can detect them via these assumptions:

 

  • The class name ends with
    $


  • The class name contains a single static field called
    MODULE$


 

Does anyone know of any mechanism I could use to implement capabilities in Scala?  I'm specifically trying to attach data to player entities, and Capabilities seem like the "right" way to do it, vs. the random hackery I'm using now.

Posted

Yes, I understand the benefits of private static final in the JVM.  It's not really an option for Scala (until 2.12) as there is no way to generate static fields.

 

I did find a workaround though, I can define the private final field in a Java file and expose everything I need to scala.  I had thought the inject annotation wouldn't work unless the field was defined in the mod, which is not, apparently, the case.

 

Sorry for the noise!

Posted

Quick question though, what kind of inline behavior are you expecting from the Capabilities?  I'm not really positive the current usage is being optimized in the way you suggested, but I'd love to learn if the JVM is more clever than I suspect!

Posted

No, we're not gunna special case scala. Stop using stupid code.

You can do normal java along with scala just deal with it.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Posted

Wow, uh thanks.  I'd ask what code is stupid, but I assume you mean all Scala.  I'm happy to use the Java APIs, I was just curious on this one, as it's the only instance so far I've found where there was any deviation at all (and kudos for how amazing forge is, it's been a breeze getting started in Scala).

 

I was able to craft some scala with the annotation on my singleton instance, but unfortunately it's not injected.

 

import scala.annotation.meta.field
type ScalaCapabilityInject = CapabilityInject @field
@ScalaCapabilityInject(classOf[PlayerWaypoints])
private final val Cap: Capability[PlayerWaypoints] = null

 

I validated the bytecode has the annotation appropriately, but it's probably something silly which is not letting the ASM table find it.  Oh well.

 

For now I have a workaround that's fine.  I'll just have one Java file to test all my capabilities.

 

I'm still a bit confused by the Capability "Factory" though, so I'll start a new thread for that. 

 

I'll mark this closed (or does a mod do that?)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Oh I forgot to update the title. I figured out the issue and I'm rather embarrassed to say that it was a file path issue. The game already knew I was accessing the achievements so I wasn't suppose to include advancements in the file path. Minecraft file paths have always confused me a little bit... ResourceLocation advancementId = new ResourceLocation( TheDeadRise.MODID,"adventure/spawntrigger");
    • Can someone help my with this? My forge server won't open and I'm not that good with this stuff. It gave me this error message:   C:\Users\apbeu\Desktop\Forge server>java -Xmx4G -Xms1G -jar server.jar nogui 2024-12-11 18:21:01,054 main WARN Advanced terminal features are not available in this environment [18:21:01] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--gameDir, ., --launchTarget, fmlserver, --fml.forgeVersion, 36.2.34, --fml.mcpVersion, 20210115.111550, --fml.mcVersion, 1.16.5, --fml.forgeGroup, net.minecraftforge, nogui] [18:21:01] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 8.1.3+8.1.3+main-8.1.x.c94d18ec starting: java version 21.0.4 by Oracle Corporation Exception in thread "main" java.lang.IllegalAccessError: class cpw.mods.modlauncher.SecureJarHandler (in unnamed module @0x402e37bc) cannot access class sun.security.util.ManifestEntryVerifier (in module java.base) because module java.base does not export sun.security.util to unnamed module @0x402e37bc         at cpw.mods.modlauncher.SecureJarHandler.lambda$static$1(SecureJarHandler.java:45)         at cpw.mods.modlauncher.api.LamdbaExceptionUtils.uncheck(LamdbaExceptionUtils.java:95)         at cpw.mods.modlauncher.SecureJarHandler.<clinit>(SecureJarHandler.java:45)         at cpw.mods.modlauncher.Launcher.lambda$new$6(Launcher.java:55)         at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)         at cpw.mods.modlauncher.api.TypesafeMap.computeIfAbsent(TypesafeMap.java:52)         at cpw.mods.modlauncher.api.TypesafeMap.computeIfAbsent(TypesafeMap.java:47)         at cpw.mods.modlauncher.Environment.computePropertyIfAbsent(Environment.java:62)         at cpw.mods.modlauncher.Launcher.<init>(Launcher.java:55)         at cpw.mods.modlauncher.Launcher.main(Launcher.java:66)         at net.minecraftforge.server.ServerMain$Runner.runLauncher(ServerMain.java:63)         at net.minecraftforge.server.ServerMain$Runner.access$100(ServerMain.java:60)         at net.minecraftforge.server.ServerMain.main(ServerMain.java:57) C:\Users\apbeu\Desktop\Forge server>pause
    • Here is the url for the crash report if anyone can help me, please. https://mclo.gs/KGn5LWy  
    • Every single time I try and open my modpack it crashes before the game fully opens and I don't know what is wrong. I open the crash logs but I don't understand what any of it means. What do I do?
    • Hey, sorry I haven't said anything in a while. I was banned on here for sending you straight up crash logs and they banned me for spam... but I learned that these forums are for forge only and I was working with neoforge... but thank you for all the help.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.