[1.8][!SOLVED!] Forge || Problem with blocks

[Lyras]

Hey folks,

 

I've got a problem in my project that I can't fix:

 

package utils;

import java.io.File;
import java.util.ArrayList;

import handler.InputHandler;
import net.minecraft.block.Block;
import net.minecraft.client.Minecraft;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumParticleTypes;
import net.minecraftforge.common.config.Configuration;

public class Marker {

private static File route = null;

public static void setRoute ( File file ) { route = file; }

/**
 * This method gets used when the player starts riding
 * with this method, I can markup the blocks of the loaded route by sending
 * particle packages to the player
 * @param bool The boolean witch I use for my loop
 */
public static void markupWay ( boolean bool ) {

	if ( route != null ) { route = InputHandler.route; }

	Configuration config = new Configuration ( route );

	if ( bool ) {

		/* Goes through all block objects in the list... */
		for ( Block block : getBlocksNearby( Minecraft.getMinecraft().thePlayer , 10 ) ) {

			for ( int i = 0; i < RouteReader.getMarkerPoints( config ); i++ ) {

				/* ... and if the x-coord is equal to an value in the config... */
				if ( config.get( "posX" , i + ":" , 0 ).getInt() == ( int ) block.getBlockBoundsMaxX() ) {

					/* ... and if the y-coord is equal to an value in the config... */
					if ( config.get( "posY" , i + ":" , 0 ).getInt() == ( int ) block.getBlockBoundsMaxY() ) {

						/* ... and if the z-coord is equal to an value in the config... */
						if ( config.get( "posZ" , i + ":" , 0 ).getInt() == ( int ) block.getBlockBoundsMaxZ() ) {

							/* Then I will send particles at the blocks position */
							Minecraft.getMinecraft().thePlayer.worldObj.spawnParticle( EnumParticleTypes.REDSTONE ,
									                       ( ( block.getBlockBoundsMaxX() + block.getBlockBoundsMinX() ) / 2 ) ,
									                       ( ( block.getBlockBoundsMaxY() + block.getBlockBoundsMinY() ) / 2 ) ,
									                       ( ( block.getBlockBoundsMaxZ() + block.getBlockBoundsMinZ() ) / 2 ) ,
									                       0.3 , 0.3 , 0.3 );

						}

					}

				}

			}

		}
		//TODO Test if block is in list
		//send particle
		markupWay( bool );

	}

}

public static ArrayList < Block > getBlocksNearby ( Entity player , int radius ) {

	ArrayList < Block > list = new ArrayList < Block > ();

	for ( int x = ( int ) player.posX - radius; x <= ( int ) player.posX + radius; x++ ) {

		for ( int y = ( int ) player.posY - radius; y <= ( int ) player.posY + radius; y++ ) {

			for ( int z = ( int ) player.posZ - radius; z <= ( int ) player.posZ + radius; z++ ) {

				if ( !list.contains( player.worldObj.getBlockState( new BlockPos ( x , y , z ) ).getBlock() ) ) {

					list.add( player.worldObj.getBlockState( new BlockPos ( x , y , z ) ).getBlock() );

				}

			}

		}

	}

	return list;

}

}

 

The player can choose a route and as soon as he starts riding by pressing a button, I want particles to spawn above the blocks, which are registered in the routes file. When I run the code, the game stops working and nothing happens and no crash-log will be created.

 

Thanks in advance 

[Abastro]

I think you have an issue with infinite loop.

Debug it with breakpoint.

[Lyras]

Nothing happens.

There is nothing in my console and "breakpoint" doesn't give me any information...

 

As I said: The game just crashes without any output into the console or something like that.

 

As long as the player is riding, the particles have to spawn above the blocks. As you can see in the code, the method is called anew while the boolean is true and the boolean is true as long the player is riding.

[Abastro]

Nothing happens.

There is nothing in my console and "breakpoint" doesn't give me any information...

 

As I said: The game just crashes without any output into the console or something like that.

 

As long as the player is riding, the particles have to spawn above the blocks. As you can see in the code, the method is called anew while the boolean is true and the boolean is true as long the player is riding.

The game crashes? Then please provide the log.

[Lyras]

"crashes" is the wrong word. When I press the button, a boolean gets set to true and then I call the method which will call itself as long as the boolean is true. But when this happens, the window doesn't react and gets whitish.

 

And thats the problem: I don't get ANY output and so I cannot figure out the problem

 

EDIT: I found out that the array only holds 7 elements and these elements are just blocktypes. Thats a new problem D:

        Is there a way to get blocks in a specified radius? I wrote several methods but no method

        really worked.  :'(

[Ernio]

Then it is not a crash.

 

It is indeed - infinite loop.

 

You pass true to method that infinitely calls itself. The boolean won't change, why would it?

 

Also note - Blocks can have metadatas and other shit - you sure you want List<Block>?

[Lyras]

1. The boolean will change. When the boolean is false and the player presses the specified button for auto-riding, the boolean will change to true. When it's true it will change to false.

 

But if I pass true to the method the game instantly freezes and nothing gets outputted and I don't have the chance to change the passed boolean because it freezes.

 

2. I just want to get the blocks in the radius and then test if their coords are registered in the route-file.

[Ernio]

Unless you are doing something behind the scenes - this is the code I see:

 

public static void markupWay ( boolean bool ) {

	if ( route != null ) { route = InputHandler.route; }

	Configuration config = new Configuration ( route );

	if ( bool ) {

		/* Goes through all block objects in the list... */
		for ( Block block : getBlocksNearby( Minecraft.getMinecraft().thePlayer , 10 ) ) {

			for ( int i = 0; i < RouteReader.getMarkerPoints( config ); i++ ) {

				/* ... and if the x-coord is equal to an value in the config... */
				if ( config.get( "posX" , i + ":" , 0 ).getInt() == ( int ) block.getBlockBoundsMaxX() ) {

					/* ... and if the y-coord is equal to an value in the config... */
					if ( config.get( "posY" , i + ":" , 0 ).getInt() == ( int ) block.getBlockBoundsMaxY() ) {

						/* ... and if the z-coord is equal to an value in the config... */
						if ( config.get( "posZ" , i + ":" , 0 ).getInt() == ( int ) block.getBlockBoundsMaxZ() ) {

							/* Then I will send particles at the blocks position */
							Minecraft.getMinecraft().thePlayer.worldObj.spawnParticle( EnumParticleTypes.REDSTONE ,
									                       ( ( block.getBlockBoundsMaxX() + block.getBlockBoundsMinX() ) / 2 ) ,
									                       ( ( block.getBlockBoundsMaxY() + block.getBlockBoundsMinY() ) / 2 ) ,
									                       ( ( block.getBlockBoundsMaxZ() + block.getBlockBoundsMinZ() ) / 2 ) ,
									                       0.3 , 0.3 , 0.3 );

						}

					}

				}

			}

		}
		//TODO Test if block is in list
		//send particle
		markupWay( bool );

	}

}

 

Now let's cut out all loops that do nothing regarding actualy result:

 

public static void markupWay ( boolean bool ) {
	if ( route != null ) { route = InputHandler.route; }

	Configuration config = new Configuration ( route );

	if ( bool ) {
		//TODO Test if block is in list
		//send particle
		markupWay( bool );
	}
}

 

If you EVER call "markupWay(true)" - It WILL roll INFINITELY!

That boolean is method-local, it cannot change out of methods scope - whatever you do.

 

Aside from that - EVEN if method would be called client side and the boolean would be global - just by calling method (when global boolean is true) would kill process (throttle client so hard that any key-input would not be able to pass to client thread).

 

You need either ClientTickEvent to run process for you (20ticks = 20 Hz) or you need to make new background thread which would introduce you to multithreading (which I don't think you would be able to code).

[Lyras]

I will do it with the ClientTickEvent.

 

But there's another problem:

The method "getBlocksNearby" is intended to get all blocks in the specified radius. But the method just returns the amount of different blocktypes...

[Ernio]

I strongly assume that this is client only stuff - right? (because if not, you will be pretty much fked )

 

Issue 1:

 

1. Have a global boolean;

2. @SubscribeEvent to ClientTickEvent

* Check against event.phase (pick one)

* if (globalBoolean) markupWay(); (note that it will not call itself)

3. @SubscribeEvent to KeyInputEvent (or other, just look into client event package)

* Use it to change globalBoolean.

 

Result: You will be calling method per tick until you change state.

 

Issue 2:

 

What is the actualy purpose of method? Do you want to have List of Block types that are around you or list of actual data about blocks around?

 

Block is a singleton that is literally a description of what some position (block) means in world (position in world say "I am this block").

BlockState is a thing that tells you what this BlockPos currently is (its state, like rotation or other stuff).

 

If you would do check against Block using contains() - you would end up with list { COBBLE, STONE, DIRT, WATER, .... other }. Size of list will be number of different block types (singletons).

If you want to have actual states you need list of IBlockState and add them by state (size of list will be x*y*z).

 

Generally you don't really want to have IBlockState list since you should be having List<BlockPos> and then get BlockState directly from world.

 

Jesus christ, something is wrong with me, I make sooo many miss-typos lately (edited a lot), it is getting scary.

[Lyras]

1. Have a global boolean;

2. @SubscribeEvent to ClientTickEvent

* Check against event.phase (pick one)

* if (globalBoolean) markupWay(); (note that it will not call itself)

3. @SubscribeEvent to KeyInputEvent (or other, just look into client event package)

* Use it to change globalBoolean.

Already done before you wrote it  The boolean was even global before

 

What is the actualy purpose of method?

I want the method to put ALL blocks within a radius of 10 blocks array. Then I want to check if the coords of the block-object I am currently testing are the same as a coordinate-bundle in the file. So basicly I want to put every single block with its data into this array and not just the type.

[Ernio]

Okay - IBlockState represents Data held by World at some BlockPos.

 

IBlockState gives you access to:

* Block (type) - #getBlock() (saved as ID in world)

* Metadata = 16 bits = "state". (metadata is saved in world itself).

* "Actual state" - which is extended "state" that can represent not only those 16 bits of saved data, but also be modified by other factors - like TileEntity or neighbor blocks.

 

As said - there are very few cases in which you will need List<IBlockState> since IBlockState is NOT BOUND to BlockPos.

 

Said that, best approach would be:

for (x)
    for (y)
        for (z)
            IBlockState state = player.worldObj.getBlockState(new BlockPos( x , y , z ));
            // now you have access to x, y, z, Block (type) and metadata.
            // Do rest of your "markupWay" method's code here.

 

Also note - idk how your config looks, so maybe there would be better way of doing it.

[Lyras]

Now I done everything you said.

 

When I don't filter the states...

public static ArrayList < IBlockState > getBlocksNearby ( Entity player , int radius ) {

	ArrayList < IBlockState > stateList = new ArrayList < IBlockState > ();

	for( int x = ( int ) Math.min( player.posX - radius , player.posX + radius ); x <= Math.max( player.posX - radius , player.posY + radius ); x++ ) {

		for( int y = ( int ) Math.min( player.posY - radius , player.posY + radius ); y <= Math.max( player.posY - radius , player.posY + radius ); y++ ) {

			for( int z = ( int ) Math.min( player.posZ - radius , player.posZ + radius ); z <= Math.max( player.posZ - radius , player.posZ + radius ); z++ ) {

				IBlockState state = player.worldObj.getBlockState( new BlockPos ( x , y , z ) );
				stateList.add( state );

			}

		}

	}

	return stateList;

}

... it will output "148617", I guess that's the amount of different states for the blocks within a radius of 10. In the same moment the game freezes and I have to close the window BUT the programm still outputs my sysout's.

 

Now I'm gone further but the game still freezes  :'(

 

Code:

	private static File route = null;
Configuration config = null;
private static boolean markingUp = false;

public static void setRoute ( File file ) { route = file; }

/**
 * This method gets used when the player starts riding
 * with this method, I can markup the blocks of the loaded route by sending
 * particle packages to the player
 * @param bool The boolean which I use for my loop
 */
public static boolean markupWay ( boolean bool ) {

	markingUp = bool;
	return bool;

}

public static ArrayList < IBlockState > getBlocksNearby ( Entity player , int radius ) {

	ArrayList < IBlockState > stateList = new ArrayList < IBlockState > ();

	for( int x = ( int ) Math.min( player.posX - radius , player.posX + radius ); x <= Math.max( player.posX - radius , player.posY + radius ); x++ ) {

		for( int y = ( int ) Math.min( player.posY - radius , player.posY + radius ); y <= Math.max( player.posY - radius , player.posY + radius ); y++ ) {

			for( int z = ( int ) Math.min( player.posZ - radius , player.posZ + radius ); z <= Math.max( player.posZ - radius , player.posZ + radius ); z++ ) {

				IBlockState state = player.worldObj.getBlockState( new BlockPos ( x , y , z ) );
				if ( stateList.contains( state ) ) {
					stateList.add( state );
				}

			}

		}

	}

	return stateList;

}

@SubscribeEvent
public void onClientTick ( TickEvent.ClientTickEvent e ) {

	if ( e.phase == Phase.END ) {

		System.out.println( "test" );

		if ( markingUp ) {

			System.out.println( "debug inner" );

			if ( route == null ) { route = InputHandler.route; }
			if ( config == null ) { config = new Configuration ( route ); }

			ArrayList < IBlockState > stateList = getBlocksNearby( Minecraft.getMinecraft().thePlayer , 10 );

			System.out.println( stateList.size() );
			for ( IBlockState state : stateList ) {

				for ( int i = 0; i < RouteReader.getMarkerPoints( config ); i++ ) {

					if ( config.get( "posX" , i + ":" , 0 ).getInt() == ( int ) state.getBlock().getBlockBoundsMaxX() ) {

						if ( config.get( "posY" , i + ":" , 0 ).getInt() == ( int ) state.getBlock().getBlockBoundsMaxY() ) {

							if ( config.get( "posZ" , i + ":" , 0 ).getInt() == ( int ) state.getBlock().getBlockBoundsMaxZ() ) {

								Minecraft.getMinecraft().thePlayer.worldObj.spawnParticle( EnumParticleTypes.REDSTONE ,
					                       ( ( state.getBlock().getBlockBoundsMaxX() + state.getBlock().getBlockBoundsMinX() ) / 2 ) ,
					                       ( ( state.getBlock().getBlockBoundsMaxY() + state.getBlock().getBlockBoundsMinY() ) / 2 ) ,
					                       ( ( state.getBlock().getBlockBoundsMaxZ() + state.getBlock().getBlockBoundsMinZ() ) / 2 ) ,
					                       0.3 , 0.3 , 0.3 );

							}

						}

					}

				}

			}

		}

	}

}

 

Anyway... Thank you for the help so far

 

[Ernio]

I am kinda lost with what is actually your goal. You have some "marker points" in configs, but what's up with "#getBlock().getBlockBoundsMaxX()"?

What is your actual goal - in words?

[Lyras]

I want the method to put ALL blocks within a radius of 10 blocks array. Then I want to check if the coords of the block-object I am currently testing are the same as a coordinate-bundle in the file.

For this I used the MaxX, MaxY and MaxZ...

They're just used to compare the coords-bundle in the config, like you said, and the coords of the block. If there is match, I will spawn particles above it...

[jeffryfisher]

I'm befuddled by a couple things. First:

 

if ( stateList.contains( state ) ) {
	stateList.add( state );
}

If the state is already in the list, why would you add it again? And if the list starts empty, will this test ever allow a state to be added?

 

Second: Why is there a posY in your loop code for x?

 

Third: Why are you getting so many blocks in a solid volume? Look through World to see how vanilla Minecraft scans for things. You may find a method already out there that will suffice. In any case, there must be a more efficient algorithm (find the next path block at radius one, then find one adjacent to that etc).

 

Fourth: What is going to happen if your player is ever near y=255 or y=1? Or in a superflat world with even tighter constraint on y?

[Lyras]

I'm befuddled by a couple things. First:

 

Code: [select]

if ( stateList.contains( state ) ) {

stateList.add( state );

}

If the state is already in the list, why would you add it again? And if the list starts empty, will this test ever allow a state to be added?

That's a left-over from old code I made. Sorry about that

 

Second: Why is there a posY in your loop code for x?

Mistake xP

 

Third: Why are you getting so many blocks in a solid volume? Look through World to see how vanilla Minecraft scans for things. You may find a method already out there that will suffice. In any case, there must be a more efficient algorithm (find the next path block at radius one, then find one adjacent to that etc).

May be. I will take a look into the code

 

Fourth: What is going to happen if your player is ever near y=255 or y=1? Or in a superflat world with even tighter constraint on y?

Where's the problem?

[jeffryfisher]

... to compare the coords-bundle in the config and the coords of the block. If there is match, I will spawn particles above it...

Hmmm... If all you care about is coords, then you don't need all those block states. Just run through the coords in the config looking for points whose calculated distance is less than radius from player. Vanilla Minecraft already has methods for distance.

 

For each hit you detect, spawn particles, perhaps after checking the blockstate for anything that would interfere. You'll fetch far fewer blockstates that way, and you'll be less likely to run out of memory.

 

PS: If you search radius 10 from a position at y=2, what does your code do? What happens if it passes y=0 or y=-1 in that method call? And what would happen then? (maybe nothing, but it looks dangerous)

[Lyras]

Thanks to you all and thanks for your patience 

You helped me alot

 

Now someone must add "[solved]" to the title

 

Greets from Germany 

[Draco18s]

Now someone must add "[solved]" to the title

 

You can do that yourself by editing the original post.