[1.9.4][Solved!] Make custom shield take damage when blocking a attack

[MCrafterzz]

This is the code I have so far:

 

http://pastebin.com/HYMQZ5yq

 

Everything works except that it takes damage every second when blocking, how should I do so it only takes damage when the shield has been attacked. I've looked in the vanilla code but I can't find what makes it take damage

[MCrafterzz]

And how do I call that methoud?

[Draco18s]

...You don't?

 

You need to implement the method.

[MCrafterzz]

And how do you implement a methoud? I can't implement EntityLivingBase because it's not a interface

[Ernio]

I feel like you have no idea what you are doing.

 

I haven't looked at shields yet, but if there are  no direct hooks to shields themselves, you can always use LivingHurtEvent to check if player has shield and change its stats (durability) if you want.

[p455w0rd]

My shield extends the vanilla shield and I use this:

@SubscribeEvent
public void attackEvent(LivingAttackEvent e) {
	float damage = e.getAmount();
	ItemStack activeItemStack;
	EntityPlayer player;
	if (!(e.getEntityLiving() instanceof EntityPlayer)) {
		return;
	}
	player = (EntityPlayer) e.getEntityLiving();
	if (player.getActiveItemStack() == null) {
		return;
	}
	activeItemStack = player.getActiveItemStack();

	if (damage > 0.0F && activeItemStack != null && activeItemStack.getItem() instanceof ItemShield) {
		int i = 1 + MathHelper.floor_float(damage);
		activeItemStack.damageItem(i, player);

		if (activeItemStack.stackSize <= 0) {
			EnumHand enumhand = player.getActiveHand();
			net.minecraftforge.event.ForgeEventFactory.onPlayerDestroyItem(player, activeItemStack, enumhand);

			if (enumhand == EnumHand.MAIN_HAND) {
				player.setItemStackToSlot(EntityEquipmentSlot.MAINHAND, (ItemStack) null);
			}
			else {
				player.setItemStackToSlot(EntityEquipmentSlot.OFFHAND, (ItemStack) null);
			}

			activeItemStack = null;
			if (FMLCommonHandler.instance().getSide() == Side.CLIENT) {
				player.playSound(SoundEvents.ITEM_SHIELD_BREAK, 0.8F, 0.8F + player.worldObj.rand.nextFloat() * 0.4F);
			}
		}
	}
}

[MCrafterzz]

Thank you but my shield still don't gets damages? Can you double check that all the code is correct

[MCrafterzz]

I mean this code:

@SubscribeEvent

public void attackEvent(LivingAttackEvent e) {

float damage = e.getAmount();

ItemStack activeItemStack;

EntityPlayer player;

if (!(e.getEntityLiving() instanceof EntityPlayer)) {

return;

}

player = (EntityPlayer) e.getEntityLiving();

if (player.getActiveItemStack() == null) {

return;

}

activeItemStack = player.getActiveItemStack();

 

if (damage > 0.0F && activeItemStack != null && activeItemStack.getItem() instanceof ItemShield) {

int i = 1 + MathHelper.floor_float(damage);

activeItemStack.damageItem(i, player);

 

if (activeItemStack.stackSize <= 0) {

EnumHand enumhand = player.getActiveHand();

net.minecraftforge.event.ForgeEventFactory.onPlayerDestroyItem(player, activeItemStack, enumhand);

 

if (enumhand == EnumHand.MAIN_HAND) {

player.setItemStackToSlot(EntityEquipmentSlot.MAINHAND, (ItemStack) null);

}

else {

player.setItemStackToSlot(EntityEquipmentSlot.OFFHAND, (ItemStack) null);

}

 

activeItemStack = null;

if (FMLCommonHandler.instance().getSide() == Side.CLIENT) {

player.playSound(SoundEvents.ITEM_SHIELD_BREAK, 0.8F, 0.8F + player.worldObj.rand.nextFloat() * 0.4F);

}

}

}

}

[MCrafterzz]

What how?

[MCrafterzz]

Solved