Jump to content

Correction or Workaround 1.10 - make commands lowercase only.


Botjoe

Recommended Posts

Just noticed that commands seem to must be lowercase in the first argument for the tab completion to work (might just be the first character). ExecuteFile and execute interfere with each other (will clear to the first /). But executefile and execute work fine. Nothing different but the name of the command.

 

Easier to change to be consistent and use lowercase than to try to figure it out. (Probably happened in 1.9 versions also.)

 

Just a shoulda known better. So the workaround or correction is always use lowercase for command names.

 

 

Link to comment
Share on other sites

I originally developed the mod to have an uppercase command called "ExecuteFile". I had always typed the ExecuteFile command and then used tab completion to add the rest of the command arguments.

 

I discovered recently that the tab completion was not working, so after trying a number of things , I changed the command to lowercase.

 

Causing the problem.

 

1) Created a command mod with the command name "ExecuteFile".

2) in the command execute coded to get list of matching command strings.

then

3) Typed any command starting with e (e.g. /exec) then tabbed.

4) Entry clears to /

then

3) Typed the command to /ExecuteF then tabbed.

4) Entry shows /ExecuteFile and works normally

then

3) Typed /execute {space}

4) Entry shows /execute and works normally

then

3) Typed /execute without a space

4) Entry clears to /

 

 

This caused the command to clear on the tab until after the F is entered. The user could enter 'execute space' and the string would not reset (deleted to the first /). 

 

I don't believe this is a forge behavior.

This has the issues.

if (args.length <= 0) {

List<String> ly = getListOfStringsMatchingLastWord(args,
		"ExecuteFile","/ExecuteEile");
      	return ly;
}

This works fine.

if (args.length <= 0) {

List<String> ly = getListOfStringsMatchingLastWord(args,
		"executefile","/executefile");
      	return ly;
}

 

Now typing /e {tab} displays

 

/execute, /entitydata, /effect, /executefile, /enchant

 

and sets the entry to /execute

 

 

Thank you.

I don't think that this is a forge behavior. I failed to use a convention of lower case commands.

----- Opinion ----

To me, it's a workaround, or fail to follow convention. While much of the rest of minecraft is inconsistent on case, commands appear to be lowercase. My reason to view it as a "gotta know" stems from how commands are parsed in terms of case in ordinary minecraft.

 

For example in standard minecraft, as a command, using /kill @e[type=villager] (entity uuid error) will not work, and /kill @e[Type=Villager] will kill everything (matches every entity), only /kill @e[type=Villager] will correctly work. Knowing to type /kill @e[type=Villager] is a "gotta know". That's why I think it's not a forge issue, but modders should know.

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • You can try other builds of Quark/Zeta
    • Hello all, I recently tried to upgrade my Minecraft mod to version 1.21.3, and I seem to have a problem with the `RenderSystem#setShaderColor` method. Here is how the screen is usually supposed to look like: Here is how it looks at present: To further explain, the note labels atop of the note buttons are colored cyan (here) using `RenderSystem#setShaderColor`. The note buttons and labels get their colors from their native texture - white. This means that even though I set the coloring to apply to the label (top), it is applied to the button (bottom). What I conclude is happening then, in essence, is that this method (at least for my case) does not color the blit after - but rather the blit before..?  This also blocks me from later resetting the shader, as I need to set it back to white before the blitting is done, and not when it's done. So like... what? I've tested this further with other components that require this method, and this preceding-like behavior seems to be pretty consistent for them too.   I should mention that all the snippets I am about to show have all worked in past versions. In my class `ClientUtil`, the following methods are defined: public static void setShaderColor(final Color color, final float alpha) { RenderSystem.setShaderColor( color.getRed() / 255f, color.getGreen() / 255f, color.getBlue() / 255f, alpha ); } public static void setShaderColor(final Color color) { setShaderColor(color, 1); } public static void resetShaderColor() { setShaderColor(Color.WHITE); } //... public static RenderType guiRT(final ResourceLocation loc) { return RenderType.guiTextured(loc); } And here is the snippet from `NoteButtonRenderer#renderNote` using it: // "Note" here refers to those symbols in the middle of a note button protected void renderNote(final GuiGraphics gui, final InstrumentThemeLoader themeLoader) { final int noteWidth = noteButton.getWidth()/2, noteHeight = noteButton.getHeight()/2; ClientUtil.setShaderColor((noteButton.isPlaying() && !foreignPlaying) ? themeLoader.notePressed() : themeLoader.noteReleased() ); gui.blit(ClientUtil::guiRT, noteTextureProvider.get(), noteButton.getX() + noteWidth/2, noteButton.getY() + noteHeight/2, 0, 0, noteWidth, noteHeight, noteWidth, noteButton.getHeight()/2 ); ClientUtil.resetShaderColor(); } You may find the full source here. The odd thing is that Minecraft does seem to use this method the regular way I showed, for instance `SkyRenderer#renderSkyDisc` (not sure if I'l allowed to paste it). Could it be that I'm doing something wrong that leads to this issue..? I'm really stumped on this one.  I couldn't really find any change logs or documentation for this rendering API (even in this Fabric blog post), so I'm sorry if this seems obvious or anything.  Either way, any help would be appreciated.
    • This did work. rip Quark Thank you
    • It says Quark Requires zeta. do i just remove Quark? https://mclo.gs/cq799kI
    • It refers to the mod elenaidodge Backup the world and make a test without it
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.