[1.10 SOLVED] Trying to cleanly implement Colored Items

[JigenEagle]

Hello,

 

I am currently trying to color different Items using the same base texture and getColorFromItemStack.

My items register fine but are not colored in my inventory or in the world when I drop them.

 

Code for Item class

package com.jigeneagle.fentonindustries.items;

import com.jigeneagle.fentonindustries.Main;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class FIItem extends Item {

protected String sharedName;
protected boolean colored = false;
protected int sharedHexColor;

public FIItem(String registryName, CreativeTabs tab) {

	// Set Registry Data for Item
	this.sharedName = registryName;
	this.setRegistryName(sharedName);
	this.setUnlocalizedName(this.getRegistryName().toString());
	this.setCreativeTab(tab);
}

public FIItem(String registryName, CreativeTabs tab, int hexColor) {

	// Set Registry Data for Colored Item
	this.sharedName = registryName;
	this.setRegistryName(sharedName);
	this.setUnlocalizedName(this.getRegistryName().toString());
	this.setCreativeTab(tab);
	this.colored = true;
	this.sharedHexColor = hexColor;
}

public void registerItemModel() {
	Main.proxy.registerItemRenderer(this, 0, sharedName);
}

// "Lets just run the colors across the bottom of the screen while we get started."
public boolean hasColor(ItemStack itemStack) {
        return colored;
    }

@SideOnly(Side.CLIENT)
public int getColorFromItemStack(ItemStack itemStack, int renderPass) {
	return sharedHexColor;
}
}

 

 

Code for Items class

package com.jigeneagle.fentonindustries.items;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class FIItems {

public static FIItem dustCopper;

public static void initItems() {
	dustCopper = register(new FIItem("dustCopper", CreativeTabs.BUILDING_BLOCKS, 0xB87333));
}

private static <T extends Item> T register(T item) {
	GameRegistry.register(item);
	((FIItem)item).registerItemModel();
	return item;
}
}

 

My plan is to simply pass a hexColor when I want to register an item with a color multiplier.

If an item doesn't need a color multiplied over it, I simply leave off the hexColor.

 

Is this an issue with how I am storing and passing the hexidecimal? I don't often use them.

 

If I am heading down the wrong path, what is the correct way to implement items with a hexColor multiplied over them?

[Draco18s]

sharedHexColor

needs to be white, not black, by default for this to work.  Right now if you don't pass a color the integer's default value of 0 is used.  That's 0x000000 which is black.

[Choonster]

You have various colour-related methods in your

FIItem

class, but Minecraft doesn't know anything about them.

 

You need to register an

IItemColor

implementation for any

Item

you want to colour. Do this by calling

ItemColors#registerItemColorHandler

in init from your client proxy.

 

For examples, look at

ItemColors#init

or my mod.

[JigenEagle]

  On 6/26/2016 at 2:40 PM, Choonster said:

You have various colour-related methods in your

FIItem

class, but Minecraft doesn't know anything about them.

 

You need to register an

IItemColor

implementation for any

Item

you want to colour. Do this by calling

ItemColors#registerItemColorHandler

in init from your client proxy.

 

Thank You -- It did seem weird to think that Minecraft would just 'know' to call the functions for what I wanted to do.

The example was very helpful.

[yooksi]

Does anyone know which colour value system Minecraft uses? I've tried entering a simple RGB value like this 171(red)36(green)36(blue) without the braces and info in it of course, just a plain number 1713636. Didn't seem to work. Any ideas?

[Draco18s]

Colors in decompiled minecraft are in decimal.  171,36,36 would be 11215908.

However, you should express your colors in hex.  Which would be 0xAB2424.

[yooksi]

  On 10/14/2016 at 8:29 PM, Draco18s said:

Colors in decompiled minecraft are in decimal.  171,36,36 would be 11215908.

However, you should express your colors in hex.  Which would be 0xAB2424.

What exactly is a decimal colour code? I've found a reference to it here, but I still don't understand it.

 

The way I am trying to do it at the moment (and it's working perfect) is like this:

import java.awt.Color;

Color color = new Color(36, 36, 155);
int colorRGB = color.getRGB();

Why is it important to express them in a hex format, is there an advantage over decimal or is it just a matter of readability and convention?

[Draco18s]

  On 10/14/2016 at 8:57 PM, yooksi said:

Why is it important to express them in a hex format, is there an advantage over decimal or is it just a matter of readability and convention?

 

Readability.

And the decimal color is just the base 10 representation of the same value.

[yooksi]

  On 10/14/2016 at 9:09 PM, Draco18s said:

Readability.

And the decimal color is just the base 10 representation of the same value.

 

Alright, thanks. I think I will stick to the way I posted above, because I personally find it more readable then hex values. I can just open up Gimp, experiment with colours and copy RGB values, and if I were to use hex values I would need to constantly recalculate them.

[Draco18s]

  On 10/14/2016 at 9:39 PM, yooksi said:

Alright, thanks. I think I will stick to the way I posted above, because I personally find it more readable then hex values. I can just open up Gimp, experiment with colours and copy RGB values, and if I were to use hex values I would need to constantly recalculate them.

 

Gimp handles hex values as well.

You can copy and paste to that field.

[yooksi]

  On 10/14/2016 at 10:23 PM, Draco18s said:

  Quote

Alright, thanks. I think I will stick to the way I posted above, because I personally find it more readable then hex values. I can just open up Gimp, experiment with colours and copy RGB values, and if I were to use hex values I would need to constantly recalculate them.

 

Gimp handles hex values as well.

You can copy and paste to that field.

Didn't know that HTML notation was actually a hexadecimal value, that's great. Thanks.