Posted July 1, 20169 yr The ASM of the mod Im making involves replacing all calls to a certain method in Minecraft, and my current method seems to be working fine with all other classes; except for the Minecraft class itself! Most recently this occurred when replacing the getMouseOver() method in the EntityRenderer class, resulting in this strange sequence of errors; (See BlockPos player is looking at is Millions!!! of blocks away from the player, and I opened a chest through a solid block) The bug is hard to notice at first, but basically whats happening is I can open a chest through the seemingly solid spruce plank. Whats causing this is the getMouseOver(F) method is called every MinecraftTick along with every RenderTick; and the game uses the info from the MinecraftTick to process interacting with the world, but the RenderTick is responsible for showing the info on the screen. The RenderTick call got transformed, but not the MinecraftTick; resulting in the me opening a chest through a solid block of wood. This problem doesnt occur in the MDK for Minecraft, which leads me to believe this is either a bug; or that I've made some fundamental error in the construction of this coremod. As far as I can tell this means for some reason no ASM transforms can occur on the Minecraft class outside of the MDK. To test this I purposely crashed the game after the transformer ran through the MC class if(callingGetMouseOver){ runTransformer("getMouseOver",m_className,calledOwner); if(m_className.equals(MinecraftName){ System.out.println(MinecraftName); System.out.println(m_className); int i = 10; i/=0; } } This crash logged me [05:16:12] [main/INFO] [sTDOUT]: [ValkyrienWarfareBase.CoreMod.TransformAdapter:runTransformer:93]: bcd [05:16:12] [main/INFO] [sTDOUT]: [ValkyrienWarfareBase.CoreMod.TransformAdapter:runTransformer:94]: bcd [05:16:12] [main/ERROR] [LaunchWrapper]: Unable to launch java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_25] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_25] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_25] at java.lang.reflect.Method.invoke(Method.java:483) ~[?:1.8.0_25] at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?] at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?] Caused by: java.lang.NoSuchMethodError: net.minecraft.client.Minecraft.func_71386_F()J at net.minecraft.client.main.Main.main(SourceFile:39) ~[Main.class:?] ... 6 more Exception in thread "main" [05:16:12] [main/INFO] [sTDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: net.minecraftforge.fml.relauncher.FMLSecurityManager$ExitTrappedException [05:16:12] [main/INFO] [sTDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraftforge.fml.relauncher.FMLSecurityManager.checkPermission(FMLSecurityManager.java:30) [05:16:12] [main/INFO] [sTDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.lang.SecurityManager.checkExit(SecurityManager.java:761) [05:16:12] [main/INFO] [sTDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.lang.Runtime.exit(Runtime.java:107) [05:16:12] [main/INFO] [sTDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.lang.System.exit(System.java:968) [05:16:12] [main/INFO] [sTDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraft.launchwrapper.Launch.launch(Launch.java:138) [05:16:12] [main/INFO] [sTDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraft.launchwrapper.Launch.main(Launch.java:28) So that proves that the Minecraft class was indeed run through the transformer, and the getMouseOver() in the Minecraft class was detected resulting in the crash. However as shown in the photo above, the transform didn't actually modify the Minecraft class despite running the same ASM transforms that work on every other class of the game NOTE: This doesn't occur in the MDK Version of Minecraft, only outside of the dev environment does this issue occur I'm not sure if this is a bug or a feature, if anyone wants to clear this up some insight would be greatly appreciated! "you seem to be THE best modder I've seen imo." ~spynathan ლ(́◉◞౪◟◉‵ლ
July 2, 20169 yr Why are you coremodding? I do Forge for free, however the servers to run it arn't free, so anything is appreciated. Consider supporting the team on Patreon
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.