Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Problem with "Exp Bank" Item

Thor597

By Thor597
in Modder Support

 Share

Recommended Posts

Thor597 Diamond Finder

Thor597

Posted
Posted

Im making this item that you can store your experience into and withdraw exp from, and everything was going just fine until when I checked if it would save the exp in the item if I relogged, but what I noticed was that when I stored exp into the bottle the players exp level goes down, but when I relog the player has the experience back again and also the item has the exp the player stored into it before I relogged.

 

So: I have 40 xp, I store the 40 exp in the item, I relog, I have 40 exp again, the bottle also has 40 exp which makes it so you basically have infinite exp.

 

Also when I close Minecraft and open it again the exp levels that was in the bottle are gone

 

Item class:


package thormod.items;                                                             
import java.util.List;

import cpw.mods.fml.common.Side;
import cpw.mods.fml.common.asm.SideOnly;
import thormod.guis.ThorMod_GuiXPStoring;
import net.minecraft.client.Minecraft;
import net.minecraft.src.*;

public class ThorMod_ItemXPStoringBottle extends Item 
{
/** The current experience level the player is on. */
public int experienceLevel;

/**
 * The total amount of experience the bottle has. This also includes the amount of experience within their
 * Experience Bar.
 */
public int experienceTotal;

/**
 * The current amount of experience the bottle has.
 */
public float experience;

public ThorMod_ItemXPStoringBottle(int par1) 
{
	super(par1);
	this.setMaxStackSize(1);
}

public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
{
	if(!(par3EntityPlayer instanceof EntityPlayerMP))
	{
		ModLoader.openGUI(par3EntityPlayer, new ThorMod_GuiXPStoring(this, par3EntityPlayer));
	}
	return par1ItemStack;	
}

/**
 * This method increases the player's current amount of experience.
 */
public void addExperience(int par1)
{
	int var2 = Integer.MAX_VALUE - this.experienceTotal;

	if (par1 > var2)
	{
		par1 = var2;
	}

	this.experience += (float)par1 / (float)this.xpBarCap();

	for (this.experienceTotal += par1; this.experience >= 1.0F; this.experience /= (float)this.xpBarCap())
	{
		this.experience = (this.experience - 1.0F) * (float)this.xpBarCap();
		this.addExperienceLevel(1);
	}
}

/**
 * Add experience levels to this player.
 */
public void addExperienceLevel(int par1)
{
	this.experienceLevel += par1;

	if (this.experienceLevel < 0)
	{
		this.experienceLevel = 0;
	}
}

/**
 * This method returns the cap amount of experience that the experience bar can hold. With each level, the
 * experience cap on the player's experience bar is raised by 10.
 */
public int xpBarCap()
{
	return this.experienceLevel >= 30 ? 62 + (this.experienceLevel - 30) * 7 : (this.experienceLevel >= 15 ? 17 + (this.experienceLevel - 15) * 3 : 17);
}

@SideOnly(Side.CLIENT)

/**
 * allows items to add custom lines of information to the mouseover description
 */
public void addInformation(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, List par3List, boolean par4)
{
	par3List.add(String.valueOf(this.experienceLevel));
}

public String getTextureFile()
{
	return "/thormod/textures/items.png";
}

}

 

Gui Class:


package thormod.guis; 

import net.minecraft.src.*;
import java.util.Random;
import net.minecraft.client.Minecraft;
import org.lwjgl.opengl.GL11;

import thormod.items.ThorMod_ItemXPStoringBottle;

import java.util.Random;

public class ThorMod_GuiXPStoring extends GuiScreen 
{
public EntityPlayer theplayer;
public ThorMod_ItemXPStoringBottle theBottle;

public ThorMod_GuiXPStoring(ThorMod_ItemXPStoringBottle bottle, EntityPlayer entityplayer)
{
	theplayer = entityplayer;
	theBottle = bottle;
}

public void initGui() 
{		
	controlList.clear();
	controlList.add(new GuiButton(1, width / 9 + 10, height / 2 + -75, 98, 20, "Deposit 10 Experience Levels"));
	controlList.add(new GuiButton(2, width / 9 + 10, height / 2 + -50, 98, 20, "Withdraw 10 Experience Levels"));
}

protected void actionPerformed(GuiButton guibutton)
{
	if(theBottle != null)
	{
		if(guibutton.id == 1 && theplayer.experienceLevel >= 10)
		{
			theBottle.addExperienceLevel(10);
			theplayer.experienceLevel -= 10;

			updateScreen();
			initGui();
		}

		if(guibutton.id == 2 && theBottle.experienceLevel >= 10)
		{
			theplayer.addExperienceLevel(10);
			theBottle.experienceLevel -= 10;

			updateScreen();
			initGui();
		}
	}
}

public boolean doesGuiPauseGame()
{
	return true;
}

public void onGuiClosed()
{

}

public void drawScreen(int i, int j, float f)
{
	drawDefaultBackground();

	String exp = String.valueOf(this.theBottle.experienceLevel);
	drawCenteredString(fontRenderer, exp, width / 2, height / 4 - 40, 8453920);

	super.drawScreen(i, j, f);
}
}

width=500 height=100http://i.imgur.com/Hppni.png[/img]
shadowmage4513 Creeper Killer

shadowmage4513

Posted
Posted

I believe itemStacks now have an NBT tag that can have custom information appended to it, which should be persistent across saves.

 

However from what I read in the source, it is only applicable for non-stackable items (or is it that any item with a custom tag becomes non-stackable?)

 

So, your answer may be in the ItemStack class, look up the custom NBT tag handling.

wishmaster Tree Puncher

wishmaster

Posted
Posted

take a look at ContainerEnchantment for exp changes on EntityPlayer it may help with this

 

EntityPlayer.addExperienceLevel(+ or - value);

 

I wouldn't physically override it where you have

 

public void addExperienceLevel(int par1)

 

as for storing in the item I would suggest damage values as per level with a cap before a new item is needed to store more.

 

a block with a TileEntity storing to nbt would allow for more storage though

QuantumLeaf7895 Tree Puncher

QuantumLeaf7895

Posted
Posted

Are item damage values big enough to host exp points that is an int though?

 

IIRC, it's in-world block metadata that's limited to 16, an item's damage value should be able to store a range of values more-or-less the same size as java's int type.

Thor597 Diamond Finder

Thor597

Posted
  • Author
Posted

It works fine however it resets to max damage every time I relog, so you basically lose the experience in the bottle :/

 

new code:

 

 

Item File


package thormod.items;                                                             
import java.util.List;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.src.ModLoader;
import net.minecraft.world.World;
import thormod.guis.ThorMod_GuiXPStoring;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class ThorMod_ItemXPStoringBottle extends Item 
{
/** The current experience level the player is on. */
public int experienceLevel;

public ThorMod_ItemXPStoringBottle(int par1) 
{
	super(par1);
	this.setMaxDamage(100);
}

public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
{
	if(!(par3EntityPlayer instanceof EntityPlayerMP))
	{
		ModLoader.openGUI(par3EntityPlayer, new ThorMod_GuiXPStoring(this, par1ItemStack, par3EntityPlayer));
	}
	return par1ItemStack;	
}

/**
 * Add experience levels to this player.
 */
public void addExperienceLevel(int par1, ItemStack par2ItemStack, EntityPlayer par3EntityPlayer)
{
	if (!(par2ItemStack.getItemDamage() == par2ItemStack.getMaxDamage()))
	{
		par2ItemStack.damageItem(par1, par3EntityPlayer);
	}
}

@SideOnly(Side.CLIENT)

/**
 * allows items to add custom lines of information to the mouseover description
 */
public void addInformation(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, List par3List, boolean par4)
{
	par3List.add(String.valueOf(par1ItemStack.getItemDamage()));
}

public String getTextureFile()
{
	return "/thormod/textures/items.png";
}

}

 

Gui File


package thormod.guis; 

import net.minecraft.client.gui.GuiButton;
import net.minecraft.client.gui.GuiScreen;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import thormod.items.ThorMod_ItemXPStoringBottle;

public class ThorMod_GuiXPStoring extends GuiScreen 
{
public EntityPlayer theplayer;
public ThorMod_ItemXPStoringBottle theBottle;
public ItemStack theBottleStack;

public ThorMod_GuiXPStoring(ThorMod_ItemXPStoringBottle bottle, ItemStack bottleStack, EntityPlayer entityplayer)
{
	theplayer = entityplayer;
	theBottle = bottle;
	theBottleStack = bottleStack;
}

public void initGui() 
{		
	controlList.clear();
	controlList.add(new GuiButton(1, width / 2, height / 2 + -75, 98, 20, "Deposit 10 Experience Levels"));
	controlList.add(new GuiButton(2, width / 2, height / 2 + -50, 98, 20, "Withdraw 10 Experience Levels"));
}

protected void actionPerformed(GuiButton guibutton)
{
	if(theBottle != null)
	{
		if(guibutton.id == 1 && theplayer.experienceLevel >= 10 && theBottleStack.getItemDamage() <= theBottleStack.getMaxDamage())
		{
			theBottle.addExperienceLevel(10, theBottleStack, theplayer);
			theplayer.experienceLevel -= 10;

			updateScreen();
			initGui();
		}

		if(guibutton.id == 2 && theBottle.experienceLevel >= 10)
		{
			theplayer.addExperienceLevel(10);
			theBottle.experienceLevel -= 10;

			updateScreen();
			initGui();
		}
	}
}

public void keyTyped(char par1, int par2)
{
	if (par2 == 1 || par2 == this.mc.gameSettings.keyBindInventory.keyCode)
	{
		this.mc.thePlayer.closeScreen();
	}
}

public boolean doesGuiPauseGame()
{
	return false;
}

public void onGuiClosed()
{

}

public void drawScreen(int i, int j, float f)
{
	drawDefaultBackground();

	String exp = String.valueOf(this.theBottleStack.getItemDamage());
	drawCenteredString(fontRenderer, exp, width / 2, height / 4 - 40, 8453920);

	super.drawScreen(i, j, f);
}
}

width=500 height=100http://i.imgur.com/Hppni.png[/img]
  • 2 weeks later...
Moritz Dragon Slayer

Moritz

Posted
Posted

i would do it like this:

 

package net.minecraft.src;

 

import java.util.List;

import net.minecraft.src.*;

 

public class ExpBank extends Item

{

    int Exp = 0;

    int maxExp = 1000000

    int howMuch = 1; //how much exp it give or consum

    int mode = 0;  // Mode 0 = nothing, Mode 1 = Give, Mode 2 = Consum

 

    public ExpBank(int id)

    {

        super(id);

        setMaxStackSize(1);

    }

 

    @Override

    public void getTextureFile()

    {

          return "/test.png";

    }

 

    public ItemStack onItemRightClick(ItemStack par1, World par2, EntityPlayer par3)

    {

          if(par3.isSneaking())

          {

              howMuch++:

          }

          else

          {

              mode++;

          }

      return par1;

      }

 

      public void onUpdate(ItemStack par1, World par2, Entity par3, int par4, boolean par5, EntityPlayer par6)

      {

          if(par5)// Has the item in the hand

          {

                if(mode > 3)

                {

                      mode = 0;

                }

 

                if(howMuch > 10)

                {

                    howMuch = 1;

                }

 

            }

            else

            {

                  if(mode == 1)

                  {

                        if(Exp > howMuch - 1) // This is for safe so that if no more exp is there than it will not give Exp

                        {

                              par6.addExperience(howMuch);

                        }

                  }

 

                  if(mode == 2)

                  {

                      if(Exp < maxExp)

                      {

                            par6.removeExperience(howMuch);

                        }

                  }

            }

        }

 

        public void addInformation(ItemStack par1, List par2)

        {

              par2.add("How Much Exp Stored: " + Exp);

              par2.add("How Much Exp Can it Store: " + maxExp);

              par2.add("Exp Transfer Level: " + howMuch);

        }

 

        public String getItemDisplayName(ItemStack par1)

        {

              return "Exp Bank";

        }

 

        public int getIconFromDanage(int i)

        {

              return 1;

          }

 

}

 

I hope Its helping.

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept