Jump to content

[1.10.2] [SOLVED] 2 Weird problems with a custom teleporter


xJon

Recommended Posts

Hello!

 

I have a mod for 1.8.9 that worked perfectly that I decided to update to 1.10.2. I didn't think it'd be such a big deal but I got now some weird issues I can't manage to fix myself.

- The first issue is the custom biome of the custom dimension:

The dimension does use the custom ChunkProvider, but when you enter it, it says the biome is "Ocean", and not my custom biome, so the spawnable creatures and more parameters don't work correctly. Code to the world, code to the init.

- The second issue is the custom teleporter. I have this weird issue that when I come back to the overworld using my custom teleporter, I have a ghost block of the teleportation block from the custom dimension. It's easier to understand with pictures: one, two, three.

All solved!

 

I'll really appreciate any kind of help, and any tip, as I sincerely need them! :P

Why are you reading this?

Link to comment
Share on other sites

Hello!

 

I have a mod for 1.8.9 that worked perfectly that I decided to update to 1.9.4. I didn't think it'd be such a big deal but I got now some weird issues I can't manage to fix myself.

- The first issue is the custom biome of the custom dimension:

The dimension does use the custom ChunkProvider, but when you enter it, it says the biome is "Ocean", and not my custom biome, so the spawnable creatures and more parameters don't work correctly. Code to the world, code to the init.

- The second issue is the custom teleporter. I have this weird issue that when I come back to the overworld using my custom teleporter, I have a ghost block of the teleportation block from the custom dimension. It's easier to understand with pictures: one, two, three.

 

I'll really appreciate any kind of help, and any tip, as I sincerely need them! :P

 

For your biome problem, you are registering the biome type, but not the actual biome. After you call BiomeDictionary.registerBiomeType (in your UselessBiomes class), register your biome with Biome.registerBiome

 

 

As for your teleporter problem, may I ask you are rechecking whether or not a machine exists near you every time a player teleports? Why not just cache the teleporter locations like how vanilla portals do it? Also, instead of checking whether or not an IBlockState instance is equal to the default IBlockState of your machine, check whether or not the Block is equal to you machine block. I only say this because I noticed your machine has different orientations, so checking against the default will fail for all the orientations except NORTH.

Link to comment
Share on other sites

Hello!

 

I have a mod for 1.8.9 that worked perfectly that I decided to update to 1.9.4. I didn't think it'd be such a big deal but I got now some weird issues I can't manage to fix myself.

- The first issue is the custom biome of the custom dimension:

The dimension does use the custom ChunkProvider, but when you enter it, it says the biome is "Ocean", and not my custom biome, so the spawnable creatures and more parameters don't work correctly. Code to the world, code to the init.

- The second issue is the custom teleporter. I have this weird issue that when I come back to the overworld using my custom teleporter, I have a ghost block of the teleportation block from the custom dimension. It's easier to understand with pictures: one, two, three.

 

I'll really appreciate any kind of help, and any tip, as I sincerely need them! :P

 

For your biome problem, you are registering the biome type, but not the actual biome. After you call BiomeDictionary.registerBiomeType (in your UselessBiomes class), register your biome with Biome.registerBiome

 

 

As for your teleporter problem, may I ask you are rechecking whether or not a machine exists near you every time a player teleports? Why not just cache the teleporter locations like how vanilla portals do it? Also, instead of checking whether or not an IBlockState instance is equal to the default IBlockState of your machine, check whether or not the Block is equal to you machine block. I only say this because I noticed your machine has different orientations, so checking against the default will fail for all the orientations except NORTH.

Thanks a lot for your reply!

The small registerBiome() did it and fixed my first issue.

As for my second issue, I did try it to check if it's equal to the block and not to the block state, yet it didn't fix my ghost block issue. About caching the location like vanilla - I'm not too sure how to do it, and I can look into it, but do you think it can solve my issue? Again: the teleporter that generates in the custom dimension, re-appears in the overworld when you come back, at the same location, as a ghost block. Isn't it a client-server thing?

In any case, I have no idea how to fix it, and I'd really appreciate any kind of help!

Why are you reading this?

Link to comment
Share on other sites

  • 2 weeks later...

- The second issue is the custom teleporter. I have this weird issue that when I come back to the overworld using my custom teleporter, I have a ghost block of the teleportation block from the custom dimension. It's easier to understand with pictures: one, two, three.

 

I'll really appreciate any kind of help, and any tip, as I sincerely need them! :P

 

So I recently encountered a similar problem. It has to do with how you are actually teleporting into your new dimension. In your block class, you check if the player is an instance of EntityPlayerMP and then proceed with teleporting with the methods in PlayerList. For some reason, this causes this problem when you teleport via onBlockActivated. (I suspect it's because you are teleporting the server player and not the client player, so the loaded chunk data gets all mixed up between the client world and the server world, but that's just a speculation). Anyway, try teleporting the player with EntityPlayer#changeDimension instead. If you need a reference, just look at BlockEndPortal. Keep in mind, however, that you still need to wrap the teleport code in a "!world.isRemote" if statement

Link to comment
Share on other sites

- The second issue is the custom teleporter. I have this weird issue that when I come back to the overworld using my custom teleporter, I have a ghost block of the teleportation block from the custom dimension. It's easier to understand with pictures: one, two, three.

 

I'll really appreciate any kind of help, and any tip, as I sincerely need them! :P

 

So I recently encountered a similar problem. It has to do with how you are actually teleporting into your new dimension. In your block class, you check if the player is an instance of EntityPlayerMP and then proceed with teleporting with the methods in PlayerList. For some reason, this causes this problem when you teleport via onBlockActivated. (I suspect it's because you are teleporting the server player and not the client player, so the loaded chunk data gets all mixed up between the client world and the server world, but that's just a speculation). Anyway, try teleporting the player with EntityPlayer#changeDimension instead. If you need a reference, just look at BlockEndPortal. Keep in mind, however, that you still need to wrap the teleport code in a "!world.isRemote" if statement

Wow Gabriel, this might be it! How could've I figured this out myself?

My only problem is, that changeDimension() doesn't use my teleporter class, but the default one. What should I do about that?

Why are you reading this?

Link to comment
Share on other sites

- The second issue is the custom teleporter. I have this weird issue that when I come back to the overworld using my custom teleporter, I have a ghost block of the teleportation block from the custom dimension. It's easier to understand with pictures: one, two, three.

 

I'll really appreciate any kind of help, and any tip, as I sincerely need them! :P

 

So I recently encountered a similar problem. It has to do with how you are actually teleporting into your new dimension. In your block class, you check if the player is an instance of EntityPlayerMP and then proceed with teleporting with the methods in PlayerList. For some reason, this causes this problem when you teleport via onBlockActivated. (I suspect it's because you are teleporting the server player and not the client player, so the loaded chunk data gets all mixed up between the client world and the server world, but that's just a speculation). Anyway, try teleporting the player with EntityPlayer#changeDimension instead. If you need a reference, just look at BlockEndPortal. Keep in mind, however, that you still need to wrap the teleport code in a "!world.isRemote" if statement

Wow Gabriel, this might be it! How could've I figured this out myself?

My only problem is, that changeDimension() doesn't use my teleporter class, but the default one. What should I do about that?

 

And...because for some reason the universe is trying to spite me, I can no longer reproduce the effect -_- I don't know why, but it has just stopped. I'm afraid I'll be useless now :(. I haven't really worked with tons of dimensions, but you could try to create the portal before teleporting? Hopefully someone with more knowledge knows what's happening.

 

Also, delving a bit deeper, it looks like EntityPlayer#changeDimension uses PlayerList#transferPlayerToDimension for EntityPlayerMP anyway, so I doubt changing it would have had an impact (although it appeared to have when I was having the same problem, so I honestly have no idea what was happening). Sorry I can't help more. I'll keep looking tho

Link to comment
Share on other sites

- The second issue is the custom teleporter. I have this weird issue that when I come back to the overworld using my custom teleporter, I have a ghost block of the teleportation block from the custom dimension. It's easier to understand with pictures: one, two, three.

 

I'll really appreciate any kind of help, and any tip, as I sincerely need them! :P

 

So I recently encountered a similar problem. It has to do with how you are actually teleporting into your new dimension. In your block class, you check if the player is an instance of EntityPlayerMP and then proceed with teleporting with the methods in PlayerList. For some reason, this causes this problem when you teleport via onBlockActivated. (I suspect it's because you are teleporting the server player and not the client player, so the loaded chunk data gets all mixed up between the client world and the server world, but that's just a speculation). Anyway, try teleporting the player with EntityPlayer#changeDimension instead. If you need a reference, just look at BlockEndPortal. Keep in mind, however, that you still need to wrap the teleport code in a "!world.isRemote" if statement

Wow Gabriel, this might be it! How could've I figured this out myself?

My only problem is, that changeDimension() doesn't use my teleporter class, but the default one. What should I do about that?

 

And...because for some reason the universe is trying to spite me, I can no longer reproduce the effect -_- I don't know why, but it has just stopped. I'm afraid I'll be useless now :(. I haven't really worked with tons of dimensions, but you could try to create the portal before teleporting? Hopefully someone with more knowledge knows what's happening.

 

Also, delving a bit deeper, it looks like EntityPlayer#changeDimension uses PlayerList#transferPlayerToDimension for EntityPlayerMP anyway, so I doubt changing it would have had an impact (although it appeared to have when I was having the same problem, so I honestly have no idea what was happening). Sorry I can't help more. I'll keep looking tho

Minecraft is so weird  :'(

I'll appreciate any help given, I'll keep looking too

Why are you reading this?

Link to comment
Share on other sites

- The second issue is the custom teleporter. I have this weird issue that when I come back to the overworld using my custom teleporter, I have a ghost block of the teleportation block from the custom dimension. It's easier to understand with pictures: one, two, three.

 

I'll really appreciate any kind of help, and any tip, as I sincerely need them! :P

 

So I recently encountered a similar problem. It has to do with how you are actually teleporting into your new dimension. In your block class, you check if the player is an instance of EntityPlayerMP and then proceed with teleporting with the methods in PlayerList. For some reason, this causes this problem when you teleport via onBlockActivated. (I suspect it's because you are teleporting the server player and not the client player, so the loaded chunk data gets all mixed up between the client world and the server world, but that's just a speculation). Anyway, try teleporting the player with EntityPlayer#changeDimension instead. If you need a reference, just look at BlockEndPortal. Keep in mind, however, that you still need to wrap the teleport code in a "!world.isRemote" if statement

Wow Gabriel, this might be it! How could've I figured this out myself?

My only problem is, that changeDimension() doesn't use my teleporter class, but the default one. What should I do about that?

 

And...because for some reason the universe is trying to spite me, I can no longer reproduce the effect -_- I don't know why, but it has just stopped. I'm afraid I'll be useless now :(. I haven't really worked with tons of dimensions, but you could try to create the portal before teleporting? Hopefully someone with more knowledge knows what's happening.

 

Also, delving a bit deeper, it looks like EntityPlayer#changeDimension uses PlayerList#transferPlayerToDimension for EntityPlayerMP anyway, so I doubt changing it would have had an impact (although it appeared to have when I was having the same problem, so I honestly have no idea what was happening). Sorry I can't help more. I'll keep looking tho

Minecraft is so weird  :'(

I'll appreciate any help given, I'll keep looking too

 

OK! I think I found the problem! In your block activated method, only return true if !world.isRemote and return false otherwise. Try that and see how it works. In case you're wondering what coding im testing this on, here it is:

 

public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer player, EnumHand hand, ItemStack item, EnumFacing side, float hitX, float hitY, float hitZ)
{
     if(!world.isRemote)
     {
          if(player instanceof EntityPlayerMP)
          {
               /* do teleport stuff with PlayerList#transferPlayerToDimension */
    	       return true;
          }	
     }
     
     return false;
}

 

-EDIT:

 

Also, I noticed that the orientation of your teleporter block thing isn't getting preserved across chunk loads. In your block class you are saving the direction it's facing to metadata, but not reading it back into your block state (you need Block#getStateFromMeta as well as Block#getMetaFromState)

Link to comment
Share on other sites

- The second issue is the custom teleporter. I have this weird issue that when I come back to the overworld using my custom teleporter, I have a ghost block of the teleportation block from the custom dimension. It's easier to understand with pictures: one, two, three.

 

I'll really appreciate any kind of help, and any tip, as I sincerely need them! :P

 

So I recently encountered a similar problem. It has to do with how you are actually teleporting into your new dimension. In your block class, you check if the player is an instance of EntityPlayerMP and then proceed with teleporting with the methods in PlayerList. For some reason, this causes this problem when you teleport via onBlockActivated. (I suspect it's because you are teleporting the server player and not the client player, so the loaded chunk data gets all mixed up between the client world and the server world, but that's just a speculation). Anyway, try teleporting the player with EntityPlayer#changeDimension instead. If you need a reference, just look at BlockEndPortal. Keep in mind, however, that you still need to wrap the teleport code in a "!world.isRemote" if statement

Wow Gabriel, this might be it! How could've I figured this out myself?

My only problem is, that changeDimension() doesn't use my teleporter class, but the default one. What should I do about that?

 

And...because for some reason the universe is trying to spite me, I can no longer reproduce the effect -_- I don't know why, but it has just stopped. I'm afraid I'll be useless now :(. I haven't really worked with tons of dimensions, but you could try to create the portal before teleporting? Hopefully someone with more knowledge knows what's happening.

 

Also, delving a bit deeper, it looks like EntityPlayer#changeDimension uses PlayerList#transferPlayerToDimension for EntityPlayerMP anyway, so I doubt changing it would have had an impact (although it appeared to have when I was having the same problem, so I honestly have no idea what was happening). Sorry I can't help more. I'll keep looking tho

Minecraft is so weird  :'(

I'll appreciate any help given, I'll keep looking too

 

OK! I think I found the problem! In your block activated method, only return true if !world.isRemote and return false otherwise. Try that and see how it works. In case you're wondering what coding im testing this on, here it is:

 

public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer player, EnumHand hand, ItemStack item, EnumFacing side, float hitX, float hitY, float hitZ)
{
     if(!world.isRemote)
     {
          if(player instanceof EntityPlayerMP)
          {
               /* do teleport stuff with PlayerList#transferPlayerToDimension */
    	       return true;
          }	
     }
     
     return false;
}

 

-EDIT:

 

Also, I noticed that the orientation of your teleporter block thing isn't getting preserved across chunk loads. In your block class you are saving the direction it's facing to metadata, but not reading it back into your block state (you need Block#getStateFromMeta as well as Block#getMetaFromState)

Thanks so much Gabriel! It fixed it! I'd never be able to fix it myself..

Why are you reading this?

Link to comment
Share on other sites

Thanks so much Gabriel! It fixed it! I'd never be able to fix it myself..

 

Always happy to help. That it a very strange bug, however, I'm not sure why it happens but it does. And it only seems to happen when you right-click a block, so there isn't a flaw in the teleportation code, but probably something MC tries to do after right-clicking a block. Anyway, glad you fixed it. (The mod looks cool btw)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, Hi and I am making a forge 1.12.2 mod and also trying to get a custom model helmet item (I made a joker mask) and exported it to .json format and put it in the ~/namespace/models/item folder. Though, I'm struggling to get the item to render what I want it to be rendered like as I've positioned it in the 'head' window view in blockbench. How did you render out your model? I checked your code and it looks like no references to the actual model are being made. I'm new to this forge modding stuff (was a fabric modder) and I desperately need some help. Is there a way to standardly render out armor models made using blockbench? any methods that one can use? My model in JSON: ```json { "credit": "Made with Blockbench", "texture_size": [160, 160], "textures": { "0": "ydyrn:items/joker_mask_texture", "particle": "ydyrn:items/joker_mask_texture" }, "elements": [ { "from": [0, 0, 0], "to": [16, 16, 1], "faces": { "north": {"uv": [0, 1.7, 16, 14.2], "texture": "#0"}, "east": {"uv": [0, 4, 0.9, 5.6], "texture": "#0"}, "south": {"uv": [0, 5.8, 1.6, 7.4], "texture": "#0"}, "west": {"uv": [0, 1.9, 1.3, 3.5], "texture": "#0"}, "up": {"uv": [0, 3.4, 1.6, 4.2], "texture": "#0"}, "down": {"uv": [0, 9, 1.6, 9.7], "texture": "#0"} } }, { "from": [15.8, 11, 0.5], "to": [16.2, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"} } }, { "from": [0.2, 11, 14.6], "to": [15.8, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 9.46, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 9.46, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 9.46, 7.94], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 9.46, 7.94], "texture": "#0"} } }, { "from": [-0.2, 11, 0.5], "to": [0.2, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"} } } ], "display": { "thirdperson_righthand": { "translation": [-0.25, -2.75, 0], "scale": [0.3, 0.3, 0.3] }, "thirdperson_lefthand": { "translation": [-0.25, -2.75, 0], "scale": [0.3, 0.3, 0.3] }, "firstperson_righthand": { "rotation": [-9, 115, 15], "translation": [0, 1.25, -1.75], "scale": [0.5, 0.5, 0.5] }, "firstperson_lefthand": { "rotation": [-9, 115, 15], "translation": [0, 1.25, -1.75], "scale": [0.5, 0.5, 0.5] }, "ground": { "rotation": [40, 0, 0], "translation": [0, -2.5, 0], "scale": [0.5, 0.5, 0.5] }, "gui": { "rotation": [0, 180, 0] }, "head": { "translation": [0, 0, 0.25], "scale": [0.82773, 0.73594, 0.9] }, "fixed": { "translation": [0, 0, 8.75] } }, "groups": [ 0, { "name": "straps", "origin": [0, 0, 0], "color": 0, "children": [1, 2, 3] } ] } ```
    • Add the crash-report or latest.log (logs-folder) with sites like https://paste.ee/ and paste the link to it here  
    • In your config folder, delete the sophisticatedcore-common.toml file and test it again
    • Add the crash-report or latest.log (logs-folder) with sites like https://paste.ee/ and paste the link to it here  
    • I am getting an error message that my mods and my server are not on the same minecraft version when they clearly are. My server and my mods are on 1.20.1 and the error says that the server is 1.20 even though it's on forge 47.2.30.  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.