[1.10.2] IllegalArgumentException Name and ID cannot both be blank

[ZeroxCorbin]

Hello, my mod had an issue reported by a user and I can't figure it out.

 

In the server code I get the village closest to the player. I then write the village to NBT using;

 

private NBTTagCompound CreateVillageNBT(EntityPlayer player, Village vil){
	NBTTagCompound nbt = new NBTTagCompound();

	nbt.setInteger("MsgType", 1);
	//Get the players UUID
	nbt.setString("UUID", player.getGameProfile().getId().toString());
	//Get the current server tick time.
	nbt.setInteger("ServerTime", splitTime);

	if(vil != null){
		try{
			vil.writeVillageDataToNBT(nbt);

		}catch(IllegalArgumentException e){
			nbt = new NBTTagCompound();

			nbt.setInteger("MsgType", 1);
			//Get the players UUID
			nbt.setString("UUID", player.getGameProfile().getId().toString());
			//Get the current server tick time.
			nbt.setInteger("ServerTime", splitTime);

			 System.out.println("Invalid Argument Exception Occured. Please report this as an issue at: http://minecraft.curseforge.com/projects/zc-village-information /n Thank you...");
			return nbt;
		}

 

I put the try/catch in to make sure it was occurring at that location. Here is the dialog I had with the player so far: http://minecraft.curseforge.com/projects/zc-village-information/issues/1

 

Here is the original error dump: http://pastebin.com/Jm83jTUV

 

I have not seen this error before myself. I suspect a different mod has modified the gameprofile of the player? Or was the village data modified?

 

Was: compiled with Forge 1.10.2-12.18.1.2020

Now: compiled with Forge 1.10.2-12.18.1.2027

 

Error occurred on 1.10.2-12.18.1.2026

 

 

Thank you for any assistance...

[Animefan8888]

May I see all of the code mainly where it is being called.

[ZeroxCorbin]

This is the line that is being called.

 

vil.writeVillageDataToNBT(nbt);

 

Since my method does not pass the player, that is done in the Village class, I wont share all the code.

 

However, if it helps here is how I get the Village;

 

for(Village vil : player.worldObj.villageCollectionObj.getVillageList())

 

The exception occurs deaper in the code;

 

java.lang.IllegalArgumentException: Name and ID cannot both be blank

    at com.mojang.authlib.GameProfile.<init>(GameProfile.java:25)

    at net.minecraft.server.management.PlayerProfileCache.func_187319_a(SourceFile:81)

    at net.minecraft.server.management.PlayerProfileCache.func_152655_a(SourceFile:140)

    at net.minecraft.village.Village.func_82689_b(SourceFile:455)

    at zc_villages.server.ServerEvents.CreateVillageNBT(ServerEvents.java:39)

[Animefan8888]

So obviously both the UUID and Name of the player seems to not exist, could it be that you are calling CreateVillageNBT on the client side only or server side only. Where is CreateVillageNBT called.

[ZeroxCorbin]

It is called from the server tick event;

 

	@SubscribeEvent
public void onTick(ServerTickEvent event){
	if(event.phase == Phase.START){

 

Maybe I should use a different phase instead of Phase.START?

[Animefan8888]

Why are you calling this every tick?

Are you making sure there is a player?

Is there another Phase?

Wouldn't it be easier to use Player Tick?

And if you don't mind me asking why are you writing a village to a players nbt?

[ZeroxCorbin]

I am not writing the player NBT I am writing the village NBt to an nearly empty NBTTagCompound. I also do not call the method every tick. Only every 5 seconds calculated by the system time.

 

A player should be available my method is called in this loop;

 

for(EntityPlayer player : ms.getEntityWorld().playerEntities){

 

The error has to do with the gameprofile of the player. This happens in the Village class of Forge;

 

            if (gameprofile != null)
            {
                nbttagcompound1.setString("UUID", gameprofile.getId().toString());
                nbttagcompound1.setInteger("S", ((Integer)this.playerReputation.get(s)).intValue());
                nbttaglist1.appendTag(nbttagcompound1);
            }

 

java.lang.IllegalArgumentException: Name and ID cannot both be blank

    at com.mojang.authlib.GameProfile.<init>(GameProfile.java:25)

    at net.minecraft.server.management.PlayerProfileCache.func_187319_a(SourceFile:81)

    at net.minecraft.server.management.PlayerProfileCache.func_152655_a(SourceFile:140)

    at net.minecraft.village.Village.func_82689_b(SourceFile:455)

    at zc_villages.server.ServerEvents.CreateVillageNBT(ServerEvents.java:39)

 

[Animefan8888]

Taken Directly from Game Profile, you should insert not equal to null checks.

    /**
     * Gets the unique ID of this game profile.
     * <p />
     * This may be null for partial profile data if constructed manually.
     *
     * @return ID of the profile
     */
    public UUID getId() {
        return id;
    }

    /**
     * Gets the display name of this game profile.
     * <p />
     * This may be null for partial profile data if constructed manually.
     *
     * @return Name of the profile
     */
    public String getName() {
        return name;
    }

 

Which line is line 39 in your server tick event btw.

[ZeroxCorbin]

Line 39: vil.writeVillageDataToNBT(nbt);

 

It could be that another mod has altered or delayed the players gameprofile from being complete?

 

I will wait for the first 5 second delay before calling writeVillageDataToNBT. Maybe this will allow the player profile to be setup before accessing it.

 

I will output the ID with the exception catch. If it is blank.

 

System.out.println("Invalid Argument Exception Occurred. Player ID:" + player.getGameProfile().getId().toString() + "\\n Please report this as an issue at: http://minecraft.curseforge.com/projects/zc-village-information \\n Thank you...");

 

 

[Animefan8888]

I don't think the Village has the players UUID saved and is throwing that error.

 

And this doesn't look like it is writing anything, it looks like it is reading

        NBTTagList nbttaglist1 = compound.getTagList("Players", 10);

        for (int j = 0; j < nbttaglist1.tagCount(); ++j)
        {
            NBTTagCompound nbttagcompound1 = nbttaglist1.getCompoundTagAt(j);

            if (nbttagcompound1.hasKey("UUID") && this.worldObj != null && this.worldObj.getMinecraftServer() != null)
            {
                PlayerProfileCache playerprofilecache = this.worldObj.getMinecraftServer().getPlayerProfileCache();
                GameProfile gameprofile = playerprofilecache.getProfileByUUID(UUID.fromString(nbttagcompound1.getString("UUID")));

                if (gameprofile != null)
                {
                    this.playerReputation.put(gameprofile.getName(), Integer.valueOf(nbttagcompound1.getInteger("S")));
                }
            }
            else
            {
                this.playerReputation.put(nbttagcompound1.getString("Name"), Integer.valueOf(nbttagcompound1.getInteger("S")));
            }
        }

[ZeroxCorbin]

I posted the wrong function. I was debugging and copied the wrong code.

 

Here is the culprit.

 

            if (gameprofile != null)
            {
                nbttagcompound1.setString("UUID", gameprofile.getId().toString());
                nbttagcompound1.setInteger("S", ((Integer)this.playerReputation.get(s)).intValue());
                nbttaglist1.appendTag(nbttagcompound1);
            }

[Animefan8888]

Where is the GameProfile initialized? How is it initialized? And After looking at the crash report, it may be mo villages, unless this is happening in dev environment.

[coolAlias]

Don't have an IDE to check, but isn't GameProfile only available on the client side?

[Animefan8888]

No it can be accessed on the server, I believe the reason for this is because they use the gameprofile(UUID from the profile)of the player to save nbt.

[ZeroxCorbin]

From my testing it seems like the player profile was modified by another mod.

 

The player has no uuid assigned at the time of the error.

 

It is caused when the Village class tries to get the reputation of the player for that village. Since the player profile does not have a UUID, the error occurs.

 

 

[Animefan8888]

Interesting, have you fixed this? If not you could just save it yourself.

[ZeroxCorbin]

All of tests I tried did not return the players uuid. The only thing I can think of is another mod has override the getid () method of the player.

 

I told the user who reported the problem that at this time I do not have a solution. I am not going to test with all the mods they have installed.

 

Thank you for you help.

[Animefan8888]

Alright, it is up to you, but i think you should test to see if it was in fact mo villages and if so post in in the mods info.

[ZeroxCorbin]

I have had little success testing with other mods in the development enviroment. I just get a bunch of class missing errors.

 

I look into decompile but did not feel comfortable recompiling someone else's code.

 

Is there a better way to debug with mods you do not have source for?

[Animefan8888]

This depends is there mod open source. You can always go to there forum page or curse mod page and check to see what they do. You can also ask the mods author for permission. And third you can compile your mod and test it outside the dev environment

[ZeroxCorbin]

Yeah, no one else has reported an issue, and the user has 30+ mods installed. If it comes up again I will investigation it further.

 

Thanks again for you suggestions.

[Leviathan143]

In 1.10.2 you do not need deobfuscated jars to run mods in the dev workspace, Forge will deobfuscate the jar automatically. Also I'd test with a FakePlayer, instances of FakePlayer should have UUIDs, but testing doesn't hurt.