Jump to content

Recommended Posts

Posted

Hello, my mod had an issue reported by a user and I can't figure it out.

 

In the server code I get the village closest to the player. I then write the village to NBT using;

 

private NBTTagCompound CreateVillageNBT(EntityPlayer player, Village vil){
	NBTTagCompound nbt = new NBTTagCompound();

	nbt.setInteger("MsgType", 1);
	//Get the players UUID
	nbt.setString("UUID", player.getGameProfile().getId().toString());
	//Get the current server tick time.
	nbt.setInteger("ServerTime", splitTime);

	if(vil != null){
		try{
			vil.writeVillageDataToNBT(nbt);

		}catch(IllegalArgumentException e){
			nbt = new NBTTagCompound();

			nbt.setInteger("MsgType", 1);
			//Get the players UUID
			nbt.setString("UUID", player.getGameProfile().getId().toString());
			//Get the current server tick time.
			nbt.setInteger("ServerTime", splitTime);

			 System.out.println("Invalid Argument Exception Occured. Please report this as an issue at: http://minecraft.curseforge.com/projects/zc-village-information /n Thank you...");
			return nbt;
		}

 

I put the try/catch in to make sure it was occurring at that location. Here is the dialog I had with the player so far: http://minecraft.curseforge.com/projects/zc-village-information/issues/1

 

Here is the original error dump: http://pastebin.com/Jm83jTUV

 

I have not seen this error before myself. I suspect a different mod has modified the gameprofile of the player? Or was the village data modified?

 

Was: compiled with Forge 1.10.2-12.18.1.2020

Now: compiled with Forge 1.10.2-12.18.1.2027

 

Error occurred on 1.10.2-12.18.1.2026

 

 

Thank you for any assistance...

Posted

This is the line that is being called.

 

vil.writeVillageDataToNBT(nbt);

 

Since my method does not pass the player, that is done in the Village class, I wont share all the code.

 

However, if it helps here is how I get the Village;

 

for(Village vil : player.worldObj.villageCollectionObj.getVillageList())

 

The exception occurs deaper in the code;

 

java.lang.IllegalArgumentException: Name and ID cannot both be blank

    at com.mojang.authlib.GameProfile.<init>(GameProfile.java:25)

    at net.minecraft.server.management.PlayerProfileCache.func_187319_a(SourceFile:81)

    at net.minecraft.server.management.PlayerProfileCache.func_152655_a(SourceFile:140)

    at net.minecraft.village.Village.func_82689_b(SourceFile:455)

    at zc_villages.server.ServerEvents.CreateVillageNBT(ServerEvents.java:39)

Posted

So obviously both the UUID and Name of the player seems to not exist, could it be that you are calling CreateVillageNBT on the client side only or server side only. Where is CreateVillageNBT called.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

It is called from the server tick event;

 

	@SubscribeEvent
public void onTick(ServerTickEvent event){
	if(event.phase == Phase.START){

 

Maybe I should use a different phase instead of Phase.START?

Posted

Why are you calling this every tick?

Are you making sure there is a player?

Is there another Phase?

Wouldn't it be easier to use Player Tick?

And if you don't mind me asking why are you writing a village to a players nbt?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

I am not writing the player NBT I am writing the village NBt to an nearly empty NBTTagCompound. I also do not call the method every tick. Only every 5 seconds calculated by the system time.

 

A player should be available my method is called in this loop;

 

for(EntityPlayer player : ms.getEntityWorld().playerEntities){

 

The error has to do with the gameprofile of the player. This happens in the Village class of Forge;

 

            if (gameprofile != null)
            {
                nbttagcompound1.setString("UUID", gameprofile.getId().toString());
                nbttagcompound1.setInteger("S", ((Integer)this.playerReputation.get(s)).intValue());
                nbttaglist1.appendTag(nbttagcompound1);
            }

 

java.lang.IllegalArgumentException: Name and ID cannot both be blank

    at com.mojang.authlib.GameProfile.<init>(GameProfile.java:25)

    at net.minecraft.server.management.PlayerProfileCache.func_187319_a(SourceFile:81)

    at net.minecraft.server.management.PlayerProfileCache.func_152655_a(SourceFile:140)

    at net.minecraft.village.Village.func_82689_b(SourceFile:455)

    at zc_villages.server.ServerEvents.CreateVillageNBT(ServerEvents.java:39)

 

Posted

Taken Directly from Game Profile, you should insert not equal to null checks.

    /**
     * Gets the unique ID of this game profile.
     * <p />
     * This may be null for partial profile data if constructed manually.
     *
     * @return ID of the profile
     */
    public UUID getId() {
        return id;
    }

    /**
     * Gets the display name of this game profile.
     * <p />
     * This may be null for partial profile data if constructed manually.
     *
     * @return Name of the profile
     */
    public String getName() {
        return name;
    }

 

Which line is line 39 in your server tick event btw.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

Line 39: vil.writeVillageDataToNBT(nbt);

 

It could be that another mod has altered or delayed the players gameprofile from being complete?

 

I will wait for the first 5 second delay before calling writeVillageDataToNBT. Maybe this will allow the player profile to be setup before accessing it.

 

I will output the ID with the exception catch. If it is blank.

 

System.out.println("Invalid Argument Exception Occurred. Player ID:" + player.getGameProfile().getId().toString() + "\\n Please report this as an issue at: http://minecraft.curseforge.com/projects/zc-village-information \\n Thank you...");

 

 

Posted

I don't think the Village has the players UUID saved and is throwing that error.

 

And this doesn't look like it is writing anything, it looks like it is reading

        NBTTagList nbttaglist1 = compound.getTagList("Players", 10);

        for (int j = 0; j < nbttaglist1.tagCount(); ++j)
        {
            NBTTagCompound nbttagcompound1 = nbttaglist1.getCompoundTagAt(j);

            if (nbttagcompound1.hasKey("UUID") && this.worldObj != null && this.worldObj.getMinecraftServer() != null)
            {
                PlayerProfileCache playerprofilecache = this.worldObj.getMinecraftServer().getPlayerProfileCache();
                GameProfile gameprofile = playerprofilecache.getProfileByUUID(UUID.fromString(nbttagcompound1.getString("UUID")));

                if (gameprofile != null)
                {
                    this.playerReputation.put(gameprofile.getName(), Integer.valueOf(nbttagcompound1.getInteger("S")));
                }
            }
            else
            {
                this.playerReputation.put(nbttagcompound1.getString("Name"), Integer.valueOf(nbttagcompound1.getInteger("S")));
            }
        }

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

I posted the wrong function. I was debugging and copied the wrong code.

 

Here is the culprit.

 

            if (gameprofile != null)
            {
                nbttagcompound1.setString("UUID", gameprofile.getId().toString());
                nbttagcompound1.setInteger("S", ((Integer)this.playerReputation.get(s)).intValue());
                nbttaglist1.appendTag(nbttagcompound1);
            }

Posted

Where is the GameProfile initialized? How is it initialized? And After looking at the crash report, it may be mo villages, unless this is happening in dev environment.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

From my testing it seems like the player profile was modified by another mod.

 

The player has no uuid assigned at the time of the error.

 

It is caused when the Village class tries to get the reputation of the player for that village. Since the player profile does not have a UUID, the error occurs.

 

 

Posted

All of tests I tried did not return the players uuid. The only thing I can think of is another mod has override the getid () method of the player.

 

I told the user who reported the problem that at this time I do not have a solution. I am not going to test with all the mods they have installed.

 

Thank you for you help.

Posted

I have had little success testing with other mods in the development enviroment. I just get a bunch of class missing errors.

 

I look into decompile but did not feel comfortable recompiling someone else's code.

 

Is there a better way to debug with mods you do not have source for?

Posted

This depends is there mod open source. You can always go to there forum page or curse mod page and check to see what they do. You can also ask the mods author for permission. And third you can compile your mod and test it outside the dev environment

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

In 1.10.2 you do not need deobfuscated jars to run mods in the dev workspace, Forge will deobfuscate the jar automatically. Also I'd test with a FakePlayer, instances of FakePlayer should have UUIDs, but testing doesn't hurt.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • The specific issue is that items in my inventory wont stack properly. For instance, if I punch a tree down to collect wood, the first block I collected goes to my hand. So when I punch the second block of wood to collect it, it drops, but instead of stacking with the piece of wood already in my hand, it goes to the second slot in my hotbar instead. Another example is that I'll get some dirt, and then when I'm placing it down later I'll accidentally place a block where I don't want it. When I harvest it again, it doesn't go back to the stack that it came from on my hotbar, where it should have gone, but rather into my inventory. That means that if my inventory is full, then the dirt wont be picked up even though there should be space available in the stack I'm holding. The forge version I'm using is 40.3.0, for java 1.18.2. I'll leave the mods I'm using here, and I'd appreciate it if anybody can point me in the right direction in regards to figuring out how to fix this. I forgot to mention that I think it only happens on my server but I&#39;m not entirely sure. PLEASE HELP ME! LIST OF THE MODS. aaa_particles Adorn AdvancementPlaques AI-Improvements AkashicTome alexsdelight alexsmobs AmbientSounds amwplushies Animalistic another_furniture AppleSkin Aquaculture aquamirae architectury artifacts Atlas-Lib AutoLeveling AutoRegLib auudio balm betterfpsdist biggerstacks biomancy BiomesOPlenty blockui blueprint Bookshelf born_in_chaos Botania braincell BrassAmberBattleTowers brutalbosses camera CasinoCraft cfm (MrCrayfish’s Furniture Mod) chat_heads citadel cloth-config Clumps CMDCam CNB cobweb collective comforts convenientcurioscontainer cookingforblockheads coroutil CosmeticArmorReworked CozyHome CrabbersDelight crashexploitfixer crashutilities Create CreativeCore creeperoverhaul cristellib crittersandcompanions Croptopia CroptopiaAdditions CullLessLeaves curios curiouslanterns curiouslights Curses' Naturals CustomNPCs CyclopsCore dannys_expansion decocraft Decoration Mod DecorationDelightRefurbished Decorative Blocks Disenchanting DistantHorizons doubledoors DramaticDoors drippyloadingscreen durabilitytooltip dynamic-fps dynamiclights DynamicTrees DynamicTreesBOP DynamicTreesPlus Easy Dungeons EasyAnvils EasyMagic easy_npc eatinganimation ecologics effective_fg elevatorid embeddium emotecraft enchantlimiter EnchantmentDescriptions EnderMail engineersdecor entityculling entity_model_features entity_texture_features epicfight EvilCraft exlinefurniture expandability explosiveenhancement factory-blocks fairylights fancymenu FancyVideo FarmersDelight fast-ip-ping FastSuite ferritecore finsandtails FixMySpawnR Forge Middle Ages fossil FpsReducer2 furnish GamingDeco geckolib goblintraders goldenfood goodall H.e.b habitat harvest-with-ease hexerei hole_filler huge-structure-blocks HunterIllager iammusicplayer Iceberg illuminations immersive_paintings incubation infinitybuttons inventoryhud InventoryProfilesNext invocore ItemBorders itemzoom Jade jei (Just Enough Items) JetAndEliasArmors journeymap JRFTL justzoom kiwiboi Kobolds konkrete kotlinforforge lazydfu LegendaryTooltips libIPN lightspeed lmft lodestone LongNbtKiller LuckPerms Lucky77 MagmaMonsters malum ManyIdeasCore ManyIdeasDoors marbledsarsenal marg mcw-furniture mcw-lights mcw-paths mcw-stairs mcw-trapdoors mcw-windows meetyourfight melody memoryleakfix Mimic minecraft-comes-alive MineTraps minibosses MmmMmmMmmMmm MOAdecor (ART, BATH, COOKERY, GARDEN, HOLIDAYS, LIGHTS, SCIENCE) MobCatcher modonomicon mods_optimizer morehitboxes mowziesmobs MutantMonsters mysticalworld naturalist NaturesAura neapolitan NekosEnchantedBooks neoncraft2 nerb nifty NightConfigFixes nightlights nocube's_villagers_sell_animals NoSeeNoTick notenoughanimations obscure_api oculus oresabovediamonds otyacraftengine Paraglider Patchouli physics-mod Pillagers Gun PizzaCraft placeableitems Placebo player-animation-lib pneumaticcraft-repressurized polymorph PrettyPipes Prism projectbrazier Psychadelic-Chemistry PuzzlesLib realmrpg_imps_and_demons RecipesLibrary reeves-furniture RegionsUnexplored restrictedportals revive-me Scary_Mobs_And_Bosses selene shetiphiancore ShoulderSurfing smoothboot
    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.