[Solved][1.9.4] Updating my custom walls from 1.8 to 1.9.4

[Erfurt]

Hey guys,

 

I'm having some difficulty updating my custom walls, and i was hoping that someone could help me.

 

Here's the code for my base wall class ( this worked in 1.8 ), I use this because I have different types of wall that have different properties, for example some of my walls emits light. I extend my other classes from the base class.

public abstract class BaseBlockWall extends BlockWall
{
public BaseBlockWall(Block block)
{
	super(block);
}

public int damageDropped(int meta)
{
	return meta;
}

public boolean canPlaceTorchOnTop(IBlockAccess world, BlockPos pos)
{
	return true;
}

public boolean canConnectTo(IBlockAccess world, BlockPos pos)
    {
	IBlockState state = world.getBlockState(pos);
        Block block = state.getBlock();
        return block == Blocks.BARRIER ? false : (((block != this && !(block instanceof BlockFenceGate) && !(block instanceof BlockWall))) ? (block.getMaterial(state).isOpaque() && state.isFullCube() ? block.getMaterial(state) != Material.GOURD : false) : true);
    }
}

At first glans everything seems to work. But none of my walls want to connect to each other. It only want to connect to itself. I want to have all of the different classes connecting to eachother. A second thing that isn't working is that I can't place torches on top of the walls.

 

This is the code for my basic walls class.

public class EadoreWall extends BaseBlockWall
{
public EadoreWall(Block block, String name)
{
	super(block);
	this.setUnlocalizedName(name);
	this.setRegistryName(name);
}

@Override
@SideOnly(Side.CLIENT)
    public void getSubBlocks(Item item, CreativeTabs tab, List<ItemStack> list)
    {
        list.add(new ItemStack(item, 1, 0));
    }
}

 

To my knowledge this should work. However it does not, maybe someone can see something I can't.

[Animefan8888]

I have a recommendation put @Override above methods you are overriding.

[Erfurt]

I have a recommendation put @Override above methods you are overriding.

Does nothing have tried it

[jeffryfisher]

Your error is in canConnectTo. You use "block != this", which will limit each wall's connection to itself. You probably want "instanceof BlockWall" (or BaseBlockWall) so all your walls accept every other wall.

 

I also recommend that you optimize that expression, but that's probably my OCD kicking in 

[Erfurt]

Your error is in canConnectTo. You use "block != this", which will limit each wall's connection to itself. You probably want "instanceof BlockWall" (or BaseBlockWall) so all your walls accept every other wall.

 

I also recommend that you optimize that expression, but that's probably my OCD kicking in 

 

I tried that, sadly it didn't make a difference. I have been looking at vanilla code, from 1.8.9 and 1.9.4 and it seems that the vanilla method was changed from public to private, could this be the reason for my problem? If so, can I even fix? How?

[Erfurt]

Your error is in canConnectTo. You use "block != this", which will limit each wall's connection to itself. You probably want "instanceof BlockWall" (or BaseBlockWall) so all your walls accept every other wall.

 

I also recommend that you optimize that expression, but that's probably my OCD kicking in 

BTW what do you mean by optimize the expression? Personally I can't see how this can be done otherwise. It's pretty much the same way that vanilla code does it.

[Erfurt]

I have fixed the torch thing, the method had been changed a bit from 1.8 to 1.9. Still haven't been able to get my walls to connect, any help would be lovely ☺️

[Animefan8888]

I have fixed the torch thing, the method had been changed a bit from 1.8 to 1.9. Still haven't been able to get my walls to connect, any help would be lovely ☺️

Post your updated BaseBlockWall and EadoreBlockWall.

[Erfurt]

I have fixed the torch thing, the method had been changed a bit from 1.8 to 1.9. Still haven't been able to get my walls to connect, any help would be lovely ☺️

Post your updated BaseBlockWall and EadoreBlockWall.

I all did was to change from

public boolean canPlaceTorchOnTop(IBlockAccess world, BlockPos pos)
{
	return true;
}

to

@Override
public boolean canPlaceTorchOnTop(IBlockState state, IBlockAccess world, BlockPos pos)
{
	return true;
}

 

I have otherwise, tried all of your suggestions, regarding the walls not connecting to each other, but without any success, and that was when I noticed that the canConnectTo method inside BlockWall had been changed from public to private, and I don't know if that's why my code from 1.8 doesn't work in 1.9.4, as I mentioned in my original post, I had everything working in 1.8.

[Animefan8888]

I have fixed the torch thing, the method had been changed a bit from 1.8 to 1.9. Still haven't been able to get my walls to connect, any help would be lovely ☺️

Post your updated BaseBlockWall and EadoreBlockWall.

I all did was to change from

public boolean canPlaceTorchOnTop(IBlockAccess world, BlockPos pos)
{
	return true;
}

to

@Override
public boolean canPlaceTorchOnTop(IBlockState state, IBlockAccess world, BlockPos pos)
{
	return true;
}

 

I have otherwise, tried all of your suggestions, regarding the walls not connecting to each other, but without any success, and that was when I noticed that the canConnectTo method inside BlockWall had been changed from public to private, and I don't know if that's why my code from 1.8 doesn't work in 1.9.4, as I mentioned in my original post, I had everything working in 1.8.

I would prefer to look at the whole class(es) but I think this is your problem.

(((block != this && !(block instanceof BlockFenceGate) && !(block instanceof BlockWall)))
// Instead use
(!(block instanceof BlockWall) || !(block instanceof BlockFenceGate))

[Erfurt]

I fixed it now. Because canConnectTo is a private boolean in the BlockWall class, I need to add and override the IBlockState getActualState, for it to work. So my final class looks like this.

public abstract class BaseBlockWall extends BlockWall
{
public BaseBlockWall(Block block)
{
	super(block);
}

public int damageDropped(int meta)
{
	return meta;
}

@Override
public boolean canPlaceTorchOnTop(IBlockState state, IBlockAccess world, BlockPos pos)
{
	return true;
}

public boolean canConnectTo(IBlockAccess world, BlockPos pos)
    {
	IBlockState state = world.getBlockState(pos);
        Block block = state.getBlock();
        return block == Blocks.BARRIER ? false : (((block != this && !(block instanceof BlockFenceGate) && !(block instanceof BlockWall))) ? (block.getMaterial(state).isOpaque() && state.isFullCube() ? block.getMaterial(state) != Material.GOURD : false) : true);
    }

@Override
public IBlockState getActualState(IBlockState state, IBlockAccess worldIn, BlockPos pos)
    {
        boolean flag = this.canConnectTo(worldIn, pos.north());
        boolean flag1 = this.canConnectTo(worldIn, pos.east());
        boolean flag2 = this.canConnectTo(worldIn, pos.south());
        boolean flag3 = this.canConnectTo(worldIn, pos.west());
        boolean flag4 = flag && !flag1 && flag2 && !flag3 || !flag && flag1 && !flag2 && flag3;
        return state.withProperty(UP, Boolean.valueOf(!flag4 || !worldIn.isAirBlock(pos.up()))).withProperty(NORTH, Boolean.valueOf(flag)).withProperty(EAST, Boolean.valueOf(flag1)).withProperty(SOUTH, Boolean.valueOf(flag2)).withProperty(WEST, Boolean.valueOf(flag3));
    }
}

 

And this works. I know that some of the methods I use in the canConnectTo boolean is deprecated, like block.getMaterial(state).isOpaque() and I will see if I can use some updated code for it instead. But at least it works now, thanks for the help guys