Jump to content

[1.10.2] Block Reach Distance (SOLVED)


Lellson
 Share

Recommended Posts

Hey!

I'm trying to increase the player's block reach distance but it doesn't seem to work. :/

This is my code:

 


        @Override
public void onUpdate(ItemStack stack, World world, Entity entity, int itemSlot, boolean isSelected) {
	super.onUpdate(stack, world, entity, itemSlot, isSelected);

	if (!(entity instanceof EntityPlayerMP)) 
		return;

	if (isSelected) 
	{
                ((EntityPlayerMP) entity).interactionManager.setBlockReachDistance(20.0D);
	}
	else
	{
		((EntityPlayerMP) entity).interactionManager.setBlockReachDistance(5.0D);
	}
}

 

The setters only run on the server side. Could that be the problem?

 

Has someone a proper solution for this?

Thanks!

Link to comment
Share on other sites

You have to do it on the client too, otherwise the client won't be aware of the extended reach.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Hey, I was making a mod, called "Reforged" and I made custom Reach for attacks with specific weapons. Here is my code: https://github.com/TheOnlySilverClaw/Reforged/blob/master/java/org/silvercatcher/reforged/ReforgedEvents.java You just need to replace some smaller parts of my code and then it should work :)

Bringing the best mod back alive! Our mod REFORGED!

Balkon's Weapons for 1.8: https://github.com/TheOnlySilverClaw/Reforged/releases

Link to comment
Share on other sites

Hey, I was making a mod, called "Reforged" and I made custom Reach for attacks with specific weapons. Here is my code: https://github.com/TheOnlySilverClaw/Reforged/blob/master/java/org/silvercatcher/reforged/ReforgedEvents.java You just need to replace some smaller parts of my code and then it should work :)

 

Looks like a nice solution!

I should probably have checked this topic before I tried something new...  ::)

 

I actually fixed it a bit differently. The problem was the method getBlockReachDistance() in PlayerControllerMP, which always returned 4.5F or 5F depending on the player's gamemode.

I overrid that method in a custom PlayerControllerMP class and set the playerController field from the minecraft instance to the custom one.

 

        Client Proxy:

        @Override
public void setWeaponRange(Entity entity, double range) {
	super.setWeaponRange(entity, range);

	class RangePlayerController extends PlayerControllerMP {

		private float range = Constants.DEFAULT_RANGE;

		public RangePlayerController(Minecraft mcIn, NetHandlerPlayClient netHandler) {
			super(mcIn, netHandler);
		}

		@Override
		public float getBlockReachDistance() {
			return range;
		}

		public void setBlockReachDistance(float range) {
			this.range = range;
		}
	}

	Minecraft mc = Minecraft.getMinecraft();
	EntityPlayer player = mc.thePlayer;

	if (player == entity) 
	{
		if (!(mc.playerController instanceof RangePlayerController)) 
		{
			GameType gameType = ReflectionHelper.getPrivateValue(PlayerControllerMP.class, mc.playerController, "currentGameType", "field_78779_k");
            NetHandlerPlayClient netClient = ReflectionHelper.getPrivateValue(PlayerControllerMP.class, mc.playerController, "connection", "field_78774_b");
            
            RangePlayerController controller = new RangePlayerController(mc, netClient);
            
            boolean isFlying = player.capabilities.isFlying;
            boolean allowFlying = player.capabilities.allowFlying;
            
            controller.setGameType(gameType);
            
            player.capabilities.isFlying = isFlying;
            player.capabilities.allowFlying = allowFlying;
            
            mc.playerController = controller;
		}

		((RangePlayerController) mc.playerController).setBlockReachDistance((float) range);
	}
}

 

Thanks anyway!

Link to comment
Share on other sites

Are you sure it is that simple? Maybe in 1.10 they've changed it, but in older versions even if you set it higher the server would still limit the maximum reach. We had to go through a lot of trouble -- see my tutorial: http://jabelarminecraft.blogspot.com/p/minecraft-modding-extending-reach-of.html

 

If it works that easy now, I need to try it!

 

 

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

Are you sure it is that simple? Maybe in 1.10 they've changed it, but in older versions even if you set it higher the server would still limit the maximum reach. We had to go through a lot of trouble -- see my tutorial: http://jabelarminecraft.blogspot.com/p/minecraft-modding-extending-reach-of.html

 

If it works that easy now, I need to try it!

 

The client part works well for me.

 

I simply did this in my server proxy:

((EntityPlayerMP) entity).interactionManager.setBlockReachDistance(range);

 

I also had to use the PlayerInteractEvent.LeftClickEmpty event, send a packet and raytrace to attack entities from the new range.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I created an SOUL_JAR Item that has been registered for each mob like - mod:soul_jar_minecraft_cow etc.. but it all has different registry names, i have a model file name soul_jar.json and i want to know how to bind each of those items to this class (When mod iterates through all of vanilla mobs and registering items for them).   I didn't found any info about it because all of info is outdated, and forge docs is complicated asf (i wish there would be more examples) i also used AI but it showing me only outdated info, but theres some code where i registering my item and trying to bind it to model ->   public static void register(IEventBus eventBus){ ITEMS.register(eventBus); Set<ResourceLocation> entityKeyList = ForgeRegistries.ENTITY_TYPES.getKeys(); for (ResourceLocation k : entityKeyList) { EntityType<?> entityType = ForgeRegistries.ENTITY_TYPES.getValue(k); if (!entityType.getCategory().equals(MobCategory.MISC)) { RegistryObject<Item> SOUL_JAR = ITEMS.register("soul_jar" + '_' + k.toString().replace(':', '_').replace('.', '_'), () -> new JarItem(new Item.Properties().rarity(Rarity.RARE).tab(ModTabs.MAGICAL_OBSESSION_JARS), entityType)); if (Thread.currentThread().getThreadGroup() == SidedThreadGroups.CLIENT) { ItemModelShaper itemModelShaper = Minecraft.getInstance().getItemRenderer().getItemModelShaper(); itemModelShaper.register(SOUL_JAR.get().asItem(), new ModelResourceLocation("item.soul_jar", "inventory")); } } } } I also have more questions like how to iterate through all other mods mobs also, or render mob inside of a jar in inventory, but i will try to figure it out.
    • I looked into OctoEconomyAPI and saw that it was a JAR api for fabric. This means you have a fabric mod in your mods folder. I downloaded your mod folder and wasted 2 solid hours creating a Python script to try to find the faulty mod, and eventually just gave up. I suggest you create two installations with half or the mods in each, find which one doesn't launch, cut that one in half, and repeat until you find the fabric mod. Investigué OctoEconomyAPI y vi que era una API JAR para fabric. Esto significa que tienes un mod de Fabric en tu carpeta de mods. Descargué su carpeta de mods y desperdicié 2 horas completas creando un script de Python para tratar de encontrar el mod defectuoso, y finalmente me di por vencido. Le sugiero que cree dos instalaciones con la mitad o las modificaciones en cada una, encuentre cuál no se inicia, córtela por la mitad y repita hasta que encuentre la modificación Fabric.   (The Python script I made is here): (El script de Python que hice está aquí):  
    • I've got it to work now. Instead of using the texture manager I used the Render System:   RenderSystem.setShaderTexture(0, new ResourceLocation("mcaquests", "textures/item/questbook.png"));  
    • Hello ive been having the same issue over Curse Forge's auto modding or when i use manual modding. The error seems to be within either Oculus or Rubidium. Im using 1.19 with the latest 1.19 forge + 1.19 compatible Oculus and Rubidium. Just in case the versions i am using; Oculus - oculus-1.4.3a Rubidium - rubidium-0.6.3 Note: I tried removing the two and add Optifine and it opens without a problem. I didnt use all 3 together to get this error im talking tho, i know they are not compatible with optifine dont worry. Logs Debug The actual error code im getting on start-up is ''1'' and nothing else on the pop up box. I have tried finding the jar files on the internet and insert them on my own but that didnt go too far.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.